Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

Anyone? :) On 3/23/19 12:22 AM, Mathieu Duponchelle wrote: > It is perfectly valid to have multiple CC Picture User Data > for the same frame. Instead of using the first side_data > potentially present with the A53_CC type, iterate over all > side_data. > --- > libavcode

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

No problem, note that the added indentation is because a loop was added :) On 4/10/19 1:14 AM, Carl Eugen Hoyos wrote: > 2019-03-23 0:22 GMT+01:00, Mathieu Duponchelle : >> It is perfectly valid to have multiple CC Picture User Data >> for the same frame. Instead of using the

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

Hello ? :) On 4/10/19 1:26 PM, Mathieu Duponchelle wrote: > No problem, note that the added indentation is because a loop > was added :) > > On 4/10/19 1:14 AM, Carl Eugen Hoyos wrote: >> 2019-03-23 0:22 GMT+01:00, Mathieu Duponchelle : >>> It is perfectly valid to ha

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

Ping! On 4/19/19 2:46 PM, Mathieu Duponchelle wrote: > Hello ? :) > > On 4/10/19 1:26 PM, Mathieu Duponchelle wrote: >> No problem, note that the added indentation is because a loop >> was added :) >> >> On 4/10/19 1:14 AM, Carl Eugen Hoyos wrote: >&

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

There isn't one, as I said the added indentation is because of the new loop! On 5/13/19 3:39 PM, Carl Eugen Hoyos wrote: > Am Mi., 10. Apr. 2019 um 13:26 Uhr schrieb Mathieu Duponchelle > : > >> No problem > I don't see an u

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

Hello, Have you read the patch? The request is to split out cosmetic indentation to a separate commit, however the added indentation is not cosmetic, but simply due to a new inner loop .. Best, Mathieu On 5/17/19 10:44 AM, Paul B Mahol wrote: > On 5/17/19, Mathieu Duponchelle wrote: >&

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

Thanks :) On 5/19/19 7:00 PM, Devin Heitmueller wrote: > Hello Paul, > > On Fri, May 17, 2019 at 4:44 AM Paul B Mahol wrote: >> On 5/17/19, Mathieu Duponchelle wrote: >>> There isn't one, as I said the added indentation is because of the new loop! >> To get

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

lice_header(s); On 5/13/19 3:39 PM, Carl Eugen Hoyos wrote: > Am Mi., 10. Apr. 2019 um 13:26 Uhr schrieb Mathieu Duponchelle > : > >> No problem > I don't see an updated patch. > > Carl Eugen > ___ > ffmpeg-devel mail

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

Sorry for pinging again, but at this point I don't know what more I can do to get this (necessary) fix upstream :) On 5/29/19 3:44 PM, Mathieu Duponchelle wrote: > As suggested elsewhere, here's the output of git diff -w, I hope that helps :) > > diff --git a/libavcodec/mpeg1

[FFmpeg-devel] [PATCH] mpeg12enc: Use Closed Captions if available

--- doc/encoders.texi | 3 +++ libavcodec/mpeg12enc.c | 24 libavcodec/mpegvideo.h | 2 ++ 3 files changed, 29 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..378a2ca8eb 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -2

[FFmpeg-devel] [PATCH] mpeg12enc: Use Closed Captions if available

--- doc/encoders.texi | 3 +++ libavcodec/mpeg12enc.c | 29 + libavcodec/mpegvideo.h | 2 ++ 3 files changed, 34 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..378a2ca8eb 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use Closed Captions if available

On 2/7/19 6:28 PM, Carl Eugen Hoyos wrote: > Should you check here if the size is not bigger than a certain maximum > value ... > >> +int i = 0; >> + >> +put_header (s, USER_START_CODE); >> + >> +put_bits(&s->pb, 8, 'G'); // user_identifier >> +

[FFmpeg-devel] [PATCH] mpeg12enc: Use Closed Captions if available

--- doc/encoders.texi | 3 +++ libavcodec/mpeg12enc.c | 29 + libavcodec/mpegvideo.h | 2 ++ 3 files changed, 34 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..378a2ca8eb 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use Closed Captions if available

On 2/7/19 7:21 PM, Devin Heitmueller wrote: > Isn’t this calculation incorrect? The max cc_count possible is 31 (0x1F), > hence the max size should be 93. > True that, updating ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/m

[FFmpeg-devel] [PATCH] mpeg12enc: Use Closed Captions if available

--- doc/encoders.texi | 3 +++ libavcodec/mpeg12enc.c | 31 +++ libavcodec/mpegvideo.h | 2 ++ 3 files changed, 36 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..378a2ca8eb 100644 --- a/doc/encoders.texi +++ b/doc/encoders.tex

[FFmpeg-devel] [PATCH] mpeg12enc: Use Closed Captions if available

--- doc/encoders.texi | 3 +++ libavcodec/mpeg12enc.c | 31 +++ libavcodec/mpegvideo.h | 2 ++ 3 files changed, 36 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..378a2ca8eb 100644 --- a/doc/encoders.texi +++ b/doc/encoders.tex

[FFmpeg-devel] [PATCH v2] mpeg12enc: Use Closed Captions if available

--- doc/encoders.texi | 3 +++ libavcodec/mpeg12enc.c | 31 +++ libavcodec/mpegvideo.h | 2 ++ 3 files changed, 36 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..378a2ca8eb 100644 --- a/doc/encoders.texi +++ b/doc/encoders.tex

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use Closed Captions if available

On 2/7/19 8:48 PM, Carl Eugen Hoyos wrote: > +Only the mpeg2 and h264 decoders provide these. > Sorry for the late comment: > This is not a helpful sentence imo, many features are not provided > by all parts of FFmpeg and it is (too) difficult to keep such lists > up-to-date. > Which other decoder

[FFmpeg-devel] [PATCH v3] mpeg12enc: Use Closed Captions if available

--- doc/encoders.texi | 5 - libavcodec/mpeg12enc.c | 31 +++ libavcodec/mpegvideo.h | 2 ++ 3 files changed, 37 insertions(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..2d3cfa3713 100644 --- a/doc/encoders.texi +++ b

[FFmpeg-devel] [PATCH v4] mpeg12enc: Use Closed Captions if available

--- doc/encoders.texi | 3 +++ libavcodec/mpeg12enc.c | 31 +++ libavcodec/mpegvideo.h | 2 ++ 3 files changed, 36 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..a283b9fddf 100644 --- a/doc/encoders.texi +++ b/doc/encoders.tex

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use Closed Captions if available

On 2/7/19 10:48 PM, Carl Eugen Hoyos wrote: > Seems like a good reason to remove the useless information. Done in my latest patch for what it's worth, I also don't think it's very important information, plus CC can also be provided by the motivated user through the new_side_data() API anyway :) _

Re: [FFmpeg-devel] [PATCH v4] mpeg12enc: Use Closed Captions if available

On 2/8/19 11:58 AM, Michael Niedermayer wrote: > what if size is not a multiple of 3 ? Good point, more bytes will be written than advertised. Do you reckon the input should be straight up refused? The other solution is to warn then iterate over side_data->size rounded down to the closest 3 multip

[FFmpeg-devel] [PATCH v5] mpeg12enc: Use Closed Captions if available

--- doc/encoders.texi | 3 +++ libavcodec/mpeg12enc.c | 32 libavcodec/mpegvideo.h | 2 ++ 3 files changed, 37 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..a283b9fddf 100644 --- a/doc/encoders.texi +++ b/doc/encoders.te

[FFmpeg-devel] [PATCH v6] mpeg12enc: Use Closed Captions if available

--- doc/encoders.texi | 3 +++ libavcodec/mpeg12enc.c | 32 libavcodec/mpegvideo.h | 2 ++ 3 files changed, 37 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..a283b9fddf 100644 --- a/doc/encoders.texi +++ b/doc/encoders.te

[FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

--- doc/encoders.texi | 3 +++ libavcodec/mpeg12enc.c | 32 libavcodec/mpegvideo.h | 2 ++ 3 files changed, 37 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..a283b9fddf 100644 --- a/doc/encoders.texi +++ b/doc/encoders.te

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

So, should this go in? :) On 2/8/19 11:10 PM, Mathieu Duponchelle wrote: > --- > doc/encoders.texi | 3 +++ > libavcodec/mpeg12enc.c | 32 > libavcodec/mpegvideo.h | 2 ++ > 3 files changed, 37 insertions(+) > > diff --git a/do

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

On 2/14/19 10:01 PM, Michael Niedermayer wrote: > if someone checks it against some spec and or tests it against some > decoders, probably yes, The relevant part of the spec is section 6.2.3 in , and I have indeed tested this pat

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

> It would be better to test against a decoder from a unrelated codebase > Otherwise its a bit like testing your new language skills by talking with > yourself. I have just tested with gstreamer's mpegvideoparse element, it detects the closed captions as expected: 0:00:00.602266814 27833  

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

Ping? :) On 2/17/19 1:23 PM, Mathieu Duponchelle wrote: >> It would be better to test against a decoder from a unrelated codebase >> Otherwise its a bit like testing your new language skills by talking with >> yourself. > I have just tested with gstreamer's mpegvideopar

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

Hello, is there anything preventing from merging this patch? On 2/14/19 10:01 PM, Michael Niedermayer wrote: > On Wed, Feb 13, 2019 at 11:49:21PM +0100, Mathieu Duponchelle wrote: >> So, should this go in? :) > if someone checks it against some spec and or tests it against som

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

Yay, thanks! On 3/16/19 12:04 AM, Michael Niedermayer wrote: > no > will apply > > thx > > [...] > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

It is perfectly valid to have multiple CC Picture User Data for the same frame. Instead of using the first side_data potentially present with the A53_CC type, iterate over all side_data. --- libavcodec/mpeg12enc.c | 56 +++--- 1 file changed, 31 insertions(+), 2

Re: [FFmpeg-devel] [RFC] New build system

Hey $list, not an FFmpeg developer, but I worked on the meson port and figured I could address some of the points that were made. Since the initial post I have also added support for compiling with Msys/MingW on Window now in addition to MSVC. ## Performance comparison A significant part of the

Re: [FFmpeg-devel] [RFC] New build system

On 07/04/2018 07:01 PM, Carl Eugen Hoyos wrote: > I don't understand: If everything is enabled and there are > no options to disable features, how did you (and other > people in favour of this change) measure performance? Everything is automatically enabled indeed, but most of the system checks a

Re: [FFmpeg-devel] [RFC] New build system

On 07/06/2018 12:46 PM, Tobias Rapp wrote: > > What are the dependencies besides Meson and Python v3 itself? Meson has no hard dependency apart from python3, if the default backend (ninja) is used, then ninja must indeed also be present on the system. > Is using Ninja mandatory for building or ca

Re: [FFmpeg-devel] [RFC] New build system

> A newbie question - how would cross-compiling for a target of Win10x64 work, > in say ubuntu still eg per zeranoe's method, or rdp's at > https://github.com/rdp/ffmpeg-windows-build-helpers ? meson has excellent support for cross compilation, you can find more info on this at

[FFmpeg-devel] Status of the generic codec options

As explained in https://ffmpeg.org/ffmpeg-codecs.html#Codec-Options : Sometimes, a global option may only affect a specific kind of codec, and may be nonsensical or ignored by another, so you need to be aware of the meaning of the specified options. As far as I can tell, there is an effort to mov