[FFmpeg-devel] [PATCH] doc/developer: add examples to clarify code style

Given the frequency that new developers, myself included, get the code style wrong, it is useful to add some examples to clarify how things should be done. --- doc/developer.texi | 57 +- 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/doc/

[FFmpeg-devel] [PATCH] avutil/hwcontext: Set proper CVBuffer colorspace

Fix #10884 --- libavutil/hwcontext_videotoolbox.c | 54 +- 1 file changed, 38 insertions(+), 16 deletions(-) diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c index 9f82b104c3..4a35bfc7ff 100644 --- a/libavutil/hwcontext_videotoolbox

[FFmpeg-devel] [PATCH v2] avutil/hwcontext_videotoolbox: Set proper CVBuffer colorspace

Fix #10884 --- libavutil/hwcontext_videotoolbox.c | 54 +- 1 file changed, 38 insertions(+), 16 deletions(-) diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c index 9f82b104c3..4a35bfc7ff 100644 --- a/libavutil/hwcontext_videotoolbox

[FFmpeg-devel] [PATCH v3 1/3] avutil/hwcontext_videotoolbox: Unset undefined values

When mapping AVFrame properties to the CVBuffer attachments, it is necessary to properly delete undefined attachments, else we can leave incorrect values in there guessed from VideoToolbox for example, leading to inconsistent results where the AVFrame and CVBuffer differ in metadata. Ref #10884 --

[FFmpeg-devel] [PATCH v3 2/3] avutil/hwcontext_videotoolbox: Update documentation

The documentation was not clear at all what specifically the function does, so it was left unspecified if it will unset or not touch attachments it could not map from the AVFrame. The documentation of the return value was wrong as well. --- libavutil/hwcontext_videotoolbox.h | 11 +-- 1

[FFmpeg-devel] [PATCH v3 3/3] avutil/hwcontext_videotoolbox: Set CVBuffer CGColorSpace

In addition to the other properties, try to obtain the right CGColorSpace and set it as well, else it could lead to a CVBuffer tagged as BT.2020 but with a CGColorSpace indicating BT.709. Therefore it is essential for consistency to set a colorspace according to the other values, or if none can be

Re: [FFmpeg-devel] [PATCH 11/15] lavc/videotoolbox: call VTRegisterSupplementalVideoDecoderIfAvailable

On 13 Nov 2021, at 22:09, rcombs wrote: This is required for VP9 to work. --- libavcodec/videotoolbox.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c index 18cc589d2a..0666446dbd 100644 --- a/libavcodec/videotoolbox.c +++ b/liba

Re: [FFmpeg-devel] [PATCH 11/15] lavc/videotoolbox: call VTRegisterSupplementalVideoDecoderIfAvailable

On 14 Nov 2021, at 3:40, Ridley Combs wrote: On Nov 13, 2021, at 18:38, Marvin Scholz wrote: On 13 Nov 2021, at 22:09, rcombs wrote: This is required for VP9 to work. --- libavcodec/videotoolbox.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/videotoolbox.c b

[FFmpeg-devel] [PATCH] avformat: do not use AVIO_FLAG_* with avio_alloc_context

The documentation states that here 0 should be used for read-only and 1 for a writable buffer. AVIO_FLAG_WRITE however is 2, while it works due to the way the flag is handled internally, it is still wrong according to the documentation. Additionally it makes it seem as if the AVIO_FLAG_* values co

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_tpad: fix check for drawing initialization

The check if drawing needs to be initialized and supported formats should be drawable ones was flawed, as pad_stop/pad_start is only populated from stop_duration/start_duration after these checks. To fix that, check the _duration variants as well and for better readability and maintainability brea

[FFmpeg-devel] [PATCH 2/2] fate: enhance tpad filter test

Adds another test that uses the start_duration and stop_duration options instead of start and stop. --- tests/fate/filter-video.mak | 3 ++- tests/ref/fate/filter-tpad-add-duration | 11 +++ 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 tests/ref/fate/fi

[FFmpeg-devel] [PATCH] lavu/time.c: Fix check for clock_gettime

According to the documentation [1] when checking for a symbol it should be explicitly checked against NULL and the function pointer dereferenced. [1] https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Concepts/WeakLinking.html#//apple_ref/doc/uid/20002378-106

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc: Fix for the compiler error for my old mac pro

On 7 Jun 2019, at 11:59, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang This looks like a different approach to a similar patch sent before by Thilo. --- libavcodec/videotoolboxenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/videotoolbox

Re: [FFmpeg-devel] Cryo APC Files (How to convert WAV files to APC files) ?

On 20 Nov 2018, at 22:09, Thomas Tgames wrote: Hi everyone ! I would like to convert a wav file of music into APC format (Atlantis The Lost Tales). I’m working on a new version of the game. I’m successfully able to convert all APC of the game to WAV. But i want to do the process backward f

Re: [FFmpeg-devel] [PATCH v3] libsvtav1: Add logical_processors option

On 27 Feb 2021, at 1:00, Christopher Degawa wrote: From: Christopher Degawa Used for limiting the size of memory buffers and threads for a target logical processor count, but does not set thread affinity or limit the amount of threads used, although thread affinities can be controlled with a

Re: [FFmpeg-devel] [PATCH] avformat/utils: add helper functions to retrieve index entries from an AVStream

On 25 Mar 2021, at 12:55, Nicolas George wrote: > James Almer (12021-03-24): >> I think it's clear by now that nothing i could say will convince you it's >> better to not return a pointer to an internal array when there are safer >> alternatives, and i already gave my reasons why, none of which

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

Hi, thanks a lot for working on a fix for this. I've just tried it and it does not seem to work, I still can't pass options to the icecast protocol using tee. Command I tried was: ffmpeg -re -i input.mov -c copy -f tee -password hackme -content_type audio/ogg -map 0:v -map 0:a "icecast://sour

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

On 3 Jun 2020, at 11:49, Nicolas George wrote: > Marvin Scholz (12020-06-03): >> Hi, thanks a lot for working on a fix for this. >> >> I've just tried it and it does not seem to work, I still can't pass >> options to the icecast protocol using tee. >>

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

On 3 Jun 2020, at 13:33, Nicolas George wrote: Marvin Scholz (12020-06-03): How would I make that explicit? I checked the command line given on the ticket and I fail to spot the difference, did I get the order wrong or do I miss something else? Quote of the last comment: | I tested your

[FFmpeg-devel] [PATCH] avformat/icecast: Add option to use TLS connection

--- doc/protocols.texi| 3 +++ libavformat/icecast.c | 7 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 7aa758541c..32c829d2a3 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -520,6 +520,9 @@ audio/mpeg. This en

[FFmpeg-devel] [PATCH v2] avformat/icecast: Add option to use TLS connection

--- doc/protocols.texi| 3 +++ libavformat/icecast.c | 8 +++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 7aa758541c..32c829d2a3 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -520,6 +520,9 @@ audio/mpeg. This

[FFmpeg-devel] [PATCH v3] avformat/icecast: Add option to use TLS connection

--- doc/protocols.texi| 3 +++ libavformat/icecast.c | 6 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 7aa758541c..32c829d2a3 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -520,6 +520,9 @@ audio/mpeg. This ena

Re: [FFmpeg-devel] [PATCH] avformat/icecast: Add option to use TLS connection

On 14 Jun 2020, at 0:18, Andreas Rheinhardt wrote: Marvin Scholz: --- doc/protocols.texi| 3 +++ libavformat/icecast.c | 7 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 7aa758541c..32c829d2a3 100644 --- a/doc

Re: [FFmpeg-devel] [PATCH v2] avformat/icecast: Add option to use TLS connection

On 14 Jun 2020, at 0:36, Carl Eugen Hoyos wrote: Am So., 14. Juni 2020 um 00:32 Uhr schrieb Marvin Scholz : +// Check which underlying protocol should be used +real_proto = (s->tls) ? "https" : "http"; Both comment and parentheses are useless. Sent new v

Re: [FFmpeg-devel] [PATCH v3] avformat/icecast: Add option to use TLS connection

On 14 Jun 2020, at 15:42, Michael Niedermayer wrote: On Sun, Jun 14, 2020 at 12:52:44AM +0200, Marvin Scholz wrote: --- doc/protocols.texi| 3 +++ libavformat/icecast.c | 6 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index

Re: [FFmpeg-devel] [PATCH v3] avformat/icecast: Add option to use TLS connection

Ping? Anything else needed to get this merged? On 14 Jun 2020, at 22:23, Marvin Scholz wrote: On 14 Jun 2020, at 15:42, Michael Niedermayer wrote: On Sun, Jun 14, 2020 at 12:52:44AM +0200, Marvin Scholz wrote: --- doc/protocols.texi| 3 +++ libavformat/icecast.c | 6 +- 2 files

Re: [FFmpeg-devel] [PATCH v3] avformat/icecast: Add option to use TLS connection

Ping On 18 Jun 2020, at 23:16, Marvin Scholz wrote: Ping? Anything else needed to get this merged? On 14 Jun 2020, at 22:23, Marvin Scholz wrote: On 14 Jun 2020, at 15:42, Michael Niedermayer wrote: On Sun, Jun 14, 2020 at 12:52:44AM +0200, Marvin Scholz wrote: --- doc/protocols.texi

[FFmpeg-devel] [PATCH] avformat/dashdec: propagate icy to child AVIOContexts

When the user decides they do not want to to send the Icy-MetaData header, this should be respected for all requests, not just the first one. Fix #5578 --- libavformat/dashdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index

[FFmpeg-devel] [PATCH] avformat/hls: propagate icy to child AVIOContexts

When the user decides they do not want to to send the Icy-MetaData header, this should be respected for all requests, not just the first one. Fix #5578 --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 21353bbad7.

Re: [FFmpeg-devel] [PATCH 4/7] avformat/icecast: Use AV_DICT_DONT_STRDUP_VAL to save an av_strdup

On 10 Nov 2019, at 5:07, Andreas Rheinhardt wrote: This will probably also fix CID 1452559, a false positive where Coverity claims a double-free occurs, because it thinks that av_dict_set() frees its key and value arguments even when the AV_DICT_DONT_STRDUP_* flags aren't used. Signed-off-by:

Re: [FFmpeg-devel] [PATCH 3/7] avformat/icecast: Free the right buffer on error

On 19 Dec 2019, at 23:36, Andreas Rheinhardt wrote: > Michael Niedermayer: >> On Sun, Nov 10, 2019 at 05:07:29AM +0100, Andreas Rheinhardt wrote: >>> In case an AVBPrint was not complete, icecast_open() would free some >>> buffers that have not been allocated yet instead of freeing the data of >

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: propagate icy to child AVIOContexts

On 17 Dec 2019, at 1:45, Marvin Scholz wrote: When the user decides they do not want to to send the Icy-MetaData header, this should be respected for all requests, not just the first one. Fix #5578 --- libavformat/dashdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [FFmpeg-devel] [PATCH] avformat/hls: propagate icy to child AVIOContexts

On 17 Dec 2019, at 1:17, Marvin Scholz wrote: When the user decides they do not want to to send the Icy-MetaData header, this should be respected for all requests, not just the first one. Fix #5578 --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [FFmpeg-devel] [PATCH] web/contact: Add libera.chat

On 21 May 2021, at 21:42, Michael Niedermayer wrote: See the internets about the whole freenode vs. libera drama This is a bit a RFC, i would assume that we will move forward with only one set of official IRC channels. Note that if you want to keep the Freenode channel for the time being t

Re: [FFmpeg-devel] Icecast protocol implementation doesn't parse "/" as a valid mountpoint

even offer you a way to change it. Regards, Marvin Scholz To my understanding assigning a lone slash as a mountpoint name isn't considered invalid by the IceCast specification and therefore I suggest that it would be an enhancement to lift this current limitation on the way that mountpoint

Re: [FFmpeg-devel] configure: Fix decklink license dependency

On 28 Jan 2019, at 21:09, Elliott Balsley wrote: I see this old thread about Decklink licensing, and I disagree with the nonfree requirement. I can’t figure out how to reply to the old thread, but here it is for reference: https://patchwork.ffmpeg.org/patch/3230/

Re: [FFmpeg-devel] Icecast protocol implementation doesn't parse "/" as a valid mountpoint

On 30 Jan 2019, at 21:15, Carl Eugen Hoyos wrote: > 2019-01-30 16:14 GMT+01:00, c0re : > >> diff --git a/libavformat/icecast.c b/libavformat/icecast.c > > We can only read patches made with "git format-patch". I think this was just to illustrate how easy it would be to change the behavior to wo

Re: [FFmpeg-devel] [PATCH] configure: request explicitly enabled components

On 3 Feb 2019, at 16:24, Marton Balint wrote: On Sun, 3 Feb 2019, Carl Eugen Hoyos wrote: 2019-01-28 2:00 GMT+01:00, Marton Balint : If we enable a component but a dependant library is disabled, then the enabled component get silently disabled. Requesting all explicitly enabled components

Re: [FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

+if (user) +av_freep(&user); +if (headers) +av_freep(&headers); pointless ifs I'm pretty sure I need it, since there are possible cases where these are not allocated and I can't free them. ___ ffmpeg-devel mailing list ffmpe

Re: [FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

av_freep() should be safe to be used with NULL Since av_freep takes a pointer I am nearly sure that it doesn't, at least I remember that I had some issues without the if's… But please correct me if I'm wrong. ___ ffmpeg-devel mailing list ffmpeg-dev

Re: [FFmpeg-devel] [PATCH] Disable chunked output for Icecast

This is needed, I forgot completely about it. Icecast at the current version is not able to handle chunked encoding correctly, so if ffmpeg uses chunked encoding it must be disable for the Icecast protocol. On 21 Aug 2014, at 23:04, Michael Niedermayer wrote: On Wed, Aug 20, 2014 at 10:31:39A

[FFmpeg-devel] [PATCH] avdevice/avfoundation: fix macOS/iOS/tvOS SDK conditional checks

This fixes the checks to properly use runtime feature detection and check the SDK version (*_MAX_ALLOWED) instead of the targeted version for the relevant APIs. The target is still checked (*_MIN_REQUIRED) to avoid using deprecated methods when targeting new enough versions. --- libavdevice/avfou

Re: [FFmpeg-devel] [PATCH 3/4] avfilter: Deduplicate default video inputs/outputs

On 3 Aug 2023, at 16:33, Andreas Rheinhardt wrote: > Lots of video filters use a very simple input or output: > An array with a single AVFilterPad whose name is "default" > and whose type is AVMEDIA_TYPE_VIDEO; everything else is unset. > > Given that we never use pointer equality for inputs or

[FFmpeg-devel] [PATCH v3 1/5] lavfi/vf_xfade_vulkan: add circleopen/circleclose

--- libavfilter/vf_xfade_vulkan.c | 37 +++ 1 file changed, 37 insertions(+) diff --git a/libavfilter/vf_xfade_vulkan.c b/libavfilter/vf_xfade_vulkan.c index f393dde202..23c61bdb48 100644 --- a/libavfilter/vf_xfade_vulkan.c +++ b/libavfilter/vf_xfade_vulkan.c @@ -7

[FFmpeg-devel] [PATCH v3 2/5] lavfi/vf_xfade_vulkan: reindent after last commit

--- libavfilter/vf_xfade_vulkan.c | 38 +-- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/libavfilter/vf_xfade_vulkan.c b/libavfilter/vf_xfade_vulkan.c index 23c61bdb48..880b3b1afe 100644 --- a/libavfilter/vf_xfade_vulkan.c +++ b/libavfilter/vf_xfa

[FFmpeg-devel] [PATCH v3 3/5] lavfi/vf_xfade_vulkan: add dissolve

--- libavfilter/vf_xfade_vulkan.c | 20 1 file changed, 20 insertions(+) diff --git a/libavfilter/vf_xfade_vulkan.c b/libavfilter/vf_xfade_vulkan.c index 880b3b1afe..6f932d 100644 --- a/libavfilter/vf_xfade_vulkan.c +++ b/libavfilter/vf_xfade_vulkan.c @@ -79,6 +79,7 @@ en

[FFmpeg-devel] [PATCH v3 4/5] lavfi/vf_xfade_vulkan: add pixelize

--- libavfilter/vf_xfade_vulkan.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavfilter/vf_xfade_vulkan.c b/libavfilter/vf_xfade_vulkan.c index 6f932d..283a8e0710 100644 --- a/libavfilter/vf_xfade_vulkan.c +++ b/libavfilter/vf_xfade_vulkan.c @@ -80,6 +80,7 @@ enum

[FFmpeg-devel] [PATCH v3 5/5] lavfi/vf_xfade_vulkan: add wipes

Add the wipetl, wipetr, wipebl, wipebr effects. --- libavfilter/vf_xfade_vulkan.c | 60 +++ 1 file changed, 60 insertions(+) diff --git a/libavfilter/vf_xfade_vulkan.c b/libavfilter/vf_xfade_vulkan.c index 283a8e0710..fdad8c913d 100644 --- a/libavfilter/vf_xfade_vu

Re: [FFmpeg-devel] [PATCH v2 2/2] lavc/videotoolboxenc: Get the encoder supported properties

On 5 Sep 2023, at 18:02, Jun Zhao wrote: > Get the encoder supported properties list, it will be used for > feature support checks. > > Signed-off-by: Jun Zhao > --- > libavcodec/videotoolboxenc.c | 68 > 1 file changed, 45 insertions(+), 23 deletions(-) > >

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/videotoolboxenc: Get the encoder supported properties

On 8 Sep 2023, at 4:55, Jun Zhao wrote: > Get the encoder supported properties list, it will be used for > feature support checks. > > Signed-off-by: Jun Zhao > --- > libavcodec/videotoolboxenc.c | 70 > 1 file changed, 47 insertions(+), 23 deletions(-) >

Re: [FFmpeg-devel] trac backups

On 13 Sep 2023, at 0:13, Michael Niedermayer wrote: > Hi all > > our trac backups died 6 months ago > i just noticed as i checked the backups before deleting spam with trac-admin > backups are working again > > failure reason where expired gpg keys > > thx > > PS: yeah, iam slightly unhappy noo

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

> enabled libvmaf && require_pkg_config libvmaf "libvmaf >= 2.0.0" > libvmaf.h vmaf_init > +enabled libvmaf && require_pkg_config libvmaf_cuda "libvmaf >= > 2.0.0" libvmaf_cuda.h vmaf_cuda_state_init > enabled libvo_amrwbenc&& require libvo_amrwbenc vo-amrwbenc/enc_if.h

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/http: expose actual Location header value

On 19 Sep 2023, at 10:52, Michael Riedl wrote: > This is needed for muxers which need to access the Location header as > transmitted when no redirection happen. > Why are you sending the same patch over and over to the ML? If you have new versions of a patchset, reply to the original and chan

Re: [FFmpeg-devel] [PATCH 2/3] lavu/fifo: clarify interaction of AV_FIFO_FLAG_AUTO_GROW with av_fifo_can_write()

On 29 Aug 2022, at 18:03, James Almer wrote: > On 8/29/2022 12:00 PM, James Almer wrote: >> On 8/29/2022 11:07 AM, Anton Khirnov wrote: >>> --- >>>   libavutil/fifo.h | 8 +++- >>>   1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/libavutil/fifo.h b/libavutil/fifo.h >>> in

[FFmpeg-devel] [PATCH 4/7] avutil: Fix mismatching argument names

--- libavutil/hwcontext.h | 2 +- libavutil/mathematics.h | 6 -- libavutil/mem.h | 3 ++- libavutil/rational.h| 3 ++- 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/libavutil/hwcontext.h b/libavutil/hwcontext.h index c18b7e1e8b..efca17585e 100644 --- a/libavutil

[FFmpeg-devel] [PATCH 5/7] swresample/swresample: Fix mismatching argument names

--- libswresample/swresample.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libswresample/swresample.h b/libswresample/swresample.h index 980be65783..83821a0930 100644 --- a/libswresample/swresample.h +++ b/libswresample/swresample.h @@ -354,8 +354,8 @@ int swr_conve

[FFmpeg-devel] [PATCH 6/7] avformat/avformat: Improve doxy style

Mostly re-indenting and adding some missing references. --- libavformat/avformat.h | 180 +++-- 1 file changed, 103 insertions(+), 77 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index c695cfc6de..1d97d56ac5 100644 --- a/libavformat

[FFmpeg-devel] [PATCH 7/7] avcodec/avcodec: Escape Doxygen reference

The # is interpreted as explicit reference request by Doxygen which is not desired here. Additionally use a typewriter font to make the inline code easier to distinguish. --- libavcodec/avcodec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/avcodec.h b/libavcodec

[FFmpeg-devel] [PATCH 1/7] avcodec: Fix Doxygen trailing brief comments

The //< comment is not any magic comment supported by Doxygen, instead use //!< to mark them as brief doc for the members. --- libavcodec/avcodec.h | 8 libavcodec/codec_par.h | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/

[FFmpeg-devel] [PATCH 2/7] avdevice/avdevice: Fix mismatching argument name

--- libavdevice/avdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/avdevice.h b/libavdevice/avdevice.h index 0b32e59fed..185593053f 100644 --- a/libavdevice/avdevice.h +++ b/libavdevice/avdevice.h @@ -494,7 +494,7 @@ int avdevice_list_devices(struct AVFormat

[FFmpeg-devel] [PATCH 3/7] avformat/avformat: Fix mismatching argument names

--- libavformat/avformat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 9d46875cce..c695cfc6de 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -2003,7 +2003,7 @@ AVProgram *av_new_program(AVFormatC

Re: [FFmpeg-devel] [PATCH 5/7] swresample/swresample: Fix mismatching argument names

On 15 Sep 2022, at 4:12, James Almer wrote: > On 9/14/2022 10:52 PM, Marvin Scholz wrote: >> --- >> libswresample/swresample.h | 8 >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/libswresample/swresample.h b/libswresample

Re: [FFmpeg-devel] [PATCH 2/2] lavc/pthread_frame: avoid leaving stale hwaccel state in worker threads

On 12 Sep 2022, at 8:59, Wang Bin wrote: > Wang Bin 于2022年9月12日周一 10:02写道： > >> >>> av_packet_unref(p->avpkt); >>> @@ -655,6 +670,14 @@ void ff_thread_finish_setup(AVCodecContext *avctx) { >>> async_lock(p->parent); >>> } >>> >>> +/* save hwaccel state for passing to the ne

[FFmpeg-devel] [PATCH 1/2] avutil/dict: Add av_dict_iterate

This is a more explicit iteration API rather than using the "magic" av_dict_get(d, "", t, AV_DICT_IGNORE_SUFFIX) which is not really trivial to grasp what it does when casually reading through code. --- libavutil/dict.c| 19 +++ libavutil/dict.h| 27

[FFmpeg-devel] [PATCH 2/2] avutil/dict: Use av_dict_iterate in av_dict_get

--- libavutil/dict.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index 2f690a5b8e..1a348d6710 100644 --- a/libavutil/dict.c +++ b/libavutil/dict.c @@ -60,18 +60,14 @@ AVDictionaryEntry *av_dict_iterate(const AVDictionary

[FFmpeg-devel] [PATCH v2 1/7] avcodec: Fix Doxygen trailing brief comments

The //< comment is not any magic comment supported by Doxygen, instead use //!< to mark them as brief doc for the members. --- libavcodec/avcodec.h | 8 libavcodec/codec_par.h | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/

[FFmpeg-devel] [PATCH v2 2/7] avdevice/avdevice: Fix mismatching argument name

--- libavdevice/avdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/avdevice.h b/libavdevice/avdevice.h index 0b32e59fed..185593053f 100644 --- a/libavdevice/avdevice.h +++ b/libavdevice/avdevice.h @@ -494,7 +494,7 @@ int avdevice_list_devices(struct AVFormat

[FFmpeg-devel] [PATCH v2 3/7] avformat/avformat: Fix mismatching argument names

--- libavformat/avformat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 9d46875cce..c695cfc6de 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -2003,7 +2003,7 @@ AVProgram *av_new_program(AVFormatC

[FFmpeg-devel] [PATCH v2 4/7] avutil: Fix mismatching argument names

--- libavutil/hwcontext.h | 2 +- libavutil/mathematics.h | 6 -- libavutil/mem.h | 3 ++- libavutil/rational.h| 3 ++- 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/libavutil/hwcontext.h b/libavutil/hwcontext.h index c18b7e1e8b..efca17585e 100644 --- a/libavutil

[FFmpeg-devel] [PATCH v2 5/7] swresample/swresample: Fix mismatching argument names

--- libswresample/swresample.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libswresample/swresample.h b/libswresample/swresample.h index 980be65783..4c26468c63 100644 --- a/libswresample/swresample.h +++ b/libswresample/swresample.h @@ -354,8 +354,8 @@ int swr_conve

[FFmpeg-devel] [PATCH v2 6/7] avformat/avformat: Improve doxy style

Mostly re-indenting and adding some missing references. --- libavformat/avformat.h | 180 +++-- 1 file changed, 103 insertions(+), 77 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index c695cfc6de..1d97d56ac5 100644 --- a/libavformat

[FFmpeg-devel] [PATCH v2 7/7] avcodec/avcodec: Escape Doxygen reference

The # is interpreted as explicit reference request by Doxygen which is not desired here. Additionally use a typewriter font to make the inline code easier to distinguish. --- libavcodec/avcodec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/avcodec.h b/libavcodec

Re: [FFmpeg-devel] [PATCH 1/2] avutil/dict: Add av_dict_iterate

On 22 Sep 2022, at 13:33, Andreas Rheinhardt wrote: > Marvin Scholz: >> This is a more explicit iteration API rather than using the "magic" >> av_dict_get(d, "", t, AV_DICT_IGNORE_SUFFIX) which is not really >> trivial to grasp what i

[FFmpeg-devel] [PATCH 1/2] fftools: Remove unused qsv declarations

--- fftools/ffmpeg.h | 4 1 file changed, 4 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index ede0b2bd96..db7413adcd 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -686,9 +686,6 @@ extern int auto_conversion_filters; extern const AVIOInterruptCB int_cb; extern

[FFmpeg-devel] [PATCH 2/2] fftools: Remove unused videotoolbox_init declaration

--- fftools/ffmpeg.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index db7413adcd..701a211544 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -712,8 +712,6 @@ int ifilter_parameters_from_frame(InputFilter *ifilter, const AVFrame *frame); int

[FFmpeg-devel] [PATCH v2 1/2] fftools: Remove unused qsv declarations

The code that uses these was removed in ecee3b07cde23e05bcc6b4eaa55d860b62dbd2dc --- fftools/ffmpeg.h | 4 1 file changed, 4 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index ede0b2bd96..db7413adcd 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -686,9 +686,6 @@ ext

[FFmpeg-devel] [PATCH v2 2/2] fftools: Remove unused videotoolbox_init declaration

The code that defined videotoolbox_init was removed in 4b54818981d2783af161c2ff670b658afbdda503 --- fftools/ffmpeg.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index db7413adcd..701a211544 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -712,8

[FFmpeg-devel] [PATCH v2 1/5] avutil/dict: Add av_dict_iterate

This is a more explicit iteration API rather than using the "magic" av_dict_get(d, "", t, AV_DICT_IGNORE_SUFFIX) which is not really trivial to grasp what it does when casually reading through code. --- libavutil/dict.c| 19 +++ libavutil/dict.h| 46

[FFmpeg-devel] [PATCH v2 2/5] avutil/dict: Use av_dict_iterate in av_dict_get

--- libavutil/dict.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index ee059d712c..ea03590d0f 100644 --- a/libavutil/dict.c +++ b/libavutil/dict.c @@ -60,18 +60,14 @@ const AVDictionaryEntry *av_dict_iterate(const AVDict

[FFmpeg-devel] [PATCH v2 3/5] avutil/dict: Use av_dict_iterate in av_dict_copy

--- libavutil/dict.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index ea03590d0f..3c05ed4c84 100644 --- a/libavutil/dict.c +++ b/libavutil/dict.c @@ -236,9 +236,9 @@ void av_dict_free(AVDictionary **pm) int av_dict_copy(AVDictiona

[FFmpeg-devel] [PATCH v2 4/5] avutil/dict: Use av_dict_iterate in av_dict_get_string

--- libavutil/dict.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index 3c05ed4c84..122606e3aa 100644 --- a/libavutil/dict.c +++ b/libavutil/dict.c @@ -250,7 +250,7 @@ int av_dict_copy(AVDictionary **dst, const AVDictionary *src, int

[FFmpeg-devel] [PATCH v2 5/5] avutil/dict: Improve documentation

Mostly consistent formatting and consistently ordering of warnings/notes to be next to the description. Additionally group the AV_DICT_* macros. --- libavutil/dict.h | 91 +--- 1 file changed, 55 insertions(+), 36 deletions(-) diff --git a/libavutil/di

Re: [FFmpeg-devel] [PATCH] Update sample upload instructions

On 17 May 2022, at 12:43, Marvin Scholz wrote: > The previous instructions do not work, there is no FTP server > running at upload.ffmpeg.org > (which is an alias for streams.videolan.org) > > Signed-off-by: Marvin Scholz > --- > src/bugreports | 16 +++-

[FFmpeg-devel] [PATCH] Makefile: Build complete doc with Doxygen

Add DISABLEDINSTHEADERS, a variable containing the headers of disabled libraries. This is needed so that Doxygen does not generate incomplete documentation when a component is disabled, which is quite unexpected behaviour and results in warnings due to, among other things, broken references. --- M

[FFmpeg-devel] [PATCH v3 00/54] Various Doxygen fixes

ygen trailing brief comments" - All patches after "avcodec/avcodec: Escape Doxygen reference" are new and were not in the previous set. Marvin Scholz (54): avcodec: Fix Doxygen trailing brief comments avdevice/avdevice: Fix mismatching argument name avformat/avformat: Fi

[FFmpeg-devel] [PATCH v3 01/54] avcodec: Fix Doxygen trailing brief comments

The //< comment is not any magic comment supported by Doxygen, instead use ///< to mark them as doc for the members. --- libavcodec/avcodec.h | 8 libavcodec/codec_par.h | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcode

[FFmpeg-devel] [PATCH v3 02/54] avdevice/avdevice: Fix mismatching argument name

--- libavdevice/avdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/avdevice.h b/libavdevice/avdevice.h index 0b32e59fed..185593053f 100644 --- a/libavdevice/avdevice.h +++ b/libavdevice/avdevice.h @@ -494,7 +494,7 @@ int avdevice_list_devices(struct AVFormat

[FFmpeg-devel] [PATCH v3 03/54] avformat/avformat: Fix mismatching argument names

--- libavformat/avformat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 9d46875cce..c695cfc6de 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -2003,7 +2003,7 @@ AVProgram *av_new_program(AVFormatC

[FFmpeg-devel] [PATCH v3 04/54] avutil: Fix mismatching argument names

--- libavutil/hwcontext.h | 2 +- libavutil/mathematics.h | 6 -- libavutil/mem.h | 3 ++- libavutil/rational.h| 3 ++- 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/libavutil/hwcontext.h b/libavutil/hwcontext.h index c18b7e1e8b..efca17585e 100644 --- a/libavutil

[FFmpeg-devel] [PATCH v3 05/54] swresample/swresample: Fix mismatching argument names

--- libswresample/swresample.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libswresample/swresample.h b/libswresample/swresample.h index 980be65783..4c26468c63 100644 --- a/libswresample/swresample.h +++ b/libswresample/swresample.h @@ -354,8 +354,8 @@ int swr_conve

[FFmpeg-devel] [PATCH v3 10/54] avutil/channel_layout: Group deprecated functions

Makes it a bit easier to spot the deprecated ones when looking at the overview. --- libavutil/channel_layout.h | 8 1 file changed, 8 insertions(+) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index 070c98072b..52af52390c 100644 --- a/libavutil/channel_layout.h ++

[FFmpeg-devel] [PATCH v3 06/54] avformat/avformat: Improve doxy style

Mostly re-indenting and adding some missing references. --- libavformat/avformat.h | 180 +++-- 1 file changed, 103 insertions(+), 77 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index c695cfc6de..1d97d56ac5 100644 --- a/libavformat

[FFmpeg-devel] [PATCH v3 11/54] avutil/channel_layout: Group pre-defined channel layouts

--- libavutil/channel_layout.h | 5 + 1 file changed, 5 insertions(+) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index 52af52390c..6415355662 100644 --- a/libavutil/channel_layout.h +++ b/libavutil/channel_layout.h @@ -359,6 +359,10 @@ typedef struct AVChannelLayout

[FFmpeg-devel] [PATCH v3 07/54] avcodec/avcodec: Escape Doxygen reference

The # is interpreted as explicit reference request by Doxygen which is not desired here, use markdown inline code to avoid that. --- libavcodec/avcodec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 9f79e61dc9..fb60331a31 100

[FFmpeg-devel] [PATCH v3 08/54] avutil/channel_layout: Remove bogus closing group

--- libavutil/channel_layout.h | 1 - 1 file changed, 1 deletion(-) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index 9e685fab72..74fe3a8328 100644 --- a/libavutil/channel_layout.h +++ b/libavutil/channel_layout.h @@ -745,7 +745,6 @@ int av_channel_layout_check(const AVCh

[FFmpeg-devel] [PATCH v3 12/54] avutil/twofish: Fix doxy @param typo

--- libavutil/twofish.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/twofish.h b/libavutil/twofish.h index 813cfecdf8..67f359e88c 100644 --- a/libavutil/twofish.h +++ b/libavutil/twofish.h @@ -59,7 +59,7 @@ int av_twofish_init(struct AVTWOFISH *ctx, const uint8_t

[FFmpeg-devel] [PATCH v3 09/54] avutil/channel_layout: Move to its own group

Before it was cluttering the general avutil Audio group page. --- libavutil/channel_layout.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index 74fe3a8328..070c98072b 100644 --- a/libavutil/channel_layout.h +

[FFmpeg-devel] [PATCH v3 13/54] avcodec/vdpau: Fix doxy comment typo

This is clearly supposed to be a doxy comment and needed to properly close the group. --- libavcodec/vdpau.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vdpau.h b/libavcodec/vdpau.h index 3010094d93..35c4b1096b 100644 --- a/libavcodec/vdpau.h +++ b/libavcodec/vdp

[FFmpeg-devel] [PATCH v3 14/54] avcodec/codec_par: Add missing doxy group opening

--- libavcodec/codec_par.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/codec_par.h b/libavcodec/codec_par.h index fa132814b1..f51d27c590 100644 --- a/libavcodec/codec_par.h +++ b/libavcodec/codec_par.h @@ -32,6 +32,7 @@ /** * @addtogroup lavc_core + * @{ */ enum AVFiel

[FFmpeg-devel] [PATCH v3 15/54] avcodec/videotoolbox: Add proper doxy group

Same as done for other HW decoders, that way it will be properly listed on the relevant module page. --- libavcodec/videotoolbox.h | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/videotoolbox.h b/libavcodec/videotoolbox.h index fd8a5b7982..cc324faa52 100644 --- a/libavcodec

  1   2   3   4   5   6   >