[FFmpeg-devel] [PATCH 1/5] fftools/ffmpeg_demux: also set -ch_layout avcodec option for -ch_layout CLI param

2024-05-18 Thread Marton Balint
since 639c2f00497257cb60ecaeeac1aacfa80df3be06. Signed-off-by: Marton Balint --- doc/ffmpeg.texi| 7 --- fftools/ffmpeg_demux.c | 46 +- 2 files changed, 32 insertions(+), 21 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index da37e3ad37..83db6584fd 100644 ---

[FFmpeg-devel] [PATCH 2/5] doc/ffmpeg: document -channel_layout/ch_layout options

2024-05-18 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/ffmpeg.texi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 83db6584fd..9b490f523f 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -1720,6 +1720,16 @@ This is an alias for @code{-filter:a}, see the

[FFmpeg-devel] [PATCH 3/5] fftools: move check_avoptions and remove_avoptions to cmdutils

2024-05-18 Thread Marton Balint
Signed-off-by: Marton Balint --- fftools/cmdutils.c | 20 fftools/cmdutils.h | 6 ++ fftools/ffmpeg.c | 20 fftools/ffmpeg.h | 3 --- 4 files changed, 26 insertions(+), 23 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index

[FFmpeg-devel] [PATCH 4/5] fftools/ffplay: use cmdutils code for checking remaining avoptions

2024-05-18 Thread Marton Balint
Signed-off-by: Marton Balint --- fftools/ffplay.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index b9d11eecee..ff48fa5f8c 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -2626,7 +2626,6 @@ static int

[FFmpeg-devel] [PATCH 5/5] fftools/ffplay: allow unused format options which are also codec options

2024-05-18 Thread Marton Balint
Same as it is handled in ffmpeg, allows using -ch_layout codec option. Signed-off-by: Marton Balint --- fftools/ffplay.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index ff48fa5f8c..1d0511b254 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mp3dec: only call ffio_ensure_seekback once

2024-05-18 Thread Marton Balint
On Tue, 14 May 2024, Marton Balint wrote: Otherwise the subsequent ffio_ensure_seekback calls destroy the buffer of the earlier. The worst case ~66kB seekback is so small it is easier to request it entirely. Fixes ticket #10837, a regression since 0d17f5228f4d3854066ec1001f69c7d1714b0df9

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-19 Thread Marton Balint
On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote: This commit adds a decoder for the frequency-domain part of USAC. [...] +/* Finish later */ +static const enum AVChannel usac_ch_pos_to_av[64] = { +[0] = AV_CHAN_FRONT_LEFT, +[1] = AV_CHAN_FRONT_RIGHT, +[2] = AV_CHAN_FRONT_CE

[FFmpeg-devel] [PATCH v2 1/5] fftools/ffmpeg_demux: honor -ch_layout options for overriding input stream channel layout

2024-05-19 Thread Marton Balint
ected results. We disable layout guessing, if a channel layout is specified. Fixes ticket #11016. Signed-off-by: Marton Balint --- fftools/ffmpeg_demux.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c

[FFmpeg-devel] [PATCH v2 2/5] doc/ffmpeg: document -channel_layout/ch_layout options

2024-05-19 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/ffmpeg.texi | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index da37e3ad37..f25f6192eb 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -1719,12 +1719,21 @@ This is an alias for @code

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-21 Thread Marton Balint
On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote: On 19/05/2024 21:39, Marton Balint wrote: On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote: This commit adds a decoder for the frequency-domain part of USAC. [...] +/* Finish later */ +static const enum AVChannel

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-21 Thread Marton Balint
On Tue, 21 May 2024, Lynne via ffmpeg-devel wrote: On 21/05/2024 09:16, Marton Balint wrote: On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote: On 19/05/2024 21:39, Marton Balint wrote:  On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote:  This commit adds a decoder for the

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-21 Thread Marton Balint
On Tue, 21 May 2024, Lynne via ffmpeg-devel wrote: On 21/05/2024 21:40, Marton Balint wrote: On Tue, 21 May 2024, Lynne via ffmpeg-devel wrote: On 21/05/2024 09:16, Marton Balint wrote:  On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote:  On 19/05/2024 21:39, Marton Balint wrote

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

2024-05-22 Thread Marton Balint
On Wed, 22 May 2024, Lynne via ffmpeg-devel wrote: On 21/05/2024 23:33, Hendrik Leppkes wrote: On Tue, May 21, 2024 at 9:52 PM Lynne via ffmpeg-devel wrote: It should be the case here, we shouldn't need reordering as NATIVE just lets you specify what order the elements appear in the b

Re: [FFmpeg-devel] [PATCH 2/4] fftools/ffmpeg: rewrite checking whether codec AVOptions have been used

2024-05-23 Thread Marton Balint
On Thu, 23 May 2024, Anton Khirnov wrote: Share the code between encoding and decoding. Instead of checking every stream's options dictionary (which is also used for other purposes), track all used options in a dedicated dictionary. --- fftools/cmdutils.c| 17 fftools/cmdu

Re: [FFmpeg-devel] [PATCH v3 01/10] channel_layout: add new channel positions supported by xHE-AAC

2024-05-24 Thread Marton Balint
On Sat, 25 May 2024, Lynne via ffmpeg-devel wrote: apichanges will be updated upon merging, as well as a version bump. --- libavutil/channel_layout.h | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index 8a078d1601..4e19bbbd9e 100

Re: [FFmpeg-devel] [PATCH v2 1/5] fftools/ffmpeg_demux: honor -ch_layout options for overriding input stream channel layout

2024-05-25 Thread Marton Balint
On Sun, 19 May 2024, Marton Balint wrote: The code only set the channel layout of the AVFormatContext, so the user could not override the channel layout if the demuxer did not have such parameter. This used to work via the respective AVCodecContext option, but since

Re: [FFmpeg-devel] [PATCH v3 01/10] channel_layout: add new channel positions supported by xHE-AAC

2024-05-26 Thread Marton Balint
On Sun, 26 May 2024, Lynne via ffmpeg-devel wrote: On 25/05/2024 08:10, Marton Balint wrote: On Sat, 25 May 2024, Lynne via ffmpeg-devel wrote: apichanges will be updated upon merging, as well as a version bump. --- libavutil/channel_layout.h | 4 1 file changed, 4 insertions

[FFmpeg-devel] [PATCH 1/3] avformat/mov_chan: use the newly added channel ids for more exact mapping

2024-06-03 Thread Marton Balint
Also make the iso_channel_position table consistent with what the AAC decoder uses in avcodec/aac/aacdec_usac.c. Fate changes are caused by the change of how 7.1 layout is mapped, previously it included Side Surround channels, now it includes the Surround channels. Signed-off-by: Marton Balint

[FFmpeg-devel] [PATCH 2/3] avformat/mov_chan: make iso_channel_position table more compact

2024-06-03 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mov_chan.c | 164 +++-- 1 file changed, 45 insertions(+), 119 deletions(-) diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c index 53805c6a35..cc5b333129 100644 --- a/libavformat/mov_chan.c +++ b

[FFmpeg-devel] [PATCH 3/3] avformat/mxfdec: use the newly added channel ids for more exact mapping

2024-06-03 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index e65cec74c2..78a3ec6b06 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1668,8 +1668,8 @@ static

[FFmpeg-devel] [PATCH] fftools/ffmpeg_demux: gracefully ignore mismatching channel layouts for -channel_layout option

2024-06-03 Thread Marton Balint
no easy way for the user to specify a channel layout only for streams with matching number of channels, so this patch restores the very old behaviour of ignoring mismatching layouts. See the discussion in ticket #11016. Signed-off-by: Marton Balint --- fftools/ffmpeg_demux.c | 9 + 1 file

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-05 Thread Marton Balint
On Tue, 4 Jun 2024, Vittorio Giovara wrote: If you stop responding with mails on all FFmpeg mailing lists from now to indefinite time in future nothing of value would be lost. Please reread what you wrote and appreciate the irony of the situation. Needless to say, this is also going strai

Re: [FFmpeg-devel] New CC member: Steven Liu

2024-06-05 Thread Marton Balint
On Tue, 4 Jun 2024, Ronald S. Bultje wrote: Hi all, Anton resigned from the CC [1], leaving an empty spot. The remaining members of the CC agreed it would be best to fill the spot with the next runner-up from the last CC Elections. The last CC election results [2] had Steven Liu as next runn

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: add -scaling_quality option for SDL

2024-06-10 Thread Marton Balint
On Tue, 4 Jun 2024, Ramiro Polla wrote: On Thu, May 30, 2024 at 11:36 PM Ramiro Polla wrote: --- doc/ffplay.texi | 2 ++ fftools/ffplay.c | 6 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/ffplay.texi b/doc/ffplay.texi index 93f77eeece..60f883e159 100644 --- a/d

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_demux: gracefully ignore mismatching channel layouts for -channel_layout option

2024-06-10 Thread Marton Balint
On Wed, 5 Jun 2024, Anton Khirnov wrote: Quoting Marton Balint (2024-06-03 23:48:47) The very old behaviour of -channel_layout was to simply warn the user about channel layouts which does not have a matching channel count, and ignore them, instead of reporting an error. The recent fix re

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov_chan: use the newly added channel ids for more exact mapping

2024-06-10 Thread Marton Balint
On Mon, 3 Jun 2024, Marton Balint wrote: Also make the iso_channel_position table consistent with what the AAC decoder uses in avcodec/aac/aacdec_usac.c. Fate changes are caused by the change of how 7.1 layout is mapped, previously it included Side Surround channels, now it includes the

[FFmpeg-devel] [PATCH] avutil/timestamp: avoid possible FPE when 0 is passed to av_ts_make_time_string2()

2024-06-17 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/timestamp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/timestamp.c b/libavutil/timestamp.c index 2a3e3012a4..6c231a517d 100644 --- a/libavutil/timestamp.c +++ b/libavutil/timestamp.c @@ -24,7 +24,7 @@ char

Re: [FFmpeg-devel] [PATCH] avutil/timestamp: avoid possible FPE when 0 is passed to av_ts_make_time_string2()

2024-06-18 Thread Marton Balint
On Tue, 18 Jun 2024, Rémi Denis-Courmont wrote: Le 17 juin 2024 22:33:01 GMT+02:00, Marton Balint a écrit : Signed-off-by: Marton Balint --- libavutil/timestamp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/timestamp.c b/libavutil/timestamp.c index

Re: [FFmpeg-devel] [PATCH 1/3] fftools/ffmpeg: rewrite checking whether codec AVOptions have been used

2024-06-27 Thread Marton Balint
On Thu, 27 Jun 2024, Anton Khirnov wrote: Share the code between encoding and decoding. Instead of checking every stream's options dictionary (which is also used for other purposes), track all used options in a dedicated dictionary. --- fftools/cmdutils.c| 17 fftools/cmdu

Re: [FFmpeg-devel] [PATCH] avutil/timestamp: avoid possible FPE when 0 is passed to av_ts_make_time_string2()

2024-06-29 Thread Marton Balint
On Tue, 18 Jun 2024, Marton Balint wrote: On Tue, 18 Jun 2024, Rémi Denis-Courmont wrote: Le 17 juin 2024 22:33:01 GMT+02:00, Marton Balint a écrit : Signed-off-by: Marton Balint --- libavutil/timestamp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [FFmpeg-devel] [PATCH 2/3] librist: allow use of circular buffer for receiving.

2021-09-28 Thread Marton Balint
On Tue, 28 Sep 2021, Gijs Peskens wrote: libRIST internally stores packets in a fifo of 1024 packets, overwriting old packets when not read in a sufficient pace. Unfortunately this results in many fifo overflow errors when ffmpeg consumes a libRIST stream. This patch creates a receiver thread

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mpegts: use named constants for stream_id types

2021-10-09 Thread Marton Balint
On Wed, 22 Sep 2021, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/mpegts.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) Will apply the series. Regards, Marton diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index da8eee2414

Re: [FFmpeg-devel] [PATCH 1/3] librist: replace deprecated functions.

2021-10-10 Thread Marton Balint
On Tue, 28 Sep 2021, Gijs Peskens wrote: This gets rid of of rist_receiver_data_read, rist_receiver_data_block_free and rist_parse_address these functions have been deprecated since librist release v0.2.1 and are replaced with functions suffixed with 2. I added a version macro check at the

Re: [FFmpeg-devel] [PATCH 3/3] librist: set logsocket config to -1

2021-10-10 Thread Marton Balint
On Tue, 28 Sep 2021, Gijs Peskens wrote: Signed-off-by: Gijs Peskens --- libavformat/librist.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/librist.c b/libavformat/librist.c index 47c01a8432..987056ccd1 100644 --- a/libavformat/librist.c +++ b/libavformat/librist.c @@ -245,

Re: [FFmpeg-devel] [PATCH] libavcodec/avpacket: add av_packet_remove_side_data

2021-10-11 Thread Marton Balint
On Mon, 11 Oct 2021, Zhao Zhili wrote: --- doc/APIchanges | 3 +++ libavcodec/avpacket.c | 15 +++ libavcodec/packet.h | 5 + libavcodec/tests/avpacket.c | 9 + libavcodec/version.h| 2 +- 5 files changed, 33 insertions(+), 1 deletion(

Re: [FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-10-12 Thread Marton Balint
On Tue, 12 Oct 2021, Tomas Härdin wrote: mån 2021-10-11 klockan 18:32 +0200 skrev Marc-Antoine Arnaud: ---  libavformat/mxf.h    |   1 +  libavformat/mxfdec.c | 276 ++-  2 files changed, 271 insertions(+), 6 deletions(-) Did we reach a consensus on th

Re: [FFmpeg-devel] [PATCH 8/8] avformat/mpegts: return proper error codes

2021-10-14 Thread Marton Balint
On Thu, 14 Oct 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegts.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) No, parse_stream_identifier_desc intentionally returns -1 for error, check how the code works which us

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: don't disable x11 compositing

2021-10-28 Thread Marton Balint
On Wed, 27 Oct 2021, Zane van Iperen wrote: Prevents desktop stutters caused by the change (specifically on KDE). We're not a game, we don't actually need it disabled. Signed-off-by: Zane van Iperen --- fftools/ffplay.c | 4 1 file changed, 4 insertions(+) diff --git a/fftools/ffplay.c

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: don't disable x11 compositing

2021-10-28 Thread Marton Balint
On Fri, 29 Oct 2021, Marton Balint wrote: On Wed, 27 Oct 2021, Zane van Iperen wrote: Prevents desktop stutters caused by the change (specifically on KDE). We're not a game, we don't actually need it disabled. Signed-off-by: Zane van Iperen --- fftools/ffplay.c | 4 ++

Re: [FFmpeg-devel] [PATCH] Fix first_pcr initial update

2021-11-06 Thread Marton Balint
On Wed, 3 Nov 2021, lance.lmw...@gmail.com wrote: On Wed, Nov 03, 2021 at 01:01:29PM +0200, Maksym Veremeyenko wrote: On 02.11.2021 12:47, Maksym Veremeyenko wrote: > One of latest commit https://source.ffmpeg.org/?p=ffmpeg.git;a=commitdiff;h=6f36eb0da71d22aadf8f056f0966bd86656ea57e > claim

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Dont include adaptation field in teletext TS packets.

2021-11-06 Thread Marton Balint
On Thu, 21 Oct 2021, Alex Shumsky wrote: From ETSI EN 300 472 V1.3.1 (2003-05) Specification for conveying ITU-R System B Teletext in DVB bitstreams: 4.1 Transport Stream (TS) packet format The standard TS packet syntax and semantics are followed, noting the following constraint: - adaptat

Re: [FFmpeg-devel] [PATCH v4] avformat/libsrt: print streamid at client

2021-11-06 Thread Marton Balint
On Mon, 25 Oct 2021, Raghavendra Rao Sidlagatta wrote: On Friday, July 23, 2021 10:59 BST, "Raghavendra Rao Sidlagatta" wrote:    On Monday, March 22, 2021 06:45 GMT, "Raghavendra Rao Sidlagatta" wrote:    On Wednesday, January 20, 2021 09:48 GMT, "Raghavendra Rao Sidlagatta" wrote:   

Re: [FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-11-07 Thread Marton Balint
On Fri, 5 Nov 2021, Marc-Antoine Arnaud wrote: --- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 280 ++- 2 files changed, 275 insertions(+), 6 deletions(-) Could you mention in the commit description which standards/recommendations cover MCA i

Re: [FFmpeg-devel] [PATCH] http: make caching of redirect url optional

2021-11-07 Thread Marton Balint
On Tue, 2 Nov 2021, Eran Kornblau wrote: Hi all, The attached patch makes the default behavior of caching HTTP redirects optional. Is caching a redirected URL allowed per the HTTP spec? If not, then no caching should take place, or the caching should be optional, and not the default.

[FFmpeg-devel] [PATCH] avformat/demux: allow total size of packets in raw_packet_buffer to reach probesize

2021-11-07 Thread Marton Balint
Previously this was hardcoded to 250 bytes, so probing of the stream codecs was always limited by this, and not probesize. Also keep track of the actual size of packets in raw_packet_buffer and not the remaining size for simplicity. Fixes ticket #5860. Signed-off-by: Marton Balint

Re: [FFmpeg-devel] [PATCH] avfilter/af_apad: do not add infinte silence for zero pad_dur or whole_dur

2021-11-07 Thread Marton Balint
On Thu, 29 Jul 2021, Marton Balint wrote: Unfortunately pad_len and pad_dur behaviour was different if 0 was specified, pad_dur handled 0 duration as infinity, for pad_len, infinity was -1. Let's make the behaviour consistent by handling 0 duration for pad_dur and whole_dur as ind

Re: [FFmpeg-devel] FFmpeg UDP multicast support broken on OpenBSD

2021-11-12 Thread Marton Balint
On Fri, 12 Nov 2021, Brad Smith wrote: Hi, I am looking for some feedback regarding a ticket I opened for UDP multicast support currently being broken on OpenBSD. https://trac.ffmpeg.org/ticket/9449 Well, send the patch to the list. I believe it is platform dependant which type should

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxf: support MCA audio information

2021-11-13 Thread Marton Balint
On Wed, 10 Nov 2021, Marc-Antoine Arnaud wrote: --- doc/demuxers.texi | 10 ++ libavformat/mxf.h | 1 + libavformat/mxfdec.c | 284 +- libavformat/version.h | 2 +- 4 files changed, 290 insertions(+), 7 deletions(-) [...] @@ -2688,6 +2841,

Re: [FFmpeg-devel] [PATCH 2/6] lavf: add an AVClass to AVStream on next major bump

2021-11-13 Thread Marton Balint
On Fri, 12 Nov 2021, Lynne wrote: 12 Nov 2021, 20:00 by h.lepp...@gmail.com: On Fri, Nov 12, 2021 at 5:47 PM Anton Khirnov wrote: Quoting James Almer (2021-11-12 17:36:58) On 11/12/2021 1:32 PM, Anton Khirnov wrote: Also add a function to retrieve that class, analogously to avformat_g

Re: [FFmpeg-devel] [PATCH] avformat/demux: allow total size of packets in raw_packet_buffer to reach probesize

2021-11-13 Thread Marton Balint
On Sun, 7 Nov 2021, Marton Balint wrote: Previously this was hardcoded to 250 bytes, so probing of the stream codecs was always limited by this, and not probesize. Also keep track of the actual size of packets in raw_packet_buffer and not the remaining size for simplicity. Fixes ticket

Re: [FFmpeg-devel] [PATCH] avfilter/af_apad: do not add infinte silence for zero pad_dur or whole_dur

2021-11-13 Thread Marton Balint
On Sun, 7 Nov 2021, Marton Balint wrote: On Thu, 29 Jul 2021, Marton Balint wrote: Unfortunately pad_len and pad_dur behaviour was different if 0 was specified, pad_dur handled 0 duration as infinity, for pad_len, infinity was -1. Let's make the behaviour consistent by handl

Re: [FFmpeg-devel] Collection Ping (softworkz)

2021-11-13 Thread Marton Balint
On Wed, 10 Nov 2021, Soft Works wrote: Hi, I thought it might be more friendly to ping for my pending patches in a single message. Here’s the list of my pending (mostly unresponded) patch sets: [FFmpeg-devel,v2] DXVA2: Add ARGB format https://patchwork.ffmpeg.org/bundle/softworkz/Pending_

Re: [FFmpeg-devel] [PATCH v3 1/1] avutil/frame: Document the possibility of negative line sizes

2021-11-18 Thread Marton Balint
On Sun, 14 Nov 2021, Soft Works wrote: Signed-off-by: softworkz --- v3: fixed patch, removed comment about 0 line size libavutil/frame.h | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/libavutil/frame.h b/libavutil/frame.h index ff2540a20f..31def23d8b 1

Re: [FFmpeg-devel] [PATCH 1/2] libRIST: Correctly initialize logging_settings

2021-11-18 Thread Marton Balint
On Wed, 17 Nov 2021, Gijs Peskens wrote: Correct solution as suggested by Martin Balint on ffmpeg-devel --- libavformat/librist.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/librist.c b/libavformat/librist.c index 6eae90cc2f..378b635ea7 100644 --- a/libavformat/librist.c ++

Re: [FFmpeg-devel] [PATCH 2/2] libRIST: allow setting fifo size and fail on overflow.

2021-11-18 Thread Marton Balint
On Wed, 17 Nov 2021, Gijs Peskens wrote: Introduce fifo_size and overrun_nonfatal params to configure fifo buffer behavior. Fifo size is used to left shift 2, since libRIST only accepts powers of 2. Can you please make fifo_size simply mean the number of packets? User facing options should

[FFmpeg-devel] [PATCH] avformat/libsrt: add missing version check for snddropdelay

2021-11-19 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/libsrt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index 145eea2f7c..19b9cb9895 100644 --- a/libavformat/libsrt.c +++ b/libavformat/libsrt.c @@ -320,7 +320,9 @@ static int libsrt_set_options_pre

[FFmpeg-devel] [PATCH] avformat/mpegts: fix stream index in verbose log message

2021-11-21 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mpegts.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 29a267436f..36ab7ab3af 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -2238,11 +2238,10 @@ static

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: add missing version check for snddropdelay

2021-11-25 Thread Marton Balint
On Sat, 20 Nov 2021, lance.lmw...@gmail.com wrote: On Fri, Nov 19, 2021 at 09:29:01PM +0100, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/libsrt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index 145eea2f7c

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: fix stream index in verbose log message

2021-11-25 Thread Marton Balint
On Mon, 22 Nov 2021, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/mpegts.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 29a267436f..36ab7ab3af 100644 --- a/libavformat/mpegts.c +++ b

Re: [FFmpeg-devel] [PATCH v2] lavu/avframe: add a time_base field

2021-11-25 Thread Marton Balint
On Thu, 25 Nov 2021, Lynne wrote: This adds a time_base field (currently unused), analogue to the AVPacket.time_base field. This allows for API clients to exchange AVFrames directly, without needing to plumb extra data from sources via side mechanisms. The objections raised before still sta

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxf: support MCA audio information

2021-11-28 Thread Marton Balint
On Thu, 25 Nov 2021, Marc-Antoine Arnaud wrote: --- doc/demuxers.texi | 10 ++ libavformat/mxf.h | 1 + libavformat/mxfdec.c | 293 +- libavformat/version.h | 2 +- 4 files changed, 299 insertions(+), 7 deletions(-) I went through this, and

[FFmpeg-devel] [PATCH 2/5] avformat/mxfdec: remove uneeded check before av_freep

2021-11-28 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 58ba330475..8cb66b73c4 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -375,8 +375,7 @@ static void

[FFmpeg-devel] [PATCH 1/5] avformat/mxf: support MCA audio information

2021-11-28 Thread Marton Balint
From: Marc-Antoine Arnaud Signed-off-by: Marton Balint --- doc/demuxers.texi | 10 ++ libavformat/mxf.h | 1 + libavformat/mxfdec.c | 293 +- libavformat/version.h | 2 +- 4 files changed, 299 insertions(+), 7 deletions(-) diff --git a/doc

[FFmpeg-devel] [PATCH 3/5] avformat/mxfdec: also check for non-positive number of channels

2021-11-28 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 8cb66b73c4..e0a52e3883 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -2843,8 +2843,8 @@ static int

[FFmpeg-devel] [PATCH 4/5] avformat/mxfdec: do not ignore mxf_read_strong_ref_array return value when reading sub descriptors

2021-11-28 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index e0a52e3883..229c02a85e 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1419,7 +1419,7 @@ static int

[FFmpeg-devel] [PATCH 5/5] avformat/mxfdec: rework MCA channel layout parsing

2021-11-28 Thread Marton Balint
channel is now based on MCA group link ID. The language of the first GroupOfSoundfieldGroups which a SoundfieldGroup is part of is also considered if the SoundfieldGroup has no language metadata. Signed-off-by: Marton Balint --- libavformat/mxf.h| 4 +- libavformat/mxfdec.c | 333

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mxfdec: rework MCA channel layout parsing

2021-11-29 Thread Marton Balint
On Sun, 28 Nov 2021, Pierre-Anthony Lemieux wrote: On Sun, Nov 28, 2021 at 5:00 PM Marton Balint wrote: Setting the channel layout was based on SoundfieldGroupLabelSubDescriptor, but this was wrong, because soundfield groups are not necessarily used and a file can also contain e.g. a

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/flvenc.c: avoid 24bit timestamp truncation for FLV metadata

2021-11-29 Thread Marton Balint
On Fri, 26 Nov 2021, asilvestre wrote: FLV AMF tags have a 24bit field for timestamps plus an 8bit for extended timestamps. All FLV AMF tags except when we write metadata handle this correctly using the put_timestamp function. Until now when writing metadata we were only using the first 24

Re: [FFmpeg-devel] [PATCH v2] lavu/avframe: add a time_base field

2021-11-29 Thread Marton Balint
On Fri, 26 Nov 2021, Lynne wrote: 25 Nov 2021, 23:49 by c...@passwd.hu: On Thu, 25 Nov 2021, Lynne wrote: This adds a time_base field (currently unused), analogue to the AVPacket.time_base field. This allows for API clients to exchange AVFrames directly, without needing to plumb extra d

Re: [FFmpeg-devel] [PATCH v3 1/1] fftools/ffprobe: print size of attachment streams (extradata_size)

2021-11-29 Thread Marton Balint
On Fri, 26 Nov 2021, Michael Niedermayer wrote: On Thu, Nov 25, 2021 at 04:59:41PM +, Soft Works wrote: Another attempt: Created on Linux and zipped... tested and works LGTM Applied. Thanks, Marton ___ ffmpeg-devel mailing list ffmpeg-deve

Re: [FFmpeg-devel] [PATCH] libavformat/fifo: avoid repeated failure and recovery

2021-11-29 Thread Marton Balint
On Mon, 22 Nov 2021, Ryoji Gyoda wrote: If fifo_thread_recover() succeeds immediately after fifo_thread_dispatch_message() fails, the dts of the packet is scaled twice, causing cur_dts to be abnormally large and "Application provided invalid, non monotonically increasing dts to muxer in strea

[FFmpeg-devel] [PATCH 1/5] avformat/file: use proper return value in file_close

2021-11-29 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/file.c b/libavformat/file.c index 9c23f680cd..7001750c80 100644 --- a/libavformat/file.c +++ b/libavformat/file.c @@ -266,7 +266,8 @@ static int64_t file_seek

[FFmpeg-devel] [PATCH 2/5] avformat/aviobuf: return stored AVIO context error on avio_close

2021-11-29 Thread Marton Balint
Otherwise IO errors at avio_flush() before closing may be lost. Signed-off-by: Marton Balint --- libavformat/aviobuf.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index 5da4dea7b6..d65c7b535d 100644 --- a/libavformat

[FFmpeg-devel] [PATCH 3/5] fftools/ffmpeg: close output files before cleanup

2021-11-29 Thread Marton Balint
This allows us to check the return value of avio_closep(). Signed-off-by: Marton Balint --- fftools/ffmpeg.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 25360423b5..ea75fad637 100644 --- a/fftools/ffmpeg.c +++ b

[FFmpeg-devel] [PATCH 4/5] avformat: make AVFormatContext io_close return an int

2021-11-29 Thread Marton Balint
Otherwise there is no way to detect any error during avio_close(). Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavformat/avformat.h | 6 +- libavformat/internal.h | 6 +- libavformat/options.c | 4 ++-- libavformat/utils.c| 6 -- libavformat/version.h

[FFmpeg-devel] [PATCH 5/5] avformat/img2enc: do not ignore IO errors

2021-11-29 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/img2enc.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c index 62202de9f4..ce23f38efb 100644 --- a/libavformat/img2enc.c +++ b/libavformat/img2enc.c

Re: [FFmpeg-devel] [PATCH 4/5] avformat: make AVFormatContext io_close return an int

2021-11-30 Thread Marton Balint
On Tue, 30 Nov 2021, Andreas Rheinhardt wrote: Marton Balint: Otherwise there is no way to detect any error during avio_close(). Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavformat/avformat.h | 6 +- libavformat/internal.h | 6 +- libavformat/options.c

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: Add blurriness filter

2021-11-30 Thread Marton Balint
On Tue, 30 Nov 2021, Thilo Borgmann wrote: Hi, $subject Can you name this blurdetect to be more in line with existing similar filters? (blackdetect, freezedetect) Thanks, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffm

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mxfdec: rework MCA channel layout parsing

2021-11-30 Thread Marton Balint
On Mon, 29 Nov 2021, Pierre-Anthony Lemieux wrote: On Mon, Nov 29, 2021 at 11:20 AM Marton Balint wrote: On Sun, 28 Nov 2021, Pierre-Anthony Lemieux wrote: On Sun, Nov 28, 2021 at 5:00 PM Marton Balint wrote: Setting the channel layout was based on SoundfieldGroupLabelSubDescriptor

Re: [FFmpeg-devel] [PATCH 1/5] avformat/rtsp: make use of avio_get_str() to load the sdp

2021-12-01 Thread Marton Balint
On Wed, 1 Dec 2021, lance.lmw...@gmail.com wrote: On Wed, Dec 01, 2021 at 05:17:08PM +0200, Martin Storsjö wrote: On Wed, 1 Dec 2021, lance.lmw...@gmail.com wrote: > On Wed, Dec 01, 2021 at 03:55:37PM +0200, Martin Storsjö wrote: > > On Wed, 1 Dec 2021, lance.lmw...@gmail.com wrote: > > > >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/aviobuf: prefer to use avio_read_partial()

2021-12-03 Thread Marton Balint
On Fri, 3 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang This is allowed to read fewer bytes than requested. The missing bytes can be read in the next call. I don't think this is needed, after all we want to read all data, there is no point in reading it in smaller chunks, no?

Re: [FFmpeg-devel] [PATCH 2/2] avformat/aviobuf: prefer to use avio_read_partial()

2021-12-03 Thread Marton Balint
On Fri, 3 Dec 2021, lance.lmw...@gmail.com wrote: On Fri, Dec 03, 2021 at 10:47:00AM +0100, Marton Balint wrote: On Fri, 3 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang This is allowed to read fewer bytes than requested. The missing bytes can be read in the next call. I

[FFmpeg-devel] [PATCH v2 4/5] avformat: introduce AVFormatContext io_close2 which returns an int

2021-12-04 Thread Marton Balint
Otherwise there is no way to detect any error during avio_close(). Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavformat/avformat.h | 13 + libavformat/dashenc.c | 1 + libavformat/fifo.c | 1 + libavformat/hlsenc.c | 1 + libavformat/internal.h

Re: [FFmpeg-devel] [PATCH v2 4/5] avformat: introduce AVFormatContext io_close2 which returns an int

2021-12-04 Thread Marton Balint
On Sat, 4 Dec 2021, Hendrik Leppkes wrote: On Sat, Dec 4, 2021 at 9:00 PM Marton Balint wrote: Otherwise there is no way to detect any error during avio_close(). Returning errors is nice and all, but whats the expected reaction to an error here, since we're already trying to

[FFmpeg-devel] [PATCH v3 4/5] avformat: introduce AVFormatContext io_close2 which returns an int

2021-12-04 Thread Marton Balint
io_close callback. Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavformat/avformat.h | 13 + libavformat/dashenc.c | 1 + libavformat/fifo.c | 1 + libavformat/hlsenc.c | 1 + libavformat/internal.h | 10 +- libavformat/options

Re: [FFmpeg-devel] [PATCH 3/6] avformat/rtsp: prefer to return EOF for incomplete read

2021-12-05 Thread Marton Balint
On Sun, 5 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 5cffe0b..2ee2463 100644 --- a/libavformat/rtsp.c +++ b/libavf

Re: [FFmpeg-devel] [PATCH 1/4] avformat/hlsenc: Add init_program_date_time so start time can be specified

2023-11-05 Thread Marton Balint
On Fri, 27 Oct 2023, David Johansen wrote: On Fri, Oct 27, 2023 at 4:58 AM wrote: On 27 Oct 2023, at 5:59, Dave Johansen wrote: > @item second_level_segment_index > Makes it possible to use segment indexes as %%d in hls_segment_filename expression > besides date/time values when strftime

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: use SDL_WaitEvent instead of SDL_PeepEvents while paused

2023-11-10 Thread Marton Balint
On Fri, 10 Nov 2023, Bolshoy Toster wrote: Currently, when ffplay is paused, it still constantly polls for events at the REFRESH_RATE (100 times per second). This leads to a high (5-10% on the latest commit, using SDL2 2.28.5-1) CPU usage, when it should be idle. This commit changes this b

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-11-19 Thread Marton Balint
rth keeping. But maybe it is easier for the end user, I don't know. Thanks, Martoncommit df4e283d7b2aa4b4de6e405e5dcbbae38d053b9f Author: Marton Balint Date: Sun Oct 16 20:45:51 2016 +0200 lavfi/af_dynaudnorm: add support for momentary loudness based normalization Signed-off-b

Re: [FFmpeg-devel] [PATCH 1/5] avformat: introduce AVStreamGroup

2023-11-21 Thread Marton Balint
On Tue, 21 Nov 2023, James Almer wrote: Signed-off-by: James Almer --- libavformat/avformat.c | 178 +++-- libavformat/avformat.h | 163 + libavformat/dump.c | 33 ++-- libavformat/internal.h | 33 libavfo

[FFmpeg-devel] [PATCH 1/7] avutil/tests/imgutils: factorize basic tests to new function

2023-12-02 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/tests/imgutils.c | 68 ++ 1 file changed, 39 insertions(+), 29 deletions(-) diff --git a/libavutil/tests/imgutils.c b/libavutil/tests/imgutils.c index 748bd6c9d2..f3a433ac4a 100644 --- a/libavutil/tests/imgutils.c

[FFmpeg-devel] [PATCH 2/7] avutil/tests/imgutils: add tests for av_image_fill_black()

2023-12-02 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/tests/imgutils.c | 60 -- tests/ref/fate/imgutils| 217 + 2 files changed, 268 insertions(+), 9 deletions(-) diff --git a/libavutil/tests/imgutils.c b/libavutil/tests/imgutils.c index f3a433ac4a

[FFmpeg-devel] [PATCH 3/7] avutil/imgutils: fix av_image_fill_black() for some pixel formats

2023-12-02 Thread Marton Balint
the bitstream mode got merged to the non-bitstream mode. Signed-off-by: Marton Balint --- libavutil/imgutils.c| 49 +++-- tests/ref/fate/imgutils | 14 ++-- 2 files changed, 25 insertions(+), 38 deletions(-) diff --git a/libavutil/imgutils.c b

[FFmpeg-devel] [PATCH 4/7] avutil/imgutils: add support for 32bit pixel format for av_image_fill_black()

2023-12-02 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/imgutils.c| 32 ++-- tests/ref/fate/imgutils | 24 2 files changed, 34 insertions(+), 22 deletions(-) diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c index 5e401139c8..26bb2f2c6f 100644

[FFmpeg-devel] [PATCH 5/7] avutil/imgutils: factorize a fill color function

2023-12-02 Thread Marton Balint
In preparation for making it public. Signed-off-by: Marton Balint --- libavutil/imgutils.c | 101 +++ 1 file changed, 63 insertions(+), 38 deletions(-) diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c index 26bb2f2c6f..959e6850ac 100644 --- a

[FFmpeg-devel] [PATCH 6/7] avutil/imgutils: add new function av_image_fill_color()

2023-12-02 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavutil/imgutils.c | 4 ++-- libavutil/imgutils.h | 30 ++ libavutil/version.h | 2 +- 4 files changed, 36 insertions(+), 3 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 4a2dc1c44f

[FFmpeg-devel] [PATCH 7/7] avcodec: add AV_CODEC_FLAG_CLEAR

2023-12-02 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ doc/codecs.texi| 14 ++ libavcodec/avcodec.h | 4 libavcodec/decode.c| 6 ++ libavcodec/options_table.h | 1 + libavcodec/version.h | 2 +- 6 files changed, 29

[FFmpeg-devel] [PATCH v2 1/7] avutil/tests/imgutils: factorize basic tests to new function

2023-12-06 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/tests/imgutils.c | 68 ++ 1 file changed, 39 insertions(+), 29 deletions(-) diff --git a/libavutil/tests/imgutils.c b/libavutil/tests/imgutils.c index 748bd6c9d2..1e2bb3fa01 100644 --- a/libavutil/tests/imgutils.c

[FFmpeg-devel] [PATCH v2 2/7] avutil/tests/imgutils: add tests for av_image_fill_black()

2023-12-06 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/tests/imgutils.c | 61 +-- tests/ref/fate/imgutils| 217 + 2 files changed, 269 insertions(+), 9 deletions(-) diff --git a/libavutil/tests/imgutils.c b/libavutil/tests/imgutils.c index 1e2bb3fa01

[FFmpeg-devel] [PATCH v2 3/7] avutil/imgutils: fix av_image_fill_black() for some pixel formats

2023-12-06 Thread Marton Balint
the bitstream mode got merged to the non-bitstream mode. Signed-off-by: Marton Balint --- libavutil/imgutils.c| 49 +++-- tests/ref/fate/imgutils | 14 ++-- 2 files changed, 25 insertions(+), 38 deletions(-) diff --git a/libavutil/imgutils.c b

  1   2   3   4   5   6   7   8   9   10   >