A DVDNAV_WAIT event by itself should not warrant an
EOF when navigating the program stream. Some discs
have WAIT events in the middle of a title, causing
playback to end prematurely prior to this fix.
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 17 -
1 file changed, 8
calculates and returns the duration of the
chapter segment instead. Additionally, validate that chapter_end
exceeds chapter_start (except in the special case of 0).
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a
these weirdly authored discs.
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index e7132725b7..b0fb5f0de2 100644
--- a/libavformat/dvdvideodec.c
+++ b
Please, ignore this particular patch. I have found a formatting
mistake (opportunity to remove braces).
I will send a v2.
I apologize for the inconvenience.
On Thu, Jun 27, 2024 at 12:38 AM Marth64 wrote:
>
> When -trim option is used (by default), padding cells
> at the beginning of
these weirdly authored discs.
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index e7132725b7..f1c960b56b 100644
--- a/libavformat/dvdvideodec.c
Please ignore this v2 patch also. There’s an issue with it.
Apologies again.
On Thu, Jun 27, 2024 at 01:06 Marth64 wrote:
> When -trim option is used (by default), padding cells
> at the beginning of the title are supposed to be ignored.
> The current implementation does the ignorin
Ping on this one to fix some discs, has been tested thoroughly.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject
Ping on this one blocking seeking when playing one chapter (and fixing
undefined option behavior).
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-de
> What is the meaning of the 0 special case?
If chapter_end is 0, this means "end". So you can say, -chapter_start
5 -chapter_end 0 and demuxer will go from chapter 5 to end of title.
This is also in the public docs since initial demuxer merge.
Thank you!
Hello, I am happy to share a DVD demuxer for ffmpeg powered by libdvdread and
libdvdnav.
I have been working on this on/off throughout the year and think it is in a
good spot
to share at the ML now. This was a major learning experience for me in many
ways and
am open to any feedback on how I cou
---
fftools/ffmpeg_opt.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 304471dd03..5e50e5efa2 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -1721,8 +1721,8 @@ const OptionDef options[] = {
{ "for
---
doc/ffmpeg.texi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
index 145cbb1032..6bcedd76d5 100644
--- a/doc/ffmpeg.texi
+++ b/doc/ffmpeg.texi
@@ -1860,7 +1860,7 @@ of seconds.
The timestamp discontinuity correction enabled by this
---
doc/bitstream_filters.texi | 5 +
1 file changed, 5 insertions(+)
diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
index c63c20370f..145aa8684e 100644
--- a/doc/bitstream_filters.texi
+++ b/doc/bitstream_filters.texi
@@ -882,6 +882,11 @@ The sample rate of stream packe
---
doc/bitstream_filters.texi | 17 +
1 file changed, 17 insertions(+)
diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
index 145aa8684e..b01ede0c93 100644
--- a/doc/bitstream_filters.texi
+++ b/doc/bitstream_filters.texi
@@ -213,6 +213,23 @@ To remove all AUD
Roger, will update. Thanks!
On Sat, Dec 9, 2023 at 1:25 PM James Almer wrote:
> On 12/9/2023 4:10 PM, Marth64 wrote:
> > ---
> > fftools/ffmpeg_opt.c | 8
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/fftools/ffmpeg_opt.c
Appreciate the good feedback, will update. Thank you.
On Sat, Dec 9, 2023 at 6:53 PM Stefano Sabatini wrote:
> On date Saturday 2023-12-09 13:31:13 -0600, Marth64 wrote:
> > ---
> > doc/bitstream_filters.texi | 17 +
> > 1 file changed, 17 insertions(+)
>
---
doc/bitstream_filters.texi | 18 ++
1 file changed, 18 insertions(+)
diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
index c63c20370f..d2ad6e78ff 100644
--- a/doc/bitstream_filters.texi
+++ b/doc/bitstream_filters.texi
@@ -213,6 +213,24 @@ To remove all AU
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 304471dd03..837bef8161 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -1722,7 +1722,7 @@ const OptionDef options[] = {
OPT_SPEC | OPT_OUTPUT,
{ .off = OFFSET(f
send a request to relicense as LGPL and update here. I
will then give credit in the header.
My apologies for mixing this. In the mean time I will also fix some
aforementioned bugs.
On Sat, Dec 9, 2023 at 4:06 AM Marth64 wrote:
> Hello, I am happy to share a DVD demuxer for ffmpeg powered
Signed-off-by: Marth64
This could be useful for folks who are just learning ffmpeg or have simple
needs for parsing input information as JSON.
---
doc/ffprobe.texi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/doc/ffprobe.texi b/doc/ffprobe.texi
index b74ff650ac..ed88e619f6 100644
This confused me for a long time, hopefully this is helpful to others.
The definition in avformat.h says "Ignore DTS on frames that contain both DTS &
PTS"
Signed-off-by: Marth64
---
doc/formats.texi| 2 +-
libavformat/options_table.h | 2 +-
2 files changed, 2 in
and the MPEG PS packet but I guess there is no
value to your point.
On Sat, Dec 9, 2023 at 9:03 PM Leo Izen wrote:
> On 12/9/23 05:06, Marth64 wrote:
> > Hello, I am happy to share a DVD demuxer for ffmpeg powered by
> libdvdread and libdvdnav.
> > I have been working on this on
Thank you!
On Sat, Dec 9, 2023 at 9:06 PM Leo Izen wrote:
> On 12/9/23 20:35, Marth64 wrote:
> > ---
> > doc/bitstream_filters.texi | 18 ++
> > 1 file changed, 18 insertions(+)
> >
>
> Make sure when you generate the second version of a patch
m opening the MPEG-PS subdemuxer with custom IO flag. It seems to expect
this according to the documentation. I can try without.
On Sat, Dec 9, 2023 at 9:03 PM Leo Izen wrote:
> On 12/9/23 05:06, Marth64 wrote:
> > Hello, I am happy to share a DVD demuxer for ffmpeg powered by
> lib
Signed-off-by: Marth64
---
doc/ffmpeg.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
index 6bcedd76d5..36fdaef879 100644
--- a/doc/ffmpeg.texi
+++ b/doc/ffmpeg.texi
@@ -1861,7 +1861,7 @@ of seconds.
The timestamp discontinuity
Added v2 label and signed off as per proper procedure.
Signed-off-by: Marth64
---
doc/bitstream_filters.texi | 18 ++
1 file changed, 18 insertions(+)
diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
index dc4f85bac0..7c36c5346d 100644
--- a/doc
Added v2 flag and signoff to follow process. Adjusted based on feedback.
Signed-off-by: Marth64
---
fftools/ffmpeg_opt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 304471dd03..837bef8161 100644
--- a/fftools
Signed-off-by: Marth64
---
doc/filters.texi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/doc/filters.texi b/doc/filters.texi
index 6d00ba2c3f..1250685bc7 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -15919,6 +15919,13 @@ further computations. This allows inserting the
Cleaned up mistake of outputting with rawvideo format
Signed-off-by: Marth64
---
doc/filters.texi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/doc/filters.texi b/doc/filters.texi
index 6d00ba2c3f..e595f7d152 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -15919,6
Clean up the example further. Sorry.
Signed-off-by: Marth64
---
doc/filters.texi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/doc/filters.texi b/doc/filters.texi
index 6d00ba2c3f..bf59352ba0 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -15919,6 +15919,13 @@ further
Since log statements printing int64 were made portable in
4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include
inttypes.h explicitly (as it is unclear where PRId64 and
such are coming from now).
Reported-by: Traneptora
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 2 ++
1 file
v2 on the way.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
I had actually applied this patch while looking into a ticket near the same
code path. LGTM.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-re
This also fixes https://trac.ffmpeg.org/ticket/10927 (recently reported by
a user)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmp
This should be withheld until after 7.0. In the same bug report it appears
that 1 user is making use of the erroneous tags via an external script for
a valid purpose. I don’t want to break people’s workflow even though it’s
invalid ASS.
After 7.0 I will revive this patchset and with additional fix
Ping if possible. The patches still apply. 3 of the 5 patches are
documentation only and the demuxer itself is much smaller now. The muxer
already made it in, so was hoping the demuxer could go too :fingers_crossed:
___
ffmpeg-devel mailing list
ffmpeg-de
> is the move needed? (but not blocking)
It is not needed, but the code flows better I think in terms of
readability. I think it feels cleaner to say, "set up `sub` then add it to
the array" vs. "set up sub's data, add it to the array, then set up its
other fields". But, I am good either way and on
Was already applied. Thanks Stefano and Leo!
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Ping on this set authored by Oneric as well.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Recent advice plus my own experience agree that this pattern
is error-prone. Instead, set `ret` in its own line and do
the error validation after. Also, explicitly return 0 on success
in dvdvideo_chapters_setup_preindex()
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 132
in the source file? We can probe this to some extent,
but what if the eia608 bytes don’t show until halfway through the source?
Open to ideas, thoughts, as I’m gathering my own on this in a notebook over
the past few weeks.
Respectfully,
Marth64
___
ffm
,
Marth64
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Thanks for checking Stefano, I have been behind a bit. I will follow up
with the fix once possible.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-d
Stefano, v10 coming shortly. Thank you!
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Since v7/8:
* Addresses last known feedback (about av_assert call)
* Changelog entry removed, since v7.0 is cut and there is no "next" space yet
(will make patch once available)
Signed-off-by: Marth64
--
2.34.1
___
ffmpeg-devel mailing l
happens to pass an empty cue or wants to
use av_get_packet() to read bytes, there are no unnecessary
operations on the packet after it is allocated.
Signed-off-by: Marth64
---
libavformat/subtitles.c | 23 +++
libavformat/subtitles.h | 2 +-
2 files changed, 16 insertions
original presentation.
Signed-off-by: Marth64
---
doc/demuxers.texi| 30 ++
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/rcwtdec.c| 123 +++
4 files changed, 155 insertions(+)
create mode 100644
The high level summary of RCWT can be delegated doc/muxers, which
makes it easier to maintain and more consistent with the documentation
of the demuxer.
Signed-off-by: Marth64
---
libavformat/rcwtenc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/libavformat/rcwtenc.c b/libavformat
Signed-off-by: Marth64
---
doc/muxers.texi | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/doc/muxers.texi b/doc/muxers.texi
index a10a8e216f..4161401059 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -3038,19 +3038,18 @@ ogg files can
Signed-off-by: Marth64
---
doc/indevs.texi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/indevs.texi b/doc/indevs.texi
index d1b2bacf8b..fc14737181 100644
--- a/doc/indevs.texi
+++ b/doc/indevs.texi
@@ -1069,9 +1069,9 @@ ffplay -f lavfi
"movie=test.avi[out0];a
Tomas Härdin:
> Can we please get away from this way of reading subtitles? Every other
> type of media (audio, video) are capable of being streamed, but not
> subtitles, precisely because all of them do all parsing in the
> read_header() call. We have a perfectly good generic index and seeking
> fu
Tomas Härdin :
> once I get my srtdec patchset through there will
> be something to follow.
I see the patch now. I agree, this looks like a good step. Thank you!
> Nah it can be done at a later point as an enhancement if you prefer
Yes, please. I am happy to do it, but I think will be
smoother to
> i think the entry for extensions should be removed (which fixes this)
> having a ".bin" is not a strong indication that its rcwt
> Is this blocking or can it be addressed later? Also, if this needs to
> be modified the muxer should be as well.
I can address both today in a new set. .bin is pret
Sorry for the delay, v11 coming shortly with the fix.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscr
Since v9:
* Removes .bin extension association in demuxer and muxer
* Updates examples in documentation
Signed-off-by: Marth64
--
2.34.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To
happens to pass an empty cue or wants to
use av_get_packet() to read bytes, there are no unnecessary
operations on the packet after it is allocated.
Signed-off-by: Marth64
---
libavformat/subtitles.c | 23 +++
libavformat/subtitles.h | 2 +-
2 files changed, 16 insertions
original presentation.
Signed-off-by: Marth64
---
doc/demuxers.texi| 30 ++
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/rcwtdec.c| 122 +++
4 files changed, 154 insertions(+)
create mode 100644
Signed-off-by: Marth64
---
libavformat/rcwtenc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/rcwtenc.c b/libavformat/rcwtenc.c
index f2459ef1d3..ed613d45f5 100644
--- a/libavformat/rcwtenc.c
+++ b/libavformat/rcwtenc.c
@@ -159,7 +159,6 @@ static int rcwt_write_trailer
The high level summary of RCWT can be delegated doc/muxers, which
makes it easier to maintain and more consistent with the documentation
of the demuxer.
Signed-off-by: Marth64
---
libavformat/rcwtenc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/libavformat/rcwtenc.c b/libavformat
Signed-off-by: Marth64
---
doc/muxers.texi | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/doc/muxers.texi b/doc/muxers.texi
index a10a8e216f..c960af1bdc 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -3038,19 +3038,18 @@ ogg files can
Signed-off-by: Marth64
---
doc/indevs.texi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/indevs.texi b/doc/indevs.texi
index d1b2bacf8b..734fc65752 100644
--- a/doc/indevs.texi
+++ b/doc/indevs.texi
@@ -1069,9 +1069,9 @@ ffplay -f lavfi
"movie=test.avi[out0];a
Djikstra is nice
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Thank you Stefano & all who helped facilitate this through.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "un
If it's not too late, I thought these fixes would make
the section look nicer for this big release.
---
Changelog | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Changelog b/Changelog
index a65c8ceee5..7ed638514b 100644
--- a/Changelog
+++ b/Changelog
@@ -40,17 +40,17 @@
Works for me. Looks great now. Thank you!
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> I'm confused by this, what kind of \N
> sequences might appear in an ASS file?
> Can you show an offending sequence?
Good day Stefano,
The one I tested with was something like :
Jim\Nancy
I made this up while testing. But I have seen similar in real world
scenarios particularly in ASS files or
> Is \N a special sequence in ASS-speak
\N is the special line break sequence in ASS
I’m not sure of other special sequences following the \ character, I yield
to Oneric on this question.
Best,
Marth64
___
ffmpeg-devel mailing list
ffmpeg-de
> +#!/bin/sh
Might I suggest `#!/usr/bin/env sh` instead for this case?
I tend to prefer it from a portability and usability perspective,
but I can imagine for sh it might not matter.
I am not close to the patch that you are working on.
But thought to throw this out there in case there is a
platfo
> so that seems like a terrible idea that would achieve
> the opposite result.
I respectfully disagree.
Neither approach is universal or POSIX specified.
So while I agree it can be left as-is since only
a basic Bourne shell is needed, I would not just
dismiss it/write it off as a terrible idea.
Regardless -- it can be left as is . I digress from the topic.
Thank you,
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org w
Thank you Stefano for your patience and reviews. I am working on
refinements that can go in after initial patch. Cheers
On Mon, Feb 12, 2024 at 09:47 Stefano Sabatini wrote:
> On date Sunday 2024-02-11 12:09:16 -0600, Marth64 wrote:
> > No critical changes since v12.
> > -
I will take care of it, thanks
On Fri, Feb 16, 2024 at 05:38 Anton Khirnov wrote:
> Quoting Marth64 (2024-02-11 19:09:16)
> > +static int dvdvideo_video_stream_add(AVFormatContext *s,
> > + DVDVideoVTSVideoStr
ak and OOB in chapter functions
* Fix timestamp overflow bug introduced in v11
Signed-off-by: Marth64
---
Changelog |2 +
configure |8 +
doc/demuxers.texi | 130
libavformat/Makefile |1 +
libavformat/allformats.c |1 +
l
Signed-off-by: Marth64
---
doc/demuxers.texi | 5 +++
libavformat/Makefile | 2 +-
libavformat/dvdclut.c | 76 +++
libavformat/dvdclut.h | 37 +++
libavformat/dvdvideodec.c | 14
5 files changed, 133 insertions
I'm willing to help. I have experience with Node.JS and Express (the
rewrite).
Thank you,
On Sat, Feb 24, 2024 at 11:49 AM Michael Niedermayer
wrote:
> Hi all
>
> Both fateserver and the fateserver rewrite lack a mainteiner
>
> The original:
> https://fate.ffmpeg.org/
> perl code here:
> https:
(with rootless)? In this way,
the application is jailed and can restart automatically on its own. Also,
more flexibility on the host machine itself.
On Sun, Feb 25, 2024 at 1:28 PM Michael Niedermayer
wrote:
> Hi Marth64
>
> adding Timothy and baptiste to the CC
>
> On Sun, Feb 25
In merged DVD patch, -pgc and -pg options were broken. While these are
rather advanced options, they are the only means to get content for
some strangely authored discs.
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 23 +--
1 file changed, 13 insertions(+), 10
FYI: hls, dashdec do the same av_freep(). Doesn't make this right, but
saying that was where I used as an example (so they should probably fixed
too?)
On Sat, Mar 2, 2024 at 10:17 AM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> James Almer:
> > On 3/2/2024 12:47 PM, Andreas Rhein
Nevermind, disregard. They do not, and I misread. Thanks for catching this.
On Sat, Mar 2, 2024 at 8:31 PM Marth64 wrote:
> FYI: hls, dashdec do the same av_freep(). Doesn't make this right, but
> saying that was where I used as an example (so they should probably fixed
> too?)
&
Patchset LGTM.
On Sat, Mar 2, 2024 at 9:42 AM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/dvdvideodec.c | 12
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/libavformat/dvdvideodec.c b/libav
I did take caution here,
ffmpeg must be built with all of the following flags: ./configure
--enable-demuxer=dvdvideo --enable-libdvdread --enable-libdvdnav
--enable-gpl
This is also called out in the docs:
> FFmpeg must be built with GPL library support available as well as the
configure switches
Bump on this one. Would be really nice to have since dvd demuxer is merged,
and colors are part of the presentation. It did have 2 reviews. Thank you.
On Sun, Feb 18, 2024 at 10:02 PM Marth64 wrote:
> Signed-off-by: Marth64
> ---
> doc/demuxers.texi | 5 +++
> libavfor
Rebased on top of recently merged fixes (should apply correctly now).
In merged DVD patch, -pgc and -pg options were broken. While these are
rather advanced options, they are the only means to get content for
some strangely authored discs.
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c
A new line was removed in a1304272c3a0ef7c3d77c702dd466b3f11bf300f
which breaks consistency in between versions.
Signed-off-by: Marth64
---
Changelog | 1 +
1 file changed, 1 insertion(+)
diff --git a/Changelog b/Changelog
index fedad5782c..f388d41b02 100644
--- a/Changelog
+++ b/Changelog
Signed-off-by: Marth64
---
doc/demuxers.texi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/doc/demuxers.texi b/doc/demuxers.texi
index 905828d852..f4bac8f3b3 100644
--- a/doc/demuxers.texi
+++ b/doc/demuxers.texi
@@ -295,6 +295,9 @@ into a conversion pipeline. Menus and seeking are not
Looks like v2 made it in. All good here. Thanks, Stefano !
On Mon, Mar 4, 2024 at 3:43 AM Stefano Sabatini wrote:
> On date Monday 2024-03-04 10:24:42 +0100, Stefano Sabatini wrote:
> > On date Saturday 2024-03-02 20:29:13 -0600, Marth64 wrote:
> > > In merged DVD patch, -p
Reported-by: BtbN
Signed-off-by: Marth64
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index db7dc89755..bbf1a70731 100755
--- a/configure
+++ b/configure
@@ -6782,7 +6782,7 @@ enabled libdavs2 && require_pkg_config
I did a quick validation with ATSC, DVD, and SCTE sources. Results were as
expected.
On Tue, Mar 5, 2024 at 2:30 PM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> The longest string here takes four bytes, so using an array
> of pointers is wasteful even when ignoring the cost of re
.
Signed-off-by: Marth64
---
doc/demuxers.texi | 43 +-
libavformat/dvdvideodec.c | 315 --
2 files changed, 339 insertions(+), 19 deletions(-)
diff --git a/doc/demuxers.texi b/doc/demuxers.texi
index 1a17c6db16..e2ea66c1a5 100644
--- a/doc
Since last iteration: removes unused variable in dvdclut.c
Signed-off-by: Marth64
---
doc/demuxers.texi | 5 +++
libavformat/Makefile | 2 +-
libavformat/dvdclut.c | 75 +++
libavformat/dvdclut.h | 37 +++
libavformat
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index 2c7ffdd148..6136060288 100644
--- a/libavformat/dvdvideodec.c
+++ b/libavformat/dvdvideodec.c
@@ -1142,7 +1142,9
Rothenpieler
wrote:
> On 06/03/2024 16:09, Stefano Sabatini wrote:
> > On date Wednesday 2024-03-06 01:19:11 -0600, Marth64 wrote:
> >> Since last iteration: removes unused variable in dvdclut.c
> >>
> >> Signed-off-by: Marth64
> >> ---
> >> doc/demu
600, Marth64 wrote:
> > Signed-off-by: Marth64
> > ---
> > libavformat/dvdvideodec.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
> > index 2c7ffdd148..6136060288 100644
at 09:36 Marth64 wrote:
> Good morning,
>
> DVD subtitle palettes, which are natively YUV, are currently carried as
> a hex string in their respective subtitle streams and have
> no concept of colorspace tagging (even predating dvd demuxer). The
> convention is to convert
>
Thank you Stefano for the review on the whole set. I will take the feedback
and come back with a better organized set in the next 2 or so days.
On Wed, Mar 6, 2024 at 09:42 Stefano Sabatini wrote:
> On date Wednesday 2024-03-06 01:19:12 -0600, Marth64 wrote:
> > Many DVDs have valuab
Niedermayer
wrote:
> Hi
>
> On Sun, Feb 25, 2024 at 06:21:14PM -0600, Marth64 wrote:
> > Thank you Michael, for the opportunity. I have some initial questions
> > while others add the remaining detail.
> >
> [...]
> > 2) Are you open to Docker containerization (
follow up with a trivial patch to update log messages
based on feedback from Stefano with respect to how options are mentioned.
You may also tour the diffs on GitHub:
https://github.com/Marth64x/FFmpeg/commits/20240309_dvdvideodec
Thank you very much.
Signed-off-by: Marth64
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index b3cc32b864..ca85aa8d3d 100644
--- a/libavformat/dvdvideodec.c
+++ b/libavformat/dvdvideodec.c
@@ -932,7 +932,9
Signed-off-by: Marth64
---
libavformat/Makefile | 2 +-
libavformat/dvdclut.c | 75 +++
libavformat/dvdclut.h | 37 +++
libavformat/dvdvideodec.c | 14
4 files changed, 127 insertions(+), 1 deletion(-)
create mode 100644
Signed-off-by: Marth64
---
doc/demuxers.texi | 43 +-
libavformat/dvdvideodec.c | 314 --
2 files changed, 339 insertions(+), 18 deletions(-)
diff --git a/doc/demuxers.texi b/doc/demuxers.texi
index f4bac8f3b3..b70f3a38d7 100644
--- a/doc
1 - 100 of 594 matches
Mail list logo
