---
libavcodec/aactab.c | 117
libavcodec/aactab.h | 4 ++
2 files changed, 121 insertions(+)
diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c
index dfb2dfd98d..18afa69bad 100644
--- a/libavcodec/aactab.c
+++ b/libavcodec/aactab.c
@@ -154,6 +15
This commit adds a decoder for the frequency-domain part of USAC.
What works:
- Mono
- Stereo (no prediction)
- Stereo (mid/side coding)
What doesn't:
- Preroll decoding (every single decoder seems faulty or weird?)
- Complex stereo prediction
Known issues:
- Spec incompliance (noise synth
On 16/05/2024 12:26, Andreas Rheinhardt wrote:
Lynne via ffmpeg-devel:
This commit adds a decoder for the frequency-domain part of USAC.
What works:
- Mono
- Stereo (no prediction)
- Stereo (mid/side coding)
What doesn't:
- Preroll decoding (every single decoder seems faulty or
On 16/05/2024 20:30, Michael Niedermayer wrote:
On Thu, May 16, 2024 at 12:08:11PM +0200, Lynne via ffmpeg-devel wrote:
AAC uses an unconventional system to send scalefactors
(the volume+quantization value for each band).
Each window is split into either 1 or 8 blocks (long vs short),
and
This patch adds support for the frequency domain part of the
xHE-AAC standard (ISO/IEC 23003-3).
The speech synthesis support is to be implemented with a later
patch. LPD is left as a stub with most bitstream parsing complete.
The DRC support is left up for discussion. The DRC system is
pretty muc
AAC uses an unconventional system to send scalefactors
(the volume+quantization value for each band).
Each window is split into either 1 or 8 blocks (long vs short),
and transformed separately from one another, with the coefficients
for each being also completely independent. The scalefactors
sligh
---
libavcodec/aac/aacdec.c | 73 -
libavcodec/aac/aacdec.h | 19 +--
2 files changed, 51 insertions(+), 41 deletions(-)
diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c
index 35722f9b9b..40554ff9e4 100644
--- a/libavcodec/aac/aacdec.c
USAC has the same syntax, with one minor change we can check for.
---
libavcodec/aac/aacdec.c | 6 +++---
libavcodec/aac/aacdec.h | 3 +++
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c
index 40554ff9e4..a7e5b2a369 100644
--- a/liba
Required for USAC
---
libavcodec/aac/aacdec.c | 4 ++
libavcodec/aac/aacdec.h | 5 +++
libavcodec/aac/aacdec_dsp_template.c | 67
libavcodec/aac/aacdec_fixed.c| 2 +
libavcodec/aac/aacdec_float.c| 4 ++
libavcodec/sinewin_f
---
libavcodec/aactab.c | 25 +
libavcodec/aactab.h | 2 ++
2 files changed, 27 insertions(+)
diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c
index 3718b81a07..8ce5e43974 100644
--- a/libavcodec/aactab.c
+++ b/libavcodec/aactab.c
@@ -3377,3 +3377,28 @@ const DECLAR
---
libavcodec/aactab.c | 117
libavcodec/aactab.h | 4 ++
2 files changed, 121 insertions(+)
diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c
index dfb2dfd98d..18afa69bad 100644
--- a/libavcodec/aactab.c
+++ b/libavcodec/aactab.c
@@ -154,6 +15
---
libavcodec/aactab.c | 376
libavcodec/aactab.h | 6 +
2 files changed, 382 insertions(+)
diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c
index 8ce5e43974..dfb2dfd98d 100644
--- a/libavcodec/aactab.c
+++ b/libavcodec/aactab.c
@@ -1193,6 +11
This commit adds a decoder for the frequency-domain part of USAC.
What works:
- Mono
- Stereo (no prediction)
- Stereo (mid/side coding)
- Stereo (complex prediction)
What's left:
- Speech coding
Known issues:
- Desync with certain sequences
- Preroll crossover missing (shouldn't matter,
On 19/05/2024 21:39, Marton Balint wrote:
On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote:
This commit adds a decoder for the frequency-domain part of USAC.
[...]
+/* Finish later */
+static const enum AVChannel usac_ch_pos_to_av[64] = {
+ [0] = AV_CHAN_FRONT_LEFT,
+ [1
On 20/05/2024 01:19, Michael Niedermayer wrote:
On Sun, May 19, 2024 at 06:54:44PM +0200, Lynne via ffmpeg-devel wrote:
This commit adds a decoder for the frequency-domain part of USAC.
What works:
- Mono
- Stereo (no prediction)
- Stereo (mid/side coding)
- Stereo (complex prediction
Starting off small with a few features.
Samples and reference decoded files copied from the official ISO
reference suite.
---
Samples and references: https://files.lynne.ee/xhe_refs/
tests/fate/aac.mak | 8
1 file changed, 8 insertions(+)
diff --git a/tests/fate/aac.mak b/tests/fate/aac
On 21/05/2024 09:18, Paul B Mahol wrote:
On Tue, May 21, 2024 at 4:05 AM Lynne via ffmpeg-devel
mailto:ffmpeg-devel@ffmpeg.org>> wrote:
Starting off small with a few features.
Samples and reference decoded files copied from the official ISO
reference suite.
Sorry
On 21/05/2024 14:32, J. Dekker wrote:
Some timers on certain device and test combinations can produce noisy
results, affecting the reliability of performance measurements. One
notable example of this is the Canaan K230 RISC-V development board.
An option to adjust the number of samples (--sample
On 21/05/2024 15:51, J. Dekker wrote:
Some timers on certain device and test combinations can produce noisy
results, affecting the reliability of performance measurements. One
notable example of this is the Canaan K230 RISC-V development board.
An option to adjust the number of samples by an exp
Helps make sense of the possible noise in the results.
---
tests/checkasm/checkasm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
index 669f2be9c1..b1c175b95d 100644
--- a/tests/checkasm/checkasm.c
+++ b/tests/checkasm/checkasm.c
@@ -
On 21/05/2024 17:07, J. Dekker wrote:
Lynne via ffmpeg-devel writes:
Helps make sense of the possible noise in the results.
---
tests/checkasm/checkasm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
index 669f2be9c1
On 21/05/2024 09:16, Marton Balint wrote:
On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote:
On 19/05/2024 21:39, Marton Balint wrote:
On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote:
This commit adds a decoder for the frequency-domain part of USAC.
[...]
+/* Finish later
On 21/05/2024 21:40, Marton Balint wrote:
On Tue, 21 May 2024, Lynne via ffmpeg-devel wrote:
On 21/05/2024 09:16, Marton Balint wrote:
On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote:
On 19/05/2024 21:39, Marton Balint wrote:
On Sun, 19 May 2024, Lynne via ffmpeg-devel wrote
On 21/05/2024 23:33, Hendrik Leppkes wrote:
On Tue, May 21, 2024 at 9:52 PM Lynne via ffmpeg-devel
wrote:
It should be the case here, we shouldn't need reordering as NATIVE just
lets you specify what order the elements appear in the bitstream.
NATIVE means "the FFmpeg native orde
On 22/05/2024 18:17, Philip Langdale via ffmpeg-devel wrote:
On Wed, 22 May 2024 11:10:31 -0400
"Ronald S. Bultje" wrote:
Hi,
On Wed, May 22, 2024 at 10:36 AM Hendrik Leppkes
wrote:
On Thu, Feb 29, 2024 at 7:19 AM llyyr wrote:
segmentation.update_map is never reset to 0 on a new frame,
On 22/05/2024 22:15, Marton Balint wrote:
On Wed, 22 May 2024, Lynne via ffmpeg-devel wrote:
On 21/05/2024 23:33, Hendrik Leppkes wrote:
On Tue, May 21, 2024 at 9:52 PM Lynne via ffmpeg-devel
wrote:
It should be the case here, we shouldn't need reordering as NATIVE
just
let
On 20/05/2024 16:52, tong1.wu-at-intel@ffmpeg.org wrote:
From: Tong Wu
Since VAAPI and future D3D12VA implementation may share some common parameters,
a base layer encode context is introduced as vaapi context's base.
Signed-off-by: Tong Wu
---
libavcodec/hw_base_encode.h | 56 +
On 24/05/2024 17:39, Wu, Tong1 wrote:
-Original Message-
From: ffmpeg-devel On Behalf Of Lynne
via ffmpeg-devel
Sent: Friday, May 24, 2024 12:11 AM
To: ffmpeg-devel@ffmpeg.org
Cc: Lynne
Subject: Re: [FFmpeg-devel] [PATCH v9 01/13] avcodec/vaapi_encode:
introduce a base layer for vaapi
AAC uses an unconventional system to send scalefactors
(the volume+quantization value for each band).
Each window is split into either 1 or 8 blocks (long vs short),
and transformed separately from one another, with the coefficients
for each being also completely independent. The scalefactors
sligh
This commit adds a decoder for the frequency-domain part of USAC.
SBR is as of now not yet supported, will be added with a future
patch.
A known issue is that preroll frames (usually present quite often
within the file, as xHE-AAC has real keyframes and I-frames) can
cause artifacts.
Lynne (10):
---
libavcodec/aac/aacdec.c | 73 -
libavcodec/aac/aacdec.h | 19 +--
2 files changed, 51 insertions(+), 41 deletions(-)
diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c
index 35722f9b9b..40554ff9e4 100644
--- a/libavcodec/aac/aacdec.c
USAC has the same syntax, with one minor change we can check for.
---
libavcodec/aac/aacdec.c | 6 +++---
libavcodec/aac/aacdec.h | 3 +++
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c
index 40554ff9e4..a7e5b2a369 100644
--- a/liba
apichanges will be updated upon merging, as well as a version bump.
---
libavutil/channel_layout.h | 4
1 file changed, 4 insertions(+)
diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h
index 8a078d1601..4e19bbbd9e 100644
--- a/libavutil/channel_layout.h
+++ b/libavutil/ch
---
libavcodec/aactab.c | 376
libavcodec/aactab.h | 6 +
2 files changed, 382 insertions(+)
diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c
index 8ce5e43974..dfb2dfd98d 100644
--- a/libavcodec/aactab.c
+++ b/libavcodec/aactab.c
@@ -1193,6 +11
Required for USAC
---
libavcodec/aac/aacdec.c | 4 ++
libavcodec/aac/aacdec.h | 5 +++
libavcodec/aac/aacdec_dsp_template.c | 67
libavcodec/aac/aacdec_fixed.c| 2 +
libavcodec/aac/aacdec_float.c| 4 ++
libavcodec/sinewin_f
---
libavcodec/aactab.c | 25 +
libavcodec/aactab.h | 2 ++
2 files changed, 27 insertions(+)
diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c
index 3718b81a07..8ce5e43974 100644
--- a/libavcodec/aactab.c
+++ b/libavcodec/aactab.c
@@ -3377,3 +3377,28 @@ const DECLAR
---
libavcodec/aactab.c | 117
libavcodec/aactab.h | 4 ++
2 files changed, 121 insertions(+)
diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c
index dfb2dfd98d..18afa69bad 100644
--- a/libavcodec/aactab.c
+++ b/libavcodec/aactab.c
@@ -154,6 +15
This commit adds a decoder for the frequency-domain part of USAC.
What works:
- Mono
- Stereo (no prediction)
- Stereo (mid/side coding)
- Stereo (complex prediction)
What's left:
- Speech coding
Known issues:
- Desync with certain sequences
- Preroll crossover missing (shouldn't matter,
Starting off small with a few features.
Samples and reference decoded files copied from the official ISO
reference suite.
FATE files: https://files.lynne.ee/xhe_refs/
---
tests/fate/aac.mak | 8
1 file changed, 8 insertions(+)
diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak
index 8
On 25/05/2024 12:30, tong1.wu-at-intel@ffmpeg.org wrote:
From: Tong Wu
Related parameters such as device context, frame context are also moved
to base layer.
Signed-off-by: Tong Wu
---
libavcodec/hw_base_encode.c | 49 ++
libavcodec/hw_base_encode.h | 17 +++
On 25/05/2024 16:18, Sean McGovern wrote:
Hi,
On Sat, May 25, 2024, 09:07 Lynne via ffmpeg-devel
wrote:
On 25/05/2024 12:30, tong1.wu-at-intel@ffmpeg.org wrote:
From: Tong Wu
Related parameters such as device context, frame context are also moved
to base layer.
Signed-off-by: Tong
The inline asm function had issues running under checkasm.
So I came to finish what I started, and wrote the last part
of LPC computation in assembly.
autocorr_10_c: 135525.8
autocorr_10_sse2: 50729.8
autocorr_10_fma3: 19007.8
autocorr_30_c: 390100.8
autocorr_30_sse2: 142478.8
autocorr_30_fma3: 50
On 26/05/2024 00:31, James Almer wrote:
On 5/25/2024 5:57 PM, Lynne via ffmpeg-devel wrote:
The inline asm function had issues running under checkasm.
So I came to finish what I started, and wrote the last part
of LPC computation in assembly.
autocorr_10_c: 135525.8
autocorr_10_sse2: 50729.8
On 26/05/2024 00:45, James Almer wrote:
On 5/25/2024 7:31 PM, James Almer wrote:
On 5/25/2024 5:57 PM, Lynne via ffmpeg-devel wrote:
The inline asm function had issues running under checkasm.
So I came to finish what I started, and wrote the last part
of LPC computation in assembly
The inline asm function had issues running under checkasm.
So I came to finish what I started, and wrote the last part
of LPC computation in assembly.
---
libavcodec/x86/lpc.asm| 91 +++
libavcodec/x86/lpc_init.c | 87 -
2
On 25/05/2024 08:10, Marton Balint wrote:
On Sat, 25 May 2024, Lynne via ffmpeg-devel wrote:
apichanges will be updated upon merging, as well as a version bump.
---
libavutil/channel_layout.h | 4
1 file changed, 4 insertions(+)
diff --git a/libavutil/channel_layout.h b/libavutil
Starting off small with a few features.
Samples and reference decoded files copied from the official ISO
reference suite.
FATE files: https://files.lynne.ee/xhe_refs/
---
tests/fate/aac.mak | 8
1 file changed, 8 insertions(+)
diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak
index 8
apichanges will be updated upon merging, as well as a version bump.
---
libavutil/channel_layout.c | 4
libavutil/channel_layout.h | 8
2 files changed, 12 insertions(+)
diff --git a/libavutil/channel_layout.c b/libavutil/channel_layout.c
index 98839b7250..2d6963b6df 100644
--- a/li
On 26/05/2024 22:51, Marton Balint wrote:
On Sun, 26 May 2024, Lynne via ffmpeg-devel wrote:
On 25/05/2024 08:10, Marton Balint wrote:
On Sat, 25 May 2024, Lynne via ffmpeg-devel wrote:
apichanges will be updated upon merging, as well as a version bump.
---
libavutil
On 27/05/2024 02:35, Wu, Tong1 wrote:
From: ffmpeg-devel On Behalf Of Lynne
via ffmpeg-devel
Sent: Saturday, May 25, 2024 10:07 PM
To: ffmpeg-devel@ffmpeg.org
Cc: Lynne
Subject: Re: [FFmpeg-devel] [PATCH v11 07/14] avcodec/vaapi_encode: extract
the init and close function to base layer
On 25
On 27/05/2024 10:40, Anton Khirnov wrote:
Quoting Lynne via ffmpeg-devel (2024-05-26 23:42:41)
...its an enum entry. Do you want a design document and a proposal?
You could talk to the person who did the research about it, JEEB.
Why wait at all? There's only you and JEEB that care about ch
On 27/05/2024 11:07, Anton Khirnov wrote:
Quoting Lynne via ffmpeg-devel (2024-05-27 10:54:40)
On 27/05/2024 10:40, Anton Khirnov wrote:
Quoting Lynne via ffmpeg-devel (2024-05-26 23:42:41)
...its an enum entry. Do you want a design document and a proposal?
You could talk to the person who
On 28/05/2024 16:03, Andreas Rheinhardt wrote:
Signed-off-by: Andreas Rheinhardt
---
libavcodec/diracdec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c
index 5bf0dcc2db..76209aebba 100644
--- a/libavcodec/diracdec.c
+++
On 28/05/2024 04:49, Andreas Rheinhardt wrote:
These strings are so short that they can be put directly
into the containing structure, avoiding the pointer
and putting it into .rodata.
Also use chars for interlaced and level while at it, as
these are so small.
Signed-off-by: Andreas Rheinhardt
On 28/05/2024 17:48, tong1.wu-at-intel@ffmpeg.org wrote:
From: Tong Wu
An avctx pointer is added to FFHWBaseEncodeContext. This is to make
FFHWBaseEncodeContext a standalone component for ff_hw_base_* functions.
This patch also removes some unnecessary AVCodecContext arguments.
Signed-off-
On 29/05/2024 00:53, Wu, Tong1 wrote:
From: ffmpeg-devel On Behalf Of Lynne
via ffmpeg-devel
Sent: Wednesday, May 29, 2024 1:08 AM
To: ffmpeg-devel@ffmpeg.org
Cc: Lynne
Subject: Re: [FFmpeg-devel] [PATCH v12 15/15] avcodec/hw_base_encode: add
avctx pointer for FFHWBaseEncodeContext
On 28/05
On 29/05/2024 23:46, James Almer wrote:
Signed-off-by: James Almer
---
fftools/ffmpeg.h| 7 +++
fftools/ffmpeg_demux.c | 16
fftools/ffmpeg_filter.c | 11 +++
fftools/ffmpeg_opt.c| 3 +++
4 files changed, 37 insertions(+)
diff --git a/fftools/ff
On 29/05/2024 23:46, James Almer wrote:
Signed-off-by: James Almer
---
libavcodec/packet.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/libavcodec/packet.h b/libavcodec/packet.h
index a9a41576da..9dee035690 100644
--- a/libavcodec/packet.h
+++ b/libavcodec/packet.h
@@ -
This commit adds a decoder for the frequency-domain part of USAC.
Changes over version 4:
- Actually reset entropy decoding upon configuration.
- Support for LFE channels.
Lynne (10):
channel_layout: add new channel positions supported by xHE-AAC
aacdec: move from scalefactor ranged arrays
apichanges will be updated upon merging, as well as a version bump.
---
libavutil/channel_layout.c | 4
libavutil/channel_layout.h | 8
2 files changed, 12 insertions(+)
diff --git a/libavutil/channel_layout.c b/libavutil/channel_layout.c
index 98839b7250..2d6963b6df 100644
--- a/li
AAC uses an unconventional system to send scalefactors
(the volume+quantization value for each band).
Each window is split into either 1 or 8 blocks (long vs short),
and transformed separately from one another, with the coefficients
for each being also completely independent. The scalefactors
sligh
---
libavcodec/aac/aacdec.c | 73 -
libavcodec/aac/aacdec.h | 19 +--
2 files changed, 51 insertions(+), 41 deletions(-)
diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c
index 35722f9b9b..40554ff9e4 100644
--- a/libavcodec/aac/aacdec.c
USAC has the same syntax, with one minor change we can check for.
---
libavcodec/aac/aacdec.c | 6 +++---
libavcodec/aac/aacdec.h | 3 +++
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c
index 40554ff9e4..a7e5b2a369 100644
--- a/liba
Required for USAC
---
libavcodec/aac/aacdec.c | 4 ++
libavcodec/aac/aacdec.h | 5 +++
libavcodec/aac/aacdec_dsp_template.c | 67
libavcodec/aac/aacdec_fixed.c| 2 +
libavcodec/aac/aacdec_float.c| 4 ++
libavcodec/sinewin_f
---
libavcodec/aactab.c | 25 +
libavcodec/aactab.h | 2 ++
2 files changed, 27 insertions(+)
diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c
index 3718b81a07..8ce5e43974 100644
--- a/libavcodec/aactab.c
+++ b/libavcodec/aactab.c
@@ -3377,3 +3377,28 @@ const DECLAR
---
libavcodec/aactab.c | 117
libavcodec/aactab.h | 4 ++
2 files changed, 121 insertions(+)
diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c
index dfb2dfd98d..18afa69bad 100644
--- a/libavcodec/aactab.c
+++ b/libavcodec/aactab.c
@@ -154,6 +15
This commit adds a decoder for the frequency-domain part of USAC.
What works:
- Mono
- Stereo (no prediction)
- Stereo (mid/side coding)
- Stereo (complex prediction)
What's left:
- Speech coding
Known issues:
- Desync with certain sequences
- Preroll crossover missing (shouldn't matter,
---
libavcodec/aactab.c | 376
libavcodec/aactab.h | 6 +
2 files changed, 382 insertions(+)
diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c
index 8ce5e43974..dfb2dfd98d 100644
--- a/libavcodec/aactab.c
+++ b/libavcodec/aactab.c
@@ -1193,6 +11
Starting off small with a few features.
Samples and reference decoded files copied from the official ISO
reference suite.
FATE files: https://files.lynne.ee/xhe_refs/
---
tests/fate/aac.mak | 8
1 file changed, 8 insertions(+)
diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak
index 8
On 30/05/2024 15:08, Dmitrii Ovchinnikov wrote:
Adds hwcontext_amf, which allows to use shared AMF
context for the encoder, decoder and AMF-based filters,
without copy to the host memory.
It will also allow you to use some optimisations in
the interaction of components (for example, SAV) and make
On 30/05/2024 18:06, Dmitrii Ovchinnikov wrote:
DX12 and Vulkan native encoders will expose less features compare to
AMF,
at least in foreseeable feature. The missing features include low
latency,
That's plainly not true.
PreAnalysis including look-ahead etc. AMF context on Windows
On 30/05/2024 03:04, James Almer wrote:
On 5/29/2024 10:01 PM, Lynne via ffmpeg-devel wrote:
On 29/05/2024 23:46, James Almer wrote:
Signed-off-by: James Almer
---
fftools/ffmpeg.h | 7 +++
fftools/ffmpeg_demux.c | 16
fftools/ffmpeg_filter.c | 11
On 31/05/2024 15:39, Jan Ekström wrote:
On Thu, May 30, 2024 at 5:39 AM Lynne via ffmpeg-devel
wrote:
apichanges will be updated upon merging, as well as a version bump.
---
libavutil/channel_layout.c | 4
libavutil/channel_layout.h | 8
2 files changed, 12 insertions
On 31/05/2024 19:51, Rémi Denis-Courmont wrote:
---
tests/checkasm/lpc.c | 57 ++--
1 file changed, 55 insertions(+), 2 deletions(-)
diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
index 592e34c03d..62232fdaf7 100644
--- a/tests/checkasm/lpc.c
On 31/05/2024 20:18, Rémi Denis-Courmont wrote:
---
tests/checkasm/aacencdsp.c | 37 +
1 file changed, 37 insertions(+)
diff --git a/tests/checkasm/aacencdsp.c b/tests/checkasm/aacencdsp.c
index 1756c4ecd5..756f92fd8f 100644
--- a/tests/checkasm/aacencdsp.c
On 31/05/2024 20:29, Rémi Denis-Courmont wrote:
Le perjantaina 31. toukokuuta 2024, 21.23.43 EEST Lynne via ffmpeg-devel a
écrit :
Please don't randomize the length in tests. Pick a few lengths to check
all corner cases.
Checkasm tests should be deterministic in how long it takes to run
---
src/index | 12
1 file changed, 12 insertions(+)
diff --git a/src/index b/src/index
index 442db4b..920a5bb 100644
--- a/src/index
+++ b/src/index
@@ -35,6 +35,18 @@
News
+ June 2rd, 2024, native xHE-AAC decoder
+
+ FFmpeg now implements a native xHE-AAC decoder. Cu
On 30/05/2024 04:37, Lynne wrote:
This commit adds a decoder for the frequency-domain part of USAC.
Changes over version 4:
- Actually reset entropy decoding upon configuration.
- Support for LFE channels.
Lynne (10):
channel_layout: add new channel positions supported by xHE-AAC
aacd
---
doc/APIchanges | 6 ++
libavutil/version.h | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/doc/APIchanges b/doc/APIchanges
index 60f056b863..e36a01336c 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@ -2,6 +2,12 @@ The last version increases of all libraries w
Not valid anymore with xHE-AAC.
---
libavcodec/codec_desc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
index a28ef68061..a3b983b907 100644
--- a/libavcodec/codec_desc.c
+++ b/libavcodec/codec_desc.c
@@ -2697,7 +2697,7 @
On 02/06/2024 19:13, James Almer wrote:
On 6/2/2024 2:10 PM, Lynne via ffmpeg-devel wrote:
---
doc/APIchanges | 6 ++
libavutil/version.h | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/doc/APIchanges b/doc/APIchanges
index 60f056b863..e36a01336c 100644
--- a
Some calls to get_escaped_value() specify 0 bits as the third value.
This would result in get_bits(0), which is not a correct usage of the
get_bits API.
---
libavcodec/aac/aacdec_usac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aa
USAC supports up to 64 audio channels, but puts no limit on the total
number of extensions that may be present. Which may mean that there's
a single audio channel, with 65 thousand extension elements.
We assume that 64 elements is the maximum for now. So check the value.
---
libavcodec/aac/aacdec
Verify that we have a correct number of channels.
---
libavcodec/aac/aacdec_usac.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c
index af3df3b449..0d5eb59de5 100644
--- a/libavcodec/aac/aacdec_usac.
---
libavcodec/aac/aacdec_usac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c
index 0d5eb59de5..80c6ab4e65 100644
--- a/libavcodec/aac/aacdec_usac.c
+++ b/libavcodec/aac/aacdec_usac.c
@@ -359,7 +359,7 @@ int ff_aac_
On 03/06/2024 01:14, James Almer wrote:
Fixes "libavcodec/aac/aacdec_usac.c(543): error C2440: 'type cast': cannot convert
from 'GetBitContext' to 'GetBitContext'"
from msvc.
That's a very weird error. Why would they not permit casts of the same type?
Signed-off-by: James Almer
---
libavc
---
doc/APIchanges | 3 +++
libavcodec/version.h | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/doc/APIchanges b/doc/APIchanges
index e36a01336c..d9bec790a3 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@ -2,6 +2,9 @@ The last version increases of all libraries wer
The issue is that AOT 45 isn't defined anywhere, and looking at the git
blame, it seems to have sprung up through a reordering of the enum,
and adding a hole.
The spec does not define an explicit AOT for SBR and no SBR, and only
uses AOT 42 (previously AOT_USAC_NOSBR), so just rename AOT_USAC to
i
This allows users to determine whether a stream is USAC or not.
---
libavcodec/aac/aacdec_usac.c | 4
libavcodec/avcodec.h | 1 +
libavcodec/defs.h| 1 +
libavcodec/profiles.c| 1 +
libavcodec/profiles.h| 1 +
5 files changed, 8 insertions(+)
diff --git a/
This makes it far easier to figure out which AOT belongs to which
profile.
Also, explicitly highlight the holes.
---
libavcodec/mpeg4audio.h | 82 +
1 file changed, 42 insertions(+), 40 deletions(-)
diff --git a/libavcodec/mpeg4audio.h b/libavcodec/mpeg4aud
On 05/06/2024 07:33, Andreas Rheinhardt wrote:
Lynne via ffmpeg-devel:
This allows users to determine whether a stream is USAC or not.
---
libavcodec/aac/aacdec_usac.c | 4
libavcodec/avcodec.h | 1 +
libavcodec/defs.h| 1 +
libavcodec/profiles.c| 1
In USAC, we set the max to 64.
---
libavcodec/aac.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/aac.h b/libavcodec/aac.h
index 9508760fa6..fc6d1361b2 100644
--- a/libavcodec/aac.h
+++ b/libavcodec/aac.h
@@ -31,7 +31,7 @@
#define AVCODEC_AAC_H
#define MAX_CHAN
---
libavcodec/aac/aacdec_usac.c | 105 +--
1 file changed, 63 insertions(+), 42 deletions(-)
diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c
index 04dd5facff..561734f930 100644
--- a/libavcodec/aac/aacdec_usac.c
+++ b/libavcodec/aac/aacdec
This was left out, and due to av_unused, forgotten about.
---
libavcodec/aac/aacdec.h | 1 +
libavcodec/aac/aacdec_usac.c | 16
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/libavcodec/aac/aacdec.h b/libavcodec/aac/aacdec.h
index ee21a94007..f0a33e7ac3 1006
Although LPD is not functional yet, the bitstream ends at that point.
---
libavcodec/aac/aacdec_usac.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c
index 3b4e980df4..9b28a9e90b 100644
--- a/libavcodec/aac/aacdec_usac.c
+++ b/libavc
The issue was that in case of common TNS parameters, TNS was
entirely skipped, as tns.present was set to 0.
---
libavcodec/aac/aacdec.h | 1 +
libavcodec/aac/aacdec_usac.c | 25 +++--
2 files changed, 16 insertions(+), 10 deletions(-)
diff --git a/libavcodec/aac/aacdec.h
Yet another thing not mentioned in the spec.
---
libavcodec/aac/aacdec_usac.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c
index 97655787ee..5dd489a43b 100644
--- a/libavcodec/aac/aacdec_usac.c
+++ b/libavcod
On 03/06/2024 11:19, tong1.wu-at-intel@ffmpeg.org wrote:
From: Tong Wu
This patch is to make FFHWBaseEncodeContext a standalone component
and avoid getting FFHWBaseEncodeContext from avctx->priv_data.
This patch also removes some unnecessary AVCodecContext arguments.
For receive_packet cal
On 06/06/2024 08:46, Wu, Tong1 wrote:
From: ffmpeg-devel On Behalf Of Lynne
via ffmpeg-devel
Sent: Thursday, June 6, 2024 2:11 PM
To: ffmpeg-devel@ffmpeg.org
Cc: Lynne
Subject: Re: [FFmpeg-devel] [PATCH v13 15/15] avcodec/hw_base_encode:
avoid getting FFHWBaseEncodeContext from avctx
On 03/06
On 03/06/2024 11:18, tong1.wu-at-intel@ffmpeg.org wrote:
From: Tong Wu
Move receive_packet function to base. This requires adding *alloc,
*issue, *output, *free as hardware callbacks. HWBaseEncodePicture is
introduced as the base layer structure. The related parameters in
VAAPIEncodeContext
1 - 100 of 418 matches
Mail list logo
