Re: [FFmpeg-devel] [PATCH 2/2] ffplay: remove unused viddec_width/viddec_height

2016-10-01 Thread Josh de Kock
On 01/10/2016 17:17, Marton Balint wrote: Signed-off-by: Marton Balint --- ffplay.c | 9 - 1 file changed, 9 deletions(-) diff --git a/ffplay.c b/ffplay.c index a7a6785..6d43191 100644 --- a/ffplay.c +++ b/ffplay.c @@ -230,9 +230,6 @@ typedef struct VideoState { Decoder viddec;

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: use decoder avctx for decoded subtitle width/height

2016-10-01 Thread Josh de Kock
On 01/10/2016 17:17, Marton Balint wrote: Fixes ticket #5873. Signed-off-by: Marton Balint --- ffplay.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ffplay.c b/ffplay.c index e64909a..a7a6785 100644 --- a/ffplay.c +++ b/ffplay.c @@ -2224,7 +2224,6 @@ static int vide

Re: [FFmpeg-devel] [PATCH] configure: define posix source on cygwin

2016-10-01 Thread Josh de Kock
On 01/10/2016 20:41, Timo Rothenpieler wrote: Will push tomorrow if nobody objects. LGTM, maybe add a note which says that it may have been a cygwin update which broke the build. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://

[FFmpeg-devel] [PATCH 1/2] doc/developer: reword some of the policies

2016-10-01 Thread Josh de Kock
Removed allowing for commiting disabled, unfinished code. Code should always try be in a working state. Explicitly state that FATE should pass, and code should work for all reviewers who tested. Signed-off-by: Josh de Kock --- doc/developer.texi | 89

[FFmpeg-devel] [PATCH 2/2] doc/developer: add sections for policies

2016-10-01 Thread Josh de Kock
And sort policies into these sections. Signed-off-by: Josh de Kock --- doc/developer.texi | 95 +++--- 1 file changed, 48 insertions(+), 47 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index d4344ff..b85bf0f 100644 --- a/doc

Re: [FFmpeg-devel] [PATCH] doc/t2h: add max-width to css.

2016-10-01 Thread Josh de Kock
On 01/10/2016 02:28, Josh de Kock wrote: Full width text is really difficult to read, this just makes it slightly more legible on larger (widescreen) screens. Signed-off-by: Josh de Kock --- See http://screenshotcomparison.com/comparison/186256 for a comparison of before/after. doc/t2h.init

[FFmpeg-devel] [PATCH v2 1/2] doc/developer: reword some of the policies

2016-10-01 Thread Josh de Kock
Explicitly state that FATE should pass, and code should work for all reviewers who tested. Signed-off-by: Josh de Kock --- doc/developer.texi | 91 ++ 1 file changed, 44 insertions(+), 47 deletions(-) diff --git a/doc/developer.texi b/doc

[FFmpeg-devel] [PATCH v2 2/2] doc/developer: add sections for policies

2016-10-01 Thread Josh de Kock
And sort policies into these sections. Signed-off-by: Josh de Kock --- doc/developer.texi | 95 +++--- 1 file changed, 48 insertions(+), 47 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index 0075a27..e466d95 100644 --- a/doc

Re: [FFmpeg-devel] [PATCH] doc/t2h: add max-width to css.

2016-10-02 Thread Josh de Kock
On 02/10/2016 08:24, Nicolas George wrote: Le decadi 10 vendémiaire, an CCXXV, Josh de Kock a écrit : Full width text is really difficult to read, this just makes it slightly more legible on larger (widescreen) screens. Signed-off-by: Josh de Kock --- See http://screenshotcomparison.com

Re: [FFmpeg-devel] [PATCH] doc/t2h: add max-width to css.

2016-10-02 Thread Josh de Kock
On 02/10/2016 13:52, Nicolas George wrote: Le primidi 11 vendémiaire, an CCXXV, Josh de Kock a écrit : Using max-width: 960px is common practice, Yet still bad practice. Not really. and since pixels are generally not 1:1 but scaled with

[FFmpeg-devel] [PATCH v2] doc/t2h: use container

2016-10-02 Thread Josh de Kock
Full width text is really difficult to read, this makes it more more legible on larger (widescreen) screens. It also means we aren't inventing our own container instead of using the bootstrap one. Signed-off-by: Josh de Kock --- doc/t2h.init | 2 +- doc/t2h.pm | 2 +- 2 files chang

Re: [FFmpeg-devel] [PATCH] libavformat/bink.c: fix warning due to misleading indentation

2016-10-02 Thread Josh de Kock
Hi Adriano, We appreciate the patches, but is it possible you could maybe collate your cosmetic patches and send them as a larger set? This patch LGTM though, will push tomorrow if no further comments. -- Josh ___ ffmpeg-devel mailing list ffmpeg-de

Re: [FFmpeg-devel] [PATCH v2 1/2] doc/developer: reword some of the policies

2016-10-02 Thread Josh de Kock
On 02/10/2016 22:47, Michael Niedermayer wrote: On Sun, Oct 02, 2016 at 01:51:41AM +0100, Josh de Kock wrote: Explicitly state that FATE should pass, and code should work for all reviewers who tested. Signed-off-by: Josh de Kock --- doc/developer.texi | 91

Re: [FFmpeg-devel] [PATCH v2] doc/t2h: use container

2016-10-02 Thread Josh de Kock
On 03/10/2016 00:07, Timothy Gu wrote: On Sun, Oct 02, 2016 at 02:53:22PM +0100, Josh de Kock wrote: Full width text is really difficult to read, this makes it more more legible on larger (widescreen) screens. It also means we aren't inventing our own container instead of using the boot

Re: [FFmpeg-devel] [PATCH]doc/platform: Mention musl where x86_32 is not supported

2016-10-02 Thread Josh de Kock
On 03/10/2016 01:44, Ronald S. Bultje wrote: Hi, On Sun, Oct 2, 2016 at 8:42 PM, Carl Eugen Hoyos wrote: 2016-10-03 2:36 GMT+02:00 Ronald S. Bultje : Hi, On Sun, Oct 2, 2016 at 7:51 PM, Carl Eugen Hoyos wrote: Attached patch adds a musl section to doc/platform. This is counter-prod

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ivi_dsp.c: fix warning due to misleading indentation

2016-10-03 Thread Josh de Kock
On 02/10/2016 19:46, Adriano Pallavicino wrote: LGTM. Will apply both patches squashed in a day if there are no further comments. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavformat/bink.c: fix warning due to misleading indentation

2016-10-03 Thread Josh de Kock
On 02/10/2016 19:35, Josh de Kock wrote: Hi Adriano, We appreciate the patches, but is it possible you could maybe collate your cosmetic patches and send them as a larger set? This patch LGTM though, will push tomorrow if no further comments. Applied. -- Josh

Re: [FFmpeg-devel] [PATCH v2 1/2] doc/developer: reword some of the policies

2016-10-04 Thread Josh de Kock
On 03/10/2016 00:05, Michael Niedermayer wrote: On Sun, Oct 02, 2016 at 11:16:49PM +0100, Josh de Kock wrote: On 02/10/2016 22:47, Michael Niedermayer wrote: On Sun, Oct 02, 2016 at 01:51:41AM +0100, Josh de Kock wrote: Explicitly state that FATE should pass, and code should work for all

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ivi_dsp.c: fix warning due to misleading indentation

2016-10-04 Thread Josh de Kock
On 03/10/2016 15:40, Josh de Kock wrote: On 02/10/2016 19:46, Adriano Pallavicino wrote: LGTM. Will apply both patches squashed in a day if there are no further comments. Applied. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH 0/4] V12 - SCTE-35 support

2016-10-04 Thread Josh de Kock
On 01/10/2016 18:27, Carlos Fernandez Sanz wrote: - Addresses new comments such as like idx value checking and filename checking Carlos Fernandez (4): Adding SCTE-35 CUI codec SCTE-35 extraction from mpegts SCTE-35 support in hlsenc Correct Indentation libavcodec/avcodec.h| 2 +

[FFmpeg-devel] [PATCH] doc/developer: remove duplicate policies and fix error

2016-10-04 Thread Josh de Kock
Fixes regression as of ee72b6d1 Signed-off-by: Josh de Kock --- The irony of this patch is terrible, but oh well. Maybe we're missing a 'everyone makes mistakes' policy. doc/developer.texi | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) d

[FFmpeg-devel] [PATCH] Fixed issue #43 JACK indev support on OSX

2016-02-18 Thread Josh de Kock
--- configure | 14 +++--- libavdevice/jack.c | 12 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 287896f..f2f7c3d 100755 --- a/configure +++ b/configure @@ -1732,6 +1732,7 @@ BUILTIN_LIST=" mm_empty rdtsc s

[FFmpeg-devel] [PATCH] Fixed issue #43 JACK indev support on OSX

2016-02-19 Thread Josh de Kock
--- configure | 12 +--- libavdevice/jack.c | 10 ++ 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 287896f..887384c 100755 --- a/configure +++ b/configure @@ -1732,6 +1732,7 @@ BUILTIN_LIST=" mm_empty rdtsc sares

Re: [FFmpeg-devel] [PATCH] Fixed issue #43 JACK indev support on OSX

2016-02-19 Thread Josh de Kock
--- configure | 13 ++--- libavdevice/jack.c | 10 ++ 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 287896f..78f9618 100755 --- a/configure +++ b/configure @@ -1732,6 +1732,7 @@ BUILTIN_LIST=" mm_empty rdtsc sare

[FFmpeg-devel] [PATCHv4] Fixed issue #43 JACK indev support on OSX

2016-02-21 Thread Josh de Kock
--- configure | 9 +++-- libavdevice/jack.c | 10 ++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/configure b/configure index a78e228..6b3ee5f 100755 --- a/configure +++ b/configure @@ -1732,6 +1732,7 @@ BUILTIN_LIST=" mm_empty rdtsc sarestar

Re: [FFmpeg-devel] [PATCH] configure: only check dispatch header on darwin

2016-02-25 Thread Josh de Kock
On 25/02/2016 14:00, Matthieu Bouron wrote: From: Matthieu Bouron Fixes build of lavd/jack on linux if dispatch happens to be available on this platform. dispatch, as well as its dependencies kqueue and pwq are generally not installed / distribued on linux systems. If it happens to be the case,

Re: [FFmpeg-devel] [PATCH] configure: only check dispatch header on darwin

2016-02-25 Thread Josh de Kock
On 25/02/2016 15:44, Clément Bœsch wrote: On Thu, Feb 25, 2016 at 03:34:37PM +, Josh de Kock wrote: On 25/02/2016 14:00, Matthieu Bouron wrote: From: Matthieu Bouron Fixes build of lavd/jack on linux if dispatch happens to be available on this platform. dispatch, as well as its

Re: [FFmpeg-devel] [PATCH] configure: only check dispatch header on darwin

2016-02-25 Thread Josh de Kock
On 25/02/2016 15:53, Nicolas George wrote: Le septidi 7 ventôse, an CCXXIV, Josh de Kock a écrit : Just thought it wouldn't hurt to fix the real problem--that libdispatch isn't being checked for correctly, rather than a quick fix. Either is fine, I guess, although the quick fix

Re: [FFmpeg-devel] [PATCH] lavc/indeo2: Fix banding artifacts and washed-out display

2016-03-16 Thread Josh de Kock
On 16/03/2016 08:31, Mats Peterson wrote: I can't really use Barbato as the author, since I was the one who included his changes, so I'm the author. But perhaps there is some way to attribute him properly in spite of that? Patches' authors are generally based on who originally wrote the patch, o

Re: [FFmpeg-devel] [PATCH] doc/developer.texi: Add a code of conduct

2016-03-26 Thread Josh de Kock
On 26/03/2016 13:28, Michael Niedermayer wrote: > +@section Code of conduct > + > +Respect other people, treat others the way you yourself want to be treated. The Code of Conduct is simple, and is based around a few key points: *insert goal of project here* Be friendly & respectful. This is the m

Re: [FFmpeg-devel] Support master branch of OpenJPEG and Grok J2K codecs

2016-04-04 Thread Josh de Kock
On 04/04/2016 14:21, Aaron Boxer wrote: > All of your arguments could be applied equally to GPL v3 components. And > yet, > FFmpeg is happy to allow distribution under GPL v3. So, I don't see what > the problem is here. The problem is AGPL can make certain builds of FFmpeg _unusable_, it's a pain t

[FFmpeg-devel] [PATCH WIP 0/2] Update usage of SDL1 library to SDL2

2016-05-17 Thread Josh de Kock
Hi, I'm trying to update the usages of SDL1 to SDL2 so that they can follow the new library, as the last version was released in 2013, and is probably becoming a bit stale. While this should be a fairly simple patch (for others), I'm having a little trouble with it, and it was suggested that I pos

[FFmpeg-devel] [PATCH WIP 1/2] ffplay: convert ffplay to use SDL2

2016-05-17 Thread Josh de Kock
From: Marton Balint This patch looks mostly fine, there's just one thing though, which is the ALSA fix using envvars. There doesn't seem to be a replacement for these functions in SDL2, so I was wondering how else it could be done. Maybe through putenv()? --- configure | 27 ++- ffplay.c | 59

[FFmpeg-devel] [PATCH WIP 2/2] avdev: add sdl2 device

2016-05-17 Thread Josh de Kock
6 --- /dev/null +++ b/libavdevice/sdl2.c @@ -0,0 +1,437 @@ +/* + * Copyright (c) 2011 Stefano Sabatini + * Copyright (c) 2016 Josh de Kock + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * Licen

Re: [FFmpeg-devel] [PATCH WIP 1/2] ffplay: convert ffplay to use SDL2

2016-05-17 Thread Josh de Kock
On 17/05/2016 21:47, Marton Balint wrote: > > On Tue, 17 May 2016, Josh de Kock wrote: > >> From: Marton Balint >> >> This patch looks mostly fine, there's just one thing though, which is >> the ALSA fix using envvars. There doesn't seem to be a repla

[FFmpeg-devel] [PATCH WIPv2 2/2] avdev: add sdl2 device

2016-05-21 Thread Josh de Kock
sndio); REGISTER_INOUTDEV(V4L2, v4l2); //REGISTER_INDEV (V4L, v4l diff --git a/libavdevice/sdl2.c b/libavdevice/sdl2.c new file mode 100644 index 000..8c3d49e --- /dev/null +++ b/libavdevice/sdl2.c @@ -0,0 +1,458 @@ +/* + * Copyright (c) 2011 Stefano Saba

[FFmpeg-devel] [PATCH] lavf: add libopenmpt demuxer

2016-06-11 Thread Josh de Kock
TER_DEMUXER (LIBOPENMPT, libopenmpt); initialized = 1; } diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c new file mode 100644 index 000..8c95c0a --- /dev/null +++ b/libavformat/libopenmpt.c @@ -0,0 +1,185 @@ +/* + * Tracked MOD demuxer (libopenmpt) + * Copyright (

[FFmpeg-devel] [PATCH] lavf: add libopenmpt demuxer

2016-06-18 Thread Josh de Kock
PT, libopenmpt); initialized = 1; } diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c new file mode 100644 index 000..b2dcb9b --- /dev/null +++ b/libavformat/libopenmpt.c @@ -0,0 +1,182 @@ +/* + * Tracked MOD demuxer (libopenmpt) + * Copyright (c) 2016 Josh de Kock +

[FFmpeg-devel] [PATCHv3] lavf: add libopenmpt demuxer

2016-06-19 Thread Josh de Kock
ISTER_MUXDEMUX(LIBNUT, libnut); +REGISTER_DEMUXER (LIBOPENMPT, libopenmpt); initialized = 1; } diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c new file mode 100644 index 000..4db820d --- /dev/null +++ b/libavformat/libopenmpt.c @@ -0,0 +1,188 @@ +/* + * Tr

[FFmpeg-devel] [PATCHv4] lavf: add libopenmpt demuxer

2016-06-29 Thread Josh de Kock
DPLUG, libmodplug); REGISTER_MUXDEMUX(LIBNUT, libnut); +REGISTER_DEMUXER (LIBOPENMPT, libopenmpt); initialized = 1; } diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c new file mode 100644 index 0000000..c9e0a8e --- /dev/null +++ b/libavfo

Re: [FFmpeg-devel] [PATCHv4] lavf: add libopenmpt demuxer

2016-07-07 Thread Josh de Kock
Hi, On Thu, Jul 7, 2016, at 10:47 AM, Carl Eugen Hoyos wrote: > Josh de Kock itanimul.li> writes: > > > +ret = openmpt_could_open_propability( > > I don't know anything about openmpt but what was > wrong with the original probe function sent by you? It probed

[FFmpeg-devel] [PATCHv5] lavf: add libopenmpt demuxer

2016-07-10 Thread Josh de Kock
DPLUG, libmodplug); REGISTER_MUXDEMUX(LIBNUT, libnut); +REGISTER_DEMUXER (LIBOPENMPT, libopenmpt); initialized = 1; } diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c new file mode 100644 index 0000000..a237ad6 --- /dev/null +++ b/libavfo

[FFmpeg-devel] [PATCH] lavc/libzvbi: remove deprecated API usage

2017-02-11 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavcodec/libzvbi-teletextdec.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/libzvbi-teletextdec.c b/libavcodec/libzvbi-teletextdec.c index d1f0a9f..2ed4a82 100644 --- a/libavcodec/libzvbi-teletextdec.c +++ b

[FFmpeg-devel] [PATCH v2] lavc/libzvbi: remove deprecated API usage

2017-02-12 Thread Josh de Kock
Hi Carl, I'm not sure, 0.2.28 doesn't compile on my system. It has been tested with the latest version 0.2.38. Does the updated patch look better? Josh Signed-off-by: Josh de Kock --- libavcodec/libzvbi-teletextdec.c | 15 +-- 1 file changed, 13 insertions(+), 2

Re: [FFmpeg-devel] [PATCH v2] lavc/libzvbi: remove deprecated API usage

2017-02-12 Thread Josh de Kock
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 12/02/2017 15:28, Marton Balint wrote: > > On Sun, 12 Feb 2017, Josh de Kock wrote: > >> Hi Carl, >> >> I'm not sure, 0.2.28 doesn't compile on my system. It has been >> tested with the latest ver

[FFmpeg-devel] [PATCH] lavf/mpegts: document DVB teletext PMT fields

2017-02-17 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavformat/mpegts.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 590abb0..bcf2118 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -1718,6 +1718,11 @@ int ff_parse_mpeg2_descriptor

[FFmpeg-devel] [PATCH] lavc/libzvbi: base support for multiple levels

2017-02-17 Thread Josh de Kock
Also add support for level 1.0 explicitly. Signed-off-by: Josh de Kock --- libavcodec/libzvbi-teletextdec.c | 60 1 file changed, 42 insertions(+), 18 deletions(-) diff --git a/libavcodec/libzvbi-teletextdec.c b/libavcodec/libzvbi-teletextdec.c index

Re: [FFmpeg-devel] [PATCH] lavc/libzvbi: base support for multiple levels

2017-02-17 Thread Josh de Kock
On 18/02/2017 00:51, Marton Balint wrote: > > On Fri, 17 Feb 2017, Josh de Kock wrote: > >> Also add support for level 1.0 explicitly. >> > > What is the use case for this? Reducing the number of colors? > Pretty much. > I don't think you can reduce

Re: [FFmpeg-devel] [PATCH 4/4] lavc, lavd, lavf, lavfi, tests: remove several register() calls

2018-03-18 Thread Josh de Kock
> On 18 Mar 2018, at 13:40, j...@itanimul.li wrote: > > From: Josh de Kock > > --- > doc/examples/filter_audio.c | 2 -- > doc/examples/filtering_audio.c | 2 -- > doc/examples/filtering_video.c | 2 -- > doc/examples/transcoding.c | 2 -- > fftool

[FFmpeg-devel] [PATCH 2/2] lavf/img2dec: use new iteration API

2018-03-18 Thread Josh de Kock
--- libavformat/img2dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index f3f52c83b3..159617f046 100644 --- a/libavformat/img2dec.c +++ b/libavformat/img2dec.c @@ -324,6 +324,7 @@ int ff_img_read_header(AVFormatContext *s1)

[FFmpeg-devel] [PATCH v2 1/2] lav*, tests: remove several register_all() calls

2018-03-18 Thread Josh de Kock
Because lavf and lavd being separated incrementally, some of the hacky behaviour in how options are found/parsed is being exposed. Basically, finding options works on some behaviour with iterating AVClasses, and making lavd not a hack-of-a-library incrementally (i.e. by separating iteration) messed

Re: [FFmpeg-devel] [PATCH 1/4] checkasm/Makefile: add EXTRALIBS-libavformat

2018-03-18 Thread Josh de Kock
On Sun, Mar 18, 2018 at 01:42:12PM -0300, James Almer wrote: > On 3/18/2018 1:06 PM, Paul B Mahol wrote: > > [...] > > And how do you know that?, without even providing alternative? > > I provided an alternative. Look at my comment about the *_FFLIBS > variables. The build system already uses it w

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/libopenmpt: Probe file format from file data if possible

2018-03-18 Thread Josh de Kock
On 2018/03/18 8:23, wm4 wrote: > On Sun, 18 Mar 2018 08:44:12 +0100 > Jörn Heusipp wrote: > >> On 03/04/2018 08:55 AM, Jörn Heusipp wrote: >>> On 02/21/2018 12:11 PM, Jörn Heusipp wrote: libavformat/libopenmpt.c | 57 1 file cha

[FFmpeg-devel] [DISCUSSION] New iteration APIs, lavf and lavd

2018-03-18 Thread Josh de Kock
Hi, The new iteration API to replace the old _next() is nearing the end of it's completion with the lavfi patch on the mailing list and only one outstanding issue: AVOptions would not be found for devices as there is no AVClass for lavd. At the moment it would work if you were to still call

[FFmpeg-devel] [PATCH v3 1/7] checkasm/Makefile: add EXTRALIBS-libavformat

2018-03-19 Thread Josh de Kock
--- tests/checkasm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile index 0520e264e2..ae7e810d25 100644 --- a/tests/checkasm/Makefile +++ b/tests/checkasm/Makefile @@ -61,7 +61,7 @@ tests/checkasm/checkasm.o: CFLAGS += -

[FFmpeg-devel] [PATCH v3 2/7] lavfi: add new iteration API

2018-03-19 Thread Josh de Kock
--- configure| 24 +- doc/APIchanges | 4 + doc/writing_filters.txt | 6 +- libavfilter/allfilters.c | 818 +-- libavfilter/avfilter.c | 45 --- libavfilter/avfilter.h | 29 +- libavfilter/version.h| 3 + 7 fil

[FFmpeg-devel] [PATCH v3 5/7] lavf, lavd: add AVClass for lavd & use iterate API

2018-03-19 Thread Josh de Kock
Add an AVClass for AVDevice as the .child_class_next member for lavf's AVClass will no longer find devices. --- fftools/cmdutils.c | 10 + fftools/ffmpeg_opt.c | 2 +- libavdevice/Makefile | 1 + libavdevice/avdevice.h | 1 + libavdevice/options.c | 115

[FFmpeg-devel] [PATCH v3 0/7] Implementation of option one

2018-03-19 Thread Josh de Kock
oute we take, options 2-4 wouldn't include this set as they would be replaced by other sets: 2) would change the way this patch has interactions between lavf and lavd. 3) would remove the interactions between lavf and lavd as they would just be the same library. 4) this set wouldnt exist. Jos

[FFmpeg-devel] [PATCH v3 3/7] cmdutils: use new iteration APIs

2018-03-19 Thread Josh de Kock
--- fftools/cmdutils.c | 239 + 1 file changed, 112 insertions(+), 127 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 708a849f51..2da313cc0a 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1250,19 +1250,11 @

[FFmpeg-devel] [PATCH v3 4/7] fftools/ff*.c: use iteration API to find formats

2018-03-19 Thread Josh de Kock
With the new API, if avdevice_register_all() isn't called av_find_input_format() wont find devices, so switch to the new API to make sure devices would always be checked if they are available even if devices are not registered through the old API. --- fftools/ffmpeg_opt.c | 25

[FFmpeg-devel] [PATCH v3 6/7] lav*, tests: remove several register_all() calls

2018-03-19 Thread Josh de Kock
--- doc/examples/filter_audio.c | 2 -- doc/examples/filtering_audio.c | 2 -- doc/examples/filtering_video.c | 2 -- doc/examples/transcoding.c | 2 -- fftools/ffmpeg.c | 6 -- fftools/ffplay.c | 7 --- fftools/ffprobe.c| 4 --

[FFmpeg-devel] [PATCH v3 7/7] lavf/img2dec: use new iteration API

2018-03-19 Thread Josh de Kock
--- libavformat/img2dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index f3f52c83b3..159617f046 100644 --- a/libavformat/img2dec.c +++ b/libavformat/img2dec.c @@ -324,6 +324,7 @@ int ff_img_read_header(AVFormatContext *s1)

[FFmpeg-devel] [PATCH 5/7] lavf, lavd: add AVClass for lavd & use iterate API

2018-03-21 Thread Josh de Kock
Add an AVClass for AVDevice as the .child_class_next member for lavf's AVClass will no longer find devices. --- fftools/cmdutils.c | 10 + fftools/ffmpeg_opt.c | 2 +- libavdevice/Makefile | 1 + libavdevice/avdevice.h | 1 + libavdevice/options.c | 115

[FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-21 Thread Josh de Kock
--- I have -ffunroll'd the macros for you Nicolas. fftools/cmdutils.c | 248 - 1 file changed, 129 insertions(+), 119 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 708a849f51..956eb7b974 100644 --- a/fftools/cmdutils

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-22 Thread Josh de Kock
On 2018/03/22 10:29, Nicolas George wrote: Josh de Kock (2018-03-22): I have -ffunroll'd the macros for you Nicolas. That is not what I asked. The macros were just a way of making the poor API a little less poor, but the problem still remains: +#ifdef CONFIG_AVDEVICE +opaqu

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-22 Thread Josh de Kock
On 2018/03/22 11:19, Nicolas George wrote: Josh de Kock (2018-03-22): I strongly oppose using the same loop. Separating devices' iteration is one of the first steps to separating lavf from lavd. And I oppose separating lavf from lavd, was it not clear enough? I have given technical argu

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-22 Thread Josh de Kock
On 2018/03/22 11:37, wm4 wrote: On Thu, 22 Mar 2018 12:32:29 +0100 Nicolas George wrote: Josh de Kock (2018-03-22): There is always the option to just merge lavf and lavd. The state of them being sort-of merged, but not really, isn't very good and adds a lot of complexity especially in

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-22 Thread Josh de Kock
On 2018/03/22 12:07, Nicolas George wrote: Josh de Kock (2018-03-22): Merging lavd into lavf may be the best option here, as it allows us to change the return type of av_iterate_indev() etc to an AVDevice or another type which may represent an actual device as opposed to a purely input/output

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-22 Thread Josh de Kock
On 2018/03/22 22:38, Michael Niedermayer wrote: > On Thu, Mar 22, 2018 at 02:01:27AM +0000, Josh de Kock wrote: > [...] >> +#ifdef CONFIG_AVDEVICE >> +opaque = 0; >> +if (muxdemuxers != SHOW_DEMUXERS) { >> +while ((of

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-23 Thread Josh de Kock
On 2018/03/23 10:05, Nicolas George wrote: Josh de Kock (2018-03-22): move lavd avinputformats and avoutputformats into lavf delete lavd Possibly ok in principle for me, but see below. I personally think this will fix a lot of the weird interactions between the two libraries, and should

[FFmpeg-devel] [PATCH 0/5] Add lavfi api & remove device iteration

2018-03-23 Thread Josh de Kock
This set is an alternative to the previous set I posted, it makes it so that the current behaviour is kept (devices are returned in by the iteration functions but must be loaded in manually). It is a compromise between what Nicolas George suggested and a full rewrite. I personally would like to ju

[FFmpeg-devel] [PATCH 1/5] checkasm/Makefile: add EXTRALIBS-libavformat

2018-03-23 Thread Josh de Kock
--- tests/checkasm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile index 0520e264e2..ae7e810d25 100644 --- a/tests/checkasm/Makefile +++ b/tests/checkasm/Makefile @@ -61,7 +61,7 @@ tests/checkasm/checkasm.o: CFLAGS += -

[FFmpeg-devel] [PATCH 2/5] lavfi: add new iteration API

2018-03-23 Thread Josh de Kock
--- configure| 24 +- doc/APIchanges | 4 + doc/writing_filters.txt | 6 +- libavfilter/allfilters.c | 820 +-- libavfilter/avfilter.c | 45 --- libavfilter/avfilter.h | 29 +- libavfilter/version.h| 3 + 7 fil

[FFmpeg-devel] [PATCH 5/5] cmdutils: use new APIs

2018-03-23 Thread Josh de Kock
--- fftools/cmdutils.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index c0ddf0b287..a6cf002fd0 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1259,8 +1259,10 @@ static int is_device(const AVClass *avcla

[FFmpeg-devel] [PATCH 4/5] lavd: remove linked lists

2018-03-23 Thread Josh de Kock
--- configure| 23 +++-- libavdevice/alldevices.c | 87 ++-- libavformat/allformats.c | 78 +-- libavformat/avformat.h | 2 ++ 4 files changed, 120 insertions(+), 70 deletions(-) diff --

[FFmpeg-devel] [PATCH 3/5] Revert "lavd: add new API for iterating input and output devices"

2018-03-23 Thread Josh de Kock
This reverts commit 0fd475704e871ef3a535947596a012894bae3cbd. Revert "lavd: fix iterating of input and output devices" This reverts commit ce1d77a5e7cebce11074bf6f9e38ad6da37338ff. --- Makefile | 3 +- configure| 23 +++--- doc/APIchanges | 5 -- li

[FFmpeg-devel] [PATCH v2 2/5] lavfi: add new iteration API

2018-03-23 Thread Josh de Kock
Signed-off-by: Josh de Kock --- configure| 24 +- doc/APIchanges | 4 + doc/writing_filters.txt | 6 +- libavfilter/allfilters.c | 820 +-- libavfilter/avfilter.c | 50 +-- libavfilter/avfilter.h | 29

Re: [FFmpeg-devel] [PATCH] libavfilter: Add OpenCL convolution filter v0.2: add name

2018-03-23 Thread Josh de Kock
On 2018/03/23 13:22, Danil Iashchenko wrote: Thanks, fixed! --- libavfilter/opencl/convolution.cl | 2 ++ libavfilter/vf_convolution_opencl.c | 2 ++ 2 files changed, 4 insertions(+) When you update patches you should send the same patch again (yes the whole patch) with the required cha

[FFmpeg-devel] [PATCH v3] lavfi: add new iteration API

2018-03-24 Thread Josh de Kock
Signed-off-by: Josh de Kock --- configure| 29 +- doc/APIchanges | 4 + doc/writing_filters.txt | 6 +- libavfilter/allfilters.c | 823 +-- libavfilter/avfilter.c | 50 +-- libavfilter/avfilter.h | 29

Re: [FFmpeg-devel] [PATCH 0/5] Add lavfi api & remove device iteration

2018-03-25 Thread Josh de Kock
On 2018/03/23 20:48, Josh de Kock wrote: This set is an alternative to the previous set I posted, it makes it so that the current behaviour is kept (devices are returned in by the iteration functions but must be loaded in manually). It is a compromise between what Nicolas George suggested and a

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-25 Thread Josh de Kock
On 2018/03/25 16:21, Michael Niedermayer wrote: On Fri, Mar 23, 2018 at 11:05:22AM +0100, Nicolas George wrote: Josh de Kock (2018-03-22): move lavd avinputformats and avoutputformats into lavf delete lavd Possibly ok in principle for me, but see below. write new lavd aimed at actual

Re: [FFmpeg-devel] [PATCH 0/5] Add lavfi api & remove device iteration

2018-03-31 Thread Josh de Kock
On 2018/03/25 13:53, Josh de Kock wrote: On 2018/03/23 20:48, Josh de Kock wrote: This set is an alternative to the previous set I posted, it makes it so that the current behaviour is kept (devices are returned in by the iteration functions but must be loaded in manually). It is a compromise

[FFmpeg-devel] [PATCH 2/4] Revert "avformat/format: temporarily use old next api"

2018-03-31 Thread Josh de Kock
This reverts commit 909e00ae816df9b6a05b1c4d0cafb794d4d0ca28. There is no need to use the old API anymore as the new API now behaves in the same way (treating devices as formats when loaded). Signed-off-by: Josh de Kock --- libavformat/format.c | 13 + 1 file changed, 1 insertion

[FFmpeg-devel] [PATCH 1/4] lavf/img2dec: use new iteration API

2018-03-31 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavformat/img2dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index f3f52c83b3..159617f046 100644 --- a/libavformat/img2dec.c +++ b/libavformat/img2dec.c @@ -324,6 +324,7 @@ int

[FFmpeg-devel] [PATCH 3/4] lavf: move avpriv function definition to internal.h

2018-03-31 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavformat/avformat.h | 2 -- libavformat/internal.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index ec4e5f45f5..a2fe7c6bb2 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h

[FFmpeg-devel] [PATCH 4/4] lav*, tests: remove several register_all calls

2018-03-31 Thread Josh de Kock
avdevice_register_all() is still required to register devices into lavf (this is required due to lavd being somewhat of a hack). Signed-off-by: Josh de Kock --- doc/examples/filter_audio.c | 2 -- doc/examples/filtering_audio.c | 2 -- doc/examples/filtering_video.c | 2 -- doc

[FFmpeg-devel] [PATCH 1/6] lavf/allformats: remove left-over index decrement

2018-03-31 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavformat/allformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/allformats.c b/libavformat/allformats.c index 2a20548c95..cf430a9680 100644 --- a/libavformat/allformats.c +++ b/libavformat/allformats.c @@ -493,7 +493,7

[FFmpeg-devel] [PATCH 6/6] lavf/format: use const AVInputFormat for iteration

2018-03-31 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavformat/format.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/format.c b/libavformat/format.c index 1b2ce22e25..1c66afb7e6 100644 --- a/libavformat/format.c +++ b/libavformat/format.c @@ -117,11 +117,11 @@ enum

[FFmpeg-devel] [PATCH 2/6] lavf/img2dec: use new iteration API

2018-03-31 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavformat/img2dec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index f3f52c83b3..5fda850e7d 100644 --- a/libavformat/img2dec.c +++ b/libavformat/img2dec.c @@ -323,7 +323,8 @@ int

[FFmpeg-devel] [PATCH 4/6] lav*, tests: remove several register_all calls

2018-03-31 Thread Josh de Kock
avdevice_register_all() is still required to register devices into lavf (this is required due to lavd being somewhat of a hack). Signed-off-by: Josh de Kock --- doc/examples/filter_audio.c | 2 -- doc/examples/filtering_audio.c | 2 -- doc/examples/filtering_video.c | 2 -- doc

[FFmpeg-devel] [PATCH 3/6] lavf: move avpriv function definition to internal.h

2018-03-31 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavdevice/alldevices.c | 1 + libavformat/allformats.c | 1 + libavformat/avformat.h | 2 -- libavformat/internal.h | 1 + 4 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libavdevice/alldevices.c b/libavdevice/alldevices.c index ebf95f8a81

[FFmpeg-devel] [PATCH 5/6] Revert "avformat/format: temporarily use old next api"

2018-03-31 Thread Josh de Kock
This reverts commit 909e00ae816df9b6a05b1c4d0cafb794d4d0ca28. There is no need to use the old API anymore as the new API now behaves in the same way (treating devices as formats when loaded). Signed-off-by: Josh de Kock --- libavformat/format.c | 19 --- 1 file changed, 4

Re: [FFmpeg-devel] [PATCH] cmdutils: fix new API break the "ffmpeg -muxers/demuxers"

2018-04-01 Thread Josh de Kock
On 2018/04/02 0:07, Jun Zhao wrote: [...] Thanks, pushed. I thought I had checked this, obviously not. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/6] lavf: move avpriv function definition to internal.h

2018-04-01 Thread Josh de Kock
On 2018/04/01 16:14, James Almer wrote: [...] > LGTM. Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/6] lavf/allformats: remove left-over index decrement

2018-04-01 Thread Josh de Kock
On 2018/04/01 3:39, Josh de Kock wrote: Signed-off-by: Josh de Kock --- libavformat/allformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/allformats.c b/libavformat/allformats.c index 2a20548c95..cf430a9680 100644 --- a/libavformat/allformats.c +++ b

Re: [FFmpeg-devel] [PATCH 1/6] lavf/allformats: remove left-over index decrement

2018-04-01 Thread Josh de Kock
On 2018/04/02 2:40, wm4 wrote: On Sun, 1 Apr 2018 03:39:40 +0100 Josh de Kock wrote: Signed-off-by: Josh de Kock --- libavformat/allformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/allformats.c b/libavformat/allformats.c index 2a20548c95

Re: [FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-04-02 Thread Josh de Kock
On 2018/04/02 3:56, mi...@brew.sh wrote: From: Misty De Meo [...] --- /dev/null +++ b/libavformat/segafilmenc.c @@ -0,0 +1,397 @@ +/* + * Sega FILM Format (CPK) Muxer + * Copyright (C) 2003 The FFmpeg project I assume you copied the demuxer but shouldn't you be here as well? + * + * This fil

[FFmpeg-devel] [PATCH] Changelog: add entry for new iteration API

2018-04-02 Thread Josh de Kock
--- Changelog | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Changelog b/Changelog index 200866d873..f0b51ad1ee 100644 --- a/Changelog +++ b/Changelog @@ -52,6 +52,8 @@ version : - E-AC-3 dependent frames support - bitstream filter for extracting E-AC-3 core - Haivision SRT protocol via

Re: [FFmpeg-devel] [PATCH] Changelog: add entry for new iteration API

2018-04-02 Thread Josh de Kock
> On 2 Apr 2018, at 14:16, James Almer wrote: > >> On 4/2/2018 10:13 AM, Josh de Kock wrote: >> --- >> Changelog | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Changelog b/Changelog >> index 200866d873..f0b51ad1ee 100644 >>

Re: [FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-04-05 Thread Josh de Kock
On 2018/04/02 18:53, mi...@brew.sh wrote: segafilm muxer Thanks, pushed. I also clarified with wm4 on IRC that while he was against it he wasn't blocking the muxer if someone else pushes it. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg

<    1   2   3   4   >