On Mon, Sep 20, 2021 at 5:44 PM James Zern wrote:
>
> On Wed, Sep 8, 2021 at 6:46 PM James Zern wrote:
> >
> > On Mon, Aug 30, 2021 at 5:11 AM Maryla
> > wrote:
> > >
> > > When a color indexing transform with 16 or fewer colors is used,
> > &
On Wed, Oct 20, 2021 at 9:59 AM Matt Oliver wrote:
>
> This fixes linking errors where variables cannot be correctly linked in
> from an external shared library such as with msvc (requires dllimport which
> is not used by libaom). Instead just call the function that returns the
> same variable.
>
On Fri, Oct 29, 2021 at 8:13 PM Matt Oliver wrote:
>
> >
> > Does this compile and link with libaom 1.0.0? We unfortunately still
> > support that version (despite being unusable speed wise) because distros
> > like Debian still ship it.
> >
>
> Just looked it up and yes version 1.0.0 includes the
On Fri, Oct 29, 2021 at 8:51 PM Matt Oliver wrote:
>
> On Sat, 30 Oct 2021 at 14:13, Matt Oliver wrote:
>
> > Does this compile and link with libaom 1.0.0? We unfortunately still
> >> support that version (despite being unusable speed wise) because distros
> >> like Debian still ship it.
> >>
> >
On Sat, Oct 30, 2021 at 6:59 AM James Almer wrote:
>
> Fixes -Wstringop-overflow warnings with libaom >= 2.0.0, where the unused
> alpha
> plane was removed from aom_image.
>
> Signed-off-by: James Almer
> ---
> libavcodec/libaomdec.c | 10 +++---
> 1 file changed, 7 insertions(+), 3 deleti
On Mon, Nov 1, 2021 at 6:11 PM Matt Oliver wrote:
>
> On Tue, 2 Nov 2021 at 04:41, James Zern
> wrote:
>
> > On Fri, Oct 29, 2021 at 8:51 PM Matt Oliver wrote:
> > >
> > > On Sat, 30 Oct 2021 at 14:13, Matt Oliver wrote:
> > >
> > &
On Mon, Nov 22, 2021 at 4:35 AM Matt Oliver wrote:
>
> On Thu, 4 Nov 2021 at 15:44, Matt Oliver wrote:
>
> > Instead link against the function that returns the correct variable. This
> > fixes linking errors with dlls with msvc.
> > ---
> > libavcodec/libvpxdec.c | 10 +-
> > 1 file chan
On Mon, Nov 22, 2021 at 6:47 AM wrote:
>
> From: Limin Wang
>
> For dst->have_sse will be assigned by ctx->have_sse soon(code line 23).
>
> Signed-off-by: Limin Wang
> ---
> libavcodec/libaomenc.c | 1 -
> 1 file changed, 1 deletion(-)
>
lgtm.
___
ff
after a successful init if the function fails for another reason close
the codec without requiring FF_CODEC_CAP_INIT_CLEANUP which is meant to
cover init failures themselves. fixes a memory leak in those cases.
BUG=oss-fuzz:15529
Signed-off-by: James Zern
---
libavcodec/utils.c | 5 -
1
Hi,
On Tue, Jul 30, 2019 at 10:06 PM Linjie Fu wrote:
> [...]
> diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c
> index feb52ea..800ba18 100644
> --- a/libavcodec/libvpxenc.c
> +++ b/libavcodec/libvpxenc.c
> @@ -1067,6 +1067,15 @@ static int vpx_encode(AVCodecContext *avctx, AVPacket
Hi,
On Tue, Aug 13, 2019 at 1:18 AM Guo, Yejun wrote:
>
> example command line to verify it:
> ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M
> tmp.webm
>
> Signed-off-by: Guo, Yejun
> ---
> configure | 7 ++
> libavcodec/libvpxenc.c | 197
>
Hi,
On Tue, Aug 13, 2019 at 2:30 AM Linjie Fu wrote:
>
> According to spec, libvpx should support dynamic resolution changes.
>
> Add dynamic resolution encoding support in libvpx.
>
> Only single pass mode with no look ahead is supported for variable
> resolution encoding without initialization.
Hi,
On Tue, Aug 13, 2019 at 8:23 PM elliottk
wrote:
>
> Current default is 256kbps, which produces inconsistent
> results (too high for low-res, too low for hi-res).
> Use CRF instead, which will adapt.
> ---
> libavcodec/libaomenc.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-
Hi,
On Thu, Aug 15, 2019 at 1:22 PM elliottk
wrote:
>
> Current default is 256kbps, which produces inconsistent
> results (too high for low-res, too low for hi-res).
> Use CRF instead, which will adapt.
> ---
> libavcodec/libaomenc.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(
Hi,
On Tue, Aug 13, 2019 at 8:29 PM Guo, Yejun wrote:
> example command line to verify it:
> ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M
> tmp.webm
>
> Signed-off-by: Guo, Yejun
> ---
> libavcodec/libvpxenc.c | 197
> +
On Tue, Aug 20, 2019 at 5:31 PM Elliott Karpilovsky
wrote:
>
> I believe the documentation is out of date. I added some debug
> statements and verified that variable was being used to pull CRF
> values when AOM_Q mode is set. I have
> https://aomedia-review.googlesource.com/c/aom/+/94104 out to up
On Wed, Aug 21, 2019 at 12:18 PM Elliott Karpilovsky
wrote:
>
> From: elliottk
>
> Current default is 256kbps, which produces inconsistent
> results (too high for low-res, too low for hi-res).
> Use CRF instead, which will adapt.
> ---
> libavcodec/libaomenc.c | 9 +
> 1 file changed, 5
Hi,
On Thu, Aug 22, 2019 at 12:25 AM Moritz Barsnick wrote:
>
> On Wed, Aug 21, 2019 at 18:03:23 -0700, James Zern wrote:
> > > From: elliottk
> > > Current default is 256kbps, which produces inconsistent
> > > results (too high for low-res, too low for hi-r
On Wed, Aug 21, 2019 at 6:03 PM James Zern wrote:
>
> On Wed, Aug 21, 2019 at 12:18 PM Elliott Karpilovsky
> wrote:
> >
> > From: elliottk
> >
> > Current default is 256kbps, which produces inconsistent
> > results (too high for low-res, too low for h
Hi,
On Thu, Aug 22, 2019 at 5:56 PM Guo, Yejun wrote:
>
> example command line to verify it:
> ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M
> tmp.webm
>
> Signed-off-by: Guo, Yejun
> ---
> libavcodec/libvpxenc.c | 194
> +++
Hi,
On Mon, Aug 26, 2019 at 11:30 PM Guo, Yejun wrote:
>
>
>
> > -Original Message-
> > From: James Zern [mailto:jz...@google.com]
> > Sent: Tuesday, August 27, 2019 12:03 PM
> > To: FFmpeg development discussions and patches
> > Cc: Guo, Yejun
&g
On Wed, Aug 28, 2019 at 10:20 PM Guo, Yejun wrote:
>
>
>
> > -Original Message-
> > From: James Zern [mailto:jz...@google.com]
> > Sent: Thursday, August 29, 2019 12:39 PM
> > To: Guo, Yejun
> > Cc: FFmpeg development discussions and patches
&g
On Fri, Aug 31, 2018 at 9:40 AM James Almer wrote:
>
> On 8/31/2018 1:00 PM, Kagami Hiiragi wrote:
> > On 31/08/18 18:18, James Almer wrote:
> >> On 8/31/2018 11:52 AM, Kagami Hiiragi wrote:
> >>> On 31/08/18 02:58, James Almer wrote:
> On 8/20/2018 2:56 PM, Kagami Hiiragi wrote:
> > Thes
On Fri, Sep 14, 2018 at 6:39 PM James Almer wrote:
>
> On 8/27/2018 10:59 PM, James Almer wrote:
> > The levels are stored as decimal values, not hexadecimal.
> >
> > Signed-off-by: James Almer
> > ---
> > libavformat/vpcc.c | 28 ++--
> > 1 file changed, 14 insertions(+)
a thread count of 0 is treated the same as 1, use av_cpu_count() to get
the correct thread count when auto threads is requested.
this matches the fix in libvpxenc:
27df34bf1f avcodec/libvpxenc: fix setting amount of threads used for encoding
Signed-off-by: James Zern
---
libavcodec/libvpxdec.c
On Sat, Oct 27, 2018 at 1:54 PM James Almer wrote:
>
> On 10/27/2018 5:52 PM, James Zern wrote:
> > a thread count of 0 is treated the same as 1, use av_cpu_count() to get
> > the correct thread count when auto threads is requested.
> >
> > this matches the fi
On Mon, Oct 29, 2018 at 10:58 PM James Zern wrote:
>
> On Sat, Oct 27, 2018 at 1:54 PM James Almer wrote:
> >
> > On 10/27/2018 5:52 PM, James Zern wrote:
> > > a thread count of 0 is treated the same as 1, use av_cpu_count() to get
> > > the correct thread
vp9 now supports [0, 6]
Signed-off-by: James Zern
---
doc/encoders.texi | 1 +
libavcodec/libvpxenc.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/doc/encoders.texi b/doc/encoders.texi
index 899faac49b..3c6f5cd70b 100644
--- a/doc/encoders.texi
+++ b/doc
enables temporal dependency model
Signed-off-by: James Zern
---
doc/encoders.texi | 2 ++
libavcodec/libvpxenc.c | 11 +++
2 files changed, 13 insertions(+)
diff --git a/doc/encoders.texi b/doc/encoders.texi
index 899faac49b..fced8d7369 100644
--- a/doc/encoders.texi
+++ b/doc
On Sat, Nov 3, 2018 at 2:02 PM James Zern wrote:
> [...]
> #define COMMON_OPTIONS \
> { "auto-alt-ref","Enable use of alternate reference " \
> - "frames (2-pass only)",
> OFFSET(auto_alt_ref),
On Sat, Nov 3, 2018 at 2:31 PM James Almer wrote:
>
> On 11/3/2018 6:04 PM, James Zern wrote:
> > On Sat, Nov 3, 2018 at 2:02 PM James Zern wrote:
> >> [...]
> >> #define COMMON_OPTIONS \
> >> { "auto-alt
On Mon, Nov 5, 2018 at 4:45 PM James Zern wrote:
>
> On Sat, Nov 3, 2018 at 2:31 PM James Almer wrote:
> >
> > On 11/3/2018 6:04 PM, James Zern wrote:
> > > On Sat, Nov 3, 2018 at 2:02 PM James Zern wrote:
> > >> [...]
> > >> #define COMMON
On Mon, Nov 5, 2018 at 5:02 PM James Zern wrote:
>
> vp9 now supports [0, 6]
>
> Signed-off-by: James Zern
> ---
> doc/encoders.texi | 1 +
> libavcodec/libvpxenc.c | 6 --
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
This version moves the opt
vp9 now supports [0, 6]
Signed-off-by: James Zern
---
doc/encoders.texi | 1 +
libavcodec/libvpxenc.c | 6 --
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/doc/encoders.texi b/doc/encoders.texi
index 899faac49b..3c6f5cd70b 100644
--- a/doc/encoders.texi
+++ b/doc
On Sat, Nov 3, 2018 at 2:01 PM James Zern wrote:
>
> enables temporal dependency model
>
> Signed-off-by: James Zern
> ---
> doc/encoders.texi | 2 ++
> libavcodec/libvpxenc.c | 11 +++
> 2 files changed, 13 insertions(+)
>
If there aren't any co
On Mon, Nov 5, 2018 at 5:03 PM James Zern wrote:
>
> On Mon, Nov 5, 2018 at 5:02 PM James Zern wrote:
> >
> > vp9 now supports [0, 6]
> >
> > Signed-off-by: James Zern
> > ---
> > doc/encoders.texi | 1 +
> > libavcodec/libvpxenc.c | 6
On Thu, Nov 8, 2018 at 2:46 PM James Zern wrote:
>
> On Sat, Nov 3, 2018 at 2:01 PM James Zern wrote:
> >
> > enables temporal dependency model
> >
> > Signed-off-by: James Zern
> > ---
> > doc/encoders.texi | 2 ++
> > libavcodec/libvp
On Mon, Nov 12, 2018 at 10:37 AM Ard Oerlemans
wrote:
>
> Thanks for the suggestion. I have updated the patch.
>
Try to keep the original patch message so it's easier to apply.
> Ard
>
> ---
> doc/encoders.texi | 28 +++
> libavcodec/libvpxenc.c | 79 +++
On Wed, Nov 14, 2018 at 12:56 PM Ard Oerlemans
wrote:
>
> This commit adds configuration options to libvpxenc.c that can be used to
> enable VP8 temporal scalability. It also adds a way to programmatically set
> the
> per-frame encoding flags which can be used to control usage and updates of
> re
On Fri, Nov 16, 2018 at 8:59 PM James Zern wrote:
>
> On Wed, Nov 14, 2018 at 12:56 PM Ard Oerlemans
> wrote:
> >
> > This commit adds configuration options to libvpxenc.c that can be used to
> > enable VP8 temporal scalability. It also adds a way to programmatically
Hi,
On Thu, Mar 5, 2020 at 6:20 PM Wang Cao wrote:
>
> Signed-off-by: Wang Cao
> ---
> The changes are made according to the code review
> - Bump the MICRO version
> - Use enum for Super resolution mode consts. The original enum in libaom
> is not public so a enum is defined and matched the or
Hi,
On Thu, Mar 5, 2020 at 6:38 PM Wang Cao wrote:
>
> Signed-off-by: Wang Cao
> ---
> Made changes according to the review.
> - Bump the MICRO version of libavcodec.
> - Use enum for 'tune' option consts for better consistency
>
> doc/encoders.texi | 11 +++
> libavcodec/libaomenc
On Fri, Apr 3, 2020 at 2:10 PM Wang Cao wrote:
>
> Signed-off-by: Wang Cao
> ---
> doc/encoders.texi | 39 +++
> libavcodec/libaomenc.c | 47 ++
> libavcodec/version.h | 2 +-
> 3 files changed, 87 insertions(+), 1 d
On Fri, Apr 10, 2020 at 10:50 PM James Zern wrote:
>
> On Fri, Apr 3, 2020 at 2:07 PM Wang Cao wrote:
> >
> > Signed-off-by: Wang Cao
> > ---
> > doc/encoders.texi | 9 +
> > libavcodec/libaomenc.c | 7 +++
> > libavcodec/version.h
On Fri, Apr 3, 2020 at 2:07 PM Wang Cao wrote:
>
> Signed-off-by: Wang Cao
> ---
> doc/encoders.texi | 9 +
> libavcodec/libaomenc.c | 7 +++
> libavcodec/version.h | 2 +-
> 3 files changed, 17 insertions(+), 1 deletion(-)
>
lgtm. I'll apply this soon.
__
On Fri, Apr 10, 2020 at 11:18 PM James Zern wrote:
>
> On Fri, Apr 10, 2020 at 10:50 PM James Zern wrote:
> >
> > On Fri, Apr 3, 2020 at 2:07 PM Wang Cao wrote:
> > >
> > > Signed-off-by: Wang Cao
> > > ---
> > > doc/encoders.tex
Hi,
On Tue, Apr 7, 2020 at 5:14 PM Ryo Hirafuji wrote:
>
> From: Ryo Hirafuji
>
> AV1 decoders, libaomdec and libdav1d, both support grayscale image.
> However, libaomenc does not support it yet.
> In this patch, I add a grayscale image support also to libaomenc.
>
> Fixes ticket #7599
> ---
>
On Tue, Mar 17, 2020 at 7:38 PM James Zern wrote:
>
> Hi,
>
> On Thu, Mar 5, 2020 at 6:20 PM Wang Cao wrote:
> >
> > Signed-off-by: Wang Cao
> > ---
> > The changes are made according to the code review
> > - Bump the MICRO version
> > - Use enu
On Tue, Apr 14, 2020 at 3:57 AM Ryo Hirafuji wrote:
>
> Thanks for the review!
>
> This should bump the micro version number in libavcodec/version.h.
>
>
> OK, I will bump up the version when the problem below is solved.
>
If we want to go for compatibility with different versions of the
library
On Tue, Apr 7, 2020 at 5:14 PM Ryo Hirafuji wrote:
>
> From: Ryo Hirafuji
>
> AV1 support lossless encoding.
> In this patch, I added a command line flag to enable it.
>
> Fixes ticket #7600
> ---
> libavcodec/libaomenc.c | 14 +++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
On Wed, Apr 15, 2020 at 8:14 AM James Almer wrote:
>
> On 4/14/2020 9:26 PM, James Zern wrote:
> > On Tue, Apr 14, 2020 at 3:57 AM Ryo Hirafuji
> > wrote:
> >>
> >> Thanks for the review!
> >>
> >> This should bump the micro version number i
On Mon, Apr 13, 2020 at 5:58 PM James Almer wrote:
>
> Based on code from the BMP parser.
>
> Addresses ticket #8574
>
> Signed-off-by: James Almer
> ---
> libavcodec/Makefile | 1 +
> libavcodec/parsers.c | 1 +
> libavcodec/webp_parser.c | 112 +
ibaom, because I also use my software)
>
Sorry, I missed this comment. I don't have any results that would be
visible publicly.
> 2020年4月15日(水) 10:00 James Zern :
>
> > On Tue, Apr 7, 2020 at 5:14 PM Ryo Hirafuji
> > wrote:
> > >
> > > From: Ryo Hirafuji
&
Hi,
On Mon, Feb 15, 2021 at 10:37 PM Wonkap Jang
wrote:
>
> While parsing ref_frame_config, AVdictionary needs to be manually
> deallocated.
> ---
> libavcodec/libvpxenc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c
> index 284cb9a1
On Tue, Feb 16, 2021 at 4:17 PM Wonkap Jang
wrote:
>
> On Tue, Feb 16, 2021 at 1:02 PM James Zern
> wrote:
> [...]
> >
> > >
> > > while ((en2 =
> > av_dict_get(ctx->vpx_ref_frame_config, "", en2, AV_DICT_IGNORE_SUFFIX
On Tue, Feb 16, 2021 at 2:29 PM Wonkap Jang
wrote:
>
> While parsing ref_frame_config, AVdictionary needs to be manually
> deallocated.
> ---
> libavcodec/libvpxenc.c | 20 +---
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/libavcodec/libvpxenc.c b/libavcodec
On Thu, Feb 18, 2021 at 11:01 AM Wonkap Jang
wrote:
>
> Getting rid of unnecessary use of AVDictionary object in parsing
> vpx_svc_ref_frame_config.
> ---
> libavcodec/libvpxenc.c | 73 +++---
> 1 file changed, 55 insertions(+), 18 deletions(-)
>
lgtm, just a
On Thu, Feb 18, 2021 at 1:17 PM James Zern wrote:
>
> On Thu, Feb 18, 2021 at 11:01 AM Wonkap Jang
> wrote:
> >
> > Getting rid of unnecessary use of AVDictionary object in parsing
> > vpx_svc_ref_frame_config.
> > ---
On Tue, May 26, 2020 at 6:40 PM James Almer wrote:
>
> Signed-off-by: James Almer
> ---
> Alternatively, we could remove support for libaom 1.0.0, since it's pretty
> much
> unusable. But unfortunately both current Debian Stable and latest Ubuntu LTS
> ship it, so i'm not sure if it would be wis
On Mon, Jun 8, 2020 at 2:56 AM Moritz Barsnick wrote:
>
> On Sun, May 10, 2020 at 00:59:25 +0900, Ryo Hirafuji wrote:
> > I can create and send a new patch without these workaround lines, but of
> > course, it will crash if the ffmpeg will be built with older versions of
> > libaom.
>
> Actually,
On Thu, Jun 25, 2020 at 6:02 PM Wang Cao wrote:
>
> This patch adds the control for enabling rectangular partitions, 1:4/4:1
> partitions and AB shape partitions.
>
> Signed-off-by: Wang Cao
> ---
> doc/encoders.texi | 10 ++
> libavcodec/libaomenc.c | 15 +++
> libavcod
On Thu, Jun 25, 2020 at 5:55 PM Wang Cao wrote:
>
> Signed-off-by: Wang Cao
> ---
> doc/encoders.texi | 21 +++
> libavcodec/libaomenc.c | 47 --
> libavcodec/version.h | 2 +-
> 3 files changed, 63 insertions(+), 7 deletions(-)
>
On Mon, Jun 29, 2020 at 11:05 AM James Zern wrote:
>
> On Thu, Jun 25, 2020 at 5:55 PM Wang Cao wrote:
> >
> > From: Wang Cao
> >
> > Signed-off-by: Wang Cao
> > ---
> > doc/encoders.texi | 39 ++
On Thu, Jun 25, 2020 at 5:56 PM Wang Cao wrote:
>
> Signed-off-by: Wang Cao
> ---
> doc/encoders.texi | 21 +
> libavcodec/libaomenc.c | 31 +++
> libavcodec/version.h | 2 +-
> 3 files changed, 53 insertions(+), 1 deletion(-)
>
> [...]
> +
On Thu, Jun 25, 2020 at 5:56 PM Wang Cao wrote:
>
> Signed-off-by: Wang Cao
> ---
> doc/encoders.texi | 36 +
> libavcodec/libaomenc.c | 61 ++
> libavcodec/version.h | 2 +-
> 3 files changed, 98 insertions(+), 1 deletion(-
On Thu, Jun 25, 2020 at 5:55 PM Wang Cao wrote:
>
> From: Wang Cao
>
> Signed-off-by: Wang Cao
> ---
> doc/encoders.texi | 39 +++
> libavcodec/libaomenc.c | 38 ++
> libavcodec/version.h | 2 +-
> 3 files changed,
Hi,
On Wed, Aug 28, 2019 at 2:26 PM Elliott Karpilovsky
wrote:
>
> Current default is 200kbps, which produces inconsistent
> results (too high for low-res, too low for hi-res). Use
> CRF instead, which will adapt. Affects vp8/vp9. Also
> have VP8 use a default bitrate of 256kbps.
> ---
> libavco
Hi,
On Tue, Sep 10, 2019 at 6:13 PM Guo, Yejun wrote:
>
> example command line to verify it:
> ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M
> tmp.webm
>
> Signed-off-by: Guo, Yejun
> ---
> libavcodec/libvpxenc.c | 188
> +++
On Sun, Sep 15, 2019 at 2:03 PM Elliott Karpilovsky
wrote:
>
> ---
> libavcodec/libaomenc.c | 14 +-
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
lgtm. This is leftover from libvpxenc, only vp8 can hit the path there.
> diff --git a/libavcodec/libaomenc.c b/libavcodec/libaome
On Wed, Sep 18, 2019 at 11:42 AM James Zern wrote:
>
> On Sun, Sep 15, 2019 at 2:03 PM Elliott Karpilovsky
> wrote:
> >
> > ---
> > libavcodec/libaomenc.c | 14 +-
> > 1 file changed, 5 insertions(+), 9 deletions(-)
> >
>
> lgtm. This is
On Wed, Sep 18, 2019 at 7:54 AM Guo, Yejun wrote:
>
>
>
> > -Original Message-
> > From: Guo, Yejun
> > Sent: Thursday, September 12, 2019 6:25 PM
> > To: ffmpeg-devel@ffmpeg.org
> > Cc: Guo, Yejun
> > Subject: [PATCH V9] avcodec/libvpxenc: add ROI-based encoding support for
> > VP8/VP9
>
On Wed, Sep 18, 2019 at 12:03 PM James Zern wrote:
>
> On Wed, Sep 18, 2019 at 7:54 AM Guo, Yejun wrote:
> >
> >
> >
> > > -Original Message-
> > > From: Guo, Yejun
> > > Sent: Thursday, September 12, 2019 6:25 PM
> > > To:
On Wed, Sep 18, 2019 at 11:42 AM James Zern wrote:
>
> On Sun, Sep 15, 2019 at 2:03 PM Elliott Karpilovsky
> wrote:
> >
> > ---
> > libavcodec/libaomenc.c | 14 +-
> > 1 file changed, 5 insertions(+), 9 deletions(-)
> >
>
> lgtm. This is
this conflicts with the current contributing guidance:
http://ffmpeg.org/developer.html#Contributing
FFmpeg is programmed in the ISO C90 language with a few additional
features from ISO C99, namely:
...
for loops with variable definition (‘for (int i = 0; i < 8; i++)’);
Signed-off-by: James Z
On Fri, Sep 20, 2019 at 12:38 AM Paul B Mahol wrote:
>
> LGTM
>
> On 9/20/19, James Zern wrote:
> > this conflicts with the current contributing guidance:
> > http://ffmpeg.org/developer.html#Contributing
> > FFmpeg is programmed in the ISO C90 language with a fe
On Tue, Sep 24, 2019 at 4:31 PM Elliott Karpilovsky
wrote:
>
> Current default is 200kbps, which produces inconsistent
> results (too high for low-res, too low for hi-res). Use
> CRF instead, which will adapt. Affects VP9. Also have
> VP8 use a default bitrate of 256kbps.
> ---
> libavcodec/libvp
On Sat, Oct 5, 2019 at 1:23 PM James Zern wrote:
>
> On Tue, Sep 24, 2019 at 4:31 PM Elliott Karpilovsky
> wrote:
> >
> > Current default is 200kbps, which produces inconsistent
> > results (too high for low-res, too low for hi-res). Use
> > CRF instead, which w
On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote:
>
> Signed-off-by: Marton Balint
> ---
> libavcodec/libvpxenc.c | 44 +++-
> 1 file changed, 23 insertions(+), 21 deletions(-)
>
The encoder can handle frame size changes. This seems to assume the
size
On Sun, Oct 27, 2019 at 10:10 AM Marton Balint wrote:
>
> Signed-off-by: Marton Balint
> ---
> libavcodec/libvpxenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
lgtm.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.
On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote:
>
> If the alpha decoder init failed we presented the error message from the
> normal
> decoder. This change should prevent such mistakes.
>
> Signed-off-by: Marton Balint
> ---
> libavcodec/libvpxdec.c | 26 +-
> 1 f
On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote:
>
> Signed-off-by: Marton Balint
> ---
> libavcodec/libvpxdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
lgtm. good catch.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
htt
On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote:
>
> This avoids copying the full frame after decoding.
>
> Signed-off-by: Marton Balint
> ---
> libavcodec/libvpxdec.c | 73
> ++
> 1 file changed, 68 insertions(+), 5 deletions(-)
>
lgtm.
>
On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote:
>
> Signed-off-by: Marton Balint
> ---
> libavcodec/libvpxdec.c | 11 +++
> 1 file changed, 11 insertions(+)
>
lgtm.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org
On Sat, Nov 2, 2019 at 9:20 AM Marton Balint wrote:
>
> Signed-off-by: Marton Balint
> ---
> libavcodec/libvpxenc.c | 60
> ++
> 1 file changed, 36 insertions(+), 24 deletions(-)
>
lgtm. I'll apply this set of patches soon if there aren't any fur
On Mon, Nov 4, 2019 at 4:55 PM James Zern wrote:
>
> On Sat, Nov 2, 2019 at 9:20 AM Marton Balint wrote:
> >
> > Signed-off-by: Marton Balint
> > ---
> > libavcodec/libvpxenc.c | 60
> > ++
> > 1 fi
On Fri, Nov 1, 2019 at 1:01 PM James Zern wrote:
>
> On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote:
> >
> > This avoids copying the full frame after decoding.
> >
> > Signed-off-by: Marton Balint
> >
On Fri, Nov 1, 2019 at 11:55 AM James Zern wrote:
>
> On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote:
> >
> > If the alpha decoder init failed we presented the error message from the
> > normal
> > decoder. This change should prevent such mistakes.
> &
On Fri, Nov 1, 2019 at 1:01 PM James Zern wrote:
>
> On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote:
> >
> > Signed-off-by: Marton Balint
> > ---
> > libavcodec/libvpxdec.c | 11 +++
> > 1 file changed, 11 insertio
On Fri, Nov 1, 2019 at 11:47 AM James Zern wrote:
>
> On Sun, Oct 27, 2019 at 10:10 AM Marton Balint wrote:
> >
> > Signed-off-by: Marton Balint
> > ---
> > libavcodec/libvpxenc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deleti
On Fri, Nov 1, 2019 at 11:52 AM James Zern wrote:
>
> On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote:
> >
> > Signed-off-by: Marton Balint
> > ---
> > libavcodec/libvpxdec.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> &
On Wed, Nov 6, 2019 at 2:21 AM Carl Eugen Hoyos wrote:
>
> Am Mi., 6. Nov. 2019 um 08:28 Uhr schrieb Marton Balint :
> > [...]
> > +if (ctx->has_alpha_channel &&
> > +(img->d_w != img_alpha->d_w ||
> > + img->d_h != img_alpha->d_h ||
> > + img->bit_depth
Signed-off-by: James Zern
---
libavcodec/libvpxdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c
index 1ae2361167..1063c546b0 100644
--- a/libavcodec/libvpxdec.c
+++ b/libavcodec/libvpxdec.c
@@ -288,7 +288,7 @@ static int
Hi,
On Mon, Dec 16, 2019 at 2:21 PM Wonkap Jang
wrote:
>
> Documentation change for adding support for encoding
> with temporal scalability in VP9.
> ---
This part sounds related to the other patches you're sending. The
documentation can be added with the code change for vp9.
> doc/encoders.te
the code already has
> two commits... so overall 4 commits in succession.
>
The doc fix should land quickly, so the other could be rebased after that.
> Would this work?
>
> Thank you,
>
> Wonkap
>
>
> On Tue, Dec 17, 2019 at 5:59 PM James Zern
> wrote:
>
&g
Hi,
On Wed, Dec 18, 2019 at 1:17 PM Wonkap Jang
wrote:
>
> ts_target_bitrate is in kbps, not bps. This commit clarifies the unit
> and modifies the example to match the description.
> ---
> doc/encoders.texi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
lgtm if you can verify t
[1] http://ffmpeg.org/contact.html#MailingLists
> Thank you,
>
> Wonkap
>
> On Wed, Dec 18, 2019 at 1:39 PM James Zern
> wrote:
>
> > Hi,
> >
> > On Wed, Dec 18, 2019 at 1:17 PM Wonkap Jang
> > wrote:
> > >
> > > ts_target_bitrate is in kbp
On Wed, Dec 18, 2019 at 7:25 PM Wang Cao wrote:
>
> Signed-off-by: Wang Cao
> ---
> libavcodec/libaomenc.c | 6 ++
Can you update doc/encoders.texi with this detail please?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/ma
On Wed, Dec 18, 2019 at 4:17 PM Wonkap Jang
wrote:
>
> ts_target_bitrate is in kbps, not bps. This commit clarifies the unit
> and modifies the example to match the description.
> ---
> doc/encoders.texi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
applied, thanks.
Hi,
On Tue, Dec 31, 2019 at 9:21 PM Jun Zhao wrote:
>
> From: Jun Zhao
>
> In case of failure, all the successfully set entries are stored in
> *pm. We need to manually free the created dictionary to avoid
> memory leak.
>
> Signed-off-by: Jun Zhao
> ---
> libavcodec/libvpxenc.c |3 +--
>
Signed-off-by: James Zern
---
libavcodec/libvpxenc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c
index 3f659b4b67..0b8a070304 100644
--- a/libavcodec/libvpxenc.c
+++ b/libavcodec/libvpxenc.c
@@ -1041,8 +1041,7 @@ static
1 - 100 of 424 matches
Mail list logo
