Re: [FFmpeg-devel] [PATCH v4 1/2] avcodec/libjxc: add JPEG XL decoding via libjxl

2021-11-02 Thread James Almer
On 11/2/2021 8:51 AM, Leo Izen wrote: diff --git a/libavcodec/codec_id.h b/libavcodec/codec_id.h index ab265ec584..853bbd4240 100644 --- a/libavcodec/codec_id.h +++ b/libavcodec/codec_id.h @@ -59,6 +59,7 @@ enum AVCodecID { AV_CODEC_ID_LJPEG, AV_CODEC_ID_SP5X, AV_CODEC_ID_JPEGLS

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: fix sei payload leaks on error

2021-11-03 Thread James Almer
On 11/1/2021 7:03 PM, James Almer wrote: Signed-off-by: James Almer --- libavcodec/libx264.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 21f434d06d..0766b4a950 100644 --- a/libavcodec/libx264.c

Re: [FFmpeg-devel] [PATCH 1/3] avformat/dashenc: enabling streaming automatically for ldash

2021-11-04 Thread James Almer
On 11/4/2021 5:03 AM, "zhilizhao(赵志立)" wrote: Ping for the patch set. On Oct 21, 2021, at 4:15 PM, Zhao Zhili wrote: There is a little chance that user specified contradicted options like -streaming 0 -ldash 1, however, it's more likely that user didn't know or forgot to enable streaming for

Re: [FFmpeg-devel] [PATCH] avfilter/vf_nlmeans: add x86 SIMD

2021-11-06 Thread James Almer
On 11/6/2021 11:41 AM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavfilter/vf_nlmeans.c | 9 ++- libavfilter/vf_nlmeans.h | 1 + libavfilter/x86/Makefile | 2 + libavfilter/x86/vf_nlmeans.asm| 97 +++ libavfilter/x86

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: Use av_memdup() where appropriate

2021-11-07 Thread James Almer
On 11/7/2021 8:33 AM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- Will apply tonight unless there are objections. libavcodec/libx264.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 0766b4a950..29546

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Don't unnecessarily reduce aspect ratio

2021-11-07 Thread James Almer
On 11/7/2021 7:42 AM, Andreas Rheinhardt wrote: Fixes ticket #9497. Signed-off-by: Andreas Rheinhardt --- Will apply later tonight unless there are objections. libavformat/matroskadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavform

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/libx264: Simplify copying packet data

2021-11-07 Thread James Almer
On 11/7/2021 11:36 AM, Andreas Rheinhardt wrote: x264.h: "the payloads of all output NALs are guaranteed to be sequential in memory." Therefore we can omit the loop. Signed-off-by: Andreas Rheinhardt --- libavcodec/libx264.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) dif

Re: [FFmpeg-devel] [PATCH] avfilter/vf_nlmeans: add x86 SIMD

2021-11-09 Thread James Almer
On 11/9/2021 2:58 PM, Paul B Mahol wrote: will apply soon A checkasm test to go with this would be ideal. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or emai

Re: [FFmpeg-devel] [PATCH 01/17] avformat/mxfenc: Auto-insert h264_mp4toannexb BSF if needed

2021-11-09 Thread James Almer
On 11/9/2021 2:34 PM, Andreas Rheinhardt wrote: The mxf and mxf_opatom muxer expect H.264 in Annex B format. Amazing that nobody noticed this until now. Guess remuxing from mp4/mkv to mxf is not a common scenario. LGTM, just tested a quick remux and without the bsf it just fails. Signed-o

Re: [FFmpeg-devel] [PATCH] */version.h: define FF_API macros unconditionally

2021-11-12 Thread James Almer
On 11/12/2021 10:34 AM, Anton Khirnov wrote: There is no reason to wrap them in #ifndef guards, they should only be defined here and nowhere else. The define guards just add the possibility to accidentally use the same FF_API name in different libraries. Should be ok. We can also later look in

[FFmpeg-devel] [PATCH 1/2] avdevice/dshow: fix print format for some variables

2021-11-12 Thread James Almer
WAVEFORMATEX.nChannels and WAVEFORMATEX.wBitsPerSample are of type WORD, aka unsigned short. Signed-off-by: James Almer --- libavdevice/dshow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index e313c9a2bf..fd62d79443 100644 --- a

[FFmpeg-devel] [PATCH 2/2] avdevice/dshow: remove unused acaps variable

2021-11-12 Thread James Almer
Unused since commit d9a9b4c877b85fea5a5bad74c3d592a756047f79. Signed-off-by: James Almer --- libavdevice/dshow.c | 4 1 file changed, 4 deletions(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index fd62d79443..0f954dde6f 100644 --- a/libavdevice/dshow.c +++ b/libavdevice

Re: [FFmpeg-devel] [PATCH 2/6] lavf: add an AVClass to AVStream on next major bump

2021-11-12 Thread James Almer
On 11/12/2021 1:32 PM, Anton Khirnov wrote: Also add a function to retrieve that class, analogously to avformat_get_class(). This will be useful for adding an AVOption for dispositions. While it's true that quite a few months have passed since the bump, we haven't made a release just yet that

Re: [FFmpeg-devel] [PATCH 2/6] lavf: add an AVClass to AVStream on next major bump

2021-11-12 Thread James Almer
On 11/12/2021 1:47 PM, Anton Khirnov wrote: Quoting James Almer (2021-11-12 17:36:58) On 11/12/2021 1:32 PM, Anton Khirnov wrote: Also add a function to retrieve that class, analogously to avformat_get_class(). This will be useful for adding an AVOption for dispositions. While it's

Re: [FFmpeg-devel] [PATCH] avfilter: add colorvd video filter

2021-11-13 Thread James Almer
On 11/13/2021 9:14 AM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_colorvd.c | 259 +++ 3 files changed, 261 insertions(+) create mode 100644 libavfilter/vf_color

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/dshow: fix print format for some variables

2021-11-13 Thread James Almer
On 11/12/2021 1:06 PM, James Almer wrote: WAVEFORMATEX.nChannels and WAVEFORMATEX.wBitsPerSample are of type WORD, aka unsigned short. Signed-off-by: James Almer --- libavdevice/dshow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/dshow.c b/libavdevice

Re: [FFmpeg-devel] [PATCH v2 2/2] swscale/input: clamp rgbf32 values before lrintf

2021-11-13 Thread James Almer
On 11/13/2021 11:56 PM, mindm...@gmail.com wrote: From: Mark Reid if the float pixel * 65535.0f > 2147483647.0f lrintf may overfow and return negative values, depending on implementation. nan and +/-inf values may also be implementation defined clamp the value first so lrintf so, always works.

Re: [FFmpeg-devel] [PATCH 02/15] swscale: add P216/P410/P416 input

2021-11-14 Thread James Almer
On 11/13/2021 6:09 PM, rcombs wrote: --- libswscale/input.c | 14 ++ libswscale/utils.c | 6 ++ 2 files changed, 20 insertions(+) diff --git a/libswscale/input.c b/libswscale/input.c index 336f957c8c..5c8a28c665 100644 --- a/libswscale/input.c +++ b/libswscale/input.c @@ -12

Re: [FFmpeg-devel] [PATCH] ffmpeg: remove ffmpeg_videotoolbox

2021-11-14 Thread James Almer
On 11/13/2021 6:41 PM, rcombs wrote: This was almost completely redundant. The only functionality that's no longer available after this removal is the videotoolbox_pixfmt arg, which has been obsolete for several years. --- fftools/Makefile | 4 - fftools/ffmpeg.c |

[FFmpeg-devel] [PATCH 1/3] ffmpeg: allocate the output hwaccel AVFrame only once

2021-11-14 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg.c| 3 +++ fftools/ffmpeg.h| 1 + fftools/ffmpeg_hw.c | 17 ++--- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index d141f34df9..26030ed25e 100644 --- a/fftools/ffmpeg.c

[FFmpeg-devel] [PATCH 2/3] ffmpeg: remove unused hwaccel_get_buffer function pointer

2021-11-14 Thread James Almer
As well as the custom get_buffer2() implementation which would become a redundant wrapper for avcodec_default_get_buffer2() after this Signed-off-by: James Almer --- fftools/ffmpeg.c | 11 --- fftools/ffmpeg.h | 1 - 2 files changed, 12 deletions(-) diff --git a/fftools/ffmpeg.c b

[FFmpeg-devel] [PATCH 3/3] ffmpeg: remove unused hw_frames_ctx AVBufferRef from InputStream

2021-11-14 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg.c | 6 -- fftools/ffmpeg.h | 1 - 2 files changed, 7 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index bde5a2f603..05e2a75f1f 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -2925,12 +2925,6 @@ static enum AVPixelFormat

[FFmpeg-devel] [PATCH 2/2] ffmpeg: Allocate InputStream.decoded_frame early

2021-11-15 Thread James Almer
Based on a commit by Andreas Rheinhardt. Signed-off-by: James Almer --- fftools/ffmpeg.c | 11 ++- fftools/ffmpeg_opt.c | 4 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index f6ab33a614..05d197b8af 100644 --- a/fftools

[FFmpeg-devel] [PATCH 1/2] ffmpeg: Allocate (In|Out)putStream.filter_frame early

2021-11-15 Thread James Almer
Based on a commit by Andreas Rheinhardt. Signed-off-by: James Almer --- fftools/ffmpeg.c | 7 --- fftools/ffmpeg_opt.c | 8 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index d141f34df9..f6ab33a614 100644 --- a/fftools

Re: [FFmpeg-devel] [PATCH v3 2/2] swscale/input: clip rgbf32 values before lrintf

2021-11-15 Thread James Almer
On 11/15/2021 12:29 PM, Michael Niedermayer wrote: On Sun, Nov 14, 2021 at 10:22:21PM -0800, mindm...@gmail.com wrote: From: Mark Reid if the float pixel * 65535.0f > 2147483647.0f lrintf may overfow and return negative values, depending on implementation. nan and +/-inf values may also be imp

Re: [FFmpeg-devel] [PATCH] avformat/http: Add short_seek_size option

2021-11-15 Thread James Almer
On 11/15/2021 12:52 PM, Derek Buitenhuis wrote: In 45bfe8b838275235412777dd430206d9a24eb3ee, short_seek_threshold was removed from the public AVIO struct. Although this option was private and not intended to be used by public API users, it was nonetheless, because it provided functionality that

Re: [FFmpeg-devel] [PATCH] avformat/http: Add short_seek_size option

2021-11-15 Thread James Almer
On 11/15/2021 6:13 PM, Derek Buitenhuis wrote: On 11/15/2021 7:53 PM, James Almer wrote: Don't forget to bump micro before you push. Yep. +{ "short_seek_size", "Threshold to favor readahead over seek.", OFFSET(short_seek_size), AV_OPT_TYPE_INT, { .i64 = -1 }

[FFmpeg-devel] [PATCH] x86/intmath: add VEX encoded versions of av_clipf() and av_clipd()

2021-11-15 Thread James Almer
Prevents mixing inlined SSE instructions and AVX instructions when the compiler generates the latter. Signed-off-by: James Almer --- libavutil/x86/intmath.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/libavutil/x86/intmath.h b/libavutil/x86/intmath.h

Re: [FFmpeg-devel] [PATCH v2] avformat/http: Add short_seek_size option

2021-11-16 Thread James Almer
On 11/16/2021 11:52 AM, Derek Buitenhuis wrote: In 45bfe8b838275235412777dd430206d9a24eb3ee, short_seek_threshold was removed from the public AVIO struct. Although this option was private and not intended to be used by public API users, it was nonetheless, because it provided functionality that

Re: [FFmpeg-devel] [PATCH 1/3] ffmpeg: allocate the output hwaccel AVFrame only once

2021-11-18 Thread James Almer
On 11/18/2021 5:35 AM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- fftools/ffmpeg.c| 3 +++ fftools/ffmpeg.h| 1 + fftools/ffmpeg_hw.c | 17 ++--- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools

Re: [FFmpeg-devel] [PATCH 1/4] fftools/cmdutils: Fix undefined 1 << 31

2021-11-18 Thread James Almer
On 11/18/2021 6:07 AM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- fftools/cmdutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 594eeef379..f80c361eba 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdu

Re: [FFmpeg-devel] [PATCH 1/3] ffmpeg: allocate the output hwaccel AVFrame only once

2021-11-18 Thread James Almer
On 11/18/2021 8:05 PM, Andreas Rheinhardt wrote: James Almer: On 11/18/2021 5:35 AM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer ---   fftools/ffmpeg.c    |  3 +++   fftools/ffmpeg.h    |  1 +   fftools/ffmpeg_hw.c | 17 ++---   3 files changed, 10

Re: [FFmpeg-devel] [PATCH] avfilter: add colorvd video filter

2021-11-19 Thread James Almer
wrote: Quoting James Almer (2021-11-13 13:22:12) Also, missing docs. Could we add a development rule that all new filters need docs and all new filters/codecs/(de)muxers need a test (unless special circumstances, like hwaccel)? Iam in favor of this Against this, as experimental filter

Re: [FFmpeg-devel] [PATCH] avfilter: add colorvd video filter

2021-11-19 Thread James Almer
< mich...@niedermayer.cc> wrote: On Fri, Nov 19, 2021 at 02:18:27PM +0100, Anton Khirnov wrote: Quoting James Almer (2021-11-13 13:22:12) Also, missing docs. Could we add a development rule that all new filters need docs and all new filters/codecs/(de)muxers need a test (unless s

Re: [FFmpeg-devel] [PATCH] avfilter: add colorvd video filter

2021-11-19 Thread James Almer
On 11/19/2021 11:38 AM, Paul B Mahol wrote: On Fri, Nov 19, 2021 at 3:29 PM James Almer wrote: On 11/19/2021 11:07 AM, Paul B Mahol wrote: On Fri, Nov 19, 2021 at 3:04 PM Anton Khirnov wrote: Quoting Paul B Mahol (2021-11-19 14:55:42) On Fri, Nov 19, 2021 at 2:27 PM Michael Niedermayer

[FFmpeg-devel] [PATCH 1/2] ffmpeg: unref ist->filter_frame in the only place it's used

2021-11-19 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index e88ca554ae..a67f489cda 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -2326,6 +2326,7 @@ static int send_frame_to_filters

[FFmpeg-devel] [PATCH 2/2] ffmpeg_hw: reuse filter_frame in hwaccel_retrieve_data()

2021-11-19 Thread James Almer
This avoids an AVFrame allocation per decoded frame. Signed-off-by: James Almer --- ist->filter_frame is safe to use here since send_frame_to_filters() also unrefs it immediately after using it. But if this is deemed ugly/evil, I'll just add a new AVFrame to InputStream. fftools/ffm

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg: remove unused hwaccel_get_buffer function pointer

2021-11-19 Thread James Almer
On 11/14/2021 3:59 PM, James Almer wrote: As well as the custom get_buffer2() implementation which would become a redundant wrapper for avcodec_default_get_buffer2() after this Signed-off-by: James Almer --- fftools/ffmpeg.c | 11 --- fftools/ffmpeg.h | 1 - 2 files changed, 12

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Avoid temporary frame

2021-11-19 Thread James Almer
On 11/19/2021 1:43 PM, Andreas Rheinhardt wrote: send_frame_to_filters() sends a frame to all the filters that need said frame; for every filter except the last one this involves creating a reference to the frame, because av_buffersrc_add_frame_flags() by default takes ownership of the supplied r

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Avoid temporary frame

2021-11-19 Thread James Almer
On 11/19/2021 2:02 PM, Andreas Rheinhardt wrote: James Almer: On 11/19/2021 1:43 PM, Andreas Rheinhardt wrote: send_frame_to_filters() sends a frame to all the filters that need said frame; for every filter except the last one this involves creating a reference to the frame, because

Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: Avoid temporary frame

2021-11-19 Thread James Almer
On 11/19/2021 7:59 PM, Andreas Rheinhardt wrote: send_frame_to_filters() sends a frame to all the filters that need said frame; for every filter except the last one this involves creating a reference to the frame, because av_buffersrc_add_frame_flags() by default takes ownership of the supplied r

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter/x86/vf_exposure: add x86 SIMD optimization

2021-11-20 Thread James Almer
On 11/4/2021 1:18 AM, Wu Jianhua wrote: Performance data(Less is better): exposure_c:857394 exposure_sse: 327589 Signed-off-by: Wu Jianhua --- libavfilter/exposure.h | 36 +++ libavfilter/vf_exposure.c | 36 +-- libavfilter/x86/Makef

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter/x86/vf_exposure: add x86 SIMD optimization

2021-11-20 Thread James Almer
On 11/20/2021 1:46 PM, James Almer wrote: On 11/4/2021 1:18 AM, Wu Jianhua wrote: diff --git a/libavfilter/x86/vf_exposure.asm b/libavfilter/x86/vf_exposure.asm new file mode 100644 index 00..3351c6fb3b --- /dev/null +++ b/libavfilter/x86/vf_exposure.asm @@ -0,0 +1,55

Re: [FFmpeg-devel] [PATCH v2 2/3] avfilter/x86/vf_exposure: add ff_exposure_avx2

2021-11-20 Thread James Almer
On 11/4/2021 1:18 AM, Wu Jianhua wrote: Performance data(Less is better): exposure_sse: 500491 You reported a better result in the first patch. exposure_avx2: 449122 This looks like a really low speed up for a function that processes twice the amount of floats per loop. Si

Re: [FFmpeg-devel] [PATCH v2 3/3] tests/checkasm: add check for vf_exposure

2021-11-20 Thread James Almer
On 11/4/2021 1:18 AM, Wu Jianhua wrote: Signed-off-by: Wu Jianhua --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c| 3 ++ tests/checkasm/checkasm.h| 1 + tests/checkasm/vf_exposure.c | 62 tests/fate/checkasm.mak | 1 +

Re: [FFmpeg-devel] [PATCH v2 2/3] avfilter/x86/vf_exposure: add ff_exposure_avx2

2021-11-20 Thread James Almer
On 11/20/2021 5:42 PM, Wu Jianhua wrote: James Almer<mailto:jamr...@gmail.com>: On 11/4/2021 1:18 AM, Wu Jianhua wrote: Performance data(Less is better): exposure_sse: 500491 You reported a better result in the first patch. For they are tested on different baseline, I th

Re: [FFmpeg-devel] [PATCH 08/16] lavc/h264dec: support all color formats in videotoolbox hwaccel

2021-11-22 Thread James Almer
On 11/22/2021 5:53 PM, rcombs wrote: --- libavcodec/h264_slice.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index 89ea16a57f..476a14d485 100644 --- a/libavcodec/h264_slice.c +++ b/libavcodec/h264_slice.c @@ -798,

Re: [FFmpeg-devel] [PATCH 09/16] lavc/hevcdec: support all color formats in videotoolbox hwaccel

2021-11-22 Thread James Almer
On 11/22/2021 5:53 PM, rcombs wrote: --- libavcodec/hevcdec.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 3e19f4ebed..47c551237f 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -401,6 +401,10 @

Re: [FFmpeg-devel] [PATCH 09/16] lavc/hevcdec: support all color formats in videotoolbox hwaccel

2021-11-22 Thread James Almer
On 11/22/2021 6:58 PM, rcombs wrote: --- libavcodec/hevcdec.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 3e19f4ebed..f99cd7094e 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -420,7 +42

Re: [FFmpeg-devel] [PATCH 01/16] ffmpeg: remove ffmpeg_videotoolbox

2021-11-24 Thread James Almer
On Mon, Nov 22, 2021 at 6:58 PM rcombs wrote: > This was almost completely redundant. The only functionality that's no > longer > available after this removal is the videotoolbox_pixfmt arg, which has been > obsolete for several years. > --- > fftools/Makefile | 4 - > fftools/ffm

Re: [FFmpeg-devel] [PATCH v15 00/16] *** SUBJECT HERE ***

2021-11-25 Thread James Almer
Have all the concerns people had been addressed? I'm also certain the design itself wasn't well received. This is big and needs more than 24 hours or just one person LGTMing it, so please wait. Also, patch 15/16 breaks FATE. Even if 16/16 fixes the tests, it will make bisecting annoying, so it nee

[FFmpeg-devel] [PATCH] ffmpeg: fix usage of -shortest in codec copy scenarios

2021-11-27 Thread James Almer
Don't mark all streams as finished, instead make sync_opts keep track of the stream's duration, and set recording_time to it, same as in transcoding paths. Fixes tickets #9512 and #9513. Signed-off-by: James Almer --- fftools/ffmpeg.c | 11 --- 1 file changed, 4 insert

Re: [FFmpeg-devel] [PATCH] fate/ffmpeg: Fix requirements of shortest tests

2021-12-02 Thread James Almer
On Thu, Dec 2, 2021 at 11:39 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Fixes FATE failures if e.g. libavdevice is disabled. > > Signed-off-by: Andreas Rheinhardt > --- > tests/fate/ffmpeg.mak | 20 +--- > 1 file changed, 17 insertions(+), 3 deletions(-) > >

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: make 2 public functions always available

2021-12-02 Thread James Almer
On Thu, Dec 2, 2021 at 3:01 PM Lynne wrote: > The issue is that if ffmpeg is compiled without Vulkan, and an API > user includes and uses the functions exposed in hwcontext_vulkan.h, > then a linking error will happen, as the hwcontext_vulkan.c file has > not been compiled. > > Move the functions

Re: [FFmpeg-devel] [PATCH v1] avcodec/av1_parser: ensure only one show frame packed data parsered

2021-12-03 Thread James Almer
On Fri, Dec 3, 2021 at 5:12 AM Fei Wang wrote: > Split packed data when it contains multiple show frames in some > non-standard bitstream. This can benefit downstream decoder which can > decode continuously instead of interrupt with unexpected error. > > Signed-off-by: Fei Wang > --- > libavcod

[FFmpeg-devel] [PATCH 0/7] Container level frame cropping parameters

2023-10-07 Thread James Almer
on to the set i sent a month ago. James Almer (7): avcodec/packet: add a decoded frame cropping side data type avformat/dump: print Frame Cropping side data info avformat/matroskadec: export cropping values avformat/avformat: add a flag to signal muxers that support storing cropping va

[FFmpeg-devel] [PATCH 1/7] avcodec/packet: add a decoded frame cropping side data type

2023-10-07 Thread James Almer
Signed-off-by: James Almer --- libavcodec/packet.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/packet.h b/libavcodec/packet.h index b19409b719..6053d43c44 100644 --- a/libavcodec/packet.h +++ b/libavcodec/packet.h @@ -299,6 +299,20 @@ enum AVPacketSideDataType

[FFmpeg-devel] [PATCH 2/7] avformat/dump: print Frame Cropping side data info

2023-10-07 Thread James Almer
Signed-off-by: James Almer --- libavformat/dump.c | 21 + 1 file changed, 21 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index c0868a1bb3..8986e7c32a 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -427,6 +427,23 @@ static void

[FFmpeg-devel] [PATCH 3/7] avformat/matroskadec: export cropping values

2023-10-07 Thread James Almer
Signed-off-by: James Almer --- libavformat/matroskadec.c | 53 +++ 1 file changed, 43 insertions(+), 10 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index c8acf91970..0e98e97957 100644 --- a/libavformat/matroskadec.c +++ b

[FFmpeg-devel] [PATCH 4/7] avformat/avformat: add a flag to signal muxers that support storing cropping values

2023-10-07 Thread James Almer
Signed-off-by: James Almer --- libavformat/avformat.h | 1 + libavformat/mux.c | 8 2 files changed, 9 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 9e7eca007e..c099ca8a01 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -500,6

[FFmpeg-devel] [PATCH 5/7] avformat/matroskaenc: support writing cropping values

2023-10-07 Thread James Almer
Signed-off-by: James Almer --- libavformat/matroskaenc.c | 59 ++- 1 file changed, 46 insertions(+), 13 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 1457a6890c..9005237a83 100644 --- a/libavformat/matroskaenc.c +++ b

[FFmpeg-devel] [PATCH 6/7] fftools/ffmpeg: support applying container level cropping

2023-10-07 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg.h| 3 +++ fftools/ffmpeg_demux.c | 6 ++ fftools/ffmpeg_enc.c| 24 +--- fftools/ffmpeg_filter.c | 23 +++ fftools/ffmpeg_opt.c| 3 +++ 5 files changed, 48 insertions(+), 11 deletions

[FFmpeg-devel] [PATCH 7/7] fftools/ffplay: support applying container level cropping

2023-10-07 Thread James Almer
Signed-off-by: James Almer --- fftools/ffplay.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index d8c69e10bc..5c213bf0d8 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -36,6 +36,7 @@ #include "libavutil/e

Re: [FFmpeg-devel] [PATCH 02/42] avcodec/refstruct: Add simple API for refcounted objects

2023-10-07 Thread James Almer
On 9/19/2023 4:56 PM, Andreas Rheinhardt wrote: + +/** + * Allocate a refcounted object of usable size `size` managed via + * the RefStruct API. + * + * By default (in the absence of flags to the contrary), + * the returned object is initially zeroed. + * + * @param sizeDesired usable size of

Re: [FFmpeg-devel] [PATCH v1] avcodec/libaomdec: don't set aspect ratio when it's not yet known

2023-10-08 Thread James Almer
On 10/8/2023 8:57 AM, Steven Liu wrote: Makes the output of the libaom av1 decoder consistent with external decoders like libdav1d. reference commit: 1652f2492f88434010053289d946dab6a57e4d58 But it is known at this point. picture->sample_aspect_ratio is set directly above. What needs to be

Re: [FFmpeg-devel] [PATCH v1] avcodec/libaomdec: don't set aspect ratio when it's not yet known

2023-10-08 Thread James Almer
On 10/8/2023 9:45 AM, Steven Liu wrote: James Almer 于2023年10月8日 周日20:08写道: On 10/8/2023 8:57 AM, Steven Liu wrote: Makes the output of the libaom av1 decoder consistent with external decoders like libdav1d. reference commit: 1652f2492f88434010053289d946dab6a57e4d58 But it is known at

Re: [FFmpeg-devel] [PATCH] avcodec/refstruct: Inline ff_refstruct_allocz()

2023-10-08 Thread James Almer
On 10/8/2023 7:21 AM, Andreas Rheinhardt wrote: Suggested by James Almer. Signed-off-by: Andreas Rheinhardt --- libavcodec/refstruct.c | 5 - libavcodec/refstruct.h | 6 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/refstruct.c b/libavcodec

Re: [FFmpeg-devel] [PATCH 4/7] avformat/avformat: add a flag to signal muxers that support storing cropping values

2023-10-10 Thread James Almer
On 10/10/2023 8:09 AM, Anton Khirnov wrote: Quoting James Almer (2023-10-07 18:25:00) Signed-off-by: James Almer --- libavformat/avformat.h | 1 + libavformat/mux.c | 8 2 files changed, 9 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index

Re: [FFmpeg-devel] [PATCH 4/7] avformat/avformat: add a flag to signal muxers that support storing cropping values

2023-10-10 Thread James Almer
On 10/10/2023 8:16 AM, Anton Khirnov wrote: Quoting James Almer (2023-10-10 13:13:46) On 10/10/2023 8:09 AM, Anton Khirnov wrote: Quoting James Almer (2023-10-07 18:25:00) Signed-off-by: James Almer --- libavformat/avformat.h | 1 + libavformat/mux.c | 8 2 files changed

Re: [FFmpeg-devel] [PATCH 0/7] Container level frame cropping parameters

2023-10-10 Thread James Almer
On 10/10/2023 8:17 AM, Anton Khirnov wrote: Quoting James Almer (2023-10-07 18:24:56) This is a simple set to add support to stream wide, container level cropping parameters, as featured in formats like Matroska and ISOBMFF. It's needed for things like AV1 streams generated by certain har

Re: [FFmpeg-devel] [PATCH 0/7] Container level frame cropping parameters

2023-10-10 Thread James Almer
On 10/10/2023 8:54 AM, Anton Khirnov wrote: Quoting James Almer (2023-10-10 13:44:19) On 10/10/2023 8:17 AM, Anton Khirnov wrote: Quoting James Almer (2023-10-07 18:24:56) This is a simple set to add support to stream wide, container level cropping parameters, as featured in formats like

Re: [FFmpeg-devel] [RFC] AG (GA?) VOTE

2023-10-10 Thread James Almer
On 10/10/2023 11:05 AM, Derek Buitenhuis wrote: On 10/10/2023 12:56 PM, Michael Niedermayer wrote: a vote on the General Assembly composition was apparently initiated with a duration of 6 days, i saw this in my inbox: "1009 23:49 Jean-Baptiste K (3,4K) Poll: FFmpeg AG members rules" Without co

Re: [FFmpeg-devel] [RFC] AG (GA?) VOTE

2023-10-10 Thread James Almer
On 10/10/2023 11:42 AM, Nicolas George wrote: James Almer (12023-10-10): The email was sent from ffc...@gmx.de, a domain that some email providers apparently dislike? Google at least is fine with it. I do not know if I am on the voting list, but I can attest that no mail with that origin

Re: [FFmpeg-devel] SWS cleanup / SPI Funding Suggestion

2023-10-17 Thread James Almer
On 10/14/2023 2:53 PM, Stefano Sabatini wrote: On date Friday 2023-10-13 21:19:34 +0200, Michael Niedermayer wrote: Hi everyone I propose using 15k$ from SPI for funding sws cleanup work. this is substantially less than what people belive this needs (see IRC logs from yesterday or so) So it re

Re: [FFmpeg-devel] [PATCH] Add a 7.1.4 channel layout

2023-10-18 Thread James Almer
On 10/18/2023 4:19 PM, Will Wolcott via ffmpeg-devel wrote: Signed-off-by: Will Wolcott --- doc/utils.texi| 2 ++ libavutil/channel_layout.c| 1 + libavutil/channel_layout.h| 2 ++ libavutil/version.h | 2 +- tests/ref/fate/channel_layout | 1 + 5 files c

Re: [FFmpeg-devel] [PATCH 1/2] lavc/internal: add skip_samples2 field

2023-10-19 Thread James Almer
On 10/19/2023 5:39 AM, Anton Khirnov wrote: Current interaction between AV_FRAME_DATA_SKIP_SAMPLES and AVCodecContext.skip_samples seems unncecessarily complicated to me and you're just making it worse. Is there any reason we can't drop AVCodecContext.skip_samples entirely and signal it purely t

[FFmpeg-devel] [PATCH v2] avformat: introduce AVStreamGroup

2023-10-23 Thread James Almer
Signed-off-by: James Almer --- Changes since the first version: - The union will now hold pointers to Group type specific structs - The array of elements in the group is now of pointers to the streams rather than index values. - Simplified the helpers - Changed field type for idx and id

[FFmpeg-devel] [PATCH 2/2] avutil/mem: add av_dynarray2_add_nofree

2023-10-23 Thread James Almer
Signed-off-by: James Almer --- libavutil/mem.c | 17 + libavutil/mem.h | 32 +--- 2 files changed, 46 insertions(+), 3 deletions(-) diff --git a/libavutil/mem.c b/libavutil/mem.c index 36b8940a0c..bd37710968 100644 --- a/libavutil/mem.c +++ b

[FFmpeg-devel] [PATCH 1/3] avutil/channel_layout: rename 7.1(top) channel layout to 5.1.2

2023-10-23 Thread James Almer
also be a better fit for the additions in the following commits. Signed-off-by: James Almer --- doc/utils.texi| 2 +- libavutil/channel_layout.c| 2 +- libavutil/channel_layout.h| 8 ++-- tests/ref/fate/channel_layout | 2 +- 4 files changed, 9 insertions(+), 5 delet

[FFmpeg-devel] [PATCH 2/3] avutil/channel_layout: add a 5.1.4 channel layout

2023-10-23 Thread James Almer
Mapping to ITU-R BS.2051-3 "Sound System D" and ITU-R BS.1196-8 "Channel Configuration 16". Signed-off-by: James Almer --- doc/utils.texi| 2 ++ libavutil/channel_layout.c| 1 + libavutil/channel_layout.h| 2 ++ tests/ref/fate/channel_layout | 1 +

[FFmpeg-devel] [PATCH 3/3] avutil/channel_layout: add a 7.1.4 channel layout

2023-10-23 Thread James Almer
From: Will Wolcott Mapping to ITU-R BS.2051-3 "Sound System J" and ITU-R BS.1196-8 "Channel Configuration 19". Signed-off-by: Will Wolcott Signed-off-by: James Almer --- doc/utils.texi| 2 ++ libavutil/channel_layout.c| 1 + libavutil/channel_layout.h

Re: [FFmpeg-devel] [PATCH 1/3] avutil/channel_layout: rename 7.1(top) channel layout to 5.1.2

2023-10-23 Thread James Almer
On 10/23/2023 8:49 PM, Hendrik Leppkes wrote: On Tue, Oct 24, 2023 at 1:46 AM Hendrik Leppkes wrote: On Tue, Oct 24, 2023 at 1:24 AM James Almer wrote: This layout maps to ITU-R BS.2051-3 "Sound System C" and ITU-R BS.1196-8 "Channel Configuration 14", and it being t

[FFmpeg-devel] [PATCH v2 1/3] avutil/channel_layout: rename 7.1(top) channel layout to 5.1.2

2023-10-23 Thread James Almer
also be a better fit for the additions in the following commits. Signed-off-by: James Almer --- doc/utils.texi| 2 +- libavutil/channel_layout.c| 2 +- libavutil/channel_layout.h| 8 ++-- tests/ref/fate/channel_layout | 2 +- 4 files changed, 9 insertions(+), 5 delet

[FFmpeg-devel] [PATCH v2 2/3] avutil/channel_layout: add a 5.1.4 channel layout

2023-10-23 Thread James Almer
Mapping to ITU-R BS.2051-3 "Sound System D" and ITU-R BS.1196-8 "Channel Configuration 16". Signed-off-by: James Almer --- doc/utils.texi| 2 ++ libavutil/channel_layout.c| 1 + libavutil/channel_layout.h| 2 ++ tests/ref/fate/channel_layout | 1 +

[FFmpeg-devel] [PATCH v2 3/3] avutil/channel_layout: add a 7.1.4 channel layout

2023-10-23 Thread James Almer
From: Will Wolcott Mapping to ITU-R BS.2051-3 "Sound System J" and ITU-R BS.1196-8 "Channel Configuration 19". Signed-off-by: Will Wolcott Signed-off-by: James Almer --- doc/utils.texi| 2 ++ libavutil/channel_layout.c| 1 + libavutil/channel_layout.h

Re: [FFmpeg-devel] [PATCH v2] avformat: introduce AVStreamGroup

2023-10-25 Thread James Almer
On 10/25/2023 4:25 PM, Tomas Härdin wrote: +enum AVStreamGroupParamsType { +    AV_STREAM_GROUP_PARAMS_NONE, Maybe AV_STREAM_GROUP_PARAMS_NUM on the end? For what purpose? Usually, when we add those values they are not part of the API and exist for some internal iteration. __

Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/channel_layout: rename 7.1(top) channel layout to 5.1.2

2023-10-26 Thread James Almer
On 10/23/2023 9:33 PM, James Almer wrote: This layout maps to ITU-R BS.2051-3 "Sound System C" and ITU-R BS.1196-8 "Channel Configuration 14", and it being the first layout with top layer channels, it's best to use a different scheme to properly convey the presence and

Re: [FFmpeg-devel] [RFC] Release 6.1

2023-10-28 Thread James Almer
On 10/28/2023 1:49 PM, Michael Niedermayer wrote: On Thu, Jul 06, 2023 at 06:04:41PM +0200, Lynne wrote: It's been a while since we've had a release, and we've had a lot of new features in. We did say we would make releases more often, and I think it's about time we have a new release. Anything

[FFmpeg-devel] [PATCH] web: move 4.1 to olddownloads

2023-10-28 Thread James Almer
our downstream list shows no maintained users of that release https://trac.ffmpeg.org/wiki/Downstreams Signed-off-by: James Almer --- src/download| 37 - src/olddownload | 37 + 2 files changed, 37 insertions(+), 37

[FFmpeg-devel] [PATCH] avutil/video_enc_params: fix doxy for av_video_enc_params_block()

2023-10-29 Thread James Almer
Signed-off-by: James Almer --- libavutil/video_enc_params.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/video_enc_params.h b/libavutil/video_enc_params.h index fc0c3bc1a5..62265a5c06 100644 --- a/libavutil/video_enc_params.h +++ b/libavutil

Re: [FFmpeg-devel] [RFC] Release 6.1

2023-10-29 Thread James Almer
On 10/29/2023 1:42 PM, Jean-Baptiste Kempf wrote: Hello, On Sat, 28 Oct 2023, at 18:49, Michael Niedermayer wrote: noone mentioned 5.1.x and 6.0.x to me before Our last releases from our two major bracnhes, are a 5.1.3 (which is a LTS branch) and a 6.0.0. Both of those have not had backport

[FFmpeg-devel] [PATCH v3 1/3] [PoC]avformat: introduce AVStreamGroup

2023-10-30 Thread James Almer
Signed-off-by: James Almer --- No changes since last version. I'm resending this for the IAMF demuxer. I need opinions or reviews for this. We need to get this right from the start and i don't want to push something that will afterwards be considered unoptimal libavformat/avform

[FFmpeg-devel] [PATCH v3 2/3] avutil/mem: add av_dynarray2_add_nofree

2023-10-30 Thread James Almer
Signed-off-by: James Almer --- No changes since last version. libavutil/mem.c | 17 + libavutil/mem.h | 32 +--- 2 files changed, 46 insertions(+), 3 deletions(-) diff --git a/libavutil/mem.c b/libavutil/mem.c index 36b8940a0c..bd37710968 100644

[FFmpeg-devel] [PATCH v3 3/3][WIP][RFC] avformat: Immersive Audio Model and Formats demuxer

2023-10-30 Thread James Almer
Signed-off-by: James Almer --- Changes since last version: - AVOptions for most new public structs, and the helpers adapted for them. - Assorted fixes. libavcodec/avpacket.c |3 + libavcodec/packet.h | 24 + libavformat/Makefile|2 + libavformat/allformats.c

Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

2023-11-01 Thread James Almer
On 11/1/2023 10:56 AM, Nicolas George wrote: Jan Ekström (12023-11-01): So my question is: Does this test case not improve for you after you have applied these patches? Or are you speaking of a separate problem which is bad both in master as well as after these patches have been applied? This

[FFmpeg-devel] [PATCH 1/2] avutil/channel_layout: add a 7.2.3 channel layout

2023-11-03 Thread James Almer
Mapping to ITU-R BS.2051-3 "Sound System F" and ITU-R BS.1196-8 "Channel Configuration 15". Signed-off-by: James Almer --- doc/utils.texi| 2 ++ libavutil/channel_layout.c| 1 + libavutil/channel_layout.h| 2 ++ tests/ref/fate/channel_layout | 1 +

[FFmpeg-devel] [PATCH 2/2] avutil/channel_layout: add a 9.1.4 channel layout

2023-11-03 Thread James Almer
Mapping to ITU-R BS.2051-3 "Sound System G" and ITU-R BS.1196-8 "Channel Configuration 20". Signed-off-by: James Almer --- doc/utils.texi| 2 ++ libavutil/channel_layout.c| 1 + libavutil/channel_layout.h| 2 ++ tests/ref/fate/channel_layout | 1 +

Re: [FFmpeg-devel] [PATCH 14/24] fftools/ffmpeg_mux: move bitstream filtering to the muxer thread

2023-11-04 Thread James Almer
On 11/4/2023 4:56 AM, Anton Khirnov wrote: This will be the appropriate place for it after the rest of transcoding is switched to a threaded architecture. --- fftools/ffmpeg_mux.c | 112 ++- 1 file changed, 67 insertions(+), 45 deletions(-) diff --git a

Re: [FFmpeg-devel] [PATCH 18/24] fftools/ffmpeg: add thread-aware transcode scheduling infrastructure

2023-11-04 Thread James Almer
On 11/4/2023 4:56 AM, Anton Khirnov wrote: +static void *task_wrapper(void *arg) +{ +SchTask *task = arg; +Scheduler *sch = task->parent; +int ret; +int err = 0; + +ret = (intptr_t)task->func(task->func_arg); +if (ret < 0) +av_log(task->func_arg, AV_LOG_ERROR, +

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: extra members for GA

2023-11-05 Thread James Almer
On 11/5/2023 4:57 PM, Ronald S. Bultje wrote: Hi, On Sun, Nov 5, 2023 at 4:24 AM Anton Khirnov wrote: Please suggest candidates in replies to this email, with a short description of how they contribute to the project. Myself, please. I currently maintain the VP8/VP9 decoders and sometimes

<    1   2   3   4   5   6   7   8   9   10   >