Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec_h264.c bug fixed: decoder fails after restart on non-annex-b content.

2015-07-25 Thread Ivan Uskov
Hello Michael, Saturday, July 25, 2015, 9:11:34 PM, you wrote: >> MN> if it avoids just a rare or small case then its not worth it >> I believe this trick will no give visible improvement in performance. >> Just small win in some rare cases. MN> then its better to avoid duplicating the bitstream

[FFmpeg-devel] [PATCH 1/2] libavcodec/h264_mp4toannexb_bsf.c: Optional argument "private_spspps_buf" to avoid extradata modification.

2015-07-25 Thread Ivan Uskov
Hello all, This patch implements optional mode which disables context extradata modification by bsf. The modification of extradata become an issue when bsf restarts (after stream detection for example). Please review. -- Best regards, Ivan mailto:ivan.us...@nablet.co

[FFmpeg-devel] [PATCH 2/2] libavcodec/qsvdec_h264.c: using "private_spspps_buf" argument for av_bitstream_filter_filter() to avoid failure after decoder re-initialization.

2015-07-25 Thread Ivan Uskov
Hello All This patch uses new "private_spspps_buf" argument of h264_mp4toannexb_bsf.c. This allow to fix bug when the qsvdec_h264.c decoder is not able to decode mp4 and mkv. Please review. -- Best regards, Ivanmailto:ivan.us...@nablet.com 0002-libavcodec-qsvdec_h26

[FFmpeg-devel] [PATCH] libavcodec/hevc_mp4toannexb_bsf.c: Optional argument "private_spspps_buf" to avoid extradata modification.

2015-07-28 Thread Ivan Uskov
Hello All, This patch implements optional mode which disables context extradata modification by bsf. The modification of extradata become an issue when bsf restarts (after stream detection for example). Please review. -- Best regards, Ivan mailto:ivan.us...@nablet.com

[FFmpeg-devel] [PATCH 1/2] libavcodec/qsvenc.c delay in 1 microsecond replaced to more appropriate 500 microseconds

2015-07-28 Thread Ivan Uskov
Hello All, The attached patch replaces 1 microsecond delay to 500 microsecond for case when MFX library does return MFX_WRN_DEVICE_BUSY status. In general this warning never appears for simple encoding or transcoding session because GPU so fast so almost always not busy and any delay value just no

[FFmpeg-devel] [PATCH 2/2] libavcodec/qsvdec.c delay in 1 microsecond replaced to more appropriate 500 microseconds

2015-07-28 Thread Ivan Uskov
Hello All, There is same patch as 1/2 but for decoder part. -- Best regards, Ivanmailto:ivan.us...@nablet.com 0002-libavcodec-qsvdec.c-delay-in-1-microsecond-replaced-.patch Description: Binary data ___ ffmpeg-devel maili

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/qsvenc.c delay in 1 microsecond replaced to more appropriate 500 microseconds

2015-07-28 Thread Ivan Uskov
Hello wm4, Tuesday, July 28, 2015, 6:39:22 PM, you wrote: >> Official MFX/QSV samples by Intel are use 1 millisecond (i.e. 1000 >> microseconds) everywhere where MFX_WRN_DEVICE_BUSY does appear. >> So 500us is much more optimal value than 1us. w> Are you 100% sure that there is no event-based way

[FFmpeg-devel] [PATCH] QSV MJPEG video decoder has been added.

2015-08-02 Thread Ivan Uskov
Hello All, The attached patch adds QSV-based mjpeg video decoder. Please review. -- Best regards, Ivan mailto:ivan.us...@nablet.com 0001-QSV-MJPEG-video-decoder-has-been-added.patch Description: Binary data ___ ffmpeg-deve

Re: [FFmpeg-devel] [PATCH] QSV MJPEG video decoder has been added.

2015-08-02 Thread Ivan Uskov
Hello Michael, Sunday, August 2, 2015, 8:55:45 PM, you wrote: >> +#if QSV_VERSION_ATLEAST(1, 3) >> +#include >> +#endif MN> this seems not working MN> CC libavcodec/qsv.o MN> libavcodec/qsv.c:33:25: fatal error: mfx/mfxjpeg.h: No such file or directory MN> #include MN>

Re: [FFmpeg-devel] [PATCH] QSV MJPEG video decoder has been added.

2015-08-02 Thread Ivan Uskov
Hello wm4, Sunday, August 2, 2015, 9:27:17 PM, you wrote: w> Is mjpeg decoding so important that we need QSV decoding of it? Why not? It is for free. -- Best regards, Ivanmailto:ivan.us...@nablet.com ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH] QSV MJPEG video decoder has been added.

2015-08-02 Thread Ivan Uskov
Hello wm4, Sunday, August 2, 2015, 9:38:33 PM, you wrote: >> w> Is mjpeg decoding so important that we need QSV decoding of it? >> Why not? It is for free. w> Having to maintain additional code has a cost, though. Near about zero, since qsv core common for all formats. -- Best regards, Ivan

Re: [FFmpeg-devel] [PATCH] QSV MJPEG video decoder has been added.

2015-08-02 Thread Ivan Uskov
Hello Michael, Sunday, August 2, 2015, 9:46:23 PM, you wrote: >> MN> it appears the file was not in mfx_dispatch previously >> MN> so a check in confgure might be needed >> As I can see here >> https://github.com/lu-zero/mfx_dispatch/tree/master/mfx >> The mfxjpeg.h was added 17 days ago and marke

Re: [FFmpeg-devel] [PATCH] QSV MJPEG video decoder has been added.

2015-08-03 Thread Ivan Uskov
Hello Hendrik, Monday, August 3, 2015, 12:45:36 AM, you wrote: HL> The decoder should depend on the header in configure directly already, HL> so its not built at all when the header is not available. In general I do not understanding why it necessary at all. All necessary headers currently avail

Re: [FFmpeg-devel] [PATCH] QSV MJPEG video decoder has been added.

2015-08-03 Thread Ivan Uskov
Hello Hendrik, Monday, August 3, 2015, 12:58:28 AM, you wrote: >> Because if it's missing, ff_get_format() refuses to return the QSV >> opaque format. I think. So you need AVHWAccels for every codec/decoder >> combination. HL> But if you use the normal h264 decoder and select the QSV format in H

Re: [FFmpeg-devel] [PATCH] QSV MJPEG video decoder has been added.

2015-08-03 Thread Ivan Uskov
Hello Michael, Monday, August 3, 2015, 12:14:39 PM, you wrote: MN> On Mon, Aug 03, 2015 at 11:36:09AM +0300, Ivan Uskov wrote: >> Hello Hendrik, >> >> Monday, August 3, 2015, 12:45:36 AM, you wrote: >> >> >> HL> The decoder should depend on the heade

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ivan Uskov
Hello Hendrik, Thank you very much for the bugreport, I believe I will able to fix all these issues quick. In general all these issues are known and in my todo list. Monday, August 3, 2015, 3:18:04 PM, you wrote: HL> Hey, HL> after a discussion on IRC about the declining quality of the QSV HL

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ivan Uskov
Hello Michael, Hendrik, I would like to make sure about following moment regarding handling of sequence header changing. The decoder has buffering of decoded frames, so when new frame dimensions are detected we can not just reset decoder, we should to deffer re-init and switch decoder to some "fl

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ivan Uskov
Hello wm4, Monday, August 3, 2015, 10:33:30 PM, you wrote: w> I was under the impression that the original Libav code handled this w> correctly. Unfortunately not, you can still see this comment at line 371 https://git.libav.org/?p=libav.git;a=blob;f=libavcodec/qsvdec.c and there is no any flush

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ivan Uskov
Hello Ronald, Monday, August 3, 2015, 11:37:22 PM, you wrote: RSB> On Mon, Aug 3, 2015 at 3:25 PM, Ivan Uskov wrote: >> By the way, about old implementation which "worked fine". >> It just did drop all buffered frames at decoder re-init on new >> sequence heade

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-04 Thread Ivan Uskov
Hello Ronald, Tuesday, August 4, 2015, 5:24:45 AM, you wrote: RSB> Hi Ivan, RSB> On Mon, Aug 3, 2015 at 4:50 PM, Ivan Uskov wrote: >> Hello Ronald, >> >> Monday, August 3, 2015, 11:37:22 PM, you wrote: >> >> RSB> On Mon, Aug 3, 2015 at 3:25 PM, Ivan Usko

[FFmpeg-devel] [PATCH] libavcodec/qsvdec.c: correct handling of dynamic frame size changing has been implemented

2015-08-04 Thread Ivan Uskov
Hello All, This patch for libavcodec/qsvdec.c does implement a correct handling of a case when frame dimensions were changed somewhere in middle of stream. Please review. -- Best regards, Ivan mailto:ivan.us...@nablet.com 0001-libavcodec-qsvdec.c-correct-handling-of

Re: [FFmpeg-devel] Questions about ffmpeg h264_qsv

2015-08-06 Thread Ivan Uskov
Hello Ron, Thursday, August 6, 2015, 5:34:51 AM, you wrote: R> Hi, R> I have some questions about ffmpeg h264_qsv with Intel media sdk. R> R> 1. The command 'ffmpeg -i in.mp4 -an -c:v h264_qsv out.mp4' to R> encode sucessful, how can I make the qsv decoder work? Just use the following syntax

[FFmpeg-devel] [PATCH 1/3] libavcodec/qsvdec.c: the ff_get_format() missed at refactoring has been restored

2015-08-09 Thread Ivan Uskov
Hello All, This patch, next two patches and also the patch posted by me a August 4 are fixing all issues about QSV-accelerated decoding. I will absent two next weeks since August 11 and will not accessible by e-mail. But even if these patches will not applied to master repository are can be used

[FFmpeg-devel] PATCH 2/3] libavcodec/qsvdec.c: Extended error messages for MFXVideoDECODE_Init() result

2015-08-09 Thread Ivan Uskov
Hello all, the attached patch does extend error codes processing to give exact message when input format is not supported by QSV (for example mpeg 422 or avc 10 bit). -- Best regards, Ivanmailto:ivan.us...@nablet.com 0002-libavcodec-qsvdec.c-Extended-error-messages-

[FFmpeg-devel] [PATCH 3/3] libavcodec/qsvdec.c: correct flush() handler has been implemented

2015-08-09 Thread Ivan Uskov
Hello All, The attached patch does add correct processing for the flush(), including QSV decoder resetting an internal buffers discarding. -- Best regards, Ivanmailto:ivan.us...@nablet.com 0003-libavcodec-qsvdec.c-correct-flush-handler-has-been-i.patch Description:

Re: [FFmpeg-devel] [PATCH 1/3] libavcodec/qsvdec.c: the ff_get_format() missed at refactoring has been restored

2015-08-09 Thread Ivan Uskov
Hello Ivan, Sunday, August 9, 2015, 6:32:55 PM, you wrote: IU> This patch, next two patches and also the patch posted by me a August 4 IU> are fixing all issues about QSV-accelerated decoding. all *known* issues of course. :-) -- Best regards, Ivanmailto:ivan.us..

Re: [FFmpeg-devel] [PATCH 1/3] libavcodec/qsvdec.c: the ff_get_format() missed at refactoring has been restored

2015-08-11 Thread Ivan Uskov
Hello Hendrik, Tuesday, August 11, 2015, 11:33:41 AM, you wrote: HL> On Sun, Aug 9, 2015 at 5:32 PM, Ivan Uskov wrote: >> Hello All, >> >> This patch, next two patches and also the patch posted by me a August 4 >> are fixing all issues about QSV-accelerated decodi

Re: [FFmpeg-devel] [PATCH] QSV : Added look ahead rate control mode

2015-08-30 Thread Ivan Uskov
Hello Michael, Thursday, August 27, 2015, 6:47:43 PM, you wrote: MN> On Thu, Aug 27, 2015 at 11:02:44AM +0200, Sven Dueking wrote: >> > -Ursprüngliche Nachricht- >> > Von: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] Im Auftrag >> > von Sven Dueking >> > Gesendet: Freitag, 21. Au

[FFmpeg-devel] [PATCH] libavcodec/qsvdec_h2645.c Bug fixed: wrong ticks_per_frame.

2015-09-16 Thread Ivan Uskov
Hello All, The attached patch does fixes the issue of frames duplication when elementary h.264 stream decodes by qsvdec. Please review. -- Best regards, Ivan mailto:ivan.us...@nablet.com 0001-libavcodec-qsvdec_h2645.c-Bug-fixed-wrong-ticks_per_.patch Descr

Re: [FFmpeg-devel] Some questions about ffmpeg h264_qsv decoder

2015-09-16 Thread Ivan Uskov
Hello Ron, Wednesday, September 16, 2015, 9:00:02 AM, you wrote: R> a) qsv decode h264 file found many duplicated frames. I have posted the patch "[PATCH] libavcodec/qsvdec_h2645.c Bug fixed: wrong ticks_per_frame." to this list, please try to apply it the issue should be solved. R> b) A 19

Re: [FFmpeg-devel] [PATCH] qsvenc.c: use query function to catch all kind of setting issues

2015-10-01 Thread Ivan Uskov
Hello Sven, >> fatal: corrupt patch at line 10 SD> Sorry, no idea what went wrong ... anyway - patch attached. I have tested this patch, looks good to me. -- Best regards, Ivanmailto:ivan.us...@nablet.com ___ ffmpeg-deve

<    1   2