Is there anything I need to do to move this forwards? I think it is relatively
uncontroversial?
Harry
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmp
> On 8 Sep 2020, at 13:08, Gyan Doshi wrote:
>
> Hi Harry,
>
> On 06-09-2020 04:24 pm, Gyan Doshi wrote:
>>
>>
>> On 06-09-2020 02:59 pm, Harry Mallon wrote:
>>> Is there anything I need to do to move this forwards? I think it is
>>> rela
> On 8 Sep 2020, at 14:29, Gyan Doshi wrote:
>
> On 08-09-2020 06:23 pm, Harry Mallon wrote:
>>
>>
>>> On 8 Sep 2020, at 13:08, Gyan Doshi wrote:
>>>
>>> Hi Harry,
>>>
>>> On 06-09-2020 04:24 pm, Gyan Doshi wrote:
>
> On 7 Sep 2020, at 10:40, Tomas Härdin wrote:
>
> mån 2020-08-31 klockan 20:07 +0100 skrev Harry Mallon:
>> +static const uint8_t mxf_mastering_display_primaries[]= {
>> 0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0x0e,0x04,0x20,0x04,0x01,0x01,0x01,0x00,0x00
&g
> On 3 Sep 2020, at 07:31, Marton Balint wrote:
>
> On Mon, 31 Aug 2020, Harry Mallon wrote:
>
>> [..]
>> };
>> +static const MXFLocalTagPair mxf_mastering_display_local_tags[] = {
>> +{ 0x8201,
>> {0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0x
> On 7 Sep 2020, at 10:46, Tomas Härdin wrote:
>
> mån 2020-08-31 klockan 20:07 +0100 skrev Harry Mallon:
>> * As embedded by Apple Compressor
>
> This needs a sample since it isn't part of any official spec, so that
> we can have a test for this.
>
Described in Annex B SMPTE ST 2067-21:2020
Signed-off-by: Harry Mallon
---
libavformat/mxf.c| 11 ++
libavformat/mxf.h| 11 ++
libavformat/mxfdec.c | 48
libavformat/mxfenc.c | 5 -
4 files changed, 70 insertions(+), 5
* As embedded by Apple Compressor
Signed-off-by: Harry Mallon
---
libavformat/mxfdec.c| 27 +
tests/fate/mxf.mak | 4 +
tests/ref/fate/mxf-probe-applehdr10 | 169
3 files changed, 200 insertions(+)
create mode 100644 tests
Described in Annex B SMPTE ST 2067-21:2020
Signed-off-by: Harry Mallon
---
libavformat/mxfenc.c | 50 +++-
1 file changed, 49 insertions(+), 1 deletion(-)
diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
index 733c747a9a..cbb0fc5a6a 100644
--- a
Signed-off-by: Harry Mallon
---
libavcodec/videotoolboxenc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 212f41b19a..fe0c98300b 100644
--- a/libavcodec/videotoolboxenc.c
+++ b/libavcodec/videotoolboxenc.c
@@ -789,7 +789,6
Signed-off-by: Harry Mallon
---
libavcodec/videotoolboxenc.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index e89cfaeed8..212f41b19a 100644
--- a/libavcodec/videotoolboxenc.c
+++ b/libavcodec
> On 14 Aug 2020, at 11:03, Harry Mallon wrote:
>
> Signed-off-by: Harry Mallon
> ---
> libavcodec/dpx.c | 15 ++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
> index b1833ed9ef..7e3ac0af2e 1006
> On 30 Sep 2020, at 08:32, Michael Niedermayer wrote:
>
> On Thu, Sep 17, 2020 at 10:49:31PM +0200, Tomas Härdin wrote:
>> mån 2020-09-14 klockan 12:23 +0200 skrev Tomas Härdin:
>>> ons 2020-09-09 klockan 15:56 +0100 skrev Harry Mallon:
>>>&g
> On 7 Oct 2020, at 22:02, Paul B Mahol wrote:
>
> Signed-off-by: Paul B Mahol
> ---
> libavcodec/dpxenc.c | 36 ++--
> tests/ref/lavf/dpx | 2 +-
> 2 files changed, 35 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/dpxenc.c b/libavcodec/dpxenc.c
> i
>>
>>>
>>> [..]
>>> +static int get_dpx_pri(int color_pri)
>>> +{
>>> +switch (color_pri) {
>>> +case AVCOL_PRI_BT709:
>>> +return 6;
>>> +case AVCOL_PRI_SMPTE240M:
>>> +case AVCOL_PRI_SMPTE170M:
>>> +return 9;
>>
>> I think perhaps this should be 8 (ITU 601 525)
> On 23 Oct 2020, at 05:57, Mohammad Izadi
> wrote:
>
> Any comments?
>
> Thanks,
> Mohammad
>
>
> On Tue, Oct 13, 2020 at 4:53 PM Mohammad Izadi wrote:
>
>> From: Mohammad Izadi
>>
>> [..]
Hi Mohammad,
Your change is in Patchwork here
https://patchwork.ffmpeg.org/project/ffmpeg/patc
Signed-off-by: Harry Mallon
---
libavcodec/dpx.c | 25 -
tests/ref/fate/dpx-probe | 4 ++--
2 files changed, 26 insertions(+), 3 deletions(-)
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
index 51428459ef..577171258a 100644
--- a/libavcodec/dpx.c
+++ b
Signed-off-by: Harry Mallon
---
libavcodec/dpx.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
index 7b18141f97..bd431ccbcb 100644
--- a/libavcodec/dpx.c
+++ b/libavcodec/dpx.c
@@ -167,7 +167,7 @@ static int decode_frame
Signed-off-by: Harry Mallon
---
libavcodec/dpx.c | 29 +
tests/ref/fate/dpx-probe | 7 +++
2 files changed, 36 insertions(+)
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
index 7e3ac0af2e..51428459ef 100644
--- a/libavcodec/dpx.c
+++ b/libavcodec
Signed-off-by: Harry Mallon
---
libavcodec/dpx.c | 127 +--
tests/ref/fate/dpx-probe | 8 +--
2 files changed, 127 insertions(+), 8 deletions(-)
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
index 577171258a..7b18141f97 100644
--- a/libavcodec
Signed-off-by: Harry Mallon
---
tests/fate/image.mak | 4 ++
tests/ref/fate/dpx-probe | 85
2 files changed, 89 insertions(+)
create mode 100644 tests/ref/fate/dpx-probe
diff --git a/tests/fate/image.mak b/tests/fate/image.mak
index 22072a62f1
Signed-off-by: Harry Mallon
---
libavcodec/dpx.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
index b1833ed9ef..7e3ac0af2e 100644
--- a/libavcodec/dpx.c
+++ b/libavcodec/dpx.c
@@ -216,10 +216,23 @@ static int decode_frame
Hi Paul etc,
I attach a smaller file (it will need the width height etc changing in the test
which I will send as a V2 in a couple of mins).
Harry
cyan.dpx
Description: Binary data
> On 10 Dec 2020, at 11:51, Paul B Mahol wrote:
>
> File is fine, gonna apply this with ffprobe improved te
Signed-off-by: Harry Mallon
---
tests/fate/image.mak | 4 ++
tests/ref/fate/dpx-probe | 85
2 files changed, 89 insertions(+)
create mode 100644 tests/ref/fate/dpx-probe
diff --git a/tests/fate/image.mak b/tests/fate/image.mak
index 22072a62f1
Signed-off-by: Harry Mallon
---
libavcodec/dpx.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
index b1833ed9ef..7e3ac0af2e 100644
--- a/libavcodec/dpx.c
+++ b/libavcodec/dpx.c
@@ -216,10 +216,23 @@ static int decode_frame
Signed-off-by: Harry Mallon
---
libavcodec/dpx.c | 25 -
tests/ref/fate/dpx-probe | 4 ++--
2 files changed, 26 insertions(+), 3 deletions(-)
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
index 51428459ef..577171258a 100644
--- a/libavcodec/dpx.c
+++ b
Signed-off-by: Harry Mallon
---
libavcodec/dpx.c | 127 +--
tests/ref/fate/dpx-probe | 8 +--
2 files changed, 127 insertions(+), 8 deletions(-)
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
index 577171258a..7b18141f97 100644
--- a/libavcodec
> On 10 Dec 2020, at 12:21, Paul B Mahol wrote:
>
> I already uploaded the other file to servers.
Ah, sorry about that.
>
> And I doubt it hurts at all in 2020.
> Also I doubt one can overwrite files that easily.
I have sent the V2. It is all exactly the same except it is set up for the
sm
Signed-off-by: Harry Mallon
---
libavcodec/dpx.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
index 7b18141f97..bd431ccbcb 100644
--- a/libavcodec/dpx.c
+++ b/libavcodec/dpx.c
@@ -167,7 +167,7 @@ static int decode_frame
Signed-off-by: Harry Mallon
---
libavcodec/dpx.c | 29 +
tests/ref/fate/dpx-probe | 7 +++
2 files changed, 36 insertions(+)
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
index 7e3ac0af2e..51428459ef 100644
--- a/libavcodec/dpx.c
+++ b/libavcodec
> On 10 Dec 2020, at 23:41, Paul B Mahol wrote:
>
> I strongly disagree, make use of money project got.
> Limiting size of samples is not gonna to be productive at all.
>
> On Fri, Dec 11, 2020 at 12:37 AM Carl Eugen Hoyos
> wrote:
>
>> Am Do., 10. Dez. 2020 um 13:22 Uhr schrieb Paul B Mahol
Hello,
Sorry I wasn't able to send this with git-send-email. The following
patch adds reading colour metadata (transfer, primaries and colour
space) from standard MXF files. I wrote it without seeing the other
patch but it turned out very similar to this one that was never merged
https://patchwork
o this one that was never
merged
https://patchwork.ffmpeg.org/project/ffmpeg/patch/1474694344-31167-1-git-send-email-ste...@strobe.cc/
.
Thanks.
Harry
From 3ff4c4187654e92a84ce165365e339995512c5be Mon Sep 17 00:00:00 2001
From: Harry Mallon
Date: Mon, 27 Jul 2020 15:52:17 +0100
Subject:
that was never merged.
https://patchwork.ffmpeg.org/project/ffmpeg/patch/1474694344-31167-1-git-send-email-ste...@strobe.cc/
.
Thanks.
Harry
From d16966e6b0a6367a5e5445987c0449fb1150785a Mon Sep 17 00:00:00 2001
From: Harry Mallon
Date: Mon, 27 Jul 2020 15:52:17 +0100
Subject: [PATCH] avf
From de460620b73379d5a869baa98e49a5d0f67d9ebb Mon Sep 17 00:00:00 2001
From: Harry Mallon
Date: Tue, 28 Jul 2020 10:33:19 +0100
Subject: [PATCH] avformat/mxfenc: Write color metadata to MXF
Writes color_primaries, color_trc and color_space to mxf
headers. ULs are from https://registry.smpte-ra.org
Thanks to Tomas for reviewing these MXF patches. Here is another. FFMPEG
already writes out the three range tags. This just reads them in.
Best,
Harry
From c49f77d1e887d8c84752df11213dcf5afa8f761e Mon Sep 17 00:00:00 2001
From: Harry Mallon
Date: Wed, 12 Aug 2020 10:26:23 +0100
Subject
Rebased the patch on master (it didn't build before) and fixed FATE.
From ac8d7884b036b504d07f38815de1c163c5e1691e Mon Sep 17 00:00:00 2001
From: Harry Mallon
Date: Wed, 12 Aug 2020 10:26:23 +0100
Subject: [PATCH v2] avformat/mxfdec: Read video range from PictureDescriptor
* Capture blac
I'm very sorry for the noise, I just thought of a way that the last patch could
be troublesome. Fixed here.
From 31ce817887ec84907b3aadb5dc1657b01b8d0dbd Mon Sep 17 00:00:00 2001
From: Harry Mallon
Date: Wed, 12 Aug 2020 10:26:23 +0100
Subject: [PATCH v3] avformat/mxfdec: Read video range
> On 12 Aug 2020, at 14:59, Tomas Härdin wrote:
>
> ons 2020-08-12 klockan 13:43 +0100 skrev Harry Mallon:
>> @@ -2492,6 +2504,18 @@ static int mxf_parse_structural_metadata(MXFContext
>> *mxf)
>> }
>> if (descriptor->aspect_ratio
Here is an updated patch (now hopefully going with correct email headers).
From 5866d0dc5536a6ea3f6a899c3d09f19df083c16a Mon Sep 17 00:00:00 2001
From: Harry Mallon
Date: Wed, 12 Aug 2020 10:26:23 +0100
Subject: [PATCH v4] avformat/mxfdec: Read video range from PictureDescriptor
* Capture
Signed-off-by: Harry Mallon
---
libavcodec/dpx.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
index b1833ed9ef..694deb27c5 100644
--- a/libavcodec/dpx.c
+++ b/libavcodec/dpx.c
@@ -216,10 +216,22 @@ static int decode_frame
Signed-off-by: Harry Mallon
---
libavcodec/dpx.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
index b1833ed9ef..694deb27c5 100644
--- a/libavcodec/dpx.c
+++ b/libavcodec/dpx.c
@@ -216,10 +216,22 @@ static int decode_frame
Signed-off-by: Harry Mallon
---
libavcodec/dpx.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
index b1833ed9ef..7e3ac0af2e 100644
--- a/libavcodec/dpx.c
+++ b/libavcodec/dpx.c
@@ -216,10 +216,23 @@ static int decode_frame
> On 14 Aug 2020, at 11:53, Tomas Härdin wrote:
>
> tor 2020-08-13 klockan 22:21 +0200 skrev Marton Balint:
>>
>> On Thu, 13 Aug 2020, Tomas Härdin wrote:
>>
>>> tor 2020-08-13 klockan 11:04 +0100 skrev Harry Mallon:
>>>> Here is an updat
> On 14 Aug 2020, at 22:33, Harry Mallon wrote:
>
>
>
>
>> On 14 Aug 2020, at 11:53, Tomas Härdin wrote:
>>
>> tor 2020-08-13 klockan 22:21 +0200 skrev Marton Balint:
>>>
>>> On Thu, 13 Aug 2020, Tomas Härdin wrote:
>>>
* chroma-derived-nc / chroma-derived-c and ictcp
Signed-off-by: Harry Mallon
---
doc/codecs.texi| 6 ++
libavcodec/options_table.h | 33 ++---
2 files changed, 24 insertions(+), 15 deletions(-)
diff --git a/doc/codecs.texi b/doc/codecs.texi
index
Signed-off-by: Harry Mallon
---
libavcodec/proresdec2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c
index d5fbfc6711..4e1d0dd3f1 100644
--- a/libavcodec/proresdec2.c
+++ b/libavcodec/proresdec2.c
@@ -289,7 +289,7 @@ static
* chroma-derived-nc / chroma-derived-c and ictcp
Signed-off-by: Harry Mallon
---
doc/codecs.texi| 6 ++
libavcodec/options_table.h | 33 ++---
2 files changed, 24 insertions(+), 15 deletions(-)
diff --git a/doc/codecs.texi b/doc/codecs.texi
index
Signed-off-by: Harry Mallon
---
libavfilter/vf_libvmaf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c
index 14c3216b3a..4d49127efc 100644
--- a/libavfilter/vf_libvmaf.c
+++ b/libavfilter/vf_libvmaf.c
@@ -74,7 +74,7
MXF CDCI color range was being set to (1<component_depth) - 1
for full range but it should be (1<component_depth) is 0 is
a valid value.
Signed-off-by: Harry Mallon
---
libavformat/mxfenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/mxfenc.c b/libav
* Capture black_ref, white_ref and color_range and recognise
full and narrow range.
Signed-off-by: Harry Mallon
---
libavformat/mxfdec.c | 37 ++
tests/ref/fate/mxf-probe-dnxhd | 2 +-
tests/ref/fate/mxf-probe-dv25 | 2 +-
3 files changed, 39
Signed-off-by: Harry Mallon
---
doc/filters.texi | 2 +-
libavfilter/vf_libvmaf.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/filters.texi b/doc/filters.texi
index d8cd45066a..610cb09a8c 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -12870,7
> On 24 Aug 2020, at 09:30, Tomas Härdin wrote:
>
> tor 2020-08-20 klockan 14:58 +0100 skrev Harry Mallon:
>> MXF CDCI color range was being set to (1<component_depth) - 1
>> for full range but it should be (1<component_depth) is 0 is
>> a valid value.
>
> On 23 Aug 2020, at 23:33, Mark Thompson wrote:
>
> ---
> Setting HDR properties is a useful feature, but it's very unclear what we
> want it to actually look like to the user. Not all encoders and decoders
> support it, so it's essentially required that the implementation happen at
> the
Described in Annex B SMPTE ST 2067-21:2020
Signed-off-by: Harry Mallon
---
libavformat/mxfenc.c | 56
1 file changed, 56 insertions(+)
diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
index e495b5ba0e..fe1ecb6705 100644
--- a/libavformat
* As embedded by Apple Compressor
Signed-off-by: Harry Mallon
---
libavformat/mxfdec.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
index a7a1e74a0a..58a11384b4 100644
--- a/libavformat/mxfdec.c
+++ b/libavformat
Described in Annex B SMPTE ST 2067-21:2020
Signed-off-by: Harry Mallon
---
libavformat/mxfdec.c | 70
1 file changed, 70 insertions(+)
diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
index 6f6e8d586c..a7a1e74a0a 100644
--- a/libavformat
> On 12 Aug 2020, at 21:58, Vittorio Giovara wrote:
>
> On Wed, Aug 12, 2020 at 6:40 PM Mohammad Izadi wrote:
>
>> Vittorio,
>>
>> What is the next step for me?
>>
>> Thanks,
>> Mohammad
>>
>
> Hi, I don't have any more comments for the patch, except that it would be
> nice if there were
58 matches
Mail list logo