Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: add option to hide vsync warnings

2018-06-27 Thread Gyan Doshi
On 27-06-2018 05:13 PM, Michael Niedermayer wrote: It was intended IIRC to detect cases where the code misbeahves or where the input/demuxer/parser is badly broken as in: timestamps: 1 2 4 5 7 9 durations: 9 8 1 -3 7 99 Maybe the condition to display the warning is faulty It can

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: fix -stream_loop with multiple inputs

2018-06-27 Thread Gyan Doshi
On 28-06-2018 02:35 AM, Marton Balint wrote: The input thread need to be properly cleaned up and re-initalized before we can start reading again in threaded mode. (threaded input reading is used when there are mode than one input file). Commit message should reference tickets 6121 and 7043.

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: add option to hide vsync warnings

2018-06-27 Thread Gyan Doshi
On 27-06-2018 11:30 PM, Marton Balint wrote: If we don't know why it spams the console or nobody is willing to fix it, then decrease loglevel to verbose. Will do this instead. Thanks, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org htt

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: add option to hide vsync warnings

2018-06-28 Thread Gyan Doshi
Alt patch attached. Plan to push tonight. From 07987404a8b7346e1904501b88320c9bab353298 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Thu, 28 Jun 2018 14:05:31 +0530 Subject: [PATCH] ffmpeg: make loglevel verbose for frame duration warning --- fftools/ffmpeg.c | 2 +- 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: add option to hide vsync warnings

2018-06-28 Thread Gyan Doshi
On 28-06-2018 02:13 PM, Gyan Doshi wrote: Alt patch attached. Plan to push tonight. Pushed in 07987404a8b7346e1904501b88320c9bab353298. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: check sseof value and clash with ss

2018-06-28 Thread Gyan Doshi
On 29-06-2018 01:58 AM, Morten With wrote: av_log(NULL, AV_LOG_WARNING, "-sseof value seeks to before start of file %s; ignored\n", filename); should be an AV_LOG_ERROR and an exit_program(1) afterwards. The warning is very high up and on a file with lots of info you will probably miss it and

Re: [FFmpeg-devel] [PATCH] doc/filters: add documentation to all existing OpenCL filters, except tonemap filter

2018-07-02 Thread Gyan Doshi
On 03-07-2018 08:20 AM, Danil Iashchenko wrote: Add documentation to all existing OpenCL filters, except tonemap filter. Why not for tonemap_opencl? +@section avgblur_opencl + +Apply average blur filter. + +Works like existing @ref{avgblur} filter. Since these filters are distinct, please

Re: [FFmpeg-devel] [FFmpeg-cvslog] Adds ESPCN super resolution filter merged with SRCNN filter.

2018-07-03 Thread Gyan Doshi
On 03-07-2018 12:49 AM, Jean-Baptiste Kempf wrote: On Mon, 2 Jul 2018, at 20:52, Pedro Arthur wrote: This code is not open source, and is not compatible with LGPLv2.1: "If you use/adapt our code in your work (either as a stand-alone tool or as a component of any algorithm), you need to ap

Re: [FFmpeg-devel] [PATCH v7 3/3] lavc, doc, configure: add avs2 video decoder wrapper

2018-07-04 Thread Gyan Doshi
On 05-07-2018 10:42 AM, hwren wrote: + +libdavs2 uses GPLv2, so you may also need to add @code{--enable-gpl} while configuring. Is it permissible to link against GPLv3 ffmpeg build? If yes, please change above line to what x264 section currently has. Thanks, Gyan

[FFmpeg-devel] [PATCH] avfilter/setpts: add FR shorthand for FRAME_RATE

2018-07-05 Thread Gyan Doshi
From 5012a823d34cecaac2bc19ef60062e6eedcdda6e Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Thu, 5 Jul 2018 15:24:55 +0530 Subject: [PATCH] avfilter/setpts: add FR shorthand for FRAME_RATE --- doc/filters.texi | 2 +- libavfilter/setpts.c | 5 - 2 files changed, 5 insertions(+), 2

[FFmpeg-devel] [PATCH] fate: allow temp files for passed test to be kept

2018-07-06 Thread Gyan Doshi
From 18351747e460d52939d54bdf20364e4156852034 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Fri, 6 Jul 2018 14:53:33 +0530 Subject: [PATCH] fate: allow temp files for passed test to be kept Set make variable KEEP to non-zero value to preserve temp files when a test has passed. Helpful in

Re: [FFmpeg-devel] [PATCH] avfilter/setpts: add FR shorthand for FRAME_RATE

2018-07-06 Thread Gyan Doshi
Plan to push tonight if no objections. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/setpts: add FR shorthand for FRAME_RATE

2018-07-07 Thread Gyan Doshi
On 07-07-2018 11:03 AM, Gyan Doshi wrote: Plan to push tonight if no objections. Pushed as c71e1e60305669c225c696dd99f6db5dc550a56a ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avformat/movenc: write track data in minf->hdlr for MOV

2018-07-08 Thread Gyan Doshi
From 13c0956d4892fd236e2923e88ef8d4fb0de1e080 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sun, 8 Jul 2018 12:05:34 +0530 Subject: [PATCH] avformat/movenc: write track data in minf->hdlr for MOV 95 FATE references updated due to changed track handler names Fixes #7104 --- libavfor

Re: [FFmpeg-devel] [PATCH] fate: allow temp files for passed test to be kept

2018-07-08 Thread Gyan Doshi
Ping. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fate: allow temp files for passed test to be kept

2018-07-08 Thread Gyan Doshi
On 08-07-2018 11:27 PM, Gyan Doshi wrote: Ping. Will push tonight if no objections. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fate: allow temp files for passed test to be kept

2018-07-09 Thread Gyan Doshi
On 09-07-2018 10:06 AM, Gyan Doshi wrote: Will push tonight if no objections. Pushed as 0bd48ab2d9e463b75ef52c0eaa0cc00c4c385cce ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avfilter/drawtext: fix box sizing

2018-07-10 Thread Gyan Doshi
Test command: ffplay -f lavfi -i "color,\ drawtext=fontfile='arial.ttf':fontcolor=white:fontsize=H/5:\ text='A string of characters':\ box=1:boxcolor=green:boxborderw=5:\ x='w-w*t/5':y=-th+h*t/10" From b98969d12b3f6959ab1a036f20ba649951bcd1ea Mon Sep 17 0

Re: [FFmpeg-devel] [PATCH] fate: allow temp files for passed test to be kept

2018-07-10 Thread Gyan Doshi
On 10-07-2018 05:40 PM, Carl Eugen Hoyos wrote: Shouldn't this be -1 for keep if fail, 0 for always delete, 1 for keep? $keep is checked only when $err = 0 i.e. a) passed test or b) failed test and GEN != no In the 2nd case, since user has decided to overwrite existing ref, I assume the a

Re: [FFmpeg-devel] [PATCH] avformat/movenc: write track data in minf->hdlr for MOV

2018-07-10 Thread Gyan Doshi
Plan to push in a day if no objections. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] doc/filters: add documentation to all existing OpenCL filters, except tonemap filter

2018-07-11 Thread Gyan Doshi
On 12-07-2018 04:33 AM, Mark Thompson wrote: I'm not sure I'm completely in favour of that change, anyway? The section feels more coherent to me as "OpenCL versions of other filters" rather than "all filters using OpenCL" - program_opencl/openclsrc do something really quite different. Does

Re: [FFmpeg-devel] mistake in patch "Add lensfun filter"

2018-07-12 Thread Gyan Doshi
On 12-07-2018 02:45 PM, Stephen Seo wrote: I have already added some lines in configure to not compile the filter unless --enable-version3 is also specified to configure, but thanks for checking. Just to be clear - the library is LGPL3 and your filter is meant to be GPL3. Regards, Gyan __

Re: [FFmpeg-devel] mistake in patch "Add lensfun filter"

2018-07-12 Thread Gyan Doshi
On 12-07-2018 03:59 PM, Stephen Seo wrote: Yes, because it also uses a lanczos resampling implementation based on the one that exists in Lenstool, which is in the Lensfun repository and that is GPL3 while Lensfun itself is LGPL3. Correct me if I'm wrong, but I think that because of this the fi

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: fix box sizing

2018-07-12 Thread Gyan Doshi
On 10-07-2018 03:31 PM, Gyan Doshi wrote: Test command: ffplay -f lavfi -i "color,\ drawtext=fontfile='arial.ttf':fontcolor=white:fontsize=H/5:\ text='A string of characters':\ box=1:boxcolor=green:boxborderw=5:\ x='w-w*t/5':y=-th+h*t/10" Pushed as

Re: [FFmpeg-devel] [PATCH][GSOC] avfilter: added colorconstancy

2018-07-13 Thread Gyan Doshi
On 13-07-2018 02:44 PM, Mina wrote:   This patch introduces Grey-Edge algorithm as part of the Color Constancy Filter project in GSOC. Docs missing. Regards, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/li

[FFmpeg-devel] [PATCH] avformat/mov: only set handler_name from mdia->hdlr

2018-07-14 Thread Gyan Doshi
From 125c35cb08ece825dade33b9dc7bf7babe1fc46d Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sat, 14 Jul 2018 13:59:51 +0530 Subject: [PATCH] avformat/mov: only set handler_name from mdia->hdlr 6 FATE references updated. Fixes #7104 --- libavformat/mo

Re: [FFmpeg-devel] [PATCH] avformat/movenc: write track data in minf->hdlr for MOV

2018-07-14 Thread Gyan Doshi
On 10-07-2018 10:40 PM, Gyan Doshi wrote: Plan to push in a day if no objections. I checked some MOVs generated by Apple s/w like FCP or QT and saw that they don't set stream-specific handlers in minf. Correct way to convey handler name from input MOV to output MOV is by not upd

Re: [FFmpeg-devel] [PATCH v2][GSOC] avfilter: added colorconstancy

2018-07-14 Thread Gyan Doshi
On 15-07-2018 07:50 AM, Mina wrote: +A variation color constancy that estimates scene illumination via grey edge algorithm +and corrects the scene colors accordingly. "A variation color constancy filter which estimates ..." Maybe add a link to the algo paper in the next line: "Grey Edge al

Re: [FFmpeg-devel] [PATCH] avformat/mov: only set handler_name from mdia->hdlr

2018-07-16 Thread Gyan Doshi
Plan to push tonight. On 14-07-2018 02:15 PM, Gyan Doshi wrote: Date: Sat, 14 Jul 2018 13:59:51 +0530 Subject: [PATCH] avformat/mov: only set handler_name from mdia->hdlr 6 FATE references updated. Fixes #7104 ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] [PATCH v2] fate: add more vc2 encoder tests

2018-07-16 Thread Gyan Doshi
I'll likely be pushing a change to the MOV demuxer tonight which will change a tag, so you'll probably need to re-gen your refs. Regards, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/mov: only set handler_name from mdia->hdlr

2018-07-16 Thread Gyan Doshi
On 16-07-2018 03:34 PM, Gyan Doshi wrote: Plan to push tonight. On 14-07-2018 02:15 PM, Gyan Doshi wrote: Date: Sat, 14 Jul 2018 13:59:51 +0530 Subject: [PATCH] avformat/mov: only set handler_name from mdia->hdlr 6 FATE references updated. Fixes #7104 Pushed

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-07-16 Thread Gyan Doshi
On 17-07-2018 02:38 AM, Wang Cao wrote: I was thinking to output stats for each video/audio stream one line by another. It seems this would be a huge change to users who are not aware. Keeping the old file bitrate looks good to me. Can I extend this to output file bitrate for each output file?

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: remove reference to non-existent option

2018-07-17 Thread Gyan Doshi
The option still exists and is effective. See current line 3528 of fftool/ffmpeg_opt.c and the block at line 822 of fftool/ffmpeg_filter.c On 17-07-2018 03:06 PM, Moritz Barsnick wrote: The "-deinterlace" option was removed in 481575d255195c6c2f32e04686b94de984ae78d4, over five years ago. Re

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: remove reference to non-existent option

2018-07-17 Thread Gyan Doshi
On 17-07-2018 04:52 PM, Moritz Barsnick wrote: I guess it was undeprecated by making it work properly again, which is fair enough, as far as I'm concerned. Still, is it preferred to use a filter? Yes, the CLI option is global, so applies to all video streams. Most invocations I've seen of i

Re: [FFmpeg-devel] [RFC] Make the user help mailing lists subscription only

2018-07-18 Thread Gyan Doshi
On 18-07-2018 04:13 AM, Lou Logan wrote: I'm considering changing the ffmpeg-user and libav-user mailing lists to only accept messages from subscribed users. ffmpeg-devel would be excluded from this due to the higher familiarity of mailing lists with that audience. What's the volume of messa

Re: [FFmpeg-devel] [PATCH 1/2] docs/filters: add documentation to all existing OpenCL filters

2018-07-21 Thread Gyan Doshi
I'll review this within a couple of days. Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] doc/filters: update info about avgblur filter to make it more understandable

2018-07-21 Thread Gyan Doshi
On 20-07-2018 10:01 PM, Danil Iashchenko wrote: doc/filters: update info about avgblur filter to make it more understandable --- doc/filters.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 705d48e..e3005c3 100644 --- a/d

Re: [FFmpeg-devel] [PATCH 1/2] docs/filters: add documentation to all existing OpenCL filters

2018-07-23 Thread Gyan Doshi
On 20-07-2018 10:01 PM, Danil Iashchenko wrote: +@section avgblur_opencl + +Apply average blur filter. + +The filter accepts the following options: + +@table @option +@item sizeX +Set horizontal radius size. By default value is @code{1}. State range as well for all options, e.g. Range is

[FFmpeg-devel] [PATCH] download: remove dead link for Mac binaries

2018-07-23 Thread Gyan Doshi
From f57cec086a22300dbc12f6e998b2cf53d7a8e103 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Mon, 23 Jul 2018 19:33:57 +0530 Subject: [PATCH] download: remove dead link for Mac binaries ffmpegmac.net now leads to a parked page. --- src/download | 3 --- 1 file changed, 3 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] doc/formats: Add documentation for skip_estimate_duration_from_pts

2018-07-24 Thread Gyan Doshi
On 25-07-2018 04:19 AM, Michael Niedermayer wrote: + +@item skip_estimate_duration_from_pts @var{bool} (@emph{input}) +skip duration calculation from pts. The function this is in is only called for MPEG-PS or seekable MPEG-TS. We should note that. The comment above the function says it's on

Re: [FFmpeg-devel] [PATCH] doc/formats: Add documentation for skip_estimate_duration_from_pts

2018-07-25 Thread Gyan Doshi
On 26-07-2018 03:37 AM, Michael Niedermayer wrote: On Wed, Jul 25, 2018 at 10:13:58AM +0530, Gyan Doshi wrote: Wouldn't it be better to move this as a private option for those two demuxers? iam not sure, it could be used by others in the future too what do people prefer ? I have no

Re: [FFmpeg-devel] [PATCH] qt-faststart: Add mode for probing faststart-ness

2018-07-27 Thread Gyan Doshi
On 27-07-2018 07:36 PM, Tomas Härdin wrote: This is something the PeerTube guys need, and this seemed a straightforward enough approach. Feedback appreciated Not a patch review, just a note that one can do this with ffmpeg/ffprobe and basic *nix tools. To check for moof, ffmpeg -i i

Re: [FFmpeg-devel] [PATCH] qt-faststart: Add mode for probing faststart-ness

2018-07-27 Thread Gyan Doshi
On 28-07-2018 03:33 AM, Tomas Härdin wrote: woot! I didn't know the mov demuxer dumped such things. It is quite slow however, since it will scan through every leaf atom in the file. For example, running time ffmpeg -i input.mov -v 56 2>&1 | wc on a 1.5 GiB MP4 on an SSD takes: Use the subfil

Re: [FFmpeg-devel] [PATCH] doc/formats: Add documentation for skip_estimate_duration_from_pts

2018-07-29 Thread Gyan Doshi
On 26-07-2018 11:38 AM, Gyan Doshi wrote: On 26-07-2018 03:37 AM, Michael Niedermayer wrote: what do people prefer ? I have no real oppinion on where to put it as long as it is documented somewhere in the docs ... ... We can leave the possible shifting for later on, but let's ad

Re: [FFmpeg-devel] [PATCH] doc/formats: Add documentation for skip_estimate_duration_from_pts

2018-07-29 Thread Gyan Doshi
On 30-07-2018 04:37 AM, Michael Niedermayer wrote: I'll modify and push this tomorrow. sure, thx Pushed as 67fb9c75efec9f069fc57b3ed211a35c63c686e5 Thanks, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/lis

[FFmpeg-devel] [PATCH] avformat/avs: add descriptive name and url

2018-08-01 Thread Gyan Doshi
From c9118d4d64a661fddd431a7437994c31eafb32c6 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Thu, 2 Aug 2018 10:47:10 +0530 Subject: [PATCH] avformat/avs: add descriptive name and url AVS now more commonly refers to the Chinese AVS format. This demuxer processes video files for Creature Shock

Re: [FFmpeg-devel] [PATCH 1/2] docs/filters: add documentation to all existing OpenCL filters

2018-08-02 Thread Gyan Doshi
On 31-07-2018 08:44 PM, Danil Iashchenko wrote: This hinders overall progress on the documentation and filter implementation of my GSoC project and there is not much time left. I suggest putting it on the backburner for the moment and leaving it out until the next patch. OK. +@item -ini

Re: [FFmpeg-devel] [PATCH] avformat/avs: add descriptive name and url

2018-08-02 Thread Gyan Doshi
Pushed as c9118d4d64a661fddd431a7437994c31eafb32c6 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] docs/filters: add documentation to all existing OpenCL filters

2018-08-03 Thread Gyan Doshi
On 03-08-2018 08:46 PM, Danil Iashchenko wrote: +For most general-purpose filters, no conversion is required. + +In case a file contains an alpha channel supported by the format, then explicit conversion is a requirement. This is unclear. So, if the input's pixel format has alpha, we should

[FFmpeg-devel] [PATCH] avcodec/libaomenc: correct range for cpu-used

2018-08-04 Thread Gyan Doshi
Don't know if micro bump is needed. From 4078eb3627999632234eb84cb132ddc4c7c96583 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sun, 5 Aug 2018 11:33:45 +0530 Subject: [PATCH] avcodec/libaomenc: correct range for cpu-used Valid range is [0,8] as stated in aom.git:aom/aomcx.h Fixes

[FFmpeg-devel] [PATCH] ffmpeg: correct units for raw pts in -progress report

2018-08-05 Thread Gyan Doshi
From a45b0ade691816d8037c846f2b773d0ddab74cbe Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sun, 5 Aug 2018 12:34:21 +0530 Subject: [PATCH] ffmpeg: correct units for raw pts in -progress report PTS is in microseconds. Fixes #7345 --- fftools/ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH] ffmpeg: correct units for raw pts in -progress report

2018-08-05 Thread Gyan Doshi
On 05-08-2018 01:46 PM, Carl Eugen Hoyos wrote: av_bprintf(&buf_script, "out_time_ms=N/A\n"); If the patch is a good idea you should also change this line. Fixed locally. Will push soon, if nothing else. Thanks, Gyan ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: correct range for cpu-used

2018-08-05 Thread Gyan Doshi
On 05-08-2018 01:49 PM, Carl Eugen Hoyos wrote: Am 05.08.2018 um 08:09 schrieb Gyan Doshi : Don't know if micro bump is needed. You may (should) always bump micro when the behaviour changes, if this counts as a change is up to you (the options you remove didn’t work before afaiu).

Re: [FFmpeg-devel] [PATCH] ffmpeg: correct units for raw pts in -progress report

2018-08-05 Thread Gyan Doshi
On 05-08-2018 02:17 PM, Nicolas George wrote: Gyan Doshi (2018-08-05): Will push soon, if nothing else. Have you considered you may be breaking some user's scripts? Ah yes, Sorry, this is used for parsing. What protocol do you suggest for correcting this? Regards,

[FFmpeg-devel] [RFC] Maintain documentation for all components?

2018-08-05 Thread Gyan Doshi
Our documentation for demuxers/muxers/decoders/encoders is incomplete and only feature a few. I propose we cover all or, at least, many more of them. Thoughts? Thanks, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mai

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: correct range for cpu-used

2018-08-05 Thread Gyan Doshi
On 05-08-2018 02:12 PM, Gyan Doshi wrote: Will push soon, if nothing else. Pushed as 076b19660e7c9466d2d78ff9ae66b97ff2b6aa1e Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] ffmpeg: correct units for raw pts in -progress report

2018-08-05 Thread Gyan Doshi
On 05-08-2018 02:28 PM, Gyan Doshi wrote: Ah yes, Sorry, this is used for parsing. What protocol do you suggest for correcting this? Any thoughts on this? I see that there were two changes made to value fields of the progress report earlier this year - a194e9c4159 and 1322b00060 Regards

Re: [FFmpeg-devel] [PATCH] avs2: Correct expression error and simplify log

2018-08-06 Thread Gyan Doshi
On 06-08-2018 07:13 PM, hwren wrote: -.long_name = NULL_IF_CONFIG_SMALL("Decoder for AVS2/IEEE 1857.4"), +.long_name = NULL_IF_CONFIG_SMALL("Decoder for AVS2-P2/IEEE1857.4"), "Decoder for" is not needed. The flag indicates its role in `ffmpeg -codecs`. Rest docs LGTM T

Re: [FFmpeg-devel] [PATCH 1/7] libavfilter: Adds on the fly generation of default DNN models for tensorflow backend instead of storing binary model.

2018-08-06 Thread Gyan Doshi
On 06-08-2018 08:23 PM, Pedro Arthur wrote: I may push the patch with proposed changes by tomorrow. Please add an entry in docs/filter as well as one in docs/general for tf backend as applicable. Thanks, Gyan ___ ffmpeg-devel mailing list ffmpe

Re: [FFmpeg-devel] [PATCH] avs2: correct avs2 description

2018-08-07 Thread Gyan Doshi
On 08-08-2018 12:05 AM, James Almer wrote: Should be ok. Will push. Thanks, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avs2: correct avs2 description

2018-08-07 Thread Gyan Doshi
On 08-08-2018 12:08 AM, Gyan Doshi wrote: Will push. Thanks, Gyan Pushed as f563e7868fb9540e1c8a589558fba2beaaba01e0 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] ffmpeg: correct units for raw pts in -progress report

2018-08-07 Thread Gyan Doshi
On 06-08-2018 08:00 PM, Nicolas George wrote: Not really. I suppose you could add the field with the correct name and remove the bogus one later. But your thoughts on this are probably better than mine. That will just defer the breaking change. The options, as I see it, are wontfix, or pus

Re: [FFmpeg-devel] [PATCH] ffmpeg: correct units for raw pts in -progress report

2018-08-08 Thread Gyan Doshi
On 08-08-2018 12:47 AM, Nicolas George wrote: Gyan Doshi (2018-08-08): That will just defer the breaking change. That will leave people time to notice the change and allow old and new scripts to work during the transition. Will do it this way. Gyan

Re: [FFmpeg-devel] [PATCH] lavfi: update xbr filter url

2018-08-08 Thread Gyan Doshi
On 09-08-2018 01:19 AM, Mina wrote: This patch update the existing url with the newly found one. Will apply. Thanks, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavfi: update xbr filter url

2018-08-08 Thread Gyan Doshi
On 09-08-2018 10:31 AM, Gyan Doshi wrote: On 09-08-2018 01:19 AM, Mina wrote: This patch update the existing url with the newly found one. Will apply. Thanks, Gyan Pushed as e0539f0349e945793c11cd88c468d9a2f3fedce9 with modified/shortened commit msg. Gyan

[FFmpeg-devel] [PATCH] avformat: correct fdebug loglevel

2018-08-13 Thread Gyan Doshi
3e4b5e68c1 intended for fdebug to be usable without -v and cmdutils sets v to DEBUG but most fdebug logs are at TRACE. Changed. From 0b349a958d6af8ce09ef7d36a34e3f0d3f6b0692 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Mon, 13 Aug 2018 12:32:41 +0530 Subject: [PATCH] avformat: correct fdebug

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-13 Thread Gyan Doshi
On 14-08-2018 03:24 AM, Carl Eugen Hoyos wrote: Why does this not use -filter_threads? Didn't know it was an option. I can certainly change the code to use it. Please do it if it works. filter_threads applies to all simple filtergraphs. The private option is specifically targeted.

Re: [FFmpeg-devel] [PATCH] avformat: correct fdebug loglevel

2018-08-14 Thread Gyan Doshi
On 13-08-2018 12:52 PM, Gyan Doshi wrote: 3e4b5e68c1 intended for fdebug to be usable without -v and cmdutils sets v to DEBUG but most fdebug logs are at TRACE. Changed. Plan to push tonight. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-14 Thread Gyan Doshi
On 14-08-2018 01:20 PM, Paul B Mahol wrote: On 8/14/18, Gyan Doshi wrote: On 14-08-2018 03:24 AM, Carl Eugen Hoyos wrote: Why does this not use -filter_threads? Didn't know it was an option. I can certainly change the code to use it. Please do it if it works. filter_th

Re: [FFmpeg-devel] [PATCH] avformat: correct fdebug loglevel

2018-08-14 Thread Gyan Doshi
On 14-08-2018 12:58 PM, Gyan Doshi wrote: On 13-08-2018 12:52 PM, Gyan Doshi wrote: 3e4b5e68c1 intended for fdebug to be usable without -v and cmdutils sets v to DEBUG but most fdebug logs are at TRACE. Changed. Plan to push tonight. Pushed as 02741853d74d214540aca4cd456877348d4f8953

Re: [FFmpeg-devel] [PATCH 1/2] docs/filters: add documentation to all existing OpenCL filters

2018-08-14 Thread Gyan Doshi
Danil, On 04-08-2018 12:43 AM, Gyan Doshi wrote: On 03-08-2018 08:46 PM, Danil Iashchenko wrote: +For most general-purpose filters, no conversion is required. + +In case a file contains an alpha channel supported by the format, then explicit conversion is a requirement. This is unclear

Re: [FFmpeg-devel] [PATCH 1/2] doc/filters.texi: Adds documentation for sr filter.

2018-08-15 Thread Gyan Doshi
On 15-08-2018 10:05 PM, Sergey Lavrushkin wrote: Resending patch with documentation for sr filter. LGTM. Will apply with some small changes. I've merged the docs entry in the 2nd part, so remove it from there. Thanks, Gyan ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 1/2] doc/filters.texi: Adds documentation for sr filter.

2018-08-15 Thread Gyan Doshi
On 15-08-2018 11:28 PM, Sergey Lavrushkin wrote: 2018-08-15 19:59 GMT+03:00 Gyan Doshi : LGTM. Will apply with some small changes. I've merged the docs entry in the 2nd part, so remove it from there. This entry corresponds to changes made in the second patch. Without these changes

Re: [FFmpeg-devel] [PATCH 1/2] doc/filters.texi: Adds documentation for sr filter.

2018-08-15 Thread Gyan Doshi
On 15-08-2018 11:37 PM, James Almer wrote: Should have been the second patch in the set, in that case. If a change is split into two patches, one for code and one for documentation, then the former goes first. Gyan should have paid more attention to it as well, to be fair. I assumed he made

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-17 Thread Gyan Doshi
On 17-08-2018 06:12 PM, Carl Eugen Hoyos wrote: 2018-08-14 9:57 GMT+02:00, Gyan Doshi : filter_threads applies to all simple filtergraphs. The private option is specifically targeted. Isn't that better? I believe the opposite is true. Which - preference for private opti

Re: [FFmpeg-devel] [PATCH 1/2] docs/filters: add documentation to all existing OpenCL filters

2018-08-18 Thread Gyan Doshi
Hi Danil, Except overlay and the topic of format requirements, rest LGTM. On 15-08-2018 05:30 PM, Danil Iashchenko wrote: docs/filters: add documentation to all existing OpenCL filters Added general instruction for format conversion in the start of overall section and separatly for overlay

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-19 Thread Gyan Doshi
On 20-08-2018 03:17 AM, Carl Eugen Hoyos wrote: I believe that if a general option exists (as in this case), it is a bad idea to have a specifically targeted option that has to be used instead. The user may not want the thread pool to be available for any other threaded filters in the graph.

Re: [FFmpeg-devel] [PATCH v2] doc/filters: Add double-pass example for loudnorm

2018-08-19 Thread Gyan Doshi
On 20-08-2018 03:27 AM, Marvin Scholz wrote: +@example +$ ffmpeg -i input -map 0:a -af loudnorm=I=-23:TP=-1:print_format=summary -f null - + +[...] +Input Integrated: -9.0 LUFS +Input True Peak: +1.5 dBTP +Input LRA: 9.4 LU +Input Threshold: -19.5 LUFS +@end example + +

Re: [FFmpeg-devel] [PATCH 2/2] libavfilter: Removes stored DNN models. Adds support for native backend model file format in tf backend.

2018-08-20 Thread Gyan Doshi
On 20-08-2018 11:52 PM, Sergey Lavrushkin wrote: But there are some issues. First, to use this filter for formats with chroma channels I do: ffmpeg -i in.bmp -filter_complex 'extractplanes=y+u+v[y][u][v]' -map '[y]' y.bmp -map '[u]' u.bmp -map '[v]' v.bmp ffmpeg -i y.bmp -vf sr=dnn_backend=tens

Re: [FFmpeg-devel] [PATCH v3] doc/filters: Add double-pass example for loudnorm

2018-08-20 Thread Gyan Doshi
On 21-08-2018 03:18 AM, Marvin Scholz wrote: +@example +ffmpeg -i input -af loudnorm=I=-23:TP=-1:measured_I=-9.0:measured_TP=1.5:measured_LRA=9.4:measured_thresh=-19.5:print_format=summary output Since your input LRA is 9.4, and output LRA is 7 (default), the filter will upsample to 192 kH

Re: [FFmpeg-devel] [PATCH 2/2] libavfilter: Removes stored DNN models. Adds support for native backend model file format in tf backend.

2018-08-21 Thread Gyan Doshi
On 21-08-2018 10:27 PM, Pedro Arthur wrote: Something like, ffmpeg -i in.bmp -filter_complex 'format=yuvj444p,extractplanes=y+u+v[y][u][v]; [y]sr=dnn_backend=tensorflow:model=espcn.model[y-sr]; [u]scale=iw*2:-1[u2x];[v]scale=iw*2:-1[v2x];

Re: [FFmpeg-devel] [PATCH 2/2] libavfilter: Removes stored DNN models. Adds support for native backend model file format in tf backend.

2018-08-21 Thread Gyan Doshi
On 22-08-2018 01:32 AM, Pedro Arthur wrote: 2018-08-21 16:40 GMT-03:00 Gyan Doshi : Agreed. Can't the filter upscale the chroma planes internally? That's exactly what the filter were doing before, but for some reason doing it this way is not 'good code'. Well,

Re: [FFmpeg-devel] [PATCH v3] doc/filters: Add double-pass example for loudnorm

2018-08-21 Thread Gyan Doshi
On 22-08-2018 04:43 AM, Marvin Scholz wrote: +@example +ffmpeg -i input -af loudnorm=I=-23:TP=-1:measured_I=-9.0:measured_TP=1.5:measured_LRA=9.4:measured_thresh=-19.5:print_format=summary output Since your input LRA is 9.4, and output LRA is 7 (default), the filter will upsample to 192 k

Re: [FFmpeg-devel] [PATCH v3] doc/filters: Add double-pass example for loudnorm

2018-08-22 Thread Gyan Doshi
On 22-08-2018 02:38 PM, Marvin Scholz wrote: On 22 Aug 2018, at 6:40, Gyan Doshi wrote: On 22-08-2018 04:43 AM, Marvin Scholz wrote: +@example +ffmpeg -i input -af loudnorm=I=-23:TP=-1:measured_I=-9.0:measured_TP=1.5:measured_LRA=9.4:measured_thresh=-19.5:print_format=summary output

Re: [FFmpeg-devel] [PATCH v3] doc/filters: Add double-pass example for loudnorm

2018-08-22 Thread Gyan Doshi
On 22-08-2018 04:01 PM, Marvin Scholz wrote: Guessed Channel Layout for Input Stream #0.0 : stereo ...     Stream #0:0(ger): Audio: wmav2 (a[1][0][0] / 0x0161), 48000 Hz, stereo, fltp, 192 kb/s [Parsed_aresample_1 @ 0x7fb7c540d500] Cannot select channel layout for the link between filters

[FFmpeg-devel] [PATCH] avdevice/decklink_enc: print preroll and buffer size

2018-08-22 Thread Gyan Doshi
From f496d970d319ec3916a55e05b925f6b43763ebfa Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Wed, 22 Aug 2018 16:23:58 +0530 Subject: [PATCH] avdevice/decklink_enc: print preroll and buffer size Helpful in diagnosing latency issues. --- libavdevice/decklink_enc.cpp | 3 +++ 1 file changed, 3

[FFmpeg-devel] [PATCH] avformat/concatf: ignore trailing whitespaces

2021-12-07 Thread Gyan Doshi
The concatf protocol returns an opaque error on open if concatf list file contains trailing newlines. --- libavformat/concat.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/concat.c b/libavformat/concat.c index 2560811ff9..faeba2293a 100644 --- a/libavformat/concat.c +++ b/li

Re: [FFmpeg-devel] [PATCH] avformat/concatf: ignore trailing whitespaces

2021-12-07 Thread Gyan Doshi
On 2021-12-07 05:39 pm, James Almer wrote: On 12/7/2021 9:00 AM, Gyan Doshi wrote: The concatf protocol returns an opaque error on open if concatf list file contains trailing newlines. ---   libavformat/concat.c | 4   1 file changed, 4 insertions(+) diff --git a/libavformat/concat.c b

Re: [FFmpeg-devel] [PATCH 2/5] avfilter/af_astats: improve options descriptions

2021-12-09 Thread Gyan Doshi
On 2021-12-09 06:49 am, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/af_astats.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/af_astats.c b/libavfilter/af_astats.c index d0810b5..776a8aa 100644 --- a/lib

[FFmpeg-devel] [PATCH v2] avformat/mov: add option max_stts_delta

2021-12-20 Thread Gyan Doshi
Very high stts sample deltas may occasionally be intended but usually they are written in error or used to store a negative value for dts correction when treated as signed 32-bit integers. This option lets the user set an upper limit, beyond which the delta is clamped to 1. Values greater than th

[FFmpeg-devel] [PATCH] avformat/mov: abort reading truncated stts

2021-12-20 Thread Gyan Doshi
Avoids overreading the box and ingesting absurd values into stts_data --- Fixes prolonged demuxing for fuzzer-generated files in the loop added in patch for max_stts_delta libavformat/mov.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 2aed6

Re: [FFmpeg-devel] [PATCH] avformat/mov: abort reading truncated stts

2021-12-20 Thread Gyan Doshi
On 2021-12-21 01:27 am, Andreas Rheinhardt wrote: Gyan Doshi: Avoids overreading the box and ingesting absurd values into stts_data --- Fixes prolonged demuxing for fuzzer-generated files in the loop added in patch for max_stts_delta libavformat/mov.c | 5 + 1 file changed, 5

[FFmpeg-devel] [PATCH v2] avformat/mov: abort reading truncated stts

2021-12-20 Thread Gyan Doshi
Avoids overreading the box and ingesting absurd values into stts_data --- libavformat/mov.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 2aed6e80ef..5a7209837f 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2935,6 +2935,11 @@ stat

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: abort reading truncated stts

2021-12-20 Thread Gyan Doshi
On 2021-12-21 02:18 am, Andreas Rheinhardt wrote: Gyan Doshi: Avoids overreading the box and ingesting absurd values into stts_data --- libavformat/mov.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 2aed6e80ef..5a7209837f 100644

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: abort reading truncated stts

2021-12-20 Thread Gyan Doshi
On 2021-12-21 02:24 am, Andreas Rheinhardt wrote: Gyan Doshi: On 2021-12-21 02:18 am, Andreas Rheinhardt wrote: Gyan Doshi: Avoids overreading the box and ingesting absurd values into stts_data ---   libavformat/mov.c | 5 +   1 file changed, 5 insertions(+) diff --git a/libavformat

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: abort reading truncated stts

2021-12-20 Thread Gyan Doshi
On 2021-12-21 03:06 am, Michael Niedermayer wrote: On Mon, Dec 20, 2021 at 10:21:53PM +0100, Michael Niedermayer wrote: On Tue, Dec 21, 2021 at 02:31:33AM +0530, Gyan Doshi wrote: On 2021-12-21 02:24 am, Andreas Rheinhardt wrote: Gyan Doshi: On 2021-12-21 02:18 am, Andreas Rheinhardt

[FFmpeg-devel] [PATCH 1/2] avformat/mov: add validate_box_size

2021-12-22 Thread Gyan Doshi
Helper function to check if stored box size is correct and looks to be fully available. --- libavformat/mov.c | 32 1 file changed, 32 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 2aed6e80ef..2cc9e699de 100644 --- a/libavformat/mov.c +++

[FFmpeg-devel] [PATCH 2/2] avformat/mov: validate box size for stts

2021-12-22 Thread Gyan Doshi
--- libavformat/mov.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 2cc9e699de..59ee7ed2a9 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2967,6 +2967,12 @@ static int mov_read_stts(MOVContext *c, AVIOContext *pb, MOVAtom atom)

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: abort reading truncated stts

2021-12-22 Thread Gyan Doshi
Patch superseded by new patch using helper function. On 2021-12-21 10:20 am, Gyan Doshi wrote: On 2021-12-21 03:06 am, Michael Niedermayer wrote: On Mon, Dec 20, 2021 at 10:21:53PM +0100, Michael Niedermayer wrote: On Tue, Dec 21, 2021 at 02:31:33AM +0530, Gyan Doshi wrote: On 2021-12-21

[FFmpeg-devel] [PATCH v2 1/2] avformat/mov: add validate_box_size

2021-12-22 Thread Gyan Doshi
Helper function to check if stored box size is correct and looks to be fully available. --- libavformat/mov.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 2aed6e80ef..7de95b7ab0 100644 --- a/libavformat/mov.c ++

<    4   5   6   7   8   9   10   11   12   13   >