Re: [FFmpeg-devel] [PATCH] avutils/hwcontext_qsv: set the source device in qsv_device_create

2021-02-22 Thread Guangxin Xu
On Mon, Feb 22, 2021 at 5:17 PM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Xu > > Guangxin > > Sent: Monday, February 22, 2021 9:45 AM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Xu Guangxin > > Subject: [FFmpeg-devel] [PATCH] avutils/hwcontext_qsv: set

Re: [FFmpeg-devel] [PATCH] avutils/hwcontext_qsv: set the source device in qsv_device_create

2021-03-04 Thread Guangxin Xu
On Tue, Feb 23, 2021 at 9:34 AM Guangxin Xu wrote: > > > On Mon, Feb 22, 2021 at 5:17 PM Soft Works wrote: > >> >> >> > -Original Message- >> > From: ffmpeg-devel On Behalf Of Xu >> > Guangxin >> > Sent: Monday, February 2

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevcdec: fix stat_coeff save/load for persistent_rice_adaptation_enabled_flag

2020-09-08 Thread Guangxin Xu
Hi Mickaël & all, any suggestions? On Sat, Aug 29, 2020 at 1:52 PM Xu Guangxin wrote: > It's required by 9.3.1. following clips have this feature: > > WPP_HIGH_TP_444_8BIT_RExt_Apple_2.bit > Bitdepth_A_RExt_Sony_1.bin > Bitdepth_B_RExt_Sony_1.bin > EXTPREC_HIGHTHROUGHPUT_444_16_INTRA_10BIT_RExt_

Re: [FFmpeg-devel] [PATCH] examples/decode_video: flush parser to fix missing frame

2020-09-08 Thread Guangxin Xu
On Tue, Aug 18, 2020 at 8:05 PM wrote: > From: Zhao Zhili > > To reproduce, run decode_video with a single frame sample. No frame > was decoded before the patch. > --- > doc/examples/decode_video.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/doc/example

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_remove_side_data()

2020-09-08 Thread Guangxin Xu
On Wed, Sep 9, 2020 at 6:36 AM James Almer wrote: > This helper removes a side data entry from the packet, maintaining the > integrity and order of the remaining entries, if any. > > Signed-off-by: James Almer > --- > Missing APIChanges entry and version bump. > > Couldn't find a place in the tr

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_remove_side_data()

2020-09-09 Thread Guangxin Xu
On Wed, Sep 9, 2020 at 6:59 AM James Almer wrote: > On 9/8/2020 7:42 PM, Andreas Rheinhardt wrote: > > James Almer: > >> This helper removes a side data entry from the packet, maintaining the > >> integrity and order of the remaining entries, if any. > >> > >> Signed-off-by: James Almer > >> ---

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/hevcdec: sync User Data Unregistered SEI buffers across threads

2020-09-17 Thread Guangxin Xu
On Thu, Sep 17, 2020 at 9:35 PM James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/hevcdec.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c > index 1f3ea54d39..2481730788 100644 > --- a/libavcodec/hevcdec

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/hevcdec: sync User Data Unregistered SEI buffers across threads

2020-09-17 Thread Guangxin Xu
On Thu, Sep 17, 2020 at 11:09 PM James Almer wrote: > On 9/17/2020 10:59 AM, Guangxin Xu wrote: > > On Thu, Sep 17, 2020 at 9:35 PM James Almer wrote: > > > >> Signed-off-by: James Almer > >> --- > >> libavcodec/hevcdec.c | 19 +

Re: [FFmpeg-devel] [PATCH] avcodec/svq1dec: use av_malloc_array() to allocate pmv

2020-09-17 Thread Guangxin Xu
On Thu, Sep 17, 2020 at 10:00 PM Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/svq1dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/svq1dec.c b/libavcodec/svq1dec.c > index 25bd3d0253..ddd02f354e 100644 > --- a/libavcodec/svq1dec.c

Re: [FFmpeg-devel] [PATCH v2 0/7] HEVC native support for Screen content coding

2020-10-02 Thread Guangxin Xu
On Tue, Sep 29, 2020 at 10:03 PM Mark Thompson wrote: > On 10/09/2020 07:42, Haihao Xiang wrote: > > Resend Linjie's patchset with the updates. > > > > As a part of the support for VA-API HEVC SCC decoding (gen12, Tiger > > Lake+). > > > > The full support could be accessed in: > > https://github

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support CODECS Attribute in hevc EXT-X-STREAM-INF

2020-10-12 Thread Guangxin Xu
On Mon, Oct 12, 2020 at 5:18 PM Steven Liu wrote: > fix ticket: 8904 > parse the SPS from extradata and get profile_tier_level > write the profile_tier_level info into CODECS Attribute > > reference to : > https://developer.apple.com/documentation/http_live_streaming/hls_authoring_specification_f

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support CODECS Attribute in hevc EXT-X-STREAM-INF

2020-10-12 Thread Guangxin Xu
On Mon, Oct 12, 2020 at 9:57 PM Steven Liu wrote: > > > > 在 2020年10月12日,21:45,Guangxin Xu 写道: > > > > > > > > On Mon, Oct 12, 2020 at 5:18 PM Steven Liu wrote: > > fix ticket: 8904 > > parse the SPS from extradata and get profile_tier_level &

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: constrained intra predict, do not check top left IS_INTRA if it's not available

2020-10-26 Thread Guangxin Xu
The bug reporter confirmed the fix. https://trac.ffmpeg.org/ticket/8932 ping for review and merge. thanks On Fri, Oct 16, 2020 at 9:57 PM Xu Guangxin wrote: > fix ticket: 8932 > > For poc 2, we have tile boundary at x = 640. > When we predict cu(640,912),the top left pixel is not avaliable to t

Re: [FFmpeg-devel] [PATCH v2] avcodec/hevcdec: fix stat_coeff save/load for persistent_rice_adaptation_enabled_flag

2020-11-14 Thread Guangxin Xu
Hi Christophe, Thanks for the test. You are right, It's a wpp decode issue. Please help review it again. I have test it with make fate-hevc THREADS=12 THREAD_TYPE=slice make fate-hevc THREADS=12 make fate-hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2 THREADS=12 THREAD_TYPE=slice thanks On

Re: [FFmpeg-devel] [PATCH v2] fate/hevc-conformance: add clip for persistent_rice_adaptation_enabled_flag

2020-11-19 Thread Guangxin Xu
Hi folks, Could you help upload the bits file in https://www.itu.int/wftp3/av-arch/jctvc-site/bitstream_exchange/draft_conformance/RExt/WPP_HIGH_TP_444_8BIT_RExt_Apple_2.zip ? it's required by https://patchwork.ffmpeg.org/project/ffmpeg/patch/20201115023622.17605-1-oddst...@gmail.com and https://pa

Re: [FFmpeg-devel] [PATCH v2] fate/hevc-conformance: add clip for persistent_rice_adaptation_enabled_flag

2020-11-21 Thread Guangxin Xu
ping. On Thu, Nov 19, 2020 at 11:01 PM Guangxin Xu wrote: > Hi folks, > Could you help upload the bits file in > https://www.itu.int/wftp3/av-arch/jctvc-site/bitstream_exchange/draft_conformance/RExt/WPP_HIGH_TP_444_8BIT_RExt_Apple_2.zip > ? > it's required by > https

Re: [FFmpeg-devel] [PATCH] avcodec/dxva2_av1: use correct grain parameters with update_grain = 0

2020-11-24 Thread Guangxin Xu
Hi Hendrik, two related questions: 1. Seems it's a generic code. Could we handle this in the av1dec.c? 2. For the current code, what's happened if frame A ref to B, B ref to C. and both A, B has update_grain == 0. thanks On Tue, Nov 24, 2020 at 4:42 AM James Almer wrote: > On 11/23/2020 8:38

Re: [FFmpeg-devel] [PATCH] avcodec/dxva2_av1: use correct grain parameters with update_grain = 0

2020-11-25 Thread Guangxin Xu
benefit from this. On Thu, Nov 26, 2020 at 3:05 AM James Almer wrote: > On 11/24/2020 5:59 AM, Guangxin Xu wrote: > > Hi Hendrik, > > two related questions: > > 1. Seems it's a generic code. Could we handle this in the av1dec.c? > > 2. For the current code, what&#

Re: [FFmpeg-devel] [PATCH 2/2] qsvdec_av1: add an option to disable film grain

2020-11-26 Thread Guangxin Xu
Hi Haihao, Hold on a moment, Let me send another related refact patch set. :) On Thu, Nov 26, 2020 at 1:30 PM Haihao Xiang wrote: > User may use '-disable_film_grain 1' to disable film grain. > --- > libavcodec/qsvdec.c | 5 + > libavcodec/qsvdec.h | 2 ++ > libavcodec/qsvdec_

Re: [FFmpeg-devel] [PATCH] avcodec/dxva2_av1: use correct grain parameters with update_grain = 0

2020-11-27 Thread Guangxin Xu
On Thu, Nov 26, 2020 at 9:05 PM James Almer wrote: > On 11/26/2020 2:34 AM, Guangxin Xu wrote: > > spec did not forbid this. > > Here is da1vd code: > > https://code.videolan.org/videolan/dav1d/-/blob/master/src/obu.c#L1057 > > If update_grain == 0, it will co

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/qsvdec_other: refact, use DEFINE_QSV_DECODER to remove duplicate code

2020-12-01 Thread Guangxin Xu
Hi Mark & Zong, Any suggestion on this? thanks On Thu, Nov 26, 2020 at 6:21 PM Xu Guangxin wrote: > --- > libavcodec/qsvdec_other.c | 188 -- > 1 file changed, 36 insertions(+), 152 deletions(-) > > diff --git a/libavcodec/qsvdec_other.c b/libavcodec/qsvdec_o

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/qsvdec_other: refact, use DEFINE_QSV_DECODER to remove duplicate code

2020-12-01 Thread Guangxin Xu
Hi Haihao, If you check the final code. The QSVOtherContext and QSVH2645Context will be unified to QSVDecContext. It's no need to pass the priv_data_size. In the final version, we have two macros DEFINE_QSV_DECODER_WITH_OPTION for h265 only. Maybe av1 can use it for film grain too. DEFINE_QSV_DECO

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/qsvdec: refact, move qsvdec_h2645.c to qsvdec.c

2020-12-01 Thread Guangxin Xu
Hi Haihao, Thanks for the review. This patch just moves all code from qsvdec_h2645.c to qsvdec.c. The original code in qsvdec_h2645.c did not free the point, so the code will not free it. The av_freep(&s->qsv.load_plugins); will addressed by https://patchwork.ffmpeg.org/project/ffmpeg/patch/2020112

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/qsvdec_other: refact, use DEFINE_QSV_DECODER to remove duplicate code

2020-12-02 Thread Guangxin Xu
Hi Haihao, Thanks for the review. Hi Mark & Zong, Are we good to go? thanks On Wed, Dec 2, 2020 at 1:52 PM Xiang, Haihao wrote: > > > Hi Haihao, > > If you check the final code. The QSVOtherContext and QSVH2645Context will > > be unified to QSVDecContext. It's no need to pass the priv_data_siz

Re: [FFmpeg-devel] [PATCH v2] fate/hevc-conformance: add clip for persistent_rice_adaptation_enabled_flag

2020-12-14 Thread Guangxin Xu
Hi Lingjie thanks for the review. The stream has the feature but not used. the decoded yuv's md5 is 3c94b5ebc0aed0abae4e619b9dcca9cc it's matched with the WPP_HIGH_TP_444_8BIT_RExt_Apple_2.md5 thanks On Thu, Dec 10, 2020 at 6:14 PM Linjie Fu wrote: > Hi Guangxin, > > On Sun, Nov 15, 2020 at 11

Re: [FFmpeg-devel] [PATCH v2] fate/hevc-conformance: add clip for persistent_rice_adaptation_enabled_flag

2021-01-04 Thread Guangxin Xu
Awesome, thanks! On Mon, Jan 4, 2021 at 11:45 PM Linjie Fu wrote: > On Fri, Jan 1, 2021 at 9:39 PM Linjie Fu > wrote: > > > > On Mon, Dec 14, 2020 at 5:49 PM Guangxin Xu wrote: > > > > > > Hi Lingjie > > > thanks for the review. > > > Th

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/qsvdec_other: refact, use DEFINE_QSV_DECODER to remove duplicate code

2021-01-04 Thread Guangxin Xu
Hi Linjie, thanks for the review. On Sat, Jan 2, 2021 at 11:29 AM Linjie Fu wrote: > Guangxin: > > On Thu, Nov 26, 2020 at 6:21 PM Xu Guangxin wrote: > > > > --- > > libavcodec/qsvdec_other.c | 188 -- > > 1 file changed, 36 insertions(+), 152 deletions(-) >

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/qsvdec: refact, remove duplicate code for plugin loading

2021-01-16 Thread Guangxin Xu
Hi Lingjie, thanks for the comment. We can use codec id to do special things for a specific codec. Just like qsv_decode_init. thanks On Sat, Jan 16, 2021 at 3:22 PM Linjie Fu wrote: > Guangxin: > > On Tue, Jan 5, 2021 at 10:44 AM Xu Guangxin wrote: > > > > --- > > libavcodec/qsvdec.c | 29 ++

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec/qsv_h2645: fix memory leak for plugin load

2021-01-29 Thread Guangxin Xu
Hi Anton, Haihao If this is the case, we allocated the string in caller, free and reallocate it in callee. It's not a good practice. 1. It will make the user confused, The original qsvdec_other.c author and I are both confused about this. https://github.com/FFmpeg/FFmpeg/blob/399c1f923574234e899be

Re: [FFmpeg-devel] [PATCH v2] avformat/mpegtsenc: support DVB 6A descriptor for AC-3

2020-08-15 Thread Guangxin Xu
On Sat, Aug 15, 2020 at 10:28 PM wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > configure | 2 +- > libavformat/mpegts.h| 16 ++ > libavformat/mpegtsenc.c | 84 > +++-- > 3 files changed, 99 insertions(+),

Re: [FFmpeg-devel] [PATCH] avformat/av1dec: inline obu_read_data() and obu_prefetch() into obu_get_packet()

2020-08-15 Thread Guangxin Xu
On Fri, Aug 14, 2020 at 10:30 PM James Almer wrote: > They don't really help making the demuxer more readable. > > Signed-off-by: James Almer > --- > libavformat/av1dec.c | 56 +--- > 1 file changed, 21 insertions(+), 35 deletions(-) > Good improvment, LG

Re: [FFmpeg-devel] [PATCH] avcodec/ff_mpv_encode_end: fix a crash for null s->avctx

2020-08-25 Thread Guangxin Xu
Hi James, thanks for the review. We can't assume s->avctx == avctx. in https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/smvjpegdec.c, it will be assigned to a new allocated codec context. Currently, it's no mpeg video encoder doing this, but in the future, some subclass maybe. On Tue, Aug 2

Re: [FFmpeg-devel] [PATCH] avcodec/ff_mpv_encode_end: fix a crash for null s->avctx

2020-08-30 Thread Guangxin Xu
thanks, James and Michael. Are we ready to merge this? thanks On Wed, Aug 26, 2020 at 5:51 AM Michael Niedermayer wrote: > On Tue, Aug 25, 2020 at 11:37:59AM -0300, James Almer wrote: > > On 8/25/2020 6:35 AM, Xu Guangxin wrote: > > > Steps to reproduce: > > > 1. ./configure --enable-debug=3 --d