[FFmpeg-devel] [PATCH] Make Immersive Audio Model optional for MOV demuxing

2024-03-27 Thread Eugene Zemtsov via ffmpeg-devel
From: Eugene Zemtsov Signed-off-by: Eugene Zemtsov --- libavformat/mov.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index c55778f3ef..662301bf67 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -839,6 +839,7

Re: [FFmpeg-devel] [PATCH] Make Immersive Audio Model optional for MOV demuxing

2024-03-27 Thread Eugene Zemtsov via ffmpeg-devel
ables iamfdec by default for mov demuxer, but I had a feeling that maintainers will be less inclined to accept it and that's why I split it from this one. I will still try to send it if this patch is accepted. On Wed, Mar 27, 2024 at 4:59 PM James Almer wrote: > > On 3/27/2024 8:55 PM

[FFmpeg-devel] [PATCH] mov demuxer: Check if a key is longer than the atom containing it

2024-04-01 Thread Eugene Zemtsov via ffmpeg-devel
From: Eugene Zemtsov Stop reading keys and return AVERROR_INVALIDDATA if key_size is larger than the amount of space left in the atom. Bug: https://crbug.com/41496983 Signed-off-by: Eugene Zemtsov --- libavformat/mov.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib

Re: [FFmpeg-devel] [PATCH] mov demuxer: Check if a key is longer than the atom containing it

2024-04-01 Thread Eugene Zemtsov via ffmpeg-devel
Thanks for the comments. I got rid of bytes_left_in_atom. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "uns

[FFmpeg-devel] [PATCH] mov demuxer: Check if a key is longer than the atom containing it

2024-04-01 Thread Eugene Zemtsov via ffmpeg-devel
From: Eugene Zemtsov Stop reading keys and return AVERROR_INVALIDDATA if key_size is larger than the amount of space left in the atom. Bug: https://crbug.com/41496983 Signed-off-by: Eugene Zemtsov --- libavformat/mov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libav

Re: [FFmpeg-devel] [PATCH] Make Immersive Audio Model optional for MOV demuxing

2024-04-02 Thread Eugene Zemtsov via ffmpeg-devel
muxer, > but I had a feeling that maintainers will be less inclined to accept > it and that's why I split it from this one. > I will still try to send it if this patch is accepted. > > > On Wed, Mar 27, 2024 at 4:59 PM James Almer wrote: > > > > On 3/27/2024 8:55 P

[FFmpeg-devel] [PATCH] configure: Separate subsystem for Immersive Audio Model

2024-04-02 Thread Eugene Zemtsov via ffmpeg-devel
From: Eugene Zemtsov This change allows users to link ffmpeg as a library without support for Immersive Audio Model by specifying --disable-iamf. It helps to save on binary size in cases where it's important. Signed-off-by: Eugene Zemtsov --- configure | 7 ++- libavformat/mov.c |

[FFmpeg-devel] [PATCH] Fix incorrect enum type used for a local variable

2024-10-24 Thread Eugene Zemtsov via ffmpeg-devel
From: Eugene Zemtsov It's AVPacketSideDataType, not AVFrameSideDataType. Bug: https://issues.chromium.org/issues/374797732 Change-Id: If75702c6d639ca63827cc3370477de00544d3c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/third_party/ffmpeg/+/5950926 Reviewed-by: Ted (Chromiu

Re: [FFmpeg-devel] [PATCH] Fix crash when trying to get a fragment time for a non-existing fragment

2024-11-05 Thread Eugene Zemtsov via ffmpeg-devel
Any feedback? On Thu, Oct 24, 2024 at 6:54 PM wrote: > From: Eugene Zemtsov > > Bug: https://issues.chromium.org/issues/372994341 > Change-Id: I695d625717c078ed6f84f44e58c34da858af4d3b > Reviewed-on: > https://chromium-review.googlesource.com/c/chromium/third_party/ffmpeg/+/5958151 > Reviewed-b

Re: [FFmpeg-devel] [PATCH] Fix incorrect enum type used for a local variable

2024-11-05 Thread Eugene Zemtsov via ffmpeg-devel
Any feedback? On Thu, Oct 24, 2024 at 6:52 PM wrote: > From: Eugene Zemtsov > > It's AVPacketSideDataType, not AVFrameSideDataType. > > Bug: https://issues.chromium.org/issues/374797732 > Change-Id: If75702c6d639ca63827cc3370477de00544d3c0f > Reviewed-on: > https://chromium-review.googlesource.

Re: [FFmpeg-devel] [PATCH] Fix incorrect enum type used for a local variable

2024-11-08 Thread Eugene Zemtsov via ffmpeg-devel
In order to reproduce the problem you need to compile with warnings as errors and "enum-conversion" warning enabled. This is the what clang complains about: ../../third_party/ffmpeg/libavcodec/decode.c:1469:60: error: implicit conversion from enumeration type 'const enum AVPacketSideDataType' to d

[FFmpeg-devel] [PATCH] Fix crash when trying to get a fragment time for a non-existing fragment

2024-10-24 Thread Eugene Zemtsov via ffmpeg-devel
From: Eugene Zemtsov Bug: https://issues.chromium.org/issues/372994341 Change-Id: I695d625717c078ed6f84f44e58c34da858af4d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/third_party/ffmpeg/+/5958151 Reviewed-by: Dale Curtis --- libavformat/mov.c | 2 ++ 1 file changed, 2 ins