[FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-21 Thread Disha Singh
Qualification task for project TrueHD encoder. There are two patches. One has the changes made to other files to support mlpenc.c and the other only has mlpenc.c. Also attached is the diff file of mlpenc.c. (Modified the file : https://github.com/ramiropolla/soc/blob/master/mlp/mlpenc.c) diff --git

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-23 Thread Disha Singh
This is the modified diff with few changes in mlp_encode_frame function. -Disha On Tue, Mar 22, 2016 at 1:59 AM, Disha Singh wrote: > Qualification task for project TrueHD encoder. > There are two patches. > One has the changes made to other files to support mlpenc.c and the other &

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-26 Thread Disha Singh
This is the revised patch created using git format-patch. -Disha On Thu, Mar 24, 2016 at 2:45 PM, Paul B Mahol wrote: > On 3/21/16, Disha Singh wrote: > > Qualification task for project TrueHD encoder. > > There are two patches. > > One has the changes made to other file

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-26 Thread Disha Singh
Just running ./patcheck would do? On Sun, Mar 27, 2016 at 12:50 AM, Lou Logan wrote: > On Sat, 26 Mar 2016 22:18:47 +0530, Disha Singh wrote: > > > From 639aa2a07be6064049b2ba1e134e1474cb7f0806 Mon Sep 17 00:00:00 2001 > > From: dinux5 > > Date: Sat, 26 Mar 2016 22

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-26 Thread Disha Singh
> testing this > ./ffmpeg -i in.m4a test.mlp > says it needs 'To use it anyways, you must set "-strict inofficial".' > thats ok if it would work: > > ./ffmpeg -i in.m4a -strict inofficial test.mlp > [mlp @ 0x2494740] Unable to parse option value "inofficial" > > Using :ffmpeg -i ~/input.mp3 -stric

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-28 Thread Disha Singh
at 4:49 AM, Michael Niedermayer wrote: > On Sun, Mar 27, 2016 at 11:01:11AM +0530, Disha Singh wrote: > > > testing this > > > ./ffmpeg -i in.m4a test.mlp > > > says it needs 'To use it anyways, you must set "-strict inofficial".' > > >

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-28 Thread Disha Singh
To correct that : the error is in line 214 in lpc.c not lpc.h On Tue, Mar 29, 2016 at 3:13 AM, Disha Singh wrote: > What is lpc ? Which lpc type (there are many in libavcodec/lpc.h)should be > used for mlp ? Also, please tell lpc_passes and precision and max_order > value to be spec

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-03-29 Thread Disha Singh
The most recent patch has been attached. The lpc error persists. I have removed some patcheck errors. -Disha On Tue, Mar 29, 2016 at 6:24 AM, Michael Niedermayer wrote: > On Tue, Mar 29, 2016 at 03:13:50AM +0530, Disha Singh wrote: > > What is lpc ? > > linear predictive codin

Re: [FFmpeg-devel] [PATCH]Addition of MLP encoder

2016-04-01 Thread Disha Singh
does not show this error? On Wed, Mar 30, 2016 at 8:04 AM, Michael Niedermayer wrote: > On Wed, Mar 30, 2016 at 06:38:33AM +0530, Disha Singh wrote: > > The most recent patch has been attached. The lpc error persists. > > I have removed some

[FFmpeg-devel] [Patch]Qualification task for TrueHD encoder

2016-04-04 Thread Disha Singh
This patch has an lpc issue, and needs some work with passing of parameters in ff_lpc_calc_coeff(), which my mentor said he would help with. Thanks! -Disha From 9ab9819c2e2bb0759944a69204918fad10102ef1 Mon Sep 17 00:00:00 2001 From: dinux5 Date: Mon, 4 Apr 2016 08:41:56 +0530 Subject: [PATCH] ML

Re: [FFmpeg-devel] [Patch]Qualification task for TrueHD encoder

2016-04-05 Thread Disha Singh
> there are the following build warnings, please fix them > > libavcodec/mlpenc.c: In function ‘mlp_encode_init’: > libavcodec/mlpenc.c:585:5: warning: ‘coded_frame’ is deprecated (declared > at libavcodec/avcodec.h:2967) [-Wdeprecated-declarations] > libavcodec/mlpenc.c: In function ‘mlp_encode_fr