Re: [FFmpeg-devel] [PATCH] avfilter: properly reduce YUV colorspace format lists

2024-03-27 Thread Damiano Galassi
On Mon, Mar 25, 2024 at 4:10 PM Niklas Haas wrote: > From: Niklas Haas > > Doing this with REDUCE_FORMATS() instead of swap_color_*() is not only > shorter, but more importantly comes with the benefit of being done > inside a loop, allowing us to correctly propagate complex graphs > involving mu

[FFmpeg-devel] [PATCH] avfilter: propagate colorspace and color_range from buffer filter and between AVFilterLink.

2024-03-22 Thread Damiano Galassi
There two new fields were never sent down the filter chain, and no filter after the first had colorspace and color_range set, causing breakage in zscale and possible other filters. --- libavfilter/avfilter.c | 4 libavfilter/buffersrc.c | 2 ++ 2 files changed, 6 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH] avfilter: propagate colorspace and color_range from buffer filter and between AVFilterLink.

2024-03-23 Thread Damiano Galassi
On Sat, Mar 23, 2024 at 1:11 PM Niklas Haas wrote: > On Fri, 22 Mar 2024 22:02:39 +0100 Damiano Galassi > wrote: > > There two new fields were never sent down the filter chain, and no > filter after the first had colorspace and color_range set, causing breakage > in zscale

[FFmpeg-devel] [PATCH v2] avfilter: propagate colorspace and color_range from buffer filter and between AVFilterLink.

2024-03-24 Thread Damiano Galassi
There two new fields were never sent down the filter chain, and no filter after the first had colorspace and color_range set, causing breakage in zscale and possible other filters. --- libavfilter/avfilter.c | 4 libavfilter/buffersrc.c | 2 ++ 2 files changed, 6 insertions(+) diff --git a/

Re: [FFmpeg-devel] [PATCH v2] avfilter: propagate colorspace and color_range from buffer filter and between AVFilterLink.

2024-03-24 Thread Damiano Galassi
On Sun, Mar 24, 2024 at 2:14 PM Niklas Haas wrote: > On Sun, 24 Mar 2024 13:49:04 +0100 Damiano Galassi > wrote: > > AVFilterLink colorspace and color_range are first set in > > avfiltergraph.c pick_format(), > > so in ff_filter_config_links() they will ne

Re: [FFmpeg-devel] [PATCH v2] avfilter: propagate colorspace and color_range from buffer filter and between AVFilterLink.

2024-03-24 Thread Damiano Galassi
On Sun, Mar 24, 2024 at 6:53 PM Niklas Haas wrote: > But wait - aren't all filter's lists set to the same reference? Isn't that > the > point of the design? If they share the same format list, they will all > inherit the correct setting (via pick_format). Except for filters like > vf_scale which

Re: [FFmpeg-devel] [PATCH v2] avfilter: propagate colorspace and color_range from buffer filter and between AVFilterLink.

2024-03-25 Thread Damiano Galassi
On Mon, Mar 25, 2024 at 2:40 PM Niklas Haas wrote: > > ffmpeg -i in.mp4 -vf > > "scale='width=1920:height=1080',zscale='width=1920:height=1080'" out.mp4 > > ffmpeg -i in.jpg -vf "zscale='width=1920:height=1080'" out.jpg > > > > it doesn't need a specific mp4 or jpg file. > > I cannot reproduce an

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec: add ambient viewing environment packet side data.

2023-08-17 Thread Damiano Galassi
Ping ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/2] avcodec: add ambient viewing environment packet side data.

2023-07-11 Thread Damiano Galassi
--- fftools/ffprobe.c | 3 +++ libavcodec/avpacket.c | 1 + libavcodec/decode.c | 1 + libavcodec/packet.h | 7 +++ 4 files changed, 12 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 1ff76ce809..9f17567897 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c

[FFmpeg-devel] [PATCH 2/2] avformat/mov: add support for 'amve' ambient viewing environment box. As defined in ISOBMFF (ISO/IEC 14496-12) document.

2023-07-11 Thread Damiano Galassi
--- libavformat/dump.c | 15 +++ libavformat/isom.h | 2 ++ libavformat/mov.c| 36 libavformat/movenc.c | 22 ++ 4 files changed, 75 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index d31e4c2ec6..e

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: add support for 'amve' ambient viewing environment box. As defined in ISOBMFF (ISO/IEC 14496-12) document.

2023-07-15 Thread Damiano Galassi
On Tue, Jul 11, 2023 at 6:53 PM James Almer wrote: > On 7/11/2023 4:41 AM, Damiano Galassi wrote: > > AVDictionaryEntry *encoder; > > @@ -2430,6 +2451,7 @@ static int mov_write_video_tag(AVFormatContext *s, > AVIOContext *pb, MOVMuxContex > > if (track-&g

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add ambient viewing environment packet side data.

2023-07-15 Thread Damiano Galassi
On Tue, Jul 11, 2023 at 6:45 PM Anton Khirnov wrote: > A FATE test would be much appreciated. > Is there some documentation on how to write a FATE test? I've got a small sample (2 bytes) ready, but I am not too sure how to write the test. ___ ffmpeg-de

[FFmpeg-devel] [PATCH v2 1/2] avcodec: add ambient viewing environment packet side data.

2023-07-15 Thread Damiano Galassi
--- fftools/ffprobe.c | 3 +++ libavcodec/avpacket.c | 1 + libavcodec/decode.c | 1 + libavcodec/packet.h | 7 +++ 4 files changed, 12 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 1ff76ce809..9f17567897 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c

[FFmpeg-devel] [PATCH v2 2/2] avformat/mov: add support for 'amve' ambient viewing environment box. As defined in ISOBMFF (ISO/IEC 14496-12) document.

2023-07-15 Thread Damiano Galassi
--- libavformat/dump.c | 15 +++ libavformat/isom.h | 3 +++ libavformat/mov.c| 36 libavformat/movenc.c | 22 ++ 4 files changed, 76 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index d31e4c2ec6..

[FFmpeg-devel] [PATCH] avcodec/amfenc: properly set primaries, transfer, and matrix values

2024-10-19 Thread Damiano Galassi
HEVC and AV1 encoders had hard-coded color values for 8-bit and 10-bit depths, and they were completely disregarding the provided values. --- libavcodec/amfenc.c | 109 +++ libavcodec/amfenc.h | 2 + libavcodec/amfenc_av1.c | 16 +++--- libavcodec/

Re: [FFmpeg-devel] Patch for libx265 memory leak

2024-11-11 Thread Damiano Galassi
On Tue, Nov 12, 2024 at 3:38 AM Zhao Zhili wrote: > > cleanup() release library static allocations, and I don’t see lock or > reference count > within x265_cleanup(). So call cleanup() will break other x265 encoder > instance, > right? x265 already crashes when trying to run two encodes with di

[FFmpeg-devel] [PATCH] avformat/mov: read and write additional iTunes style metadata

2025-02-12 Thread Damiano Galassi
--- libavformat/mov.c | 67 +++- libavformat/movenc.c| 69 +++-- tests/ref/fate/caf-alac-remux | 5 ++- tests/ref/fate/cover-art-flac-remux | 5 ++- tests/ref/fate/matroska-alac-remux | 5 ++- tests/ref/fat