1) The crash is caused by accessing un-allocated memory area.
2) You can't compute the contrast outside of search window (by default,
rx=ry=16).
From: ffmpeg-devel on behalf of Michael
Niedermayer
Sent: September 21, 2018 3:24 PM
To: FFmpeg development discuss
---
libavcodec/v4l2_m2m_enc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/v4l2_m2m_enc.c b/libavcodec/v4l2_m2m_enc.c
index 474e6bef89..17fc3d30cf 100644
--- a/libavcodec/v4l2_m2m_enc.c
+++ b/libavcodec/v4l2_m2m_enc.c
@@ -312,6 +312,7 @@ static av_cold int v4l2_encode_init(AVCode
- Add a function to handle the base URL Processing described in section 5.6.5
of IEC_23009-1.
- Fix for downloading content with byte range selection
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index f63f1ff..19ef6f8 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
diff --git a/doc/examples/Makefile b/doc/examples/Makefile
index 58afd71..bff4af6 100644
--- a/doc/examples/Makefile
+++ b/doc/examples/Makefile
@@ -1,3 +1,16 @@
+# use pkg-config for getting CFLAGS and LDLIBS
+FFMPEG_LIBS=libavdevice\
+libavformat
Please ignore the previous "patch" email.
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 0e3afd2..68196e9 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -522,6 +522,22 @@ static enum AVMediaType get_content_type(xmlNodePtr node)
return type;
}
+static
- Add a function to handle the base URL Processing described in section 5.6.5
of IEC_23009-1.
- Fix for downloading dash content with byte range info
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 0e3afd2..0be8a49 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.
es
Subject: Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)
2017-11-15 3:54 GMT+01:00 Colin NG :
> - Add a function to handle the base URL Processing described in section 5.6.5
> of IEC_23009-1.
>
> - Fix for downloading dash content with byte range info
As
range info
2017-11-15 10:26 GMT+08:00 Colin NG :
> Please ignore the previous "patch" email.
>
>
>
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
&g
info
2017-11-15 22:00 GMT+01:00 Colin NG :
> This patch is partial fix for ticket 6658 (Dash demuxer segfault).
> +static struct fragment * get_Fragment(char *range) {
> +struct fragment * seg = av_mallocz(sizeof(struct fragment));
Please make it (code-style):
... fragment *get
---
libavformat/dashdec.c | 32 +---
1 file changed, 25 insertions(+), 7 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 0e3afd2..33255f2 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -522,6 +522,22 @@ static enum AVMed
Excluded the fix for byte range issue and update some coding style issues.
From: Colin NG
Sent: November 15, 2017 10:58 AM
To: FFmpeg development discussions and patches
Subject: Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)
Have
, 2017 at 08:33:35PM +, Colin NG wrote:
> ---
> libavformat/dashdec.c | 32 +---
> 1 file changed, 25 insertions(+), 7 deletions(-)
>
> diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
> index 0e3afd2..33255f2 100644
> --- a/libavfor
---
libavformat/dashdec.c | 39 +--
1 file changed, 33 insertions(+), 6 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 0e3afd2..671ae9d 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -522,6 +522,25 @@ static enu
Colin NG :
> Excluded the fix for byte range issue and update some coding style issues.
> +if (pb) av_freep(pb);
The if() should be unnecessary.
Please avoid adding empty lines in unrelated parts of the file
and while there, try to fix "if (condition) {" to "if (condition)
---
libavformat/dashdec.c | 38 --
1 file changed, 32 insertions(+), 6 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 0e3afd2..3798649 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -522,6 +522,24 @@ static enum
Add NULL pointer check for incoming audio data.
diff --git a/libavcodec/opus_pvq.c b/libavcodec/opus_pvq.c
index f98b85d..f1dbc5d 100644
--- a/libavcodec/opus_pvq.c
+++ b/libavcodec/opus_pvq.c
@@ -504,6 +504,9 @@ static av_always_inline uint32_t
quant_band_template(CeltPVQ *pvq, CeltFrame *f,
---
Fix for ticket 7674
libavcodec/opus_pvq.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/libavcodec/opus_pvq.c b/libavcodec/opus_pvq.c
index f98b85d..02ccd69 100644
--- a/libavcodec/opus_pvq.c
+++ b/libavcodec/opus_pvq.c
@@ -504,6 +504,9 @@ static av_alw
Clean up coding style.
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 3798649..7e7ae52 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -148,6 +148,11 @@ static uint64_t get_current_time_in_sec(void)
return av_gettime() / 100;
}
+static char *ishttp(c
development discussions and patches
Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/opus: Add NULL pointer check for
incoming data; avoid segfault
On 23 November 2017 at 00:53, Colin NG wrote:
> ---
> Fix for ticket 7674
>
> libavcodec/opus_pvq.c | 16 +---
> 1 file changed
---
libavformat/dashdec.c | 95 ---
1 file changed, 82 insertions(+), 13 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 3798649..5d5970e 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -148,6 +148,11
---
fftools/ffprobe.c | 5 +
libavcodec/decode.c | 5 -
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index 0e7a771..20b64ef 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -2276,10 +2276,14 @@ static av_always_inline int pr
---
fftools/ffprobe.c | 2 ++
libavcodec/dvbsubdec.c | 10 +-
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index 0e7a771..6ddd81e 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -2280,6 +2280,7 @@ static av_always_inli
---
fftools/ffprobe.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index 0e7a771..6ddd81e 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -2280,6 +2280,7 @@ static av_always_inline int process_frame(WriterContext
*w,
break;
---
libavcodec/dvbsubdec.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c
index a657b1d..29997a2 100644
--- a/libavcodec/dvbsubdec.c
+++ b/libavcodec/dvbsubdec.c
@@ -1596,7 +1596,7 @@ static int dvbsub_display_end_segm
---
libavformat/dashdec.c | 112 --
1 file changed, 99 insertions(+), 13 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 3798649..d04bec0 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -148,6 +148,11
From: ffmpeg-devel on behalf of Steven Liu
Sent: December 4, 2017 4:52 AM
To: FFmpeg development discussions and patches
Subject: Re: [FFmpeg-devel] [PATCH] libavformat/dashdec: Fix for ticket 6658
(Dash demuxer segfault)
2017-12-04 12:28 GMT+08:00 Colin NG
---
libavformat/dashdec.c | 111 --
1 file changed, 98 insertions(+), 13 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 3798649..6e35e91 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -148,6 +148,11
---
libavformat/dashdec.c | 116 --
1 file changed, 103 insertions(+), 13 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 3798649..cdb9f67 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -148,6 +148,11
---
libavformat/dashdec.c | 110 --
1 file changed, 97 insertions(+), 13 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 3798649..6574e56 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -148,6 +148,11
- Add function 'resolve_content_path' to propagate the baseURL from upper level
nodes.
* if no baseURL is available, the path of mpd file will be set as the baseURL.
- Remove checking for newly established connection.
- Establish the communication protocol in each connection rather than applying
- simplify the code to check common init section
---
libavformat/dashdec.c | 48 +++-
1 file changed, 11 insertions(+), 37 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index c6f350d..acaa1bf 100644
--- a/libavformat/dashdec.c
- Add NULL pointer check for init_section
---
libavformat/dashdec.c | 30 +++---
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 42202e0..c6f350d 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.
- Add function 'resolve_content_path' to propagate the baseURL from upper level
nodes.
* if no baseURL is available, the path of mpd file will be set as the baseURL.
- Remove checking for newly established connection.
- Establish the communication protocol in each connection rather than applying
---
libavformat/dashdec.c | 87 +--
1 file changed, 56 insertions(+), 31 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 5345f91..7316213 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -141,6 +141,7 @
at 10:50:07PM +, Colin NG wrote:
> ---
> libavformat/dashdec.c | 87
> +--
> 1 file changed, 56 insertions(+), 31 deletions(-)
applying: libavformat/dashdec: Fix for ticket 6856 (filename limited to 1024)
error: sha1 information i
---
libavformat/dashdec.c | 36 ++--
1 file changed, 30 insertions(+), 6 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 2492f1d..67a92d6 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -550,6 +550,23 @@ static enum A
- Add function 'resolve_content_path' to propagate the baseURL from upper level
nodes.
* if no baseURL is available, the path of mpd file will be set as the baseURL.
- Remove checking for newly established connection.
- Establish the communication protocol in each connection rather than applying
---
libavformat/dashdec.c | 88 +--
1 file changed, 58 insertions(+), 30 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 1d520d4..9d5986d 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -147,6 +147,7 @
Believe the comment is related to the 3rd patch. The update version is attached.
From: 刘歧
Sent: January 16, 2018 10:39 PM
To: FFmpeg development discussions and patches
Cc: 刘歧; Colin NG
Subject: Re: [FFmpeg-devel] [PATCH 2/3] libavformat/dashdec: Fix for ticket
How about having different memory location for init_section of each
presentation?
rep_dest->init_section = (struct fragment *) av_mallocz(sizeof(struct
fragment));
From: ffmpeg-devel on behalf of Carl Eugen
Hoyos
Sent: July 31, 2018 6:06 PM
To: FFmpeg d
---
libavformat/dashdec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 09b06ef..fa784f1 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -1040,7 +1040,6 @@ end:
xmlFree(rep_bandwidth_val);
---
libavformat/dashdec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 09b06ef..5730252 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -1879,7 +1879,6 @@ static int is_common_init_section_exist(struct
representation **pl
---
libavformat/dashdec.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 5730252..310dc20 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -1764,6 +1764,12 @@ static int reopen_demux_for_component(AVFormatContext
*s,
43 matches
Mail list logo
