Quick question as a user that is not entirely related to this patch, would
it be possible to add something like a `ffmpeg ... -libaom-params help -f
null -` or someother way that would print out the options available in the
compiled libaom? (In the case where we do not have aomenc compiled or it's
From: Christopher Degawa
Equivalent to the --lp option for SvtAv1EncApp, and is the only way
to control how much cpu power svt-av1 uses for now
Not using thread_count as it would be preferable to reserve that until
svt-av1 properly implements a threads option
0 == getconf _NPROCESSORS_ONLN
From: Christopher Degawa
Equivalent to the --lp option for SvtAv1EncApp, and is the only way
to control how much cpu power svt-av1 uses for now
Not using thread_count as it would be preferable to reserve that until
svt-av1 properly implements a threads option
0 == getconf _NPROCESSORS_ONLN
>
> It is very non-obvious what "lp" means, "logical_processors" would be
> better IMO.
>
Okay, I will change it to `-logical_processors`
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscri
Based on my limited understanding of the code, it's limiting the usage
using pthread_setaffinity_np and CPU_SET on Linux to limit the process to
certain CPUs, but it also has a default and max of the return of
`sysconf(_SC_NPROCESSORS_ONLN)`. According to Hassene Tmar of SVT-AV1, it
is a "target co
>
> That said, if you have a general use-case where this is helpful and the
> documentation explains what it is doing (and warns about the bad cases)
> then maybe?
>
The main use case we have internally is to able to run multiple instances
of SvtAv1EncApp with `--lp 1` without worrying about poten
On Sun, Feb 14, 2021 at 12:27 PM Christopher Degawa
wrote:
> That said, if you have a general use-case where this is helpful and the
>> documentation explains what it is doing (and warns about the bad cases)
>> then maybe?
>>
>
> The main use case we have internally
>
> It does seem like the number correlates somehow with how much CPU it
> uses, but it's not an upper bound.
>
If it isn't, then that might be an issue, but the idea is that with the
logical_processor option you can limit the amount of ram a single encoder
instance will use since on a system wit
From: Christopher Degawa
Used for limiting the size of memory buffers and threads for a target
logical processor count, but does not set thread affinity or limit the
amount of threads used, although thread affinities can be controlled
with an additional parameters, it is prefered to add them
From: Christopher Degawa
Used for limiting the size of memory buffers and threads for a target
logical processor count, but does not set thread affinity or limit the
amount of threads used, although thread affinities can be controlled
with an additional parameters, it is prefered to add them
> Maybe I am reading this wrong or not understanding but this says it is
> used for limiting threads and then in the next sentence says it does
> not limit threads?
>
> It is quite confusing.
>
it's confusing for me too, but the idea is that it doesn't set n threads,
but it can be used to make it s
From: Christopher Degawa
Used for limiting the size of memory buffers and threads for a target
logical processor count, but does not set thread affinity or the total
amount of threads used, although thread affinities can be controlled
with an additional parameters, it is prefered to add them
> You should restrict the line length here, just for consistency with the
> rest of this document. (It doesn't affect the formatting of the output
> documents, obviously.)
>
What would be a good line length for the docs to aim for? 75?
> > +unsigned logical_processors;
>
> The libsvtav1 API d
libsvtav1 internally changed cqp to be crf while enable-tp-la is on,
which is on by default, and uses the same variables as cqp
Signed-off-by: Christopher Degawa
---
doc/encoders.texi | 14 +-
libavcodec/libsvtav1.c | 15 +--
2 files changed, 26 insertions(+), 3
From: Christopher Degawa
Used for limiting the size of memory buffers and threads for a target
logical processor count, but does not set thread affinity or the total
amount of threads used, although thread affinities can be controlled
with an additional parameters, it is prefered to add them
clang errors when compiling with C++11 about needing spaces between
literal and identifier
Signed-off-by: Christopher Degawa
---
libavutil/timer.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/timer.h b/libavutil/timer.h
index 0bb353cfce..737bfc160e 100644
--- a
On Sat, Mar 13, 2021 at 01:09 Chris Degawa wrote:
>
>
> > On Mar 13, 2021, at 00:57, Anton Khirnov wrote:
> >
> > Quoting Christopher Degawa (2021-03-13 05:20:37)
> >> clang errors when compiling with C++11 about needing spaces between
> >> literal an
ping on this patch
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
ping again, would rather not have to maintain this and the
logical_processor patch out of tree
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-
On Tue, Mar 30, 2021 at 4:53 PM Jan Ekström wrote:
> > @@ -218,6 +220,8 @@ static int
> config_enc_params(EbSvtAv1EncConfiguration *param,
> > param->tile_columns = svt_enc->tile_columns;
> > param->tile_rows= svt_enc->tile_rows;
> >
> > +param->logical_processors = svt_enc->log
From: Christopher Degawa
Used as a thread count multiplier with a max of the logical cores
available
Signed-off-by: Christopher Degawa
---
doc/encoders.texi | 3 +++
libavcodec/libsvtav1.c | 7 +++
2 files changed, 10 insertions(+)
diff --git a/doc/encoders.texi b/doc/encoders.texi
You might want to check your email client as it has added a bunch of
` ` which mangles your message when viewed
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or em
ping on this patch again
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
On Sat, Apr 10, 2021 at 3:07 PM Christopher Degawa
wrote:
> ping on this patch again
>
pong again
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
If you are talking about "[FFmpeg-devel] [PATCH] doc/ffmpeg: Fix bug
#8204", it seems the list has received it
On Sat, Feb 8, 2020 at 12:33 AM Gautam Ramakrishnan
wrote:
> Hello,
>
> I wish to contribute to ffmpeg and though of submitting a small patch
> to fix a bug listed on the bug tracker. H
ping.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
these fields are only available past svt-av1 0.8.7
Signed-off-by: Christopher Degawa
---
libavcodec/libsvtav1.c | 20
1 file changed, 20 insertions(+)
diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
index fabc4e6428..6c12777911 100644
--- a/libavcodec
On Thu, Jul 22, 2021 at 9:02 PM Christopher Degawa
wrote:
> these fields are only available past svt-av1 0.8.7
>
> Signed-off-by: Christopher Degawa
> ---
> libavcodec/libsvtav1.c | 20
> 1 file changed, 20 insertions(+)
>
> diff --git a/libavcodec/
On Fri, Jul 30, 2021 at 4:48 AM Jan Ekström wrote:
> On Fri, Jul 23, 2021 at 5:02 AM Christopher Degawa
> wrote:
> > +#ifndef SVTAV1_MAKE_VERSION
> > +#define SVTAV1_MAKE_VERSION(x,y,z) ((x) << 16 | (y) << 8 | z)
> > +#endif
> > +
>
On Sat, Mar 16, 2024 at 09:08 Gnattu OC via ffmpeg-devel <
ffmpeg-devel@ffmpeg.org> wrote:
> If you are using Xcode >= 15 then you will need to add `-Wl,-ld_classic`
> to LDFLAGS. During configure you will also need to set
> `--host-ldflags='-Wl,-ld_classic’`.
>
> > On Mar 16, 2024, at 09:04, Hel
ive-mpd-AV-NBS.mpd
-f null -
Signed-off-by: Christopher Degawa
---
libavformat/dashdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 99b9c45439..42ea74635b 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
> You should also reset c->adaptionset_lang to NULL after freeing it. (I
> remember finding this issue myself, but somehow forgot to fix it. Strange.)
Ah, I forgot that's what av_freep does in addition to freeing, do you
wish to make the change, or do you want me to?
> (Actually, the lifetime of
From: Christopher Degawa
compressed_ten_bit_format has been deprecated upstream and has no effect
and can be removed. Plus, technically it was never used in the first place
since it would require the app (ffmpeg) to set it and do additional
processing of the input frames.
Also simplify
From: Christopher Degawa
svt-av1 v1.2.0 has deprecated vbv_bufsize in favor of using
- maximum_buffer_size_ms (--buf-sz)
- starting_buffer_level_ms (--buf-initial-sz)
- optimal_buffer_level_ms (--buf-optimal-sz)
and vbv_bufsize has not been in use since svt-av1 v0.8.6
Signed-off-by
On Wed, Oct 19, 2022 at 7:00 PM James Almer wrote:
> On 10/19/2022 7:47 PM, Christopher Degawa wrote:
> > From: Christopher Degawa
> > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
> > index 28da206cf8..74dad9892b 100644
> > --- a/libavcodec/libsv
From: Christopher Degawa
compressed_ten_bit_format has been deprecated upstream and has no effect
and can be removed. Plus, technically it was never used in the first place
since it would require the app (ffmpeg) to set it and do additional
processing of the input frames.
Also simplify
From: Christopher Degawa
svt-av1 v1.2.0 has deprecated vbv_bufsize in favor of using
- maximum_buffer_size_ms (--buf-sz)
- starting_buffer_level_ms (--buf-initial-sz)
- optimal_buffer_level_ms (--buf-optimal-sz)
and vbv_bufsize has not been in use since svt-av1 v0.8.6
Signed-off-by
codec2.pc has been available since 2016, and I believe most distros
have it by now.
codec2-dev's commit:
https://github.com/drowe67/codec2-dev/commit/fdfda67436b5b7308cf0758d9192f1dd540d439d
Signed-off-by: Christopher Degawa
---
configure | 3 ++-
1 file changed, 2 insertions(+), 1 del
On Sun, Jul 21, 2024 at 12:03 AM Christopher Degawa
wrote:
> +enabled libcodec2 && { require_pkg_config libcodec2 codec2
> codec2.h codec2_create ||
> + require libcodec2 codec2/codec2.h
> codec2_create -lcodec2; }
>
I made a mista
codec2.pc has been available since 2016, and I believe most distros
have it by now.
codec2-dev's commit:
https://github.com/drowe67/codec2-dev/commit/fdfda67436b5b7308cf0758d9192f1dd540d439d
Signed-off-by: Christopher Degawa
---
configure | 3 ++-
1 file changed, 2 insertions(+), 1 del
On Thu, Oct 20, 2022 at 11:56 PM Christopher Degawa
wrote:
> From: Christopher Degawa
>
> compressed_ten_bit_format has been deprecated upstream and has no effect
> and can be removed. Plus, technically it was never used in the first place
> since it would require the app (ffmpeg
On Thu, Oct 27, 2022 at 11:23 AM Christopher Degawa
wrote:
>
>
> On Thu, Oct 20, 2022 at 11:56 PM Christopher Degawa
> wrote:
>
>> From: Christopher Degawa
>>
>> compressed_ten_bit_format has been deprecated upstream and has no effect
>> and can be remov
division by zero occurs if it's not specified
Signed-off-by: Christopher Degawa
---
libavcodec/libsvtav1.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
index 48cd58a0b3..06874dfa63 100644
--- a/libavcodec/libsvt
maximum_buffer_size_ms should only be set if both are specified or if
the user sets it through -svtav1-params buf-sz=val
Signed-off-by: Christopher Degawa
---
libavcodec/libsvtav1.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/libsvtav1.c b/libavcodec
On Tue, Nov 29, 2022 at 4:38 PM James Almer wrote:
> Stick to the library's default value instead.
>
> Should address AOMediaCodec/SVT-AV1 issue #2011.
>
> Signed-off-by: James Almer
> ---
> libavcodec/libsvtav1.c | 25 +++--
> 1 file changed, 15 insertions(+), 10 deletions(
ted: https://trac.ffmpeg.org/ticket/8903
Signed-off-by: Christopher Degawa
---
libavcodec/x86/cabac.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/x86/cabac.h b/libavcodec/x86/cabac.h
index b046a56a6b..70f990db8d 100644
--- a/libavcodec/x86/cabac.h
+++ b/liba
On Mon, Jan 2, 2023 at 5:36 PM Hendrik Leppkes wrote:
> On Tue, Jan 3, 2023 at 12:01 AM Christopher Degawa
> wrote:
> >
>
> I regularly build with 12.2 on win32 and its fine.
>
> In fact, there is a fate station for that:
>
> https://fate.ffmpeg.org/report.cgi?slo
On Tue, Jan 3, 2023 at 12:32 PM Christopher Degawa
wrote:
>
>
> On Mon, Jan 2, 2023 at 5:36 PM Hendrik Leppkes
> wrote:
>
>> On Tue, Jan 3, 2023 at 12:01 AM Christopher Degawa
>> wrote:
>> >
>>
>> I regularly build with 12.2 on win32 and its
On Tue, Jan 3, 2023 at 4:16 AM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> Christopher Degawa:
> > previouslly, it only was an issue with 32-bit clang from msys2's
> > mingw32 repo, however, at some point with an update to gcc 12.2.0,
> > the sam
On Tue, Jan 3, 2023 at 12:51 PM Christopher Degawa
wrote:
>
>
> On Tue, Jan 3, 2023 at 4:16 AM Andreas Rheinhardt <
> andreas.rheinha...@outlook.com> wrote:
>
>> Christopher Degawa:
>> > previouslly, it only was an issue with 32-bit clang from msys2's
>
> I used the devel list because I considered, and still consider this as
> a bug, and not a user "how-to" question.
>
My general rule of thumb I use whenever someone asks if they should post in
#ffmpeg or #ffmpeg-devel (irc) etc is to only ask on devel if you are
specifically hacking on ffmpeg a
I think this topic is more suited for the ffmpeg-user mailing list instead
of the devel mailing list
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-
mecode *tc, AVRational
frame_rate, BMDTimecodeFormat tc_format, IDeckLinkVideoInputFrame *videoFrame)
Signed-off-by: Christopher Degawa
---
libavdevice/decklink_dec.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp
index
I forgot to mark get_frame_timecode as static as well
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscr
> Considering that 1.4.0 was released 10 months ago, I wonder whether
> anyone compiled against a recent libsrt since then?
I can confirm that this fixes compilation errors with the latest
master branch of srt
https://github.com/Haivision/srt/commit/0e2201aff6b379979cec43fee5e8f162717f6346
and FFm
On Sat, Jul 18, 2020 at 9:24 AM myp...@gmail.com wrote:
>
> On Thu, Jul 16, 2020 at 9:35 AM myp...@gmail.com wrote:
> >
> > On Tue, Jul 14, 2020 at 9:47 PM Moritz Barsnick wrote:
> > >
> > > On Sun, Jul 12, 2020 at 22:44:46 +0800, myp...@gmail.com wrote:
> > > > Maybe I give an inaccurate descri
Doesn't break msys2 builds, so it's okay to me.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
This patch is needed to fix compilation on windows using the git
master branches of both glslang and ffmpeg, although I don't know what
version or commit of glslang started to require it, the earliest
record I have of this issue is july 5th.
___
ffmpeg-de
On Mon, Dec 20, 2021 at 3:31 PM Helmut K. C. Tessarek
wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> Hello,
>
> The following 2 commits break the build with a deployment target of 10.9 on
> macOS.
>
> I agree that 10.9 is quite old, but the rest of the code worked perfectly
> fine
On Mon, Dec 20, 2021 at 6:39 PM Aman Karmani wrote:
>
> Could you share the output of `xcrun metal -v`
>
>
xcrun metal -v
Apple LLVM version 31001.43 (metalfe-31001.43)
Target: air64-apple-darwin19.6.0
Thread model: posix
InstalledDir:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDe
On Mon, Dec 20, 2021 at 6:55 PM Aman Karmani wrote:
> On Mon, Dec 20, 2021 at 4:52 PM Helmut K. C. Tessarek <
> tessa...@evermeet.cx>
> wrote:
>
> > -BEGIN PGP SIGNED MESSAGE-
> > Hash: SHA512
> >
> >
> >
> > On 2021-12-20 19:38, Aman Karmani wrote:
> > > Could you share the output of `xc
On Mon, Dec 20, 2021 at 7:25 PM Aman Karmani wrote:
> On Mon, Dec 20, 2021 at 5:19 PM Christopher Degawa
> wrote:
>
> > On Mon, Dec 20, 2021 at 6:55 PM Aman Karmani wrote:
> >
> > > On Mon, Dec 20, 2021 at 4:52 PM Helmut K. C. Tessarek <
> &
On Mon, Dec 20, 2021 at 7:29 PM Ridley Combs wrote:
> The main thing that confuses me here is that this file does build for me
> when I use the iOS version of the metal compiler (tbh I didn't even know
> there was a difference between them).
>
> What Xcode and macOS version are you on?
>
system
On Mon, Dec 20, 2021 at 7:21 PM Aman Karmani wrote:
>
>
> On Mon, Dec 20, 2021 at 5:03 PM Helmut K. C. Tessarek <
> tessa...@evermeet.cx> wrote:
>
>> -BEGIN PGP SIGNED MESSAGE-
>> Hash: SHA512
>>
>> On 2021-12-20 19:11, Christopher Degawa w
On Mon, Dec 20, 2021 at 7:53 PM Aman Karmani wrote:
>
>
> On Mon, Dec 20, 2021 at 5:48 PM Christopher Degawa
> wrote:
>
>>
>>
>> On Mon, Dec 20, 2021 at 7:21 PM Aman Karmani wrote:
>>
>>>
>>>
>>> On Mon, Dec 20, 2021
On Tue, Dec 21, 2021 at 1:40 AM Ridley Combs wrote:
> Huh, TIL that the metal compiler doesn't exist without Xcode, but the
> metal framework does! Wacky. Anyway, this patch oughtta fix that (does more
> or less as you suggested); if this is all fine on your end, I'll go ahead
> and split this up
Fixes https://trac.ffmpeg.org/ticket/8903
relevant https://github.com/msys2/MINGW-packages/discussions/9258
Signed-off-by: Christopher Degawa
---
libavcodec/x86/cabac.h | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/libavcodec/x86/cabac.h b/libavcodec/x86/cabac.h
On Fri, Sep 17, 2021 at 9:28 PM wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
>
As a note, I personally favor this patch over mine since I don't think
`enable_tpl_la` is worth exposing to the user if its main role is to switch
between crf and cqp
__
On Sun, Sep 19, 2021 at 2:02 PM Christopher Degawa
wrote:
>
>
> On Fri, Sep 17, 2021 at 9:28 PM wrote:
>
>> From: Limin Wang
>>
>> Signed-off-by: Limin Wang
>>
> As a note, I personally favor this patch over mine since I don't think
> `enable_tp
match the behavior of SvtAv1EncApp to ensure pic_type is always set
before passing it to the library.
The other options for pic_type aren't currently used inside the library,
so they aren't introduced in this patch.
Signed-off-by: Christopher Degawa
---
libavcodec/libsvtav1.c | 5 +++
match the behavior of SvtAv1EncApp to ensure pic_type is always set
before passing it to the library.
The other options for pic_type aren't currently used inside the library,
so they aren't introduced in this patch.
Signed-off-by: Christopher Degawa
---
libavcodec/libsvt
sdl2 recently changed their versioning, moving the patch level to minor level
https://github.com/libsdl-org/SDL/commit/cd7c2f1de7d9e418bb554047d714dd7cacc020ff
trac: https://trac.ffmpeg.org/ticket/9768
Signed-off-by: Christopher Degawa
---
configure | 7 +++
1 file changed, 7 insertions
sdl2 recently changed their versioning, moving the patch level to minor level
https://github.com/libsdl-org/SDL/commit/cd7c2f1de7d9e418bb554047d714dd7cacc020ff
trac: https://trac.ffmpeg.org/ticket/9768
Signed-off-by: Christopher Degawa
---
configure | 7 +++
1 file changed, 7 insertions
sdl2 recently changed their versioning, moving the patch level to minor level
https://github.com/libsdl-org/SDL/commit/cd7c2f1de7d9e418bb554047d714dd7cacc020ff
and have said that they will instead ship sdl3.pc for 3.0.0
trac: https://trac.ffmpeg.org/ticket/9768
Signed-off-by: Christopher Degawa
On Thu, Jun 9, 2022 at 6:22 PM softworkz wrote:
> From: softworkz
>
> Signed-off-by: softworkz
> ---
> avformat/os_support: use windows stat structs with 64bit time_t
>
> Signed-off-by: softworkz softwo...@hotmail.com
>
>
>
Ping on this patch, this fixes an error with decklink due to cl
Currently, the -1 (MR) preset is disallowed as it's taken as the preset
option not set, and the only way to access it was through svtav1-params.
Signed-off-by: Christopher Degawa
---
libavcodec/libsvtav1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libav
76 matches
Mail list logo
