[FFmpeg-devel] [PATCH] libavdevice/lavfi.c: adjust subcc_packet->pts to be in 90 timebase

2016-09-30 Thread Chris Landry
From: Chris Landry When a video stream timebase is not 90k, the cc packet pts is relevant to the timebase of the video stream, but later is assumed to be 90k. Adjust it here to be 90k so timing is accurate in resulting subs. Signed-off-by: Chris Landry --- libavdevice/lavfi.c | 11

[FFmpeg-devel] [PATCH] libavdevice/lavfi.c: adjust subcc_packet->pts to correct timebase with av_rescale_q

2016-10-01 Thread Chris Landry
From: Chris Landry Should have used av_rescale_q to do the timebase adjustment. Fixed compiler warning for variable declaration. Signed-off-by: Chris Landry --- libavdevice/lavfi.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavdevice/lavfi.c b/libavdevice

Re: [FFmpeg-devel] [PATCH] libavdevice/lavfi.c: adjust subcc_packet->pts to correct timebase with av_rescale_q

2016-10-01 Thread Chris Landry
Sorry, this was supposed to be submitted in response to my thread on this one. New to sending email with git. On Sat, Oct 1, 2016 at 2:04 PM, Chris Landry wrote: > From: Chris Landry > > Should have used av_rescale_q to do the timebase adjustment. Fixed > compiler warning

[FFmpeg-devel] [PATCH] libavdevice/lavfi.c: adjust subcc_packet->pts to be in 90 timebase

2016-10-01 Thread Chris Landry
From: Chris Landry When a video stream timebase is not 90k, the cc packet pts is relevant to the timebase of the video stream, but later is assumed to be 90k. Adjust it here to be 90k so timing is accurate in resulting subs. Signed-off-by: Chris Landry --- libavdevice/lavfi.c | 11

Re: [FFmpeg-devel] [PATCH] libavdevice/lavfi.c: adjust subcc_packet->pts to be in 90 timebase

2016-10-01 Thread Chris Landry
27 AM, Michael Niedermayer wrote: > On Fri, Sep 30, 2016 at 11:02:32PM -0400, Chris Landry wrote: > > From: Chris Landry > > > > When a video stream timebase is not 90k, the cc packet pts is relevant > to the timebase of the video stream, but later is assumed to be 90k. Adjust

[FFmpeg-devel] FATE Sub-CC Test

2017-01-04 Thread Chris Landry
I submitted a patch that failed a FATE test a while back. The patch changed the time position of subtitles. I have finally been able to take a look at the test (fate-sub-cc), and I believe the test is incorrect. It is looking for the following cues: Dialogue: 0,0:00:12.36,0:00:40.83,Default,,0,0