[FFmpeg-devel] avformat: adding RTP support for AV1

2024-11-21 Thread Chris Hodges
Hello, Axis Communications AB would like to contribute a packetizer and depacketizer in avformat implementing the RTP for AV1 specification. This is my first contribution and I have read the chapter about submitting patches a couple of times. Nevertheless, I am sorry there are mistakes in th

[FFmpeg-devel] [PATCH] avformat: add AV1 RTP depacketizer and packetizer

2024-11-21 Thread Chris Hodges
Add RTP packetizer and depacketizer according to (most) of the official AV1 RTP specification. This enables streaming via RTSP between ffmpeg and ffmpeg and has also been tested to work with AV1 RTSP streams via GStreamer. It also adds the required SDP additions. Signed-off-by: Chris Hodges

Re: [FFmpeg-devel] [PATCH] avformat: add AV1 RTP depacketizer and packetizer

2024-11-26 Thread Chris Hodges
Hi Tristan, On 11/25/24 18:47, Tristan Matthews via ffmpeg-devel wrote: I haven't done an in-depth review but I tested this locally and it's working well. I'm impressed you were able to implement the packetization without allocating scratch buffers. I had to rewrite it a couple of times unt

Re: [FFmpeg-devel] [PATCH] avformat: add AV1 RTP depacketizer and packetizer

2024-12-02 Thread Chris Hodges
d to work with AV1 RTSP streams via GStreamer. It also adds the required SDP attributes for AV1. AV1 RTP encoding is marked as experimental due to draft specification status (courtesy of Tristan). Change-Id: Ie7f984b97be54d86d06bc73fa97c6faa8ffabf89 Signed-off-by: Chris Hodges --- libavformat/Ma

Re: [FFmpeg-devel] [PATCH] avformat: add AV1 RTP depacketizer and packetizer

2024-11-24 Thread Chris Hodges
to (most) of the official AV1 RTP specification. This enables streaming via RTSP between ffmpeg and ffmpeg and has also been tested to work with AV1 RTSP streams via GStreamer. It also adds the required SDP additions. Signed-off-by: Chris Hodges --- libavformat/Makefile | 2

Re: [FFmpeg-devel] [PATCH] avformat: add AV1 RTP depacketizer and packetizer

2024-12-12 Thread Chris Hodges
Hi Tristan, I have a draft reply ongoing the last couple of days, but I got sidetracked with other work, sorry. Will send it out without a new patch so we can discuss the changes and it gives me more time to look into the issue below. On 12/11/24 23:53, Tristan Matthews via ffmpeg-devel wrot

Re: [FFmpeg-devel] [PATCH] avformat: add AV1 RTP depacketizer and packetizer

2024-12-12 Thread Chris Hodges
Hi Tristan, thanks for taking the time reviewing. On 12/6/24 18:39, Tristan Matthews via ffmpeg-devel wrote: Hi (also apologies if my client mangles the inline version of the patch, it's the first time I've tried to review an attached patch with it)... > +av_log(ctx, AV_LOG_DEBUG, "RTP

Re: [FFmpeg-devel] [PATCH v3] avformat: add AV1 RTP depacketizer and packetizer

2024-12-13 Thread Chris Hodges
ded optional code for searching the sequence header to determine the first packet for broken AV1 encoders / parsers. Stops depacketizing on corruption until next keyframe, no longer prematurely issues packet on decoding if temporal unit was not complete yet. Signed-off-by: Chris Hodges ---

Re: [FFmpeg-devel] [PATCH] avformat: add AV1 RTP depacketizer and packetizer

2024-12-19 Thread Chris Hodges
Hi there, On 12/13/24 15:09, Tristan Matthews via ffmpeg-devel wrote: I don't seem to be able to replay the Chimera video directly with my local build of ffplay, get's all choppy and skips big deals of the video. Might be an outdated libdav1d? I still have problems with the media server and t

[FFmpeg-devel] [PATCH] avformat: Fix AV1 RTP wrong log condition

2025-04-01 Thread Chris Hodges
Fixed warning about OBU count being wrong, which can only be determined when the number of OBUs in the header is non-zero, not the other way round. Signed-off-by: Chris Hodges --- libavformat/rtpdec_av1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec_av1: Fix fragment continuation check when OBU_HAS_SIZE_FIELD is set

2025-04-14 Thread Chris Hodges
Hi there, On 4/13/25 17:56, Parallelc wrote: When OBU_HAS_SIZE_FIELD is set in the OBU header, frag_obu_size remains 0. The code used !frag_obu_size to check for unexpected fragment continuation, which resulted in incorrect drops. Introduce expect_frag_cont to explicitly track continuation expe

Re: [FFmpeg-devel] [PATCH v4] avformat: add AV1 RTP depacketizer and packetizer

2025-02-27 Thread Chris Hodges
On 2/26/25 19:26, Ronald S. Bultje wrote: Added code to support this and enabled the extra scan for the sequence header OBU. This is great work, thanks for the additions and LGTM after some testing. Merged. Thanks a lot for reviewing and valuable suggestions to all involved! Will stay on

Re: [FFmpeg-devel] [PATCH v4] avformat: add AV1 RTP depacketizer and packetizer

2025-02-21 Thread Chris Hodges
broken AV1 encoders / parsers. Stops depacketizing on corruption until next keyframe, no longer prematurely issues packet on decoding if temporal unit was not complete yet. Change-Id: I90f5c5b9d577908a0d713606706b5654fde5f910 Signed-off-by: Chris Hodges --- libavformat/Makefile | 2