[FFmpeg-devel] [PATCH 1/6] doc/examples/metadata.c: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- doc/examples/metadata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/metadata.c b/doc/examples/metadata.c index b6cfa6bd36

[FFmpeg-devel] [PATCH 2/6] fftools/: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- fftools/cmdutils.c | 2 +- fftools/ffmpeg.c| 6 +++--- fftools/ffmpeg_filter.c | 6 +++--- fftools/ffmpeg_opt.c| 8 fftools/ffplay.c

[FFmpeg-devel] [PATCH 3/6] libavcodec/: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- libavcodec/libaomenc.c | 2 +- libavcodec/libvpxenc.c | 4 ++-- libavcodec/libx264.c | 2 +- libavcodec/libx265.c | 2 +- libavcodec/mjpegdec.c | 2 +- 5 files

[FFmpeg-devel] [PATCH 4/6] libavfilter/: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- libavfilter/avfilter.c | 2 +- libavfilter/f_bench.c | 2 +- libavfilter/f_drawgraph.c | 2 +- libavfilter/f_metadata.c| 2 +- libavfilter/f_select.c

[FFmpeg-devel] [PATCH 5/6] libavformat/: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- libavformat/aiffenc.c | 2 +- libavformat/apetag.c| 2 +- libavformat/asfenc.c| 8 +++ libavformat/au.c| 2 +- libavformat

[FFmpeg-devel] [PATCH 6/6] libavutil/: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- libavutil/hwcontext_qsv.c| 2 +- libavutil/hwcontext_vulkan.c | 6 +++--- libavutil/opt.c | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions

[FFmpeg-devel] [PATCH 1/6] doc/examples/metadata.c: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- doc/examples/metadata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/metadata.c b/doc/examples/metadata.c index b6cfa6bd36

[FFmpeg-devel] [PATCH 2/6] fftools/: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- fftools/cmdutils.c | 2 +- fftools/ffmpeg.c| 6 +++--- fftools/ffmpeg_filter.c | 6 +++--- fftools/ffmpeg_opt.c| 8 fftools/ffplay.c| 8

[FFmpeg-devel] [PATCH 3/6] libavcodec/: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- libavcodec/libaomenc.c | 2 +- libavcodec/libvpxenc.c | 4 ++-- libavcodec/libx264.c | 2 +- libavcodec/libx265.c | 2 +- libavcodec/mjpegdec.c | 2 +- 5 files

[FFmpeg-devel] [PATCH 4/6] libavfilter/: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- libavfilter/avfilter.c | 2 +- libavfilter/f_bench.c | 2 +- libavfilter/f_drawgraph.c | 2 +- libavfilter/f_metadata.c| 2 +- libavfilter/f_select.c

[FFmpeg-devel] [PATCH 5/6] libavformat/: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- libavformat/aiffenc.c | 2 +- libavformat/apetag.c| 2 +- libavformat/asfenc.c| 8 +++ libavformat/au.c| 2 +- libavformat

[FFmpeg-devel] [PATCH 6/6] libavutil/: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- libavutil/hwcontext_qsv.c| 2 +- libavutil/hwcontext_vulkan.c | 6 +++--- libavutil/opt.c | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions

[FFmpeg-devel] [PATCH 2/6] fftools/: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- fftools/cmdutils.c | 2 +- fftools/ffmpeg.c| 6 +++--- fftools/ffmpeg_filter.c | 6 +++--- fftools/ffmpeg_opt.c| 8 fftools/ffplay.c| 8

[FFmpeg-devel] [PATCH 3/6] libavcodec/: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- libavcodec/libaomenc.c | 2 +- libavcodec/libvpxenc.c | 4 ++-- libavcodec/libx264.c | 2 +- libavcodec/libx265.c | 2 +- libavcodec/mjpegdec.c | 2 +- 5 files

[FFmpeg-devel] [PATCH 4/6] libavfilter/: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- libavfilter/avfilter.c | 2 +- libavfilter/f_bench.c | 2 +- libavfilter/f_drawgraph.c | 2 +- libavfilter/f_metadata.c| 2 +- libavfilter/f_select.c

[FFmpeg-devel] [PATCH 5/6] libavformat/: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- libavformat/aiffenc.c | 2 +- libavformat/apetag.c| 2 +- libavformat/asfenc.c| 8 +++ libavformat/au.c| 2 +- libavformat

[FFmpeg-devel] [PATCH 6/6] libavutil/: constify values from av_dict_get().

Treat values returned from av_dict_get() as const, since they are internal to AVDictionary. Signed-off-by: Chad Fraleigh --- libavutil/hwcontext_qsv.c| 2 +- libavutil/hwcontext_vulkan.c | 6 +++--- libavutil/opt.c | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions

Re: [FFmpeg-devel] Patch for IPC SHM

On 7/22/2019 11:14 AM, aran.clau...@wwu.edu wrote: +static void rm_shmid(AVFormatContext *s) { +XCBGrabContext *c = s->priv_data; +if(c->shmid != -1) { + shmctl(c->shmid, IPC_RMID, 0); + c->shmid == -1; ^^ Assignment/compare operator mismatch. +}

Re: [FFmpeg-devel] [PATCH 2/8] avformat/mov: Support size = 1 and size = 0 special cases in probing

On 2/6/2021 9:22 AM, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 9406e42f49..70f76caff5 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -7113,

Re: [FFmpeg-devel] [PATCH] avutils/opt: fix discarded-qualifiers compiler warning

On 2/14/2021 10:16 AM, Andreas Rheinhardt wrote: Nuo Mi: On Mon, Feb 15, 2021 at 2:08 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: Nuo Mi: --- libavutil/opt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 590146b

Re: [FFmpeg-devel] [PATCH V2 1/7] libavdevice/v4l2.c: fix build warning for [-Wformat-truncation=]

On 2/24/2021 10:38 PM, Guo, Yejun wrote: Here is the warning message: src/libavdevice/v4l2.c: In function ‘v4l2_get_device_list’: src/libavdevice/v4l2.c:1054:58: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 251 [-Wformat-truncation=] s

Re: [FFmpeg-devel] [PATCH] avutils/opt: fix discarded-qualifiers compiler warning

On 2/14/2021 10:12 AM, Nuo Mi wrote: On Mon, Feb 15, 2021 at 2:08 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: Nuo Mi: --- libavutil/opt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 590146b5fb..c554e9c063 10064

Re: [FFmpeg-devel] [PATCH] avutils/opt: fix discarded-qualifiers compiler warning

On 3/9/2021 5:30 AM, Nuo Mi wrote: On Tue, Mar 9, 2021 at 3:17 AM Chad Fraleigh wrote: On 2/14/2021 10:12 AM, Nuo Mi wrote: On Mon, Feb 15, 2021 at 2:08 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: Nuo Mi: --- libavutil/opt.c | 2 +- 1 file changed, 1 insertion

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/udp: add memory alloc checks

On 1/7/2021 2:43 AM, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/udp.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/udp.c b/libavformat/udp.c index 798b789..e6d1235 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @

Re: [FFmpeg-devel] [PATCH] avformat/hls: change sequence number type to int64_t

On 1/15/2021 3:41 AM, Zhao Zhili wrote: Fix atoi() overflow for large EXT-X-MEDIA-SEQUENCE. The spec says the type of sequence number is uint64_t. Use int64_t here since current implementation requires it to be signed integer, and hlsenc use int64_t too. --- libavformat/hls.c | 49 +++

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

On 8/22/2021 11:18 AM, Michael Niedermayer wrote: On Sun, Aug 15, 2021 at 11:24:47AM +0200, Nicolas George wrote: Nicolas George (12021-08-08): Here is a patch series for fateserver, to fix warnings and enable Perl's taint checks, thus protecting against a whole class of security issues. I wo

Re: [FFmpeg-devel] Question regarding ogg cover art implementation

On 8/22/2021 4:49 PM, Jesse Obic wrote: I'm looking at implementing https://trac.ffmpeg.org/ticket/4448 , and I understand what I need to do but I'm on the fence about how I should go about doing it. For the OGG container, cover art is embedded into the fi

Re: [FFmpeg-devel] [PATCH] Fix setsockopt IP_MULTICAST_TTL on OpenBSD

Since apparently linux will auto-detect (as mentioned by Marton Balint), based on the optlen parameter, just using unsigned char in all cases seems to be the cleanest. However, I would advise including a comment in the code to that effect which says to ignore the [outdated] linux documentation (

Re: [FFmpeg-devel] [PATCH] Fix setsockopt IP_MULTICAST_TTL on OpenBSD

On 1/26/2022 12:50 PM, Marton Balint wrote: > > > On Wed, 26 Jan 2022, Brad Smith wrote: > >> On Wed, Jan 12, 2022 at 12:13:14AM -0500, Brad Smith wrote: >>> Fix setsockopt() usage on OpenBSD with IP_MULTICAST_TTL. The field >>> type should be an unsigned char on anything but Linux. >> >> Based

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/udp: Fix IP_MULTICAST_TTL for BSD compatibility

Since any [valid] value over 255 is impossible in the IPv4 protocol (the TTL field is only 8-bits), it should always be capped at 255 (for consistency) or return an invalid value error (the one I would suggest). Despite VLC's reversed comment, using an int seems to be the exception to the rule

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/udp: Fix IP_MULTICAST_TTL for BSD compatibility

On 2/5/2022 6:09 PM, lance.lmw...@gmail.com wrote: > On Sat, Feb 05, 2022 at 01:26:18PM -0800, Chad Fraleigh wrote: >> Since any [valid] value over 255 is impossible in the IPv4 protocol (the TTL >> field is only 8-bits), it should always be capped at 255 (for consistency)