[FFmpeg-devel] [PATCH] avformat/hlsenc: Dont write stream info for agroup

2018-01-18 Thread Brendan McGrath
DIO,GROUP-ID="group_audio_0",NAME="audio_0",DEFAULT=YES,URI="tv_hls_0.m3u8" #EXT-X-STREAM-INF:BANDWIDTH=2120800,RESOLUTION=1920x1080,AUDIO="group_audio_0" tv_hls_1.m3u8 #EXT-X-STREAM-INF:BANDWIDTH=1267200,RESOLUTION=1920x1080,AUDIO="group_audio_0&

[FFmpeg-devel] [PATCH] dashdec: Only free url string if being reused

2018-01-18 Thread Brendan McGrath
If no representation bandwidth value is set, the url value returned by get_content_url is corrupt (as the memory has been freed). This change ensures the url string is not freed unless it is about to be reused Signed-off-by: Brendan McGrath --- libavformat/dashdec.c | 4 +++- 1 file changed, 3

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Dont write stream info for agroup

2018-01-18 Thread Brendan McGrath
F tag SHOULD include a CODECS attribute So I guess this is a bug in iOS. On 18/01/18 21:59, Dixit, Vishwanath wrote: On 1/18/18 2:39 PM, Brendan McGrath wrote: When using an 'agroup' within var_stream_map - the audio stream is being added to the master playlist file as both an audio r

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Dont write stream info for agroup

2018-01-18 Thread Brendan McGrath
:53 PM, Brendan McGrath wrote: I tried your suggestion and it still didn't work. So I took another look at the spec and it looks like what was originally there was correct (as seen in the below example): https://tools.ietf.org/html/rfc8216#section-8.6 In that example - english-audio.m3u8 ap

[FFmpeg-devel] [PATCH] avformat/hlsenc: Check that data is set

2018-01-19 Thread Brendan McGrath
If codecpar->extradata is not set (for example, when the stream goes through the 'tee' muxer), then a segfault occurs. This patch ensures the data variable is not null before attempting to access it Signed-off-by: Brendan McGrath --- Before the var_stream_map option was available

[FFmpeg-devel] [PATCHv2] dashdec: Only free url string if being reused

2018-01-19 Thread Brendan McGrath
If no representation bandwidth value is set, the url value returned by get_content_url is corrupt (as it has been freed). This change ensures the url string is not freed unless it is about to be reused Signed-off-by: Brendan McGrath --- Changes since v1: - removed the unneeded 'if'

[FFmpeg-devel] [PATCH] dashdec: Fix segfault on decoding segment timeline

2018-01-19 Thread Brendan McGrath
;) Signed-off-by: Brendan McGrath --- This can be reproduced by creating a dash file with the following command: ffmpeg -i in.ts -f dash -window_size 2 out.mpd and then after about 10 seconds run ffprobe against it. The SegementTemplatei of out.mpd will look something

[FFmpeg-devel] [PATCH] avformat/hlsenc: Check ret on avformat_write_header

2018-01-23 Thread Brendan McGrath
hls_mux_init. This patch checks the return of avformat_write_header so that if it is greater than zero (indicating the avformat is already initialized) then it does not error. Signed-off-by: Brendan McGrath --- I'm not sure if hls_ts_options is supposed to be used with fmp4 as the descripti

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Check ret on avformat_write_header

2018-01-27 Thread Brendan McGrath
On 26/01/18 14:30, 刘歧 wrote: On 24 Jan 2018, at 09:24, Brendan McGrath wrote: Encoding currently fails when using hls_ts_options with the fmp4 segment type. This is due to the fact that avformat_write_header does not process the passed options when the avformat is already initialized. When

Re: [FFmpeg-devel] [PATCH] dashdec: Fix segfault on decoding segment timeline

2018-01-27 Thread Brendan McGrath
#x27; will be 7 but the 'pls->timelines' array will only have the one element - hence: pls->timelines[pls->first_seq_no] causes a segfault. This patch removes the use of 'pls->first_seq_no' within the 'pls->timelines' array On 20/01/18 18:07, Brendan McGrath wr