[FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-04 Thread Bohan Li
ttps://aomedia.googlesource.com/aom/+/c1d42fe6615c96fc929257 The libaom issue tracker: https://bugs.chromium.org/p/aomedia/issues/detail?id=2875 Signed-off-by: Bohan Li --- doc/encoders.texi | 11 +++ libavcodec/libaomenc.c | 30 ++ 2 files changed

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-04 Thread Bohan Li
Thanks for the review! Indeed the buf string does not play any role here. I have removed it in the new patch. Bohan On Thu, Feb 4, 2021 at 1:02 PM Bohan Li wrote: > This key & value API can greatly help with users who wants to try > libaom-av1 specific options that are not supported

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-08 Thread Bohan Li
Gentle ping :) On Thu, Feb 4, 2021 at 1:45 PM Bohan Li wrote: > Thanks for the review! Indeed the buf string does not play any role here. > I have removed it in the new patch. > > Bohan > > On Thu, Feb 4, 2021 at 1:02 PM Bohan Li wrote: > >> This key & value API

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-08 Thread Bohan Li
would modify and apply it? Thanks a lot! Bohan On Mon, Feb 8, 2021 at 3:47 PM Jan Ekström wrote: > On Thu, Feb 4, 2021 at 11:02 PM Bohan Li > wrote: > > > > This key & value API can greatly help with users who wants to try > > libaom-av1 specific options that ar

[FFmpeg-devel] [PATCH v2] Add support for the new key & value API in libaom.

2021-02-08 Thread Bohan Li
ttps://aomedia.googlesource.com/aom/+/c1d42fe6615c96fc929257 The libaom issue tracker: https://bugs.chromium.org/p/aomedia/issues/detail?id=2875 Signed-off-by: Bohan Li --- doc/encoders.texi | 11 +++ libavcodec/libaomenc.c | 18 ++ 2 files changed, 29 insertions(+)

Re: [FFmpeg-devel] [PATCH v2] Add support for the new key & value API in libaom.

2021-02-08 Thread Bohan Li
Thanks for the info! Just uploaded the patch v2 as suggested. Best, Bohan On Mon, Feb 8, 2021 at 8:04 PM Bohan Li wrote: > This key & value API can greatly help with users who wants to try > libaom-av1 specific options that are not supported by ffmpeg options. > > As was prev

Re: [FFmpeg-devel] [PATCH v2] Add support for the new key & value API in libaom.

2021-02-09 Thread Bohan Li
Hi Jan, Yes the modified patch looks good to me. Please let me know if there is anything needed from my end. Thank you very much! Bohan On Tue, Feb 9, 2021, 12:01 PM Jan Ekström wrote: > On Tue, Feb 9, 2021 at 6:05 AM Bohan Li > wrote: > > > > This key & value API

[FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread Bohan Li
Signed-off-by: Bohan Li --- libavcodec/libaomenc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index 2b0581b15a..a5d9843ae2 100644 --- a/libavcodec/libaomenc.c +++ b/libavcodec/libaomenc.c @@ -124,6 +124,7 @@ typedef struct

[FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread Bohan Li
Add the option to use -enable-keyframe-filtering with libaom-av1 codec. The option controls the encoder behavior on performing temporal filtering on keyframes. Signed-off-by: Bohan Li --- libavcodec/libaomenc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/libaomenc.c b

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread Bohan Li
o use AV_OPT_TYPE_INT here so people who build libaom from source could use that option. Please let me know if there are any concerns with it. Thanks and best regards, Bohan On Mon, Oct 26, 2020 at 2:07 PM James Almer wrote: > On 10/26/2020 6:01 PM, Bohan Li wrote: > > Signed-of

[FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread Bohan Li
Add the option to use -enable-keyframe-filtering with libaom-av1 codec. The option controls the encoder behavior on performing temporal filtering on keyframes. Signed-off-by: Bohan Li --- doc/encoders.texi | 13 + libavcodec/libaomenc.c | 5 + 2 files changed, 18

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread Bohan Li
Thanks a lot for the explanation! I'll add the documentation accordingly. Best, Bohan On Mon, Oct 26, 2020 at 2:46 PM James Almer wrote: > On 10/26/2020 6:21 PM, Bohan Li wrote: > > > Regarding the last comment, the enable-keyframe-filtering parameter was a > > boolean

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-27 Thread Bohan Li
Thompson wrote: > On 26/10/2020 22:04, Bohan Li wrote: > > Add the option to use -enable-keyframe-filtering with libaom-av1 > > codec. The option controls the encoder behavior on performing > > temporal filtering on keyframes. > > > > Signed-off-by: Bohan Li > >

[FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-27 Thread Bohan Li
Add the option to use -enable-keyframe-filtering with libaom-av1 codec. The option controls the encoder behavior on performing temporal filtering on keyframes. Signed-off-by: Bohan Li --- doc/encoders.texi | 17 + libavcodec/libaomenc.c | 5 + 2 files changed, 22

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-27 Thread Bohan Li
Tue, Oct 27, 2020 at 10:38 PM Bohan Li > wrote: > > > > Add the option to use -enable-keyframe-filtering with libaom-av1 > > codec. The option controls the encoder behavior on performing > > temporal filtering on keyframes. > > > > Hi, > > Looking at th

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-30 Thread Bohan Li
Gentle ping :) Bohan On Tue, Oct 27, 2020 at 4:13 PM Bohan Li wrote: > Hi Jan, > > Thanks for the suggestion! I believe that is a good idea. I am not super > familiar with this part, though, so will probably need to propose this to > the Aomedia issue tracker. > Meanwhile

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-05 Thread Bohan Li
Another ping :) Bohan On Fri, Oct 30, 2020 at 2:43 PM Bohan Li wrote: > Gentle ping :) > > Bohan > > On Tue, Oct 27, 2020 at 4:13 PM Bohan Li wrote: > >> Hi Jan, >> >> Thanks for the suggestion! I believe that is a good idea. I am not super >> familia

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-06 Thread Bohan Li
Steven Liu wrote: > > > > 2020年11月6日 上午2:29,Bohan Li 写道: > > > > Another ping :) > I think maybe you should fix JEEB’s review comment, then will get > responses comments. > Not only apply a middle version. > > > > Bohan > > > > On Fri, Oct

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-06 Thread Bohan Li
2020 at 11:46 AM Steven Liu wrote: > > > > > > > > > 2020年11月6日 下午4:42,Bohan Li 写道: > > > > > > Thanks for the reply, Steven! > > > > > > Regarding JEEB’s comment, the suggestion was to add an api to the > *libaom* library, not to f

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-09 Thread Bohan Li
t me know if there are any concerns. Thanks! Bohan On Fri, Nov 6, 2020 at 9:31 AM Bohan Li wrote: > Thanks a lot for the comment, Jan and Steven! Yes I very much agree that > the number of options is quite large and this is not a great path to go > for. But for the moment I still suggest

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-16 Thread Bohan Li
Gentle ping :) On Mon, Nov 9, 2020 at 11:00 AM Bohan Li wrote: > I have added a feature request in the libaom issue tracker for the key & > value api, although it may take some time for the api to land. Meanwhile I > still suggest that we apply this patch to ffmpeg since as m

[FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-03 Thread Bohan Li
ttps://aomedia.googlesource.com/aom/+/c1d42fe6615c96fc929257 The libaom issue tracker: https://bugs.chromium.org/p/aomedia/issues/detail?id=2875 Signed-off-by: Bohan Li --- doc/encoders.texi | 10 ++ libavcodec/libaomenc.c | 32 2 files changed

[FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-03 Thread Bohan Li
ttps://aomedia.googlesource.com/aom/+/c1d42fe6615c96fc929257 The libaom issue tracker: https://bugs.chromium.org/p/aomedia/issues/detail?id=2875 Signed-off-by: Bohan Li --- doc/encoders.texi | 10 ++ libavcodec/libaomenc.c | 32 2 files changed

[FFmpeg-devel] [PATCH] Add unmet target level warning to libaom encoding.

2022-04-18 Thread Bohan Li
When target levels are set, this patch checks whether they are satisfied by libaom. If not, a warning is shown. Otherwise the output levels are also logged. This patch applies basically the same approach used for libvpx. Signed-off-by: Bohan Li --- libavcodec/libaomenc.c | 64

[FFmpeg-devel] [PATCH] avcodec/libaomenc: Add unmet target level warning

2022-04-19 Thread Bohan Li
When target levels are set, this patch checks whether they are satisfied by libaom. If not, a warning is shown. Otherwise the output levels are also logged. This patch applies basically the same approach used for libvpx. Signed-off-by: Bohan Li --- libavcodec/libaomenc.c | 64

[FFmpeg-devel] [PATCH v2] avcodec/libaomenc: Add unmet target level warning

2022-04-19 Thread Bohan Li
When target levels are set, this patch checks whether they are satisfied by libaom. If not, a warning is shown. Otherwise the output levels are also logged. This patch applies basically the same approach used for libvpx. Signed-off-by: Bohan Li --- libavcodec/libaomenc.c | 64

Re: [FFmpeg-devel] [PATCH v2] avcodec/libaomenc: Add unmet target level warning

2022-04-29 Thread Bohan Li
Gentle ping on this :) On Tue, Apr 19, 2022 at 11:20 AM Bohan Li wrote: > When target levels are set, this patch checks whether they are > satisfied by libaom. If not, a warning is shown. Otherwise the output > levels are also logged. > > This patch applies basically the same ap

Re: [FFmpeg-devel] [PATCH v2] avcodec/libaomenc: Add unmet target level warning

2022-05-16 Thread Bohan Li
Another ping :) On Fri, Apr 29, 2022 at 2:46 PM Bohan Li wrote: > Gentle ping on this :) > > On Tue, Apr 19, 2022 at 11:20 AM Bohan Li wrote: > >> When target levels are set, this patch checks whether they are >> satisfied by libaom. If not, a warning is shown. Otherw

Re: [FFmpeg-devel] [PATCH v2] avcodec/libaomenc: Add unmet target level warning

2022-05-25 Thread Bohan Li
fmpeg patch. Best, Bohan On Tue, May 24, 2022 at 5:43 PM James Zern wrote: > On Tue, May 17, 2022 at 12:45 PM James Zern wrote: > > > > On Tue, Apr 19, 2022 at 11:20 AM Bohan Li > > wrote: > > > > > > When target levels are set, this patch checks whether t