Setting OPJ_STATIC when building shared libraries with openjpeg 2 causes
the openjpeg symbols to have visibility hidden and the final linker step
to fail due to undefined references.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/libopenjpegdec.c | 3 +++
libavcodec/libopenjpegenc.c | 3 +++
2
openjpeg 2 sets the data pointers of the image components to NULL,
causing segfaults if the image is reused.
Signed-off-by: Andreas Cadhalpun
---
The relevant openjpeg2 code is:
https://sources.debian.net/src/openjpeg2/2.1.2-1/src/lib/openjp2/j2k.c/?hl=10253#L10247
---
libavcodec
On 11.10.2016 19:13, Hendrik Leppkes wrote:
> On Tue, Oct 11, 2016 at 5:50 PM, Andreas Cadhalpun
> wrote:
>> Setting OPJ_STATIC when building shared libraries with openjpeg 2 causes
>> the openjpeg symbols to have visibility hidden and the final linker step
>> to fail due
lly, check for non-static libopenjpeg, too.
Signed-off-by: Andreas Cadhalpun
---
configure | 9 ++---
libavcodec/libopenjpegdec.c | 2 --
libavcodec/libopenjpegenc.c | 2 --
3 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/configure b/configure
index 8fc71fb..ff743
On 12.10.2016 03:35, Michael Bradshaw wrote:
> Oh man, I literally just wrote a patch for this today. You beat me by 6
> hours. Anyway, thanks for the patch!
What a coincidence!
> On Tue, Oct 11, 2016 at 11:37 AM, Andreas Cadhalpun <
> andreas.cadhal...@google
On 12.10.2016 03:42, Michael Bradshaw wrote:
> On Tue, Oct 11, 2016 at 9:57 AM, Andreas Cadhalpun <
> andreas.cadhal...@googlemail.com> wrote:
>
>> openjpeg 2 sets the data pointers of the image components to NULL,
>> causing segfaults if the image is reused.
>>
On 04.10.2016 12:24, Carl Eugen Hoyos wrote:
> Sorry if I miss something but with this patch, the hardening_check
> script succeeds here both for x86_32 and x86_64 (static and shared).
This script uses a very simplistic approach for testing position
independent executables.
I think it just does t
On 05.10.2016 15:12, Carl Eugen Hoyos wrote:
> From 5e26339b041f5e35112ed7f479ade6e57c3b5248 Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos
> Date: Wed, 5 Oct 2016 15:10:23 +0200
> Subject: [PATCH] configure: Use LDEXEFLAGS in check_ld().
>
> Avoids detecting libraries that are not compatible
On 12.10.2016 23:44, Carl Eugen Hoyos wrote:
> 2016-10-12 19:04 GMT+02:00 Andreas Cadhalpun
> :
>> On 04.10.2016 12:24, Carl Eugen Hoyos wrote:
>>> Sorry if I miss something but with this patch, the hardening_check
>>> script succeeds here both for x86_32
On 13.10.2016 03:11, Michael Bradshaw wrote:
> On Wed, Oct 12, 2016 at 8:30 AM, Andreas Cadhalpun <
> andreas.cadhal...@googlemail.com> wrote:
>>
>> Updated patch attached.
>
>
> New patch looks good to me (though I don't have push privileges so can'
t) for every call to libopenjpeg_encode_frame.
OK. Attached patch does that for openjpeg 2.
I didn't change the behavior for openjpeg 1, as reusing the image works there.
Best regards,
Andreas
>From 350ceab27db0346d89698070e40b1ae19ff1d559 Mon Sep 17 00:00:00 2001
From: Andreas Cadhalpu
without the explicit cast to
int.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/libopenjpegenc.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/libavcodec/libopenjpegenc.c b/libavcodec/libopenjpegenc.c
index 857ee1a..83c965d 100644
--- a/libavco
Thanks to Mathieu Malaterre for reporting the
Que/Queue typo. (https://bugs.debian.org/839542)
Signed-off-by: Andreas Cadhalpun
---
doc/Doxyfile| 2 +-
doc/encoders.texi | 2 +-
doc/ffprobe.texi| 2 +-
doc/filters.texi| 10
On 14.10.2016 00:00, Hendrik Leppkes wrote:
> On Thu, Oct 13, 2016 at 10:25 PM, Andreas Cadhalpun
> wrote:
>> If x is 0, 'x - 1' is in the previous line, or worse outside the buffer
>> for the first line.
>>
>> If y is 0, 'x - image->comps[compno
On 14.10.2016 00:49, Michael Niedermayer wrote:
> On Fri, Oct 14, 2016 at 12:23:02AM +0200, Andreas Cadhalpun wrote:
>> The avctx->width/avctx->height is not zero, but libopenjpeg_copy_unpacked8
>> does:
>
>> width = avctx->width / image->comps[c
aac 0001-libopenjpegenc-fix-out-
>> of-bounds-reads-when-filling-.patch
>>> From 1461064c1eaabb71661f9ff68b94f35a1b98e3b5 Mon Sep 17 00:00:00 2001
>>> From: Andreas Cadhalpun
>>> Date: Thu, 13 Oct 2016 22:14:46 +0200
>>> Subject: [PATCH] libopenjpegenc: fix
On 14.10.2016 15:02, Carl Eugen Hoyos wrote:
> 2016-10-04 12:24 GMT+02:00 Carl Eugen Hoyos :
>
>> Sorry if I miss something but with this patch, the hardening_check
>> script succeeds here both for x86_32 and x86_64 (static and shared).
>
> Tested successfully on x86_64 and x86_32 Linux (pie actu
On 14.10.2016 06:07, Michael Bradshaw wrote:
> On Thu, Oct 13, 2016 at 12:21 PM, Andreas Cadhalpun <
> andreas.cadhal...@googlemail.com> wrote:
>>
>> OK. Attached patch does that for openjpeg 2.
>> I didn't change the behavior for openjpeg 1, as reusing the image
On 14.10.2016 18:28, Michael Niedermayer wrote:
> On Thu, Oct 13, 2016 at 12:56:56AM +0200, Andreas Cadhalpun wrote:
>> If you want both NX and ASLR security features for an executable it has
>> to be built with '-pie' and must not contain text relocations.
>
>
On 05.10.2016 21:37, Jon Toohill wrote:
> ---
> libavformat/mp3enc.c | 34 +++---
> 1 file changed, 27 insertions(+), 7 deletions(-)
>
> diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c
> index de63401..ddf4b93 100644
> --- a/libavformat/mp3enc.c
> +++ b/libavf
On 05.10.2016 21:37, Jon Toohill wrote:
> ---
> libavcodec/libmp3lame.c | 26 +-
> 1 file changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c
> index 5642264..b3ba0d8 100644
> --- a/libavcodec/libmp3lame.c
> +++ b/lib
The problem was introduced in commit 1273bc6.
Signed-off-by: Andreas Cadhalpun
---
libavformat/matroskadec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
index 8847c62..a5d3c0e 100644
--- a/libavformat/matroskadec.c
Signed-off-by: Andreas Cadhalpun
---
libavformat/aiffdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c
index cd916f9..de82787 100644
--- a/libavformat/aiffdec.c
+++ b/libavformat/aiffdec.c
@@ -380,7 +380,7 @@ static int
Signed-off-by: Andreas Cadhalpun
---
libavformat/astdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/astdec.c b/libavformat/astdec.c
index f3ca721..7a53d0b 100644
--- a/libavformat/astdec.c
+++ b/libavformat/astdec.c
@@ -90,7 +90,7 @@ static int
Signed-off-by: Andreas Cadhalpun
---
libavformat/westwood_aud.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavformat/westwood_aud.c b/libavformat/westwood_aud.c
index 4750167..9c2d35c 100644
--- a/libavformat/westwood_aud.c
+++ b/libavformat/westwood_aud.c
@@ -164,6 +164,12
On 17.10.2016 15:44, James Almer wrote:
> On 10/17/2016 4:47 AM, Benoit Fouet wrote:
>> On 17/10/2016 06:49, James Almer wrote:
>>> On 10/16/2016 9:30 PM, James Almer wrote:
>>>> On 10/16/2016 5:11 PM, Andreas Cadhalpun wrote:
>>>>> The problem was int
On 17.10.2016 05:43, Michael Niedermayer wrote:
> On Sun, Oct 16, 2016 at 10:38:42PM +0200, Andreas Cadhalpun wrote:
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> libavformat/aiffdec.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --gi
On 17.10.2016 17:13, Michael Niedermayer wrote:
> On Mon, Oct 17, 2016 at 04:17:35PM +0200, Andreas Cadhalpun wrote:
>> On 17.10.2016 05:43, Michael Niedermayer wrote:
>>> On Sun, Oct 16, 2016 at 10:38:42PM +0200, Andreas Cadhalpun wrote:
>>>> Si
On 17.10.2016 20:11, Michael Niedermayer wrote:
> On Mon, Oct 17, 2016 at 06:27:29PM +0200, Andreas Cadhalpun wrote:
>> On 17.10.2016 17:13, Michael Niedermayer wrote:
>>> On Mon, Oct 17, 2016 at 04:17:35PM +0200, Andreas Cadhalpun wrote:
>>>> On 17.10.2016 05
The parser depends on the codec and thus must not be used with a different one.
If it is, the 'avctx->codec_id == s->parser->codec_ids[0] ...' assert in
av_parser_parse2 gets triggered.
Signed-off-by: Andreas Cadhalpun
---
libavformat/utils.c | 12
1 file cha
On 17.10.2016 23:55, Jon Toohill wrote:
> Round trip wav->mp3->wav now preserves the correct number of samples.
> Remuxing mp3->mp3 with -c:a copy also preserves any existing gapless
> metadata in the Info tag.
>
> The code in libmp3lame.c to set AV_PKT_DATA_SKIP_SAMPLES was mostly
> copied from l
Nothing guarantees to set request_probe to -1, so this assert can be
triggered, e.g. if st->probe_packets is 0.
Signed-off-by: Andreas Cadhalpun
---
I think the reason why this assert isn't triggered way more often is
that the probing code usually works quite well.
---
libavformat/uti
On 18.10.2016 22:56, Michael Niedermayer wrote:
> On Tue, Oct 18, 2016 at 10:31:37PM +0200, Andreas Cadhalpun wrote:
>> Nothing guarantees to set request_probe to -1, so this assert can be
>> triggered, e.g. if st->probe_packets is 0.
>
> probe_codec() called wit
On 18.10.2016 23:46, Hendrik Leppkes wrote:
> On Tue, Oct 18, 2016 at 11:26 PM, Andreas Cadhalpun
> wrote:
>> On 18.10.2016 22:56, Michael Niedermayer wrote:
>>> On Tue, Oct 18, 2016 at 10:31:37PM +0200, Andreas Cadhalpun wrote:
>>>> Nothing guarantees to set re
On 19.10.2016 04:15, James Almer wrote:
> On 10/17/2016 9:57 PM, Michael Niedermayer wrote:
>> On Sun, Oct 16, 2016 at 09:34:50PM -0300, James Almer wrote:
>>> Fixes valgrind warning about "Conditional jump or move depends on
>>> uninitialised value(s)"
>>>
>>> Signed-off-by: James Almer
>>> ---
av_assert0(st->request_probe <= 0);
Yes, this works fine and should guarantee that the assert can't be triggered.
Patch doing it that way is attached.
Best regards,
Andreas
>From 7912c6f200a37130844221a73941a7971afa6455 Mon Sep 17 00:00:00 2001
From: Andreas Cad
On 19.10.2016 18:52, Sven C. Dack wrote:
> On 19/10/16 17:18, Hendrik Leppkes wrote:
>> Thats the general interpretation of the license situation. If you
>> include non-free headers, your binary becomes non-free, hence why
>> building with cuda currently requires the --enable-nonfree option.
> No.
This is similar to commit c143a9c.
Signed-off-by: Andreas Cadhalpun
---
libavformat/aiffdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c
index de82787..d96fc1d 100644
--- a/libavformat/aiffdec.c
+++ b/libavformat/aiffdec.c
On 19.10.2016 20:46, Sven C. Dack wrote:
> No. This is exactly what I meant with wearing tin foil hats.
Insults won't help you.
> Just because a compiler includes information provided by header
> files into the compilation process does this not imply a transfer
> of ownership or copyright of this
Signed-off-by: Andreas Cadhalpun
---
libavformat/dcstr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/dcstr.c b/libavformat/dcstr.c
index 69fae41..d5d2281 100644
--- a/libavformat/dcstr.c
+++ b/libavformat/dcstr.c
@@ -47,7 +47,7 @@ static int dcstr_read_header
On 19.10.2016 21:41, Sven C. Dack wrote:
> You are misinterpreting it. The FAQ explicitly excludes external
> components such as compilers, kernels and libraries.
What is or is not a system component is quite debatable.
However, it always depends on the specific operating system under
consideratio
On 19.10.2016 22:45, Michael Niedermayer wrote:
> On Wed, Oct 19, 2016 at 07:27:59PM +0200, Andreas Cadhalpun wrote:
>> f1f2b8b10efdab27848eeb2e2bac646eda08a175
>> 0001-avformat-prevent-triggering-request_probe-assert-in-.patch
>> From 7912c6f200a37130844221a73941a7971afa645
Negative values don't make sense and too large values can cause
overflows. For AV_CODEC_ID_ADPCM_THP this leads to a too small extradata
buffer being allocated, causing out-of-bounds writes.
Signed-off-by: Andreas Cadhalpun
---
libavformat/rsd.c | 4 +++-
1 file changed, 3 insertions(
On 20.10.2016 02:04, Michael Niedermayer wrote:
> On Wed, Oct 19, 2016 at 11:46:43PM +0200, Andreas Cadhalpun wrote:
>> Negative values don't make sense and too large values can cause
>> overflows. For AV_CODEC_ID_ADPCM_THP this leads to a too small extradata
>> buffer be
On 20.10.2016 02:56, Michael Niedermayer wrote:
> On Wed, Oct 19, 2016 at 09:18:51PM +0200, Andreas Cadhalpun wrote:
>> This is similar to commit c143a9c.
>>
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> libavformat/aiffdec.c | 2 +-
>> 1 file changed, 1 in
On 20.10.2016 02:59, Michael Niedermayer wrote:
> On Wed, Oct 19, 2016 at 10:41:22PM +0200, Andreas Cadhalpun wrote:
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> libavformat/dcstr.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --
On 20.10.2016 03:25, Michael Niedermayer wrote:
> On Wed, Oct 19, 2016 at 07:30:29PM +0200, Andreas Cadhalpun wrote:
>> On 19.10.2016 04:15, James Almer wrote:
>>> On 10/17/2016 9:57 PM, Michael Niedermayer wrote:
>>>> On Sun, Oct 16, 2016 at 09:34:50PM -0300,
This fixes asserts (from commit 13aae8) in av_frame_ref and
av_frame_move_ref.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/cavsdec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/cavsdec.c b/libavcodec/cavsdec.c
index 70ac6f8..fed7043 100644
--- a/libavcodec/cavsdec.c
Otherwise another frame gets referenced into picture, triggering an assert
(from commit 13aae8) in av_frame_ref.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/mpeg12dec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c
index 44f7b61..ac8160d
On 21.10.2016 01:37, Michael Niedermayer wrote:
> On Thu, Oct 20, 2016 at 08:19:00PM +0200, Andreas Cadhalpun wrote:
>> dcstr.c |8 +++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>> 365ebc3a050f6754a981340e0a8df5dbf781
>> 0001-dcstr-fix-div
On 21.10.2016 02:31, Michael Niedermayer wrote:
> On Thu, Oct 20, 2016 at 10:16:17PM +0200, Andreas Cadhalpun wrote:
>> This fixes asserts (from commit 13aae8) in av_frame_ref and
>> av_frame_move_ref.
>>
>> Signed-off-by: Andreas Cadhalpun
>> ---
>>
On 21.10.2016 02:36, Michael Niedermayer wrote:
> On Thu, Oct 20, 2016 at 10:57:15PM +0200, Andreas Cadhalpun wrote:
>> Otherwise another frame gets referenced into picture, triggering an assert
>> (from commit 13aae8) in av_frame_ref.
>>
>> Signed-off-by: Andreas Cadha
On 21.10.2016 01:32, Michael Niedermayer wrote:
> On Thu, Oct 20, 2016 at 08:11:19PM +0200, Andreas Cadhalpun wrote:
>> aiffdec.c |5 +
>> 1 file changed, 5 insertions(+)
>> 2fb78e5573b52b635b5077a265a54542e054cf02
>> 0001-aiff-check-block_align-in-aif
On 13.10.2016 23:25, Andreas Cadhalpun wrote:
> Thanks to Mathieu Malaterre for reporting the
> Que/Queue typo. (https://bugs.debian.org/839542)
>
> Signed-off-by: Andreas Cadhalpun
> ---
> doc/Doxyfile| 2 +-
> doc/encoders.texi | 2 +
On 17.10.2016 20:49, Andreas Cadhalpun wrote:
> The parser depends on the codec and thus must not be used with a different
> one.
> If it is, the 'avctx->codec_id == s->parser->codec_ids[0] ...' assert in
> av_parser_parse2 gets triggered.
>
On 21.10.2016 22:12, Lou Logan wrote:
> On Thu, Oct 13, 2016, at 01:25 PM, Andreas Cadhalpun wrote:
> [...]
>> @item mgain
>> Set max gain that will be displayed. Only useful if curves option is
>> activated.
>> -Setting this to reasonable value allows to display
On 21.10.2016 23:47, Lou Logan wrote:
> On Fri, Oct 21, 2016, at 01:21 PM, Andreas Cadhalpun wrote:
>>
>> Updated patch is attached.
>
> LGTM, thanks.
Pushed.
Best regards,
Andreas
___
ffmpeg-devel mailing list
ffmpeg-
On 22.10.2016 00:18, Michael Niedermayer wrote:
> On Mon, Oct 17, 2016 at 08:49:23PM +0200, Andreas Cadhalpun wrote:
>> The parser depends on the codec and thus must not be used with a different
>> one.
>> If it is, the 'avctx->codec_id == s->par
It is negative, so can't be used for left shifting.
This fixes ubsan runtime error: shift exponent -1 is negative
Signed-off-by: Andreas Cadhalpun
---
libavformat/mpegts.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
On 22.10.2016 11:41, Michael Niedermayer wrote:
> On Sat, Oct 22, 2016 at 01:22:21AM +0200, Andreas Cadhalpun wrote:
>> It is negative, so can't be used for left shifting.
>>
>> This fixes ubsan runtime error: shift exponent -1 is negative
>>
>
This way locally installed documentation refers to itself instead of the
website.
Bud-Id: https://bugs.debian.org/841501
Signed-off-by: Andreas Cadhalpun
---
doc/faq.texi | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/doc/faq.texi b/doc/faq.texi
index ef111c7
On 23.10.2016 06:24, James Almer wrote:
> On 10/22/2016 3:17 PM, Andreas Cadhalpun wrote:
>> This way locally installed documentation refers to itself instead of the
>> website.
>>
>> Bud-Id: https://bugs.debian.org/841501
>> Signed-off-by: Andreas Cadhal
Hi,
On 23.10.2016 04:10, Ronald S. Bultje wrote:
> This is hideous, you're sprinkling emms_c in various places to make some
> stupid test pass. The test is morbidly stupid
Can you elaborate why you think the test is bad?
> and there is no general
> consensus on patterns to be followed as for whe
On 23.10.2016 05:37, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer
> ---
> libavutil/x86/emms.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavutil/x86/emms.h b/libavutil/x86/emms.h
> index 6fda6e2..42c18e2 100644
> --- a/libavutil/x86/emms.h
> +++ b/libavutil/
A negative sample rate doesn't make sense and triggers assertions in
av_rescale_rnd.
Signed-off-by: Andreas Cadhalpun
---
libavformat/adxdec.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavformat/adxdec.c b/libavformat/adxdec.c
index cf44531..0315ecb 100644
--- a/libavf
A negative sample rate doesn't make sense and triggers assertions in
av_rescale_rnd.
Signed-off-by: Andreas Cadhalpun
---
libavformat/bfi.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavformat/bfi.c b/libavformat/bfi.c
index 568363d..ef4c17d 100644
--- a/libavformat/bfi.c
A negative sample rate doesn't make sense and triggers assertions in
av_rescale_rnd.
Signed-off-by: Andreas Cadhalpun
---
libavformat/ffmdec.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/libavformat/ffmdec.c b/libavformat/ffmdec.c
index 16ba8ec..6b09be2 100644
--- a/libavf
A negative timescale doesn't make sense and triggers assertions in
av_rescale_rnd.
Signed-off-by: Andreas Cadhalpun
---
libavformat/mov.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 0a3fdd1..6f313a5 100644
A negative sample rate doesn't make sense and triggers assertions in
av_rescale_rnd.
fate-aac-al07_96 fails if sample_rate == 0 is rejected in
ff_mov_read_stsd_entries.
Signed-off-by: Andreas Cadhalpun
---
libavformat/mov.c | 8
1 file changed, 8 insertions(+)
diff --
A negative sample rate doesn't make sense and triggers assertions in
av_rescale_rnd.
Also check for errors from avpriv_mpeg4audio_get_config in
ff_mp4_read_dec_config_descr.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/mpeg4audio.c | 5 +
libavformat/isom.c | 6 --
2
A negative timescale doesn't make sense and triggers assertions in
av_rescale_rnd.
Signed-off-by: Andreas Cadhalpun
---
libavformat/mov.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 6f313a5..413675f 100644
--- a/libavformat/mov.c
A negative sample rate doesn't make sense and triggers assertions in
av_rescale_rnd.
Signed-off-by: Andreas Cadhalpun
---
libavformat/mvdec.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavformat/mvdec.c b/libavformat/mvdec.c
index 80ef4b1..f0a29eb 100644
--- a/libavformat/mv
A negative sample rate doesn't make sense and triggers assertions in
av_rescale_rnd.
Signed-off-by: Andreas Cadhalpun
---
libavformat/nuv.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/libavformat/nuv.c b/libavformat/nuv.c
index d920250..9bdea4a 100644
A negative sample rate doesn't make sense and triggers assertions in
av_rescale_rnd.
Signed-off-by: Andreas Cadhalpun
---
libavformat/oggparsespeex.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavformat/oggparsespeex.c b/libavformat/oggparsespeex.c
index 434b0fd..2b49150 1
A negative sample rate doesn't make sense and triggers assertions in
av_rescale_rnd.
Signed-off-by: Andreas Cadhalpun
---
libavformat/voc_packet.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavformat/voc_packet.c b/libavformat/voc_packet.c
index 5833a79..0d56436 100644
AVCodecParameters.sample_rate is a signed integer, so
XMVAudioPacket.sample_rate should be, too.
A negative sample rate doesn't make sense and triggers assertions in
av_rescale_rnd.
Signed-off-by: Andreas Cadhalpun
---
libavformat/xmv.c | 4 ++--
1 file changed, 2 insertions(+), 2 dele
On 24.10.2016 09:55, wm4 wrote:
> On Sun, 23 Oct 2016 18:27:02 +0200
> Andreas Cadhalpun wrote:
>
>> A negative sample rate doesn't make sense and triggers assertions in
>> av_rescale_rnd.
>>
>> Signed-off-by: Andreas Cadhalpun
>> ---
>>
On 23.10.2016 20:18, Carl Eugen Hoyos wrote:
> 2016-10-23 12:14 GMT+02:00 Andreas Cadhalpun
> :
>
>> I also don't like adding emms_c in various places, but I don't see a
>> realistic alternative
>
> (+1!)
>
>> other than not fixing the problem
On 24.10.2016 16:14, Ronald S. Bultje wrote:
> On Mon, Oct 24, 2016 at 8:47 AM, wm4 wrote:
>> On Mon, 24 Oct 2016 07:54:47 -0400
>> "Ronald S. Bultje" wrote:
>>> On Mon, Oct 24, 2016 at 3:36 AM, wm4 wrote:
I was under the impression that it is UB to have the FPU in MMX state
at any tim
On 24.10.2016 21:34, wm4 wrote:
> On Mon, 24 Oct 2016 21:19:46 +0200
> Andreas Cadhalpun wrote:
>> On 24.10.2016 16:14, Ronald S. Bultje wrote:
>>> On Mon, Oct 24, 2016 at 8:47 AM, wm4 wrote:
>>>> The next safest assumption is that it's fine as long as
This should reduce the impact of a demuxer (or API user) setting bogus
codec parameters.
Suggested-by: wm4
Signed-off-by: Andreas Cadhalpun
---
libavcodec/utils.c | 82 +-
1 file changed, 81 insertions(+), 1 deletion(-)
diff --git a
Bud-Id: https://bugs.gentoo.org/show_bug.cgi?id=598054
Signed-off-by: Andreas Cadhalpun
---
configure | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 481f692..14a20ed 100755
--- a/configure
+++ b/configure
@@ -1147,8 +1147,14
On 25.10.2016 12:58, Paul B Mahol wrote:
> patch(es)have good intent, but better fix is doing/checking it in single
> place.
I don't agree.
In general, validity checks should be where the values are actually read.
This eliminates the risk that bogus values could cause problems between being
set
On 25.10.2016 23:34, Carl Eugen Hoyos wrote:
> 2016-10-25 19:19 GMT+02:00 Andreas Cadhalpun
> :
>
>> +# LTO could optimize out the test functions without this
>> +echo "#if defined(__GNUC__) && __GNUC__ >= 4"
>> +
On 26.10.2016 01:26, Michael Niedermayer wrote:
> On Wed, Oct 26, 2016 at 01:16:13AM +0200, Andreas Cadhalpun wrote:
>> configure |7 ++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>> 742684cf379693d08075d43fdfb75ed5e2e936c6
>> 0001-configure-make-sur
On 25.10.2016 13:43, Michael Niedermayer wrote:
> On Tue, Oct 25, 2016 at 01:50:47AM +0200, Andreas Cadhalpun wrote:
>> This should reduce the impact of a demuxer (or API user) setting bogus
>> codec parameters.
>>
>> Suggested-by: wm4
>> Signed-off-by: Andreas
On 25.10.2016 14:56, Hendrik Leppkes wrote:
> On Tue, Oct 25, 2016 at 2:39 PM, wm4 wrote:
>> On Tue, 25 Oct 2016 09:47:29 +0200
>> Hendrik Leppkes wrote:
>>
>>> On Tue, Oct 25, 2016 at 1:50 AM, Andreas Cadhalpun
>>> wrote:
>>>> This should r
On 26.10.2016 10:52, Carl Eugen Hoyos wrote:
> 2016-10-26 1:16 GMT+02:00 Andreas Cadhalpun
> :
>> I'm under the impression that __attribute__((used)) is not available
>> for all compilers,
> Yes, but __attribute__((foo_bar)) does not break compilation here.
Have you te
On 26.10.2016 20:15, Paul B Mahol wrote:
> On 10/25/16, Michael Niedermayer wrote:
>> On Tue, Oct 25, 2016 at 07:45:25PM +0200, Andreas Cadhalpun wrote:
>>> On 25.10.2016 12:58, Paul B Mahol wrote:
>>>> patch(es)have good intent, but better fix is doing/checking it i
On 22.10.2016 01:16, Andreas Cadhalpun wrote:
> From 9de87a4fb2c6c6311a11a2da5de8554a71adfa66 Mon Sep 17 00:00:00 2001
> From: Andreas Cadhalpun
> Date: Mon, 17 Oct 2016 20:26:51 +0200
> Subject: [PATCH] avformat: close parser if codec changed
>
> The parser depends on the c
On 26.10.2016 22:57, Carl Eugen Hoyos wrote:
> 2016-10-26 21:36 GMT+02:00 Andreas Cadhalpun
> :
>> On 26.10.2016 10:52, Carl Eugen Hoyos wrote:
>>> 2016-10-26 1:16 GMT+02:00 Andreas Cadhalpun
>>> :
>>>> I'm under the impression that __attribute__(
On 27.10.2016 00:16, Rostislav Pehlivanov wrote:
> On 26 October 2016 at 22:48, James Almer wrote:
>
>> On 10/26/2016 6:19 PM, Rostislav Pehlivanov wrote:
>>> Also removes url_feof from libavformat.v which should have been
>>> removed long ago and changed the multipart jpeg boundary tag to
>>> ff
Hi,
On 26.10.2016 21:29, Michael Niedermayer wrote:
> On Tue, Sep 27, 2016 at 03:30:03PM +0200, Michael Niedermayer wrote:
>> Its long since FFmpeg 3.1, so its time to make 3.2
>> ill branch release/3.2 off master and make 3.2 in maybe about a week or
>> 2 unless something delays it
>
> release/3
On 27.10.2016 18:44, James Almer wrote:
> Could you do a bisect and trac ticket for these? HLS got a lot of commits in
> the past
> few months.
> apng didn't, so that one is weird.
I've found the commits causing the problems:
* commit 5ef19590802f000299e418143fc2301e3f43affe causes the apng issu
On 27.10.2016 20:07, Michael Niedermayer wrote:
> i didnt see this before making the release
Bad timing, can happen.
(I guess I should have checked this earlier, or rather FATE should have...)
> but 3.2.1 is planed in a week or 2
Let's get it fixed in that release.
Best regards,
Andreas
_
This fixes creating apng files.
This partly reverts commit 5ef19590802f000299e418143fc2301e3f43affe.
Signed-off-by: Andreas Cadhalpun
---
ffmpeg.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/ffmpeg.c b/ffmpeg.c
index 3b91710..9971148 100644
--- a/ffmpeg.c
+++ b/ffmpeg.c
This fixes probing dts/eac3/mp2 in hls.
This partly reverts commit 04964ac311abe670fb3b60290a330f2067544b13.
Signed-off-by: Andreas Cadhalpun
---
libavformat/hls.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/libavformat/hls.c b/libavformat/hls.c
index
On 27.10.2016 21:30, Hendrik Leppkes wrote:
> On Thu, Oct 27, 2016 at 9:20 PM, Andreas Cadhalpun
> wrote:
>> This fixes probing dts/eac3/mp2 in hls.
>>
>> This partly reverts commit 04964ac311abe670fb3b60290a330f2067544b13.
>>
>
> That commit does a lot of
6 Mon Sep 17 00:00:00 2001
From: Andreas Cadhalpun
Date: Thu, 27 Oct 2016 22:34:48 +0200
Subject: [PATCH] apng: use side data to pass extradata to muxer
This fixes creating apng files, which is broken since commit
5ef19590802f000299e418143fc2301e3f43affe.
Signed-off-by: Andreas Cadhalpun
---
l
On 27.10.2016 22:14, Michael Niedermayer wrote:
> On Wed, Oct 26, 2016 at 01:59:59AM +0200, Andreas Cadhalpun wrote:
>> Note that the added asserts are triggered by *many* of my fuzzed samples.
>> I'm happy to write patches for these cases, if we achieve agreement
>> th
1 - 100 of 1524 matches
Mail list logo
