[FFmpeg-devel] [PATCH] movenc: Add support for writing st3d and sv3d boxes.

2017-03-27 Thread Aaron Colwell
From 8654212c2f2a3ee404020cf5b948d7db3e6270f2 Mon Sep 17 00:00:00 2001 From: Aaron Colwell Date: Mon, 27 Mar 2017 08:00:12 -0700 Subject: [PATCH] movenc: Add support for writing st3d and sv3d boxes. --- libavformat/movenc.c | 105 +++ 1 file

Re: [FFmpeg-devel] [PATCH] movenc: Add support for writing st3d and sv3d boxes.

2017-03-27 Thread Aaron Colwell
Made all suggested changes and attached a new patch. Thanks for the quick review. Aaron On Mon, Mar 27, 2017 at 10:00 AM James Almer wrote: > On 3/27/2017 1:02 PM, Aaron Colwell wrote: > > > > 0001-movenc-Add-support-for-writing-st3d-andsv3d-boxes.patch &

Re: [FFmpeg-devel] [PATCH][RFC] avutil/spherical: add a flag to signal tiled/padded projections

2017-03-30 Thread Aaron Colwell
On Thu, Mar 30, 2017 at 7:17 AM James Almer wrote: > On 3/30/2017 5:54 AM, Vittorio Giovara wrote: > > On Wed, Mar 29, 2017 at 8:01 PM, James Almer wrote: > >> A new field is added to AVSphericalMapping for this purpose, > >> and is used by both Equirectangular and Cubemap projections. > >> This

[FFmpeg-devel] [PATCH] Add spherical_mapping command-line argument to ffmpeg.

2017-06-05 Thread Aaron Colwell
Add spherical_mapping command-line argument to ffmpeg. This allows adding AVSphericalMapping information to files that don't already have it. From eaa84a5f86d37e7de8bd0d6f72a308af57f3ef1d Mon Sep 17 00:00:00 2001 From: Aaron Colwell Date: Fri, 2 Jun 2017 16:11:21 -0700 Subject: [PATCH

Re: [FFmpeg-devel] [PATCH] Add spherical_mapping command-line argument to ffmpeg.

2017-06-05 Thread Aaron Colwell
index cef759cf27..643cff7f44 100644 > > --- a/libavutil/spherical.h > > +++ b/libavutil/spherical.h > > @@ -190,6 +190,20 @@ typedef struct AVSphericalMapping { > > */ > > AVSphericalMapping *av_spherical_alloc(size_t *size); > > > > +/** > > + * Parses a command-line option int

Re: [FFmpeg-devel] [PATCH] Add spherical_mapping command-line argument to ffmpeg.

2017-06-05 Thread Aaron Colwell
Attached a new patch that fixes a bug and the indentation in the previous patch. This should be good now. Sorry for the spam. Aaron On Mon, Jun 5, 2017 at 12:32 PM Aaron Colwell wrote: > Comments below.. > > On Mon, Jun 5, 2017 at 12:02 PM Vittorio Giovara < > vittorio.giov...@g

[FFmpeg-devel] [PATCH] ffmpeg: Add spherical_mapping command-line option.

2017-10-06 Thread Aaron Colwell
Allows spherical mapping metadata to be injected into files. From 6a86e9766708b9b74e4ae0ec6928a81df4041afc Mon Sep 17 00:00:00 2001 From: Aaron Colwell Date: Fri, 6 Oct 2017 08:14:15 -0700 Subject: [PATCH] ffmpeg: Add spherical_mapping command-line option. Allows spherical mapping metadata to be

Re: [FFmpeg-devel] [PATCH] ffmpeg: Add spherical_mapping command-line option.

2017-10-06 Thread Aaron Colwell
Hi Mark, You aren't missing anything. I haven't really used bsf's so it didn't occur to me to use them. I'll take a look. Thanks for the suggestion. Aaron On Fri, Oct 6, 2017 at 8:53 AM Mark Thompson wrote: > On 06/10/17 16:19, Aaron Colwell wrote: > > Allow

[FFmpeg-devel] [PATCH] mov: Fix spherical metadata_source field parsing.

2017-01-09 Thread Aaron Colwell
the string properly. Aaron From a20866dfeae07a5427e8255145f7fe19d846187d Mon Sep 17 00:00:00 2001 From: Aaron Colwell Date: Mon, 9 Jan 2017 09:58:01 -0800 Subject: [PATCH] mov: Fix spherical metadata_source field parsing. The metadata_source field is a null-terminated string like other ISOBMFF

Re: [FFmpeg-devel] [PATCH] mov: Fix spherical metadata_source field parsing.

2017-01-09 Thread Aaron Colwell
On Mon, Jan 9, 2017 at 6:00 PM James Almer wrote: > On 1/9/2017 3:47 PM, Aaron Colwell wrote: > > The attached patch fixes MOV spherical metadata parsing when the > > metadata_source field is not an empty string. > > > > The metadata_source field is a null-terminated

Re: [FFmpeg-devel] [PATCH] mov: Fix spherical metadata_source field parsing.

2017-01-09 Thread Aaron Colwell
On Mon, Jan 9, 2017 at 7:27 PM James Almer wrote: > On 1/9/2017 11:47 PM, Aaron Colwell wrote: > > On Mon, Jan 9, 2017 at 6:00 PM James Almer wrote: > > > >> On 1/9/2017 3:47 PM, Aaron Colwell wrote: > >>> The attached patch fixes MOV spherical metadata pa

[FFmpeg-devel] [PATCH] mov: Fix spherical metadata_source parsing.

2017-01-27 Thread Aaron Colwell
tents of the metadata_source field. From f63f65135e7059376acff3acc0e5268a8861d21d Mon Sep 17 00:00:00 2001 From: Aaron Colwell Date: Fri, 27 Jan 2017 09:33:29 -0800 Subject: [PATCH] mov: Fix spherical metadata_source parsing. The metadata_source field is a null-terminated string, like other IS

[FFmpeg-devel] [PATCH] movenc: Add support for writing st3d and sv3d boxes.

2017-01-27 Thread Aaron Colwell
Adding support for writing spherical metadata in MP4 files. From 8eb03f706e5c490be7a9644018dd3efaf0154a81 Mon Sep 17 00:00:00 2001 From: Aaron Colwell Date: Fri, 27 Jan 2017 10:07:44 -0800 Subject: [PATCH] movenc: Add support for writing st3d and sv3d boxes. Adding support for writing spherical

[FFmpeg-devel] [PATCH] matroskaenc: Add support for writing video projection.

2017-01-27 Thread Aaron Colwell
Adding support for writing spherical metadata in Matroska. From 5a9cf56bf3114186412bb5572b153f886edb6ddb Mon Sep 17 00:00:00 2001 From: Aaron Colwell Date: Fri, 27 Jan 2017 12:07:25 -0800 Subject: [PATCH] matroskaenc: Add support for writing video projection element. Adding support for writing

Re: [FFmpeg-devel] [PATCH] matroskaenc: Add support for writing video projection.

2017-01-27 Thread Aaron Colwell
On Fri, Jan 27, 2017 at 5:46 PM James Almer wrote: > On 1/27/2017 5:12 PM, Aaron Colwell wrote: > > Adding support for writing spherical metadata in Matroska. > > > > > > 0001-matroskaenc-Add-support-for-writing-video-projection.patch > > > > > > From

Re: [FFmpeg-devel] [PATCH] matroskaenc: Add support for writing video projection.

2017-01-31 Thread Aaron Colwell
On Tue, Jan 31, 2017 at 2:12 AM Vittorio Giovara wrote: > On Sat, Jan 28, 2017 at 4:13 AM, James Almer wrote: > > On 1/27/2017 11:21 PM, Aaron Colwell wrote: > >> On Fri, Jan 27, 2017 at 5:46 PM James Almer wrote: > >> > >> yeah. I'm a little confus

Re: [FFmpeg-devel] [PATCH] matroskaenc: Add support for writing video projection.

2017-02-03 Thread Aaron Colwell
On Fri, Feb 3, 2017 at 3:28 AM Vittorio Giovara wrote: > On Thu, Feb 2, 2017 at 9:34 PM, James Almer wrote: > > On 1/31/2017 12:40 PM, Aaron Colwell wrote: > >> > >> > >> On Tue, Jan 31, 2017 at 2:12 AM Vittorio Giovara < > vittorio.giov...@gmail.com

Re: [FFmpeg-devel] [PATCH] matroskaenc: Add support for writing video projection.

2017-02-06 Thread Aaron Colwell
wrote: > On Fri, Feb 3, 2017 at 5:57 PM, Aaron Colwell wrote: > > I still think you don't understand what these fields do given what you > say > > here. Yes there is a little more math. At the end of the day all these > > fields do is specify a the min & max for

[FFmpeg-devel] [PATCH] mov, matroskadec : Allow matroskadec & mov to share spherical parsing logic.

2017-02-06 Thread Aaron Colwell
- Extracts common spherical metadata parsing logic. - Adds checks to enforce that only non-tiled equirect & non-padded cubemaps are accepted. From 218dfd7ca1924bc44a168b34ec3c07051823c2dc Mon Sep 17 00:00:00 2001 From: Aaron Colwell Date: Mon, 6 Feb 2017 13:48:58 -0800 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-15 Thread Aaron Colwell
On Wed, Feb 15, 2017 at 5:52 AM James Almer wrote: > On 2/14/2017 11:20 PM, Vittorio Giovara wrote: > > On Tue, Feb 14, 2017 at 6:54 PM, James Almer wrote: > >> On 2/14/2017 5:52 PM, Vittorio Giovara wrote: > >>> On Fri, Feb 10, 2017 at 6:25 PM, Michael Niedermayer > >>> wrote: > On Fri, F

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-15 Thread Aaron Colwell
io Giovara < vittorio.giov...@gmail.com> wrote: > Hi Aaron, > > On Wed, Feb 15, 2017 at 11:48 AM, Aaron Colwell > wrote: > >> If the spec changes, it will be the contents of the equi/cbmp/mesh. > >> By exporting them raw as extradata, said changes in the spec would

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-16 Thread Aaron Colwell
On Thu, Feb 16, 2017 at 11:09 AM Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > On Wed, Feb 15, 2017 at 2:54 PM, Aaron Colwell > wrote: > > Hi Vittorio, > > > > This may not be a blocker for this patch, but one issue with converting > the > > bo

[FFmpeg-devel] [PATCH] Fix sample_aspect_ratio computation for stereo matroska content.

2015-11-23 Thread Aaron Colwell
matroskaenc.c applies divisors to the display width/height when generating stereo content. This patch adds the corresponding multipliers to matroskadec.c so that the original sample aspect ratio can be recovered. --- libavformat/matroskadec.c | 34 -- 1 file changed

Re: [FFmpeg-devel] [PATCH] Fix sample_aspect_ratio computation for stereo matroska content.

2015-11-25 Thread Aaron Colwell
On Tue, Nov 24, 2015 at 10:43 AM Kirill Gavrilov wrote: > On Mon, Nov 23, 2015 at 11:37 PM, Aaron Colwell > wrote: > > > matroskaenc.c applies divisors to the display width/height when > generating > > stereo content. This patch adds the corresponding multipliers to

Re: [FFmpeg-devel] [PATCH] Fix sample_aspect_ratio computation for stereo matroska content.

2015-11-30 Thread Aaron Colwell
On Mon, Nov 30, 2015 at 10:57 AM wm4 wrote: > On Mon, 30 Nov 2015 18:31:56 + > Aaron Colwell wrote: > > > Hi, > > Can I get a review for this please? It has been a week since I sent out > > this patch and I haven't gotten any real feedback about the chang

Re: [FFmpeg-devel] [PATCH] Fix sample_aspect_ratio computation for stereo matroska content.

2015-12-01 Thread Aaron Colwell
On Mon, Nov 30, 2015 at 4:35 PM wm4 wrote: > > I tried your patch, and it actually makes it work better (looks correct > with the patch). The patch itself also LGTM. > > Ok. Great. Thanks for the review. What do I need to do next to get this checked in. I don't have commit access. Aaron

Re: [FFmpeg-devel] [PATCH] Fix sample_aspect_ratio computation for stereo matroska content.

2015-12-02 Thread Aaron Colwell
On Wed, Dec 2, 2015 at 2:16 AM wm4 wrote: > On Wed, 02 Dec 2015 00:32:46 + > Aaron Colwell wrote: > > > On Mon, Nov 30, 2015 at 4:35 PM wm4 wrote: > > > > > > > > I tried your patch, and it actually makes it work better (looks correct > >