[FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

The vf_drawtext filter uses the GET_UTF8 macro in multiple locations. Each of these use `continue;` as the error handler. However the documentation for the GET_UTF8 macro states "ERROR should not contain a loop control statement which could interact with the internal while loop, and should force an

[FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

The vf_drawtext filter uses the GET_UTF8 macro in multiple locations. Each of these use `continue;` as the error handler. However the documentation for the GET_UTF8 macro states "ERROR should not contain a loop control statement which could interact with the internal while loop, and should force an

[FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

ork didn't pick it up. From efdc96ace59d676e76434499a399d1d7df7fa093 Mon Sep 17 00:00:00 2001 From: Aaron Boushley Date: Fri, 26 Jul 2019 15:49:36 -0700 Subject: [PATCH] libavfilter/drawtext: avoid undefined behavior with GET_UTF8 Currently the GET_UTF8 usage in drawtext use a continue

[FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing

option is passed). When loading the file over a network this results in significantly better performance since avformat_open_input doesn't require a scan of the entire file. Signed-off-by: Aaron Boushley --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mo

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing

On Mon, Nov 5, 2018 at 2:21 PM Michael Niedermayer wrote: > > On Mon, Nov 05, 2018 at 11:17:25AM -0800, Aaron Boushley wrote: > > When parsing a fragmented MP4 with the use_mfra_for option set so that > > the mfra box is parsed we currently continue to parse all the top level &g

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing

On Mon, Nov 5, 2018 at 3:13 PM Carl Eugen Hoyos wrote: > > 2018-11-06 0:03 GMT+01:00, Aaron Boushley : > > On Mon, Nov 5, 2018 at 2:21 PM Michael Niedermayer > > wrote: > > >> > diff --git a/libavformat/mov.c b/libavformat/mov.c > >> > index ec57a0580

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing

On Mon, Nov 5, 2018 at 3:25 PM Aaron Boushley wrote: > > On Mon, Nov 5, 2018 at 3:13 PM Carl Eugen Hoyos wrote: > > > > 2018-11-06 0:03 GMT+01:00, Aaron Boushley : > > > On Mon, Nov 5, 2018 at 2:21 PM Michael Niedermayer > > > wrote: > > > > &

[FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing (Take 2)

doesn't require a scan of the entire file. Aaron From 61412c5990037484e13c7daa60d83b8ba548b8a6 Mon Sep 17 00:00:00 2001 From: Aaron Boushley Date: Mon, 5 Nov 2018 11:02:00 -0800 Subject: [PATCH] libavformat/mov: Speed up fragmented mp4 parsing When parsing a fragmented MP4 with the use_mfr

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Speed up fragmented mp4 parsing (Take 2)

On Mon, Nov 5, 2018 at 3:48 PM Aaron Boushley wrote: > > Sorry for the second thread, first one was corrupted with a newline > because I attempted an inline patch. Hopefully the mime-type will be set > correctly on this one. > --- > When parsing a fragmented MP4 with the use_m

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

Can I get a review on this. Anywhere we have code calling out and performing undefined behavior we should clean that up. Aaron On Sat, Jul 27, 2019 at 7:58 AM Aaron Boushley wrote: > > The vf_drawtext filter uses the GET_UTF8 macro in multiple locations. > Each of these use `continue

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

yer wrote: > On Sat, Jul 27, 2019 at 07:58:48AM -0700, Aaron Boushley wrote: > > The vf_drawtext filter uses the GET_UTF8 macro in multiple locations. > > Each of these use `continue;` as the error handler. However the > > documentation for the GET_UTF8 macro states "ERROR s