Re: [FFmpeg-devel] [PATCH] matroskaenc: Add support for writing video projection.

2017-02-06 Thread Aaron Colwell
patch to fix the demuxers so they reject the "tiled equirect" cases for now. This seems like reasonable compromise to allow end-to-end preservation of non-controversial use cases. That is really all I'm trying to do right now. Aaron On Sat, Feb 4, 2017 at 7:46 AM Vittorio Giovara

[FFmpeg-devel] [PATCH] mov, matroskadec : Allow matroskadec & mov to share spherical parsing logic.

2017-02-06 Thread Aaron Colwell
- Extracts common spherical metadata parsing logic. - Adds checks to enforce that only non-tiled equirect & non-padded cubemaps are accepted. From 218dfd7ca1924bc44a168b34ec3c07051823c2dc Mon Sep 17 00:00:00 2001 From: Aaron Colwell Date: Mon, 6 Feb 2017 13:48:58 -0800 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-15 Thread Aaron Colwell
h for now. > > I too feel like this path is tying the API pretty closely to the Google draft's semantics. This seems ok for things like signalling projection type and yaw/pitch/roll projection rotation, but it seems a little risky for projecti

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-15 Thread Aaron Colwell
adjust it accordingly. I think cubemap padding in pixels may have a similar issue. This is no way intended to be a blocking comment. It is just meant to raise awareness on something you might not have considered. Thank you for your patience with me. Aaron On Wed, Feb 15, 2017 at 10:43 AM Vittor

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-16 Thread Aaron Colwell
On Thu, Feb 16, 2017 at 11:09 AM Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > On Wed, Feb 15, 2017 at 2:54 PM, Aaron Colwell > wrote: > > Hi Vittorio, > > > > This may not be a blocker for this patch, but one issue with converting > the > > bo

[FFmpeg-devel] libopenjpegenc initialization

2017-03-05 Thread Aaron Boxer
e the corresponding flags from the context. See here https://github.com/uclouvain/openjpeg/wiki/DocJ2KCodec for more info on how quality layers are specified in OpenJPEG. Also, there doesn't seem to be any way of setting lossy vs. lossless encoding. Kind Regards, Aaron __

[FFmpeg-devel] [PATCH] Clean up support for openjpeg encoder

2017-03-06 Thread Aaron Boxer
I limited encoder to single quality layer, since there is currently no way of specifying distortion for multiple layers. If there is any interest in this, I can add support. Someone just needs to tell me how to create an AVOption which takes a comma separated list of doubles. Cheers, Aaron 0001

Re: [FFmpeg-devel] [PATCH] Clean up support for openjpeg encoder

2017-03-06 Thread Aaron Boxer
On Mon, Mar 6, 2017 at 10:04 AM, Paul B Mahol wrote: > On 3/6/17, Aaron Boxer wrote: > > I limited encoder to single quality layer, since there is currently no > way > > of specifying distortion for multiple layers. If there is any interest in > > this, > > I can a

Re: [FFmpeg-devel] [PATCH] Clean up support for openjpeg encoder

2017-03-06 Thread Aaron Boxer
> > >> > >> This was vertically algined. Now its not any more. > >> > > > > > > How is this? Feels like doing ASCII artwork to format this. > > The irreversible thing is not used at all, its just blank option. > Yes, quite right. Here is an updated patch. > ___

Re: [FFmpeg-devel] [PATCH] Clean up support for openjpeg encoder

2017-03-06 Thread Aaron Boxer
One last change: numresolution default setting changed to 6, to match OpenJPEG default. On Mon, Mar 6, 2017 at 10:49 AM, Aaron Boxer wrote: > >> >> >> This was vertically algined. Now its not any more. >> >> >> > >> > >> > How is th

Re: [FFmpeg-devel] [PATCH] Clean up support for openjpeg encoder

2017-03-06 Thread Aaron Boxer
Sorry, another change: switched irreversible default to 0, which matches the OpenJPEG default (i.e. lossless is the default) On Mon, Mar 6, 2017 at 11:10 AM, Aaron Boxer wrote: > One last change: numresolution default setting changed to 6, to match > OpenJPEG default. > > On Mon,

[FFmpeg-devel] [PATCH] libavcodec/libopenjpegenc.c

2017-03-08 Thread Aaron Boxer
Final version of simple patch to : limit encoder to single layer add lossless option set better defaults for a few encoding parameters. Cheers, Aaron 0001-1.-limit-to-single-layer-as-there-is-no-current-supp.patch Description: Binary data ___ ffmpeg

Re: [FFmpeg-devel] [PATCH] libavcodec/libopenjpegenc.c

2017-03-09 Thread Aaron Boxer
On Thu, Mar 9, 2017 at 10:31 PM, Michael Bradshaw wrote: > On Wed, Mar 8, 2017 at 5:19 AM, Aaron Boxer wrote: > > > Final version of simple patch to : > > > > limit encoder to single layer > > add lossless option > > set better defaults for a few encoding par

Re: [FFmpeg-devel] [PATCH] libavcodec/libopenjpegenc.c

2017-03-10 Thread Aaron Boxer
On Fri, Mar 10, 2017 at 7:52 AM, Paul B Mahol wrote: > On 3/10/17, Michael Bradshaw wrote: > > On Thu, Mar 9, 2017 at 8:09 PM, Aaron Boxer wrote: > >> > >> Thanks, Michael. Here are those changes. > > > > > > Applied. Thanks for the patch! > >

Re: [FFmpeg-devel] [PATCH] libavcodec/libopenjpegenc.c

2017-03-10 Thread Aaron Boxer
On Fri, Mar 10, 2017 at 12:00 AM, Michael Bradshaw wrote: > On Thu, Mar 9, 2017 at 8:09 PM, Aaron Boxer wrote: > > > > Thanks, Michael. Here are those changes. > > > Applied. Thanks for the patch! > My pleasure. If there are any changes people are interested in for

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: add support for decoding teletext from 10bit ancillary data

2017-07-03 Thread Aaron Levinson
if (i == 22) +i = 317; } - if (i == 22) -i = 317; } vanc->Release(); if (txt_buf - txt_buf0 > 1) { Overall, looks good. I'll review the second patch in a bit. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] avdevice/decklink_dec: add support for receiving op47 teletext

2017-07-03 Thread Aaron Levinson
av_log(avctx, AV_LOG_ERROR, "Libzvbi support is needed for capturing teletext, please recompile FFmpeg.\n"); -return AVERROR(ENOSYS); -} -#endif - /* Check audio channel option for valid values: 2, 8 or 16 */ switch (cctx->audio_channel

Re: [FFmpeg-devel] [PATCH 2/2] avdevice/decklink_dec: add support for receiving op47 teletext

2017-07-03 Thread Aaron Levinson
On 7/3/2017 1:06 PM, Marton Balint wrote: On Mon, 3 Jul 2017, Aaron Levinson wrote: +22, and lines 318 to 335. Line 6 is the LSB in the mask. Selected lines which +do not contain teletext information will be ignored. You can use the special +@option{all} constant to select all possible

[FFmpeg-devel] Testing JPEG 2000 over MPEG TS

2017-07-22 Thread Aaron Boxer
test this feature with GStreamer, if anyone is interested. Cheers, Aaron ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Testing JPEG 2000 over MPEG TS

2017-07-23 Thread Aaron Boxer
On Sun, Jul 23, 2017 at 6:16 PM, Carl Eugen Hoyos wrote: > 2017-07-22 15:39 GMT+02:00 Aaron Boxer : > > > GStreamer project now has a working muxer/demuxer for J2K over MPEG TS. > > Did you test it? > Hi Carl. muxer+demuxer pipeline has been tested in GStreamer. Not

Re: [FFmpeg-devel] Testing JPEG 2000 over MPEG TS

2017-08-02 Thread Aaron Boxer
On Sun, Jul 23, 2017 at 6:16 PM, Carl Eugen Hoyos wrote: > 2017-07-22 15:39 GMT+02:00 Aaron Boxer : > > > GStreamer project now has a working muxer/demuxer for J2K over MPEG TS. > > Did you test it? > I have acquired a test capture of VSF TR1 video from a nevion VS902: ht

Re: [FFmpeg-devel] Testing JPEG 2000 over MPEG TS

2017-08-02 Thread Aaron Boxer
On Wed, Aug 2, 2017 at 12:02 PM, Carl Eugen Hoyos wrote: > 2017-08-02 14:07 GMT+02:00 Aaron Boxer : > > On Sun, Jul 23, 2017 at 6:16 PM, Carl Eugen Hoyos wrote: > > > >> 2017-07-22 15:39 GMT+02:00 Aaron Boxer : > >> > >> > GStreamer project now ha

Re: [FFmpeg-devel] Testing JPEG 2000 over MPEG TS

2017-08-02 Thread Aaron Boxer
Sorry, it looks like this is a packet capture of mpeg ts. On Wed, Aug 2, 2017 at 1:26 PM, Aaron Boxer wrote: > > > On Wed, Aug 2, 2017 at 12:02 PM, Carl Eugen Hoyos > wrote: > >> 2017-08-02 14:07 GMT+02:00 Aaron Boxer : >> > On Sun, Jul 23, 2017 at 6

Re: [FFmpeg-devel] [PATCH] JPEG2000 encoding with variable codeblock size

2017-08-03 Thread Aaron Boxer
On Aug 3, 2017 9:58 AM, wrote: From: Francesco Cuzzocrea Hi to all I've made some simple changes tha allow encoding with variable codeblock size. Default value are the same as previous (16X16) but now setting them to 64x128 make generated codestream compatible with Analog Devices ADV212 video

Re: [FFmpeg-devel] [PATCH] JPEG2000 encoding with variable codeblock size

2017-08-04 Thread Aaron Boxer
be less or equal to 12 ( xvalue + yvalue <=12). So 64x128 >> are allowed because >> >> xvalue = 4 and yvalue = 5. >> >> >> >> On 03/08/2017 19.24, Aaron Boxer wrote: >> >>> On Aug 3, 2017 9:58 AM, wrote: >>> >>> From: France

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

2017-12-28 Thread Aaron Levinson
formance perspective. According to the blog post, it builds at least twice as fast under WSL than it does with msys2. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

2017-12-29 Thread Aaron Levinson
deo modes, then there probably ought to be checks to make sure the code changes are only exercised for those video modes. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

2017-12-29 Thread Aaron Levinson
On 12/29/2017 10:12 AM, Devin Heitmueller wrote: Hook in libklvanc and use it for output of EIA-708 captions over SDI. The bulk of this patch is just general support for ancillary data for the Decklink SDI module - the real work for construction of the EIA-708 CDP and VANC line construction is d

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

2017-12-29 Thread Aaron Levinson
io_mode"}, +{ "discrete", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = AUDIO_MODE_DISCRETE}, 0, 0,DEC, "audio_mode"}, +{ "pairs",NULL, 0, AV_OPT_TYPE_CONST, { .i64 = AUDIO_MODE_PAIRS}, 0, 0,DEC, "audio_mode"}, { "duplex_mode", "duplex mode", OFFSET(duplex_mode), AV_OPT_TYPE_INT, { .i64 = 0}, 0, 2,DEC, "duplex_mode"}, { "unset", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = 0}, 0, 0,DEC, "duplex_mode"}, { "half", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = 1}, 0, 0,DEC, "duplex_mode"}, Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 5/8] Support encoding of Active Format Description (AFD) in libx264

2017-12-29 Thread Aaron Levinson
c 8.2.5) */ +sei_data[7] = 0x41; +sei_data[8] = 0xf0 | side_data->data[0]; + +return 0; +} + int64_t ff_guess_coded_bitrate(AVCodecContext *avctx) { AVRational framerate = avctx->framerate; I don't know enough about this to review the technical aspects of this co

Re: [FFmpeg-devel] [PATCH 6/8] Add suppoort for using libklvanc from within decklink capture module

2017-12-29 Thread Aaron Levinson
ERROR(). +goto error; +} else { +ctx->vanc_ctx->verbose = 0; +ctx->vanc_ctx->callbacks = &callbacks; +} +#endif + if (ctx->dli->StartStreams() != S_OK) { av_log(avctx, AV_LOG_ERROR, "Cannot start input stream\n"); ret = AVERROR(EIO); Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 7/8] decklink: Add support for SCTE-104 to decklink capture

2017-12-30 Thread Aaron Levinson
FSET(enable_scte_104), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, DEC, "enable_scte_104"}, { NULL }, }; diff --git a/libavdevice/version.h b/libavdevice/version.h index 364404d65e..0d4477f82e 100644 --- a/libavdevice/version.h +++ b/libavdevice/version.h @@ -29,7 +29,7

Re: [FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

2017-12-30 Thread Aaron Levinson
e need for using goto and the done label: store the return value of ScheduleAudioSamples() in a local variable. Then, free outbuf if appropriate. Then handle the ScheduleAudioSamples() failure case. Eliminating the goto will also make the code easier to understand, and it will result

Re: [FFmpeg-devel] [PATCH] tcp: properly return EOF

2017-12-30 Thread Aaron Levinson
On 12/30/2017 8:44 AM, wm4 wrote: There is no POSIX error code for EOF - recv() signals EOF by simply returning 0. But libavformat recently changed its conventionts and "conventionts" -> "conventions" requires an explicit AVERROR_EOF, or it might get into an endless retry loop, consuming 100%

[FFmpeg-devel] [PATCH] Fix sample_aspect_ratio computation for stereo matroska content.

2015-11-23 Thread Aaron Colwell
matroskaenc.c applies divisors to the display width/height when generating stereo content. This patch adds the corresponding multipliers to matroskadec.c so that the original sample aspect ratio can be recovered. --- libavformat/matroskadec.c | 34 -- 1 file changed

Re: [FFmpeg-devel] [PATCH] Fix sample_aspect_ratio computation for stereo matroska content.

2015-11-25 Thread Aaron Colwell
On Tue, Nov 24, 2015 at 10:43 AM Kirill Gavrilov wrote: > On Mon, Nov 23, 2015 at 11:37 PM, Aaron Colwell > wrote: > > > matroskaenc.c applies divisors to the display width/height when > generating > > stereo content. This patch adds the corresponding multipliers to

Re: [FFmpeg-devel] [PATCH] Fix sample_aspect_ratio computation for stereo matroska content.

2015-11-30 Thread Aaron Colwell
On Mon, Nov 30, 2015 at 10:57 AM wm4 wrote: > On Mon, 30 Nov 2015 18:31:56 + > Aaron Colwell wrote: > > > Hi, > > Can I get a review for this please? It has been a week since I sent out > > this patch and I haven't gotten any real feedback about the chang

Re: [FFmpeg-devel] [PATCH] Fix sample_aspect_ratio computation for stereo matroska content.

2015-12-01 Thread Aaron Colwell
On Mon, Nov 30, 2015 at 4:35 PM wm4 wrote: > > I tried your patch, and it actually makes it work better (looks correct > with the patch). The patch itself also LGTM. > > Ok. Great. Thanks for the review. What do I need to do next to get this checked in. I don't have c

Re: [FFmpeg-devel] [PATCH] Fix sample_aspect_ratio computation for stereo matroska content.

2015-12-02 Thread Aaron Colwell
On Wed, Dec 2, 2015 at 2:16 AM wm4 wrote: > On Wed, 02 Dec 2015 00:32:46 + > Aaron Colwell wrote: > > > On Mon, Nov 30, 2015 at 4:35 PM wm4 wrote: > > > > > > > > I tried your patch, and it actually makes it work better (looks correct > >

[FFmpeg-devel] [PATCH] lavc/libvpxenc: Fix parsing of ts_layering_mode parameter

2024-05-15 Thread Aaron Thompson via ffmpeg-devel
The value was being parsed as base 4, so the value "4" was invalid and would result in ts_layering_mode being set to 0. Signed-off-by: Aaron Thompson --- libavcodec/libvpxenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/l

<    1   2   3