Re: [FFmpeg-devel] [PATCH v1] lavf/url: fix rel path’s query string contains :/

2020-10-15 Thread
Thanks for your reply. Scheme can't contain ?. RFC3986 definition of Scheme (https://tools.ietf.org/html/rfc3986#section-3.1) scheme = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." ) Delimiters is lavf "schemes" can contain options, and ? should not be part of schemes. So it is not suitable to

Re: [FFmpeg-devel] [PATCH v1] lavf/url: fix rel path’s query string contains :/

2020-10-15 Thread
_absolute_url: (null) baz => baz /foo/bar baz => /foo/baz -- 2.24.1 (Apple Git-126) 蔡昊凝 于2020年10月16日周五 上午11:24写道: > Thanks for your reply. > > Scheme can't contain ?. > > R

Re: [FFmpeg-devel] [PATCH v1] lavf/url: fix rel path’s query string contains :/

2020-10-16 Thread
Although not a standard URL, is it necessary that protocol can contain "?" Regards, Nicolas George 于2020年10月16日周五 下午4:13写道: > 蔡昊凝 (12020-10-16): > > Scheme can't contain ?. > > Scheme in standard URLs cannot contain ?, but these are not standard > URLs,

Re: [FFmpeg-devel] [PATCH v1] lavf/url: fix rel path’s query string contains :/

2020-10-16 Thread
Excuse me, what does this mean for your last reply. I submitted the patch for the first time. Regards, Nicolas George 于2020年10月16日周五 下午6:55写道: > 蔡昊凝 (12020-10-16): > > Although not a standard URL, is it necessary that protocol can contain > "?" > > > > Regards

Re: [FFmpeg-devel] [PATCH v2] lavf/url: fix rel path’s query string contains :/

2020-10-17 Thread
Marton Balint 于2020年10月17日周六 下午4:35写道: > And why not also add # here as well? With the same logic, there can be > URL-s like dummy.mp4#t=0:02:00,121.5 and they will fail currently. > > Also a more clear wording for the comment: > /* lavf "schemes" can contain options but not some RFC 3986 delimit

Re: [FFmpeg-devel] [PATCH v3] lavf/url: fix rel path’s query string contains :/

2020-10-22 Thread
于2020年10月17日周六 下午11:17写道: > From: "ruiquan.crq" > > Signed-off-by: ruiquan.crq > --- > libavformat/tests/url.c | 2 ++ > libavformat/url.c | 2 +- > tests/ref/fate/url | 8 > 3 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/libavformat/tests/url.c b/libavfo