Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-09 Thread Дмитрий Гуменюк
There is no rush on this. Could you please do a code review so I can see how to do things properly? > On 10 Jan 2018, at 08:43, Kyle Swanson wrote: > > Hi, > > On Tue, Jan 9, 2018 at 3:49 PM, wrote: >> From: Dmytro Humeniuk >> >> Signed-off-by: Dmytro Humeniuk >> --- >> Changelog

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-10 Thread Дмитрий Гуменюк
Hi, While Waveform.js converts old SoundCloud PNGs, wavesurer.js is using Web Audio API which is limited/not supported by all browsers > On 10 Jan 2018, at 08:51, Дмитрий Гуменюк wrote: > > There is no rush on this. Could you please do a code review so I can see how > to do thi

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-10 Thread Дмитрий Гуменюк
> wavesurer.js - Web Audio API I mean its would be hard to do the same for large files https://developer.mozilla.org/en-US/docs/Web/API/BaseAudioContext/decodeAudioData > On 10 Jan 2018, at 09:04, Дмитрий Гуменюк wrote: > > Hi, > While Waveform.js converts old SoundCloud PNGs,

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-10 Thread Дмитрий Гуменюк
Same JSON schema used by SoundCloud > On 10 Jan 2018, at 10:16, Дмитрий Гуменюк wrote: > >> wavesurer.js - Web Audio API > I mean its would be hard to do the same for large files > https://developer.mozilla.org/en-US/docs/Web/API/BaseAudioContext/decodeAudioData > >&g

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-12 Thread Дмитрий Гуменюк
Hi > On 11 Jan 2018, at 09:20, Tobias Rapp wrote: > > On 10.01.2018 18:18, Kyle Swanson wrote: >> Hi, >> For this to be a part of libavfilter the output needs to be more generic >> than the just the Soundcloud format. If we want this to be generally useful >> it should probably just output an arr

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-12 Thread Дмитрий Гуменюк
> On 12 Jan 2018, at 13:17, Tobias Rapp wrote: > > On 12.01.2018 12:16, Дмитрий Гуменюк wrote: >> Hi >>> On 11 Jan 2018, at 09:20, Tobias Rapp wrote: >>> >>> On 10.01.2018 18:18, Kyle Swanson wrote: >>>> Hi, >>>> For th

Re: [FFmpeg-devel] [PATCH v2] avfilter: add dumpwave filter.

2018-01-12 Thread Дмитрий Гуменюк
Hi One more thing regarding asetnsamples->metadata I think it would be hard to set up 2 chains of them for getting 2 different “resolutions" at the same time > On 12 Jan 2018, at 08:36, Kyle Swanson wrote: > > Hi, > > Make sure you go back and read our comments. There were several things you >

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-12 Thread Дмитрий Гуменюк
Hi > On 12 Jan 2018, at 13:32, Дмитрий Гуменюк wrote: > >> On 12 Jan 2018, at 13:17, Tobias Rapp > <mailto:t.r...@noa-archive.com>> wrote: >> >> On 12.01.2018 12:16, Дмитрий Гуменюк wrote: >>> Hi >>>> On 11 Jan 2018, at 09:2

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-13 Thread Дмитрий Гуменюк
Hi, > On 13 Jan 2018, at 01:37, Дмитрий Гуменюк wrote: > > Hi > >> On 12 Jan 2018, at 13:32, Дмитрий Гуменюк wrote: >> >>> On 12 Jan 2018, at 13:17, Tobias Rapp wrote: >>> >>> On 12.01.2018 12:16, Дмитрий Гуменюк wrote: >>