Signed-off-by: Sasi Inguva
---
libavutil/frame.c | 1 +
libavutil/frame.h | 4
libavutil/version.h | 2 +-
3 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/libavutil/frame.c b/libavutil/frame.c
index 662c20d..3c74931 100644
--- a/libavutil/frame.c
+++ b/libavutil/frame.c
> On Fri, Aug 05, 2016 at 05:18:39PM -0700, Sasi Inguva wrote:
> > In YouTube we have long been receiving MOV files from users, which have
> non-trivial edit lists (Those edit lists which are not just used to offset
> video start from audio start) and multiple edit lists. Recently
timestamps, inside the read_packet function.
On Wed, Aug 10, 2016 at 5:08 AM, Hendrik Leppkes
wrote:
> On Wed, Aug 10, 2016 at 3:48 AM, Sasi Inguva
> wrote:
> > Signed-off-by: Sasi Inguva
> > ---
> > libavformat/avformat.h | 3 +++
> > libavformat/version.h
skip_samples shouldn't be negative. But it's not enforced because it is an int
field. Changed the condition to equality. Added an assert where skip_samples is
populated.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/li
Signed-off-by: Sasi Inguva
---
libavcodec/avcodec.h | 6 ++
libavcodec/utils.c | 15 ++-
libavcodec/version.h | 2 +-
3 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 3b21537..d68da01 100644
--- a/libavcodec
skip_samples shouldn't be negative. But it's not enforced because it is an
int field. Changed the condition to equality. Added an assert where
skip_samples is populated.
On Sun, Aug 14, 2016 at 5:40 AM, Clément Bœsch wrote:
> On Tue, Aug 09, 2016 at 06:48:21PM -0700, Sasi
Changes done. Also commented in the code about the differences between the
add_index_entry function and teh ff_add_index_entry function.
About stream copy, yes there will be a big behavior difference when doing "-c
copy" for files with edit lists.
Currently, ignoring edit lists we will copy all
Thanks
On Aug 17, 2016 6:25 AM, "Clément Bœsch" wrote:
> On Mon, Aug 15, 2016 at 07:04:56PM -0700, Sasi Inguva wrote:
> > Changes done. Also commented in the code about the differences between
> the add_index_entry function and teh ff_add_index_entry function.
> >
I don't know who the owner of MOV demuxer is. If somebody could do a deeper
review of this patch and approve it that would be great.
Thanks,
Sasi
On Wed, Aug 17, 2016 at 8:59 AM, Sasi Inguva wrote:
> Thanks
>
> On Aug 17, 2016 6:25 AM, "Clément Bœsch" wrote:
>
>&
ping!
On Fri, Aug 19, 2016 at 9:49 AM, Sasi Inguva wrote:
> I don't know who the owner of MOV demuxer is. If somebody could do a
> deeper review of this patch and approve it that would be great.
>
> Thanks,
> Sasi
>
> On Wed, Aug 17, 2016 at 8:59 AM, Sasi Inguva wrote
On Fri, Aug 26, 2016 at 5:55 PM, Michael Niedermayer wrote:
> On Fri, Aug 26, 2016 at 12:49:19PM -0700, Sasi Inguva wrote:
> > I think there is some bug in mp3 decoder which is making skip
> > samples -1431655766 for ~/tickets/5528/fire.mp3 . For now I have removed
> > th
On Aug 31, 2016 5:23 AM, "Michael Niedermayer"
wrote:
>
> On Tue, Aug 30, 2016 at 06:37:22PM -0700, Sasi Inguva wrote:
> > On Sun, Aug 28, 2016 at 3:10 AM, Michael Niedermayer
> > wrote:
> >
> > > On Sat, Aug 27, 2016 at 03:30:24PM -0700, Sasi Inguva
On Tue, Sep 13, 2016 at 4:39 PM, Sasi Inguva wrote:
> Sorry for the very late reply. I was busy with other things.
>
> On Sat, Sep 3, 2016 at 4:48 PM, Michael Niedermayer <
> mich...@niedermayer.cc> wrote:
>
>> On Sat, Sep 03, 2016 at 12:06:39PM -0700, Sasi In
Signed-off-by: Sasi Inguva
---
libavutil/frame.c | 1 +
libavutil/frame.h | 4
libavutil/version.h | 2 +-
3 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/libavutil/frame.c b/libavutil/frame.c
index 662c20d..3c74931 100644
--- a/libavutil/frame.c
+++ b/libavutil/frame.c
Signed-off-by: Sasi Inguva
---
libavformat/avformat.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/avformat.h b/libavformat/avformat.h
index 21e505d..ae70cc8 100644
--- a/libavformat/avformat.h
+++ b/libavformat/avformat.h
@@ -814,6 +814,9 @@ typedef struct AVIndexEntry
Signed-off-by: Sasi Inguva
---
ffprobe.c | 3 +-
tests/ref/fate/concat-demuxer-extended-lavf-mxf| 2 +-
.../ref/fate/concat-demuxer-extended-lavf-mxf_d10 | 2 +-
tests/ref/fate/concat-demuxer-simple1-lavf-mxf | 242 -
tests
Signed-off-by: Sasi Inguva
---
libavformat/utils.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/libavformat/utils.c b/libavformat/utils.c
index d605a96..f043bae 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@@ -1937,6 +1937,16 @@ int ff_index_search_timestamp
Signed-off-by: Sasi Inguva
---
libavcodec/avcodec.h | 6 ++
libavcodec/utils.c | 15 ++-
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 01f9b29..db1061d 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec
Is it ok to just log an error and return 0 ?
On Sep 18, 2016 1:53 PM, "Michael Niedermayer"
wrote:
> On Sat, Sep 17, 2016 at 03:14:24PM -0700, Sasi Inguva wrote:
> [...]
> > > [...]
> > > > @@ -2756,6 +2757,343 @@ static int mov_read_sbgp(MOVContext *c
On Sun, Sep 18, 2016 at 6:05 PM, Michael Niedermayer wrote:
> On Sun, Sep 18, 2016 at 02:45:52PM -0700, Sasi Inguva wrote:
> > Is it ok to just log an error and return 0 ?
>
> Is a global timescale of 0 allowed ?
> QT does not seem to explicitly say so
>
> can something
Thanks Michael, for the assiduous review. We caught 2-3 audio decoding bugs
because of it, and implemented basic seek functionality.
On Mon, Sep 19, 2016 at 10:54 AM, Michael Niedermayer <
mich...@niedermayer.cc> wrote:
> On Sun, Sep 18, 2016 at 10:09:03PM -0700, Sasi Inguva wrote:
&
wrote:
> On Mon, Sep 19, 2016 at 11:08:30AM -0700, Sasi Inguva wrote:
> > Thanks Michael, for the assiduous review. We caught 2-3 audio decoding
> bugs
> > because of it, and implemented basic seek functionality.
>
> It seems this causes a regression
> durandal117 and wm
Signed-off-by: Sasi Inguva
---
libavcodec/utils.c | 15 +++---
libavformat/mov.c| 75
tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 2 +-
tests/ref/fate/gaplessenc-pcm-to-mov-aac | 2 +-
4 files changed, 74
time, exactly as before the edit list patch.
On Mon, Sep 19, 2016 at 11:37 AM, wm4 wrote:
> On Tue, 9 Aug 2016 18:48:22 -0700
> Sasi Inguva wrote:
>
>
> > diff --git a/tests/ref/fate/gaplessenc-itunes-to-ipod-aac
> b/tests/ref/fate/gaplessenc-itunes-to-ipod-aac
>
On Mon, Sep 19, 2016 at 9:22 PM, Michael Niedermayer wrote:
> On Mon, Sep 19, 2016 at 06:31:31PM -0700, Sasi Inguva wrote:
> > Signed-off-by: Sasi Inguva
> > ---
> > libavcodec/utils.c | 15 +++---
> > libavformat/mov.c
Signed-off-by: Sasi Inguva
---
libavcodec/utils.c | 15 +++---
libavformat/mov.c| 81
tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 2 +-
tests/ref/fate/gaplessenc-pcm-to-mov-aac | 2 +-
4 files changed, 78
friendly ping
On Tue, Sep 20, 2016 at 2:29 PM, Sasi Inguva wrote:
> Signed-off-by: Sasi Inguva
> ---
> libavcodec/utils.c | 15 +++---
> libavformat/mov.c| 81
>
> tests/ref/fate/gaplessenc-
Signed-off-by: Sasi Inguva
---
libavcodec/utils.c | 16 +++---
libavformat/mov.c| 81
tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 2 +-
tests/ref/fate/gaplessenc-pcm-to-mov-aac | 2 +-
4 files changed, 79
On Thu, Sep 22, 2016 at 5:49 AM, wm4 wrote:
> On Tue, 20 Sep 2016 14:29:46 -0700
> Sasi Inguva wrote:
>
> > Signed-off-by: Sasi Inguva
> > ---
> > libavcodec/utils.c | 15 +++---
> > libavformat/mov.
ping
On Thu, Sep 15, 2016 at 1:36 PM, Sasi Inguva wrote:
> Signed-off-by: Sasi Inguva
> ---
> ffprobe.c | 3 +-
> tests/ref/fate/concat-demuxer-extended-lavf-mxf| 2 +-
> .../ref/fate/concat-demuxer-extended-lavf-mxf_d10 | 2
I have updated the patch with flag values for fate tests.
On Thu, Sep 22, 2016 at 11:38 AM, Sasi Inguva wrote:
>
> On Thu, Sep 22, 2016 at 5:49 AM, wm4 wrote:
>
>> On Tue, 20 Sep 2016 14:29:46 -0700
>> Sasi Inguva wrote:
>>
>> > Signed-off-by: Sasi Inguv
Signed-off-by: Sasi Inguva
---
libavcodec/utils.c | 16 +++---
libavformat/mov.c| 81
tests/fate-run.sh| 2 +-
tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 32 +--
tests/ref
Signed-off-by: Sasi Inguva
---
libavcodec/utils.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index b0345b6..6323156 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -2320,7 +2320,6 @@ int
Signed-off-by: Sasi Inguva
---
tests/fate-run.sh| 2 +-
tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 32 ++--
tests/ref/fate/gaplessenc-pcm-to-mov-aac | 32 ++--
tests/ref/fate/gaplessinfo-itunes1 | 32
Signed-off-by: Sasi Inguva
---
libavformat/mov.c| 81
tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 2 +-
tests/ref/fate/gaplessenc-pcm-to-mov-aac | 2 +-
3 files changed, 72 insertions(+), 13 deletions(-)
diff --git a/libavformat
Sent three separate patches. PTAL. Thanks.
On Fri, Sep 23, 2016 at 6:55 PM, Michael Niedermayer wrote:
> On Fri, Sep 23, 2016 at 06:20:18PM -0700, Sasi Inguva wrote:
> > Signed-off-by: Sasi Inguva
> > ---
> > libavcodec/utils.c | 16 +++---
&
On Mon, Sep 26, 2016 at 6:01 PM, Michael Niedermayer wrote:
> On Mon, Sep 26, 2016 at 11:42:50AM -0700, Sasi Inguva wrote:
> > Signed-off-by: Sasi Inguva
> > ---
> > libavcodec/utils.c | 16 +++-
> > 1 file changed, 7 insertions(+), 9 deletions(-)
&
On Mon, Sep 26, 2016 at 6:01 PM, Michael Niedermayer wrote:
> On Mon, Sep 26, 2016 at 11:42:50AM -0700, Sasi Inguva wrote:
> > Signed-off-by: Sasi Inguva
> > ---
> > libavcodec/utils.c | 16 +++-
> > 1 file changed, 7 insertions(+), 9 deletions(-)
&
Signed-off-by: Sasi Inguva
---
libavcodec/utils.c | 16 +++-
libavcodec/version.h | 2 +-
2 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index b0345b6..6323156 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
Fixes gapless decoding. Adjust skip_samples field correctly in case of
DISCARDed audio frames.
Signed-off-by: Sasi Inguva
---
libavformat/mov.c| 81
tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 2 +-
tests/ref/fate/gaplessenc-pcm-to
Fixes gapless decoding. Adjust skip_samples field correctly in case of
DISCARDed audio frames.
Signed-off-by: Sasi Inguva
---
libavformat/mov.c| 80
tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 2 +-
tests/ref/fate/gaplessenc-pcm-to
Corrected indentation. Don't know why the patch would not apply. I am
attaching it as a file, if it helps.
On Tue, Sep 27, 2016 at 12:02 PM, Moritz Barsnick wrote:
> On Tue, Sep 27, 2016 at 09:28:13 -0700, Sasi Inguva wrote:
> > if (curr_cts < edit_list_media
Signed-off-by: Sasi Inguva
---
libavcodec/movtextdec.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c
index abf8711..a33fff7 100644
--- a/libavcodec/movtextdec.c
+++ b/libavcodec/movtextdec.c
@@ -471,6 +471,10 @@ static int
Fixes DTS detection for any H264 file of less than 7 frames length. Without
this DTS is N/A.
Signed-off-by: Sasi Inguva
---
libavformat/utils.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavformat/utils.c b/libavformat/utils.c
index 5f48de1..5017937 100644
--- a
Fixes DTS detection for any H264 file of less than 7 frames length. Without
this DTS is N/A.
Signed-off-by: Sasi Inguva
---
libavformat/utils.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavformat/utils.c b/libavformat/utils.c
index 5f48de1..5017937 100644
--- a
Please ignore this patch as the commit message is incorrect. Sent a new
patch with corrected commit message.
On Mon, Mar 7, 2016 at 11:02 AM, Sasi Inguva wrote:
> Fixes DTS detection for any H264 file of less than 7 frames length.
> Without this DTS is N/A.
>
> Signed-off-by:
6AM -0800, Sasi Inguva wrote:
> > Fixes DTS detection for any H264 file of less than 7 frames length.
> Without this DTS is N/A.
> >
> > Signed-off-by: Sasi Inguva
> > ---
> > libavformat/utils.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
Fill DTS if all packets have been read in avformat_find_stream_info, and still
has_decode_delay_been_guessed returns false.
Signed-off-by: Sasi Inguva
---
libavformat/utils.c | 37 +
1 file changed, 37 insertions(+)
diff --git a/libavformat/utils.c b
With this patch it doesn't produce invalid DTS for the file you mentioned
tickets/1242/sample.mkv
./ffmpeg -i sample.mkv -c:v copy -an -t 1 -f framecrc -
On Fri, Mar 11, 2016 at 12:36 PM, Sasi Inguva wrote:
> Having another go at this. My goal is to fix DTS of H264 videos which are
&
Having another go at this. My goal is to fix DTS of H264 videos which are
shorter than 7 frames and don't have B-frames. Currently ffmpeg will output
DTS=N/A for such frames.
On Fri, Mar 11, 2016 at 12:34 PM, Sasi Inguva wrote:
> Fill DTS if all packets have been
For testing , a link to one such failing video
https://drive.google.com/file/d/0Bz6XfEJZ-9N3X0FSMWR6T3B3U28/view?usp=sharing
. Without this patch,
ffprobe -show_frames -print_format compact | grep media_type=video -
shows dts=N/A
On Fri, Mar 11, 2016 at 12:39 PM, Sasi Inguva wrote:
> W
x27;t figure out what return value maps to eof and what return value
maps to error , by reading the code of read_frame_internal . If you have an
idea, I can include the return value condition there.
Thanks
On Fri, Mar 11, 2016 at 1:52 PM, Carl Eugen Hoyos wrote:
> Sasi Inguva ffmpeg.org
Fill DTS if all packets have been read in avformat_find_stream_info, and still
has_decode_delay_been_guessed returns false.
Signed-off-by: Sasi Inguva
---
libavformat/utils.c | 77 ++---
tests/fate/h264.mak | 3 +
tests/ref/fate/h264-dts_5frames
, 2016 at 4:31 PM, Michael Niedermayer wrote:
> On Fri, Mar 11, 2016 at 01:54:07PM -0800, Sasi Inguva wrote:
> > For testing , a link to one such failing video
> >
> https://drive.google.com/file/d/0Bz6XfEJZ-9N3X0FSMWR6T3B3U28/view?usp=sharing
> > . Without this patch,
>
>
st AVIndexEntry
> *entries, int nb_entries,
> > m = (a + b) >> 1;
> >
> > // Search for the next non-discarded packet.
> > -while ((entries[m].flags & AVINDEX_DISCARD_FRAME) && m < b) {
> > +while ((entries[m].flags &
True. Correct way would be to have another option controlling just the
mov_fix_index part for the edit list code.
On Mon, Nov 14, 2016 at 5:48 AM, Derek Buitenhuis <
derek.buitenh...@gmail.com> wrote:
> On 11/12/2016 6:02 AM, Sasi Inguva wrote:
> > +/* Adjust skip_samples
; Sasi Inguva wrote:
>
> > Signed-off-by: Sasi Inguva
> > ---
> > libavformat/isom.h | 2 ++
> > libavformat/mov.c | 22 +-
> > 2 files changed, 23 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavformat/isom.h b/libavformat
Signed-off-by: Sasi Inguva
---
libavformat/isom.h | 1 +
libavformat/mov.c | 23 ---
2 files changed, 21 insertions(+), 3 deletions(-)
diff --git a/libavformat/isom.h b/libavformat/isom.h
index 12cefc9..ff3a234 100644
--- a/libavformat/isom.h
+++ b/libavformat/isom.h
Sent a patch adding a new option to lavf/mov.c . PTAL.
Thanks.
On Thu, Dec 29, 2016 at 2:15 PM, Sasi Inguva wrote:
> True. Correct way would be to have another option controlling just the
> mov_fix_index part for the edit list code.
>
> On Mon, Nov 14, 2016 at 5:48 AM, Dere
I agree . #4 makes the most sense.
On Thu, Jan 5, 2017 at 12:38 PM, Eran Kornblau
wrote:
> Hi all,
>
> We found today that this change:
> https://github.com/FFmpeg/FFmpeg/commit/ca6cae73db207f17a0d5507609de12
> 842d8f0ca3
> can break the decryption of MP4s encrypted with common encryption.
>
> I
Adding an MOV format option to turn on/off the editlist supporting code,
introduced in
https://github.com/FFmpeg/FFmpeg/commit/ca6cae73db207f17a0d5507609de12842d8f0ca3
Signed-off-by: Sasi Inguva
---
libavformat/isom.h | 1 +
libavformat/mov.c | 28
2 files
,7 @@ static int mov_read_packet(AVFormatContext *s,
> AVPacket *pkt)
> aax_filter(pkt->data, pkt->size, mov);
>
> if (sc->cenc.aes_ctr) {
> -ret = cenc_filter(mov, sc, pkt->data, pkt->size);
> +ret = cenc_filter(mov, sc, current_index, pkt->data,
According to spec ( ISO-IEC-15444-12 ) specifying edit list duration 0,
makes sense for MP4F files
"A non‐empty edit may insert a portion of the media timeline that is not
present in the initial movie, and
is present only in subsequent movie fragments. Particularly in an empty
initial movie of a f
Signed-off-by: Sasi Inguva
---
ffmpeg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ffmpeg.c b/ffmpeg.c
index 977708c069..a566c3fe2a 100644
--- a/ffmpeg.c
+++ b/ffmpeg.c
@@ -1347,7 +1347,7 @@ static void do_video_stats(OutputStream *ost, int
frame_size)
enc = ost
The mov_fix_index is executed inside mov_read_trak . Normally 'moof' atom
is after the 'trak' atom in mp4f file. So the method of looking whether
moof atom exists won't work.
On Thu, Jan 19, 2017 at 2:18 PM, Matthieu Bouron
wrote:
> On Thu, Jan 19, 2017 at 10:33:2
17 at 02:34:14PM -0800, Sasi Inguva wrote:
> > Signed-off-by: Sasi Inguva
> > ---
> > ffmpeg.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ffmpeg.c b/ffmpeg.c
> > index 977708c069..a566c3fe2a 100644
> > --- a/ffmp
Signed-off-by: Sasi Inguva
---
doc/ffmpeg.texi | 4
ffmpeg.c| 1 +
ffmpeg.h| 1 +
ffmpeg_opt.c| 3 +++
4 files changed, 9 insertions(+)
diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
index b56bdbe261..cdea1a271f 100644
--- a/doc/ffmpeg.texi
+++ b/doc/ffmpeg.texi
Thanks. I have sent a patch introducing -vstats_version option. PTAL.
On Sat, Jan 21, 2017 at 3:52 AM, Michael Niedermayer
wrote:
> On Fri, Jan 20, 2017 at 07:31:09PM -0800, Sasi Inguva wrote:
> > Couldn't find any version that relates to vstats. There is nothing that
> > sa
I have it in a separate patch. Sorry about the newline.
On Tue, Jan 24, 2017 at 6:47 AM, Moritz Barsnick wrote:
> On Tue, Jan 24, 2017 at 15:45:27 +0100, Moritz Barsnick wrote:
> > On Mon, Jan 23, 2017 at 18:25:45 -0800, Sasi Inguva wrote:
> >
> > > +@item -
Signed-off-by: Sasi Inguva
---
doc/ffmpeg.texi | 4
ffmpeg.h| 1 +
ffmpeg_opt.c| 3 +++
3 files changed, 8 insertions(+)
diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
index b56bdbe261..cdea1a271f 100644
--- a/doc/ffmpeg.texi
+++ b/doc/ffmpeg.texi
@@ -636,6 +636,10 @@ Calculate
Updated the patch with using vstats_version. PTAL.
On Sat, Jan 21, 2017 at 3:52 AM, Michael Niedermayer
wrote:
> On Fri, Jan 20, 2017 at 07:31:09PM -0800, Sasi Inguva wrote:
> > Couldn't find any version that relates to vstats. There is nothing that
> > says format may c
Signed-off-by: Sasi Inguva
---
doc/ffmpeg.texi | 8 +++-
ffmpeg.c| 9 +++--
ffmpeg_opt.c| 2 +-
3 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
index cdea1a271f..996d6a6cc4 100644
--- a/doc/ffmpeg.texi
+++ b/doc/ffmpeg.texi
Signed-off-by: Sasi Inguva
---
libavformat/matroskaenc.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index f731b678b9..88f6c647b9 100644
--- a/libavformat/matroskaenc.c
+++ b/libavformat/matroskaenc.c
@@ -393,6
> > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On
> Behalf Of Sasi Inguva
> > > > Sent: Wednesday, January 18, 2017 3:30 AM
> > > > To: FFmpeg development discussions and patches <
> ffmpeg-devel@ffmpeg.org>
> > > >
Signed-off-by: Sasi Inguva
---
libavformat/mov.c | 12
1 file changed, 12 insertions(+)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index b5181775e7..2a7cbfe142 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -2847,11 +2847,23 @@ static int64_t
According to
https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html
Signed-off-by: Sasi Inguva
---
libavformat/movenc.c| 70 +
tests/ref/fate/adtstoasc_ticket3715 | 4 +--
tests/ref/fate/copy-psp
byte addresses for some atoms will change for all
MP4 files .
On Fri, Aug 4, 2017 at 12:11 PM, Derek Buitenhuis <
derek.buitenh...@gmail.com> wrote:
> On 8/4/2017 7:46 PM, Sasi Inguva wrote:
> > According to https://developer.apple.com/library/content/documentation/
> Qu
According to
https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html
and ISO-IEC-14496-12 Section 10.1.1.1 and 10.1.1.3
Signed-off-by: Sasi Inguva
---
libavformat/movenc.c| 70 +
tests/ref/fate
To the best of my knowledge, all fate changes are benign. All of them
correspond to a size increase of 54 bytes, which is the total size of the
new atoms added.
On Sat, Aug 5, 2017 at 9:27 AM, Derek Buitenhuis wrote:
> On 8/4/2017 9:35 PM, Sasi Inguva wrote:
> > According
Ping!
On Aug 5, 2017 10:08 AM, "Sasi Inguva" wrote:
> To the best of my knowledge, all fate changes are benign. All of them
> correspond to a size increase of 54 bytes, which is the total size of the
> new atoms added.
>
> On Sat, Aug 5, 2017 at 9:27 AM, Derek Bui
According to
https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html
and ISO-IEC-14496-12 Section 10.1.1.1 and 10.1.1.3
Signed-off-by: Sasi Inguva
---
libavformat/movenc.c| 22 +++---
tests/ref/fate
Sorry, forgot to add the test reference files. Sending the revised patch.
On Wed, Mar 21, 2018 at 1:35 PM, Sasi Inguva wrote:
> Attaching fate sample.
>
> On Wed, Mar 21, 2018 at 1:33 PM, Sasi Inguva wrote:
>
>> Signed-off-by: Sasi Inguva
>> ---
>> libavform
Attaching fate sample.
On Wed, Mar 21, 2018 at 1:33 PM, Sasi Inguva wrote:
> Signed-off-by: Sasi Inguva
> ---
> libavformat/utils.c | 4 +++-
> tests/fate/mov.mak | 10 +-
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/utils.c
Signed-off-by: Sasi Inguva
---
libavformat/utils.c | 4 +++-
tests/fate/mov.mak | 10 +-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/libavformat/utils.c b/libavformat/utils.c
index 4d0b56c2a8..f13c8208b1 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
Signed-off-by: Sasi Inguva
---
libavformat/utils.c | 4 +++-
tests/fate/mov.mak| 10 +++-
tests/ref/fate/mov-neg-firstpts-discard | 3 +++
.../ref/fate/mov-neg-firstpts-discard-frames | 24 +++
4 files changed, 39
friendly ping
On Wed, Mar 21, 2018 at 2:55 PM, Michael Niedermayer
wrote:
> On Wed, Mar 21, 2018 at 01:35:05PM -0700, Sasi Inguva wrote:
> > Attaching fate sample.
>
> sample uploded
>
> thx
>
> [...]
>
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730B
If we can support ffmpeg to parse and display a timeline with multiple
edits correctly, I am ok with deleting that code.
On Thu, Mar 29, 2018 at 6:43 AM, Derek Buitenhuis <
derek.buitenh...@gmail.com> wrote:
> On 3/29/2018 1:06 PM, wm4 wrote:
> > I think mov files at least use a
> > filename/URL
Signed-off-by: Sasi Inguva
---
libavformat/mov.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index cb6f3a45de..6b13742e4d 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -3568,7 +3568,7 @@ static void mov_fix_index
From: Sasi Inguva
Using same timestamp for multiple packets confuses clients like Ffms2
while seeking to a packet with specific timestamp.
Signed-off-by: Sasi Inguva
---
libavformat/mov.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/libavformat/mov.c b
On Wed, Apr 4, 2018 at 8:30 AM, Vittorio Giovara wrote:
> The transformation operations that can be described by a display matrix
> are not limited to pure rotation, but include horizontal and vertical
> flip, as well as transpose and antitranspose. Unfortunately the current
> API can only return
>
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 5adba52e08..f0bd3e3623 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -3148,7 +3148,7 @@ static int find_prev_closest_index(AVStream *st,
> *ctts_index = 0;
> *ctts_sample = 0;
> for (index_ct
"
> |ctts_index| will be available outside of this function. How do we make
> sure it won't cause trouble later?
>
> On Fri, Feb 9, 2018 at 12:26 PM, Sasi Inguva org
> > wrote:
>
> > >
> > > diff --git a/libavformat/mov.c b/libavformat/mov.c
> > &g
, the "wrong"
> |ctts_index| will be available outside of this function. How do we make
> sure it won't cause trouble later?
>
> On Fri, Feb 9, 2018 at 12:26 PM, Sasi Inguva org
> > wrote:
>
> > >
> > > diff --git a/libavformat/mov.c b/libav
On Sun, Nov 19, 2017 at 12:46 PM, John Stebbins
wrote:
> ---
> libavformat/isom.h | 10 ++
> libavformat/mov.c | 92 ++
> ---
> libavformat/utils.c | 3 +-
> 3 files changed, 99 insertions(+), 6 deletions(-)
>
> diff --git a/libavformat/iso
This will increase memory requirement, since we are storing one CTTS for
each sample. Please see my comments on your previous patch.
On Sun, Nov 19, 2017 at 1:00 PM, John Stebbins
wrote:
> Merges ctts_data into mov_index_entries. This allows a considerable
> amount of code simplification.
> ---
This patch seems to be doing the wrong thing and breaking seek tests for us.
As far as I understand , seeking for most containers is based on "decoding
timestamp". Unless AV_SEEK_TO_PTS flag is specified in container, which is
not for most containers and MOV. So if PTS and DTS are like such,
Pts
ong because there is no offset between DTS and PTS in this case .
The offset by which to shift timestamp, can be computed more accurately.
I'll send a patch to fix this.
On Wed, Mar 7, 2018 at 3:27 AM, Michael Niedermayer
wrote:
> On Mon, Mar 05, 2018 at 03:53:04PM -0800, Sasi I
Fixes seek for files with empty edits and files with negative ctts
(dts_shift > 0). Added fate samples and tests.
Signed-off-by: Sasi Inguva
---
libavformat/isom.h | 1 +
libavformat/mov.c| 27 +++--
tests/fate/seek.mak |
Pass through color range to vp9 encoder, and parse it in libvpxdec
Signed-off-by: Sasi Inguva
---
libavcodec/libvpxdec.c | 4
libavcodec/libvpxenc.c | 20
2 files changed, 24 insertions(+)
diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c
index 7267590
Pass through color range to vp9 encoder.
Signed-off-by: Sasi Inguva
---
libavcodec/libvpxenc.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c
index 8588241..58da30d 100644
--- a/libavcodec/libvpxenc.c
+++ b
101 - 200 of 237 matches
Mail list logo
