Re: [FFmpeg-devel] [PATCH] Whisper audio filter

2025-07-10 Thread Zhao Zhili
> On Jul 10, 2025, at 16:43, Vittorio Palmisano > wrote: > >> While the filter provides great value, the accelerating pace of AI >> innovation raises concerns >> about its longevity. Given how rapidly newer models emerge, is there a risk >> of this filter >> becoming deprecated in the near

[FFmpeg-devel] [PATCH v4 1/3] avformat/tls_openssl: add hostname for verification

2025-07-10 Thread Marvin Scholz
From: Daniel N Pettersson When verification is enabled (using -tls_verify 1) now the hostname will be verified properly too, while before only other aspects of the certificate were checked. Co-Authored-By: Marvin Scholz --- libavformat/tls_openssl.c | 15 --- 1 file changed, 12 ins

[FFmpeg-devel] [PATCH v4 3/3] avformat/tls_openssl: load default verify locations

2025-07-10 Thread Marvin Scholz
When no explicit CAs file is set, load the default locations, else there is no way for verification to succeed. This matches the behavior of other TLS backends. --- libavformat/tls_openssl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_open

[FFmpeg-devel] [PATCH v4 2/3] avformat/tls_openssl: verify setting hostname for SNI

2025-07-10 Thread Marvin Scholz
--- libavformat/tls_openssl.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 8abe15ae55..33b3a46dfd 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -930,7 +930,11 @@ static int tls_open(

[FFmpeg-devel] [PATCH] Whisper audio filter

2025-07-10 Thread Vittorio Palmisano
It adds a new audio filter for running audio transcriptions with the whisper model. Documentation and examples are included into the patch. Signed-off-by: Vittorio Palmisano --- configure| 5 + doc/filters.texi | 101 libavfilter/Makefile | 2 + libavfil

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/tls_openssl: add hostname for verification

2025-07-10 Thread Marvin Scholz
On 8 Jul 2025, at 20:53, Marvin Scholz wrote: > From: Daniel N Pettersson > > When verification is enabled (using -tls_verify 1) now > the hostname will be verified properly too, while before > only other aspects of the certificate were checked. > > Co-Authored-By: Marvin Scholz > --- > liba

Re: [FFmpeg-devel] [PATCH] Whisper audio filter

2025-07-10 Thread Michael Niedermayer
Hi On Thu, Jul 10, 2025 at 10:34:50AM +0200, Vittorio Palmisano wrote: > Thanks Michael, I will try to answer your comments. > > > > +ffmpeg -i input.mp4 -vn -af > > > "aformat=sample_rates=16000:channel_layouts=mono,whisper= > > > > Is there a reason why we convert to 16khz mono here ? > > It

Re: [FFmpeg-devel] [PATCH v5] gcc: Don't disable '-ftree-vectorize' if gcc version higher than 13.

2025-07-10 Thread Martin Storsjö
On Thu, 10 Jul 2025, Jiawei wrote: Hi Martin, Is there any progress for this patch, should I resend it to the mailing list again? When I posted the updated version of the patch, the patchwork test runners noticed that this patch causes test failures on Loongarch. So modern versions of GCC

[FFmpeg-devel] [PATCH] libavcodec/alsdec.c: Add check for av_malloc_array() and av_calloc()

2025-07-10 Thread Jiasheng Jiang
Add check for the return value of av_malloc_array() and av_calloc() to avoid potential NULL pointer dereference. Fixes: dcfd24b10c ("avcodec/alsdec: Implement floating point sample data decoding") Signed-off-by: Jiasheng Jiang --- libavcodec/alsdec.c | 6 +- 1 file changed, 5 insertions(+),

[FFmpeg-devel] [PATCH v2] libavcodec/alsdec.c: Add check for av_malloc_array() and av_calloc()

2025-07-10 Thread Jiasheng Jiang
Add check for the return value of av_malloc_array() and av_calloc() to avoid potential NULL pointer dereference. Fixes: dcfd24b10c ("avcodec/alsdec: Implement floating point sample data decoding") Signed-off-by: Jiasheng Jiang --- Changelog: 1. Wrap the if condtion. --- libavcodec/alsdec.c | 8

Re: [FFmpeg-devel] [PATCH v2] ffprobe: add -codec: option

2025-07-10 Thread Maryla Ustarroz via ffmpeg-devel
--- Begin Message --- On Fri, Jun 27, 2025 at 10:24 AM Maryla Ustarroz-Calonge via ffmpeg-devel wrote: > > > > > -- Forwarded message -- > From: Maryla Ustarroz-Calonge > To: ffmpeg-devel@ffmpeg.org > Cc: > Bcc: > Date: Fri, 27 Jun 2025 10:23:56 +0200 > Subject: [PATCH v2] ffprobe

[FFmpeg-devel] [PATCH] avfilter/vf_blackdetect: add AVX2 SIMD version

2025-07-10 Thread Niklas Haas
From: Niklas Haas Requested by a user. Even with autovectorization enabled, the compiler performs a quite poor job of optimizing this function, due to not being able to take advantage of the pmaxub + pcmpeqb trick for counting the number of pixels less than or equal-to a threshold. blackdetect8_

[FFmpeg-devel] [PATCH 2/7] hwcontext_vulkan: temporarily disable host_image_copy

2025-07-10 Thread Lynne
NVIDIA's support for it is a disaster. Of no benefit to other vendors. NVIDIA are working on fixing it, but it may take time. --- libavutil/hwcontext_vulkan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 894bc3dae1..5a9b995eb

[FFmpeg-devel] [PATCH 3/7] vulkan: add support for 16-bit RGGB Bayer pixfmt

2025-07-10 Thread Lynne
--- libavutil/hwcontext_vulkan.c | 3 +++ libavutil/vulkan.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 5a9b995eb9..4551867b70 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil/hwcont

[FFmpeg-devel] [PATCH 1/7] vf_libplacebo: add support for specifying a LUT for the input

2025-07-10 Thread Lynne
This makes it possible to apply Adobe .cube files to inputs. --- libavfilter/vf_libplacebo.c | 28 1 file changed, 28 insertions(+) diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c index 475030c80d..d74a6e1bf7 100644 --- a/libavfilter/vf_libplace

[FFmpeg-devel] [PATCH 7/7] lavc: add a ProRes RAW Vulkan hwaccel

2025-07-10 Thread Lynne
This commit adds a ProRes RAW hardware implementation written in Vulkan. Both version 0 and version 1 streams are supported. The implementation is highly parallelized, with 512 invocations dispatched per every tile, with generally 4k tiles on a 5.8k stream. Thanks to unlord for the 8-point iDCT.

[FFmpeg-devel] [PATCH 6/7] lavc: add a ProRes RAW decoder

2025-07-10 Thread Lynne
--- configure | 1 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/proresdec_raw.c | 519 + libavcodec/proresdec_raw.h | 60 + 5 files changed, 582 insertions(+) create mode 100644 libavcodec/proresde

[FFmpeg-devel] [PATCH 5/7] lavc: add codec ID and profiles for ProRes RAW

2025-07-10 Thread Lynne
--- libavcodec/codec_desc.c | 8 libavcodec/codec_id.h | 1 + libavcodec/defs.h | 3 +++ libavcodec/profiles.c | 6 ++ libavcodec/profiles.h | 1 + libavformat/isom_tags.c | 4 6 files changed, 23 insertions(+) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_

[FFmpeg-devel] [PATCH 4/7] lavc/vulkan/common: sign-ify lengths

2025-07-10 Thread Lynne
This makes left_bits return useful data rather than overflowing, and also saves some 64-bit integer operations, which is still always a plus sadly. --- libavcodec/vulkan/common.comp | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/libavcodec/vulkan/commo

Re: [FFmpeg-devel] [PATCH] Whisper audio filter

2025-07-10 Thread Nicolas George
Nicolas George (HE12025-07-10): > A query_format() function is indeed suspiciously absent from this patch. And there is no reason for a filter of this kind to require activate(). Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@

Re: [FFmpeg-devel] [PATCH] Whisper audio filter

2025-07-10 Thread Michael Niedermayer
Hi Vittorio On Thu, Jul 10, 2025 at 12:25:41PM +0200, Vittorio Palmisano wrote: > It adds a new audio filter for running audio transcriptions with the whisper > model. > Documentation and examples are included into the patch. > > Signed-off-by: Vittorio Palmisano > --- > configure

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: fix leak of options dict on error

2025-07-10 Thread Marvin Scholz
On 8 Jul 2025, at 20:33, Kieran Kunhya via ffmpeg-devel wrote: > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.

[FFmpeg-devel] svg linked images: rendering images referenced with xlink:href attribute

2025-07-10 Thread swf2d49e--- via ffmpeg-devel
--- Begin Message --- Hi, I'm wondering if it was possible to add support for image links in svg files to ffmpeg? I was trying to use mpv (that uses ffmpeg) to render such linked images in .svg files directly, but it didn't show any images that were linked via xlink:href attribute. It only worked

Re: [FFmpeg-devel] [PATCH] Whisper audio filter

2025-07-10 Thread Michael Niedermayer
Hi On Wed, Jul 09, 2025 at 11:24:26PM +0800, Zhao Zhili wrote: > > > On Jul 9, 2025, at 15:23, Vittorio Palmisano > > wrote: > > > > It adds a new audio filter for running audio transcriptions with the > > whisper model. > > Documentation and examples are included into the patch. > > The pat

Re: [FFmpeg-devel] [PATCH v5] gcc: Don't disable '-ftree-vectorize' if gcc version higher than 13.

2025-07-10 Thread Martin Storsjö
On Thu, 10 Jul 2025, Jiawei wrote: In addition, can you provide a bug record or a reproduction method? I think it should also be fixed in the GCC community, and I will report the problems you encounter in test to GCC Bugzilla. https://patchwork.ffmpeg.org/check/125495/ If you build ffmpeg wi

[FFmpeg-devel] [PATCH v3] avformat/mov_muxer: Extended MOV muxer to handle APV video content

2025-07-10 Thread Dawid Kozinski
- Changes in mov_write_video_tag function to handle APV elementary stream - Provided structure APVDecoderConfigurationRecord that specifies the decoder configuration information for APV video content Signed-off-by: Dawid Kozinski --- libavcodec/cbs_apv.c| 19 +- libavformat/Makefile|

Re: [FFmpeg-devel] [PATCH] Whisper audio filter

2025-07-10 Thread Vittorio Palmisano
> Leaving out parameter names is a C++ thing, its not allowed in C. > Ok, I've added some modifications and fixed the empty transcription output. -- /Vittorio Palmisano/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rtsp: fix misleading indentation

2025-07-10 Thread Marvin Scholz
On 8 Jul 2025, at 17:09, Marvin Scholz wrote: > --- > libavformat/rtsp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c > index 8d360b375f..6201f09136 100644 > --- a/libavformat/rtsp.c > +++ b/libavformat/rtsp.c > @@ -602,8

Re: [FFmpeg-devel] [PATCHv2] avcodec/adpcm: squelch uninitialized variable warnings

2025-07-10 Thread Marvin Scholz
On 8 Jul 2025, at 21:16, Marvin Scholz wrote: > On 8 Jul 2025, at 10:49, Peter Ross wrote: > >> Fixes CID1655273 and CID1655274. >> --- >> v2: Use the new av_unreachable() macro >> >> libavcodec/adpcm.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/libavcodec/adpcm.c b/libavc

Re: [FFmpeg-devel] [PATCH] Whisper audio filter

2025-07-10 Thread Nicolas George
Michael Niedermayer (HE12025-07-10): > then af_whisper should take care of this automatically. > without the user having to add this convertion stuff manually A query_format() function is indeed suspiciously absent from this patch. Regards, -- Nicolas George __

Re: [FFmpeg-devel] [PATCH] Whisper audio filter

2025-07-10 Thread Marvin Scholz
On 10 Jul 2025, at 10:34, Vittorio Palmisano wrote: > Thanks Michael, I will try to answer your comments. > >>> +ffmpeg -i input.mp4 -vn -af >>> "aformat=sample_rates=16000:channel_layouts=mono,whisper= >> >> Is there a reason why we convert to 16khz mono here ? > > It is the only format suppo

Re: [FFmpeg-devel] [PATCH] Whisper audio filter

2025-07-10 Thread Vittorio Palmisano
> While the filter provides great value, the accelerating pace of AI innovation > raises concerns > about its longevity. Given how rapidly newer models emerge, is there a risk > of this filter > becoming deprecated in the near term? I think that the design of the whisper.cpp library allows us to

Re: [FFmpeg-devel] [PATCH] Whisper audio filter

2025-07-10 Thread Vittorio Palmisano
Thanks Michael, I will try to answer your comments. > > +ffmpeg -i input.mp4 -vn -af > > "aformat=sample_rates=16000:channel_layouts=mono,whisper= > > Is there a reason why we convert to 16khz mono here ? It is the only format supported by the whisper.cpp library. > > +model=../whisper.cpp/mode

Re: [FFmpeg-devel] [PATCH] avformat/scd: ensure SCD_MIN_HEADER_SIZE bytes are read

2025-07-10 Thread Michael Niedermayer
On Mon, Jul 07, 2025 at 09:25:30PM +0200, Kacper Michajłow wrote: > Instead of accessing unintialized data when input is shorter than > expected size. > > Fixes use of uninitialized value in MSAN build. > Found by OSS-Fuzz. > > Signed-off-by: Kacper Michajłow > --- > libavformat/scd.c | 3 ++- >

[FFmpeg-devel] [PATCH] fftools/cmdutils: Add av_freep() to avoid memory leak

2025-07-10 Thread Jiasheng Jiang
Add av_freep() to free new_elem to avoid memory leak. Fixes: 2d0bfbd0fa ("fftools/cmdutils: Use av_dynarray_add_nofree()") Signed-off-by: Jiasheng Jiang --- fftools/cmdutils.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c inde

[FFmpeg-devel] [PATCH] libavcodec/sonic.c: Add check for av_calloc()

2025-07-10 Thread Jiasheng Jiang
Add check for the return value of av_calloc() to avoid potential NULL pointer dereference. Fixes: 54f5fd22ea ("new opensource lossy/lossless audio codec based on speech compression techniques (actually based on bonk)") Signed-off-by: Jiasheng Jiang --- libavcodec/sonic.c | 2 ++ 1 file changed,

Re: [FFmpeg-devel] [PATCH 2/3] libavcodec: add NETINT Quadra HW decoders & encoders

2025-07-10 Thread Desmond Liu
Hi Timo, > I'm very much in favour of adding support. Assuming it is then also > properly maintained and not just "dumped" on us. > Of course we can't reasonably add support for every single niche bit of > hardware, but this seems mature and adopted enough to me to warrant it. Thanks. We don't re

Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth

2025-07-10 Thread Michael Niedermayer
Hi Nicolas On Wed, Jul 09, 2025 at 02:04:03PM +0200, Nicolas George wrote: > Michael Niedermayer (HE12025-07-07): > > a file called self_ref.ffconcat, containing: > > > > ffconcat version 1.0 > > file self_ref.ffconcat > > Oh, that. Thanks for explaining. I am not sure it is our responsibility >