[FFmpeg-devel] [PATCH 2/2] tests/fate: Sanyo LD-ADPCM test case

2025-06-25 Thread Peter Ross
--- tests/fate/audio.mak | 11 tests/ref/fate/sanyo-3bit | 36 + tests/ref/fate/sanyo-4bit | 46 +++ tests/ref/fate/sanyo-5bit | 57 +++ 4 files changed, 150 insertions(+) create mode 100644 test

Re: [FFmpeg-devel] [PATCH 2/2] avformat/tee: fix multiple bsfs in tee

2025-06-25 Thread Nicolas George
Marvin Scholz (HE12025-06-25): > Since 155508c6e925f4f2f5e77087a7e1925b3de735ff specifying multiple > bsfs for different streams was broken: > > "[bsfs/a=h264_metadata:bsfs/v=h264_metadata]out.mp4|..." > > This incorrectly only parsed the first bsfs specification. The reason > for this is that th

Re: [FFmpeg-devel] [PATCH 1/2] avformat/tee: refactor option processing

2025-06-25 Thread Nicolas George
Marvin Scholz (HE12025-06-25): > Instead of the convoluted nested macros, use a convenience > helper function. While this makes the code slightly longer, it > is now much clearer what is happening without running the file > through a preprocessor first. I do not find the modified code clearer than

Re: [FFmpeg-devel] [PATCH] Revert "Add FUNDING.json"

2025-06-25 Thread Michael Niedermayer
On Wed, Jun 25, 2025 at 12:14:15AM +0200, Kieran Kunhya via ffmpeg-devel wrote: > Date: Wed, 25 Jun 2025 00:14:15 +0200 > From: Kieran Kunhya > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] Revert "Add FUNDING.json" > > On Tue, Jun 24, 2025 at 8:48 AM Kiera

Re: [FFmpeg-devel] [PATCH] Revert "Add FUNDING.json"

2025-06-25 Thread Michael Niedermayer
On Tue, Jun 24, 2025 at 04:59:45PM +0200, Kieran Kunhya via ffmpeg-devel wrote: > Date: Tue, 24 Jun 2025 16:59:45 +0200 > From: Kieran Kunhya > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] Revert "Add FUNDING.json" > > On Tue, Jun 24, 2025 at 4:53 PM Micha

Re: [FFmpeg-devel] [PATCH 01/12] avfilter: factorize requesting an input frame from multi output filters

2025-06-25 Thread Nicolas George
Marton Balint (HE12025-06-24): > Signed-off-by: Marton Balint > --- > doc/filter_design.txt | 1 + > libavfilter/af_acrossover.c| 10 +- > libavfilter/af_channelsplit.c | 10 +- > libavfilter/filters.h | 15 +++ > libavfilter/split.c

Re: [FFmpeg-devel] [PATCH 1/2] avformat/tee: refactor option processing

2025-06-25 Thread Marvin Scholz
On 25 Jun 2025, at 13:23, Nicolas George wrote: > Marvin Scholz (HE12025-06-25): >> Instead of the convoluted nested macros, use a convenience >> helper function. While this makes the code slightly longer, it >> is now much clearer what is happening without running the file >> through a preproce

Re: [FFmpeg-devel] [PATCH v2 1/2] avfilter: add scale_d3d11 filter

2025-06-25 Thread Dash Santosh Sathyanarayanan
On 24-06-2025 13:26, Hendrik Leppkes wrote: +if (frames_ctx->sw_format == AV_PIX_FMT_NV12) { +frames_hwctx->BindFlags |= D3D11_BIND_VIDEO_ENCODER; +} The filter should be designed universally rather than expecting to be connected to something specific at its output.

[FFmpeg-devel] [PATCH] libavcodec/utils: Ensure allocated buffer is zero-initialized

2025-06-25 Thread xjdeng
In `av_fast_padded_mallocz`, the allocated buffer's zero-initialization is not guaranteed. This is because it calls `av_fast_malloc`, which in turn calls `fast_malloc` with `zero_realloc=0`. Consequently, the memory returned by the underlying `av_malloc` (used within `fast_malloc`) is not guaran

Re: [FFmpeg-devel] [PATCH] libavformat/usmdec: add support for HCA stream decryption

2025-06-25 Thread Andreas Rheinhardt
Pavel Roslyy: > --- > libavformat/usmdec.c | 53 +--- > 1 file changed, 50 insertions(+), 3 deletions(-) > > diff --git a/libavformat/usmdec.c b/libavformat/usmdec.c > index fd28e935ce..c5f2e208df 100644 > --- a/libavformat/usmdec.c > +++ b/libavformat/usmd

[FFmpeg-devel] [RFC] webp decoding

2025-06-25 Thread Michael Niedermayer
Hi some people use webp apparently, and we have no decoder There are 2 patchsets Thilos v13 (native decoder) Peters libwebp based one I tested both and thilos code decodes the files from the 4709 ticket i was not able to decode anything with peters patch. Iam not sure it needs some demuxer chang

[FFmpeg-devel] [PATCH v1] avformat/apvdec: framerate option added to the APV demuxer

2025-06-25 Thread Dawid Kozinski
Signed-off-by: Dawid Kozinski --- libavformat/apvdec.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/libavformat/apvdec.c b/libavformat/apvdec.c index 1e5497bcd3..420c7196fd 100644 --- a/libavformat/apvdec.c +++ b/libavformat/apvdec.c @@ -18,12 +1

[FFmpeg-devel] [PATCH] doc/developer: Fix typos

2025-06-25 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/developer: Fix typos Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-103%2Fsoftworkz%2Fsubmit_typos-v1 Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-103/softworkz/submit_typos-v1 Pull-R

Re: [FFmpeg-devel] [PATCH] doc/developer: Fix typos

2025-06-25 Thread Gyan Doshi
On 2025-06-26 12:16 pm, softworkz wrote: From: softworkz Signed-off-by: softworkz --- doc/developer: Fix typos Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-103%2Fsoftworkz%2Fsubmit_typos-v1 Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr

[FFmpeg-devel] [PATCH v2] avcodec/itut35: always check the provider code and country code together

2025-06-25 Thread Maryla Ustarroz-Calonge via ffmpeg-devel
--- Begin Message --- From: Maryla ITU-T T.35 provider codes are attributed by national bodies and it's possible to have collisions across countries. This is why the country code must always be checked as well. Use if statements rather than nested switches which would be unreadable. Rename some

[FFmpeg-devel] [PATCH 0/2] fix multiple memory leaks

2025-06-25 Thread Lidong Yan
This patch improves code in https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/345435.html -BEGIN PGP PUBLIC KEY BLOCK- mDMEaEpkmRYJKwYBBAHaRw8BAQdAGwGqH/Dwod+i6kR0/Rhn5GanJ7wK8mM9tWP/ W2qu8Ti0HTUwMjAyNDMzMDA1NkBzbWFpbC5uanUuZWR1LmNuiJkEExYKAEEWIQQC zskBcOehk1y8GoKZR31bPD+6owUCaEpkmQIb

[FFmpeg-devel] [PATCH 2/2] avformat/sapenc: fix leak in sap_write_header()

2025-06-25 Thread Lidong Yan
In sap_write_header(), ff_format_set_url() assign new allocated new_url to contexts[i]->url but forgot to free it later. Add for loop to free contexts[i]->url before av_free(context). To prevent from writing free-for-loop in every return point, replace `return 0` with `ret = 0` so normal execution

[FFmpeg-devel] [PATCH 1/2] avcodec/adpcm: Sanyo LD-ADPCM decoder

2025-06-25 Thread Peter Ross
--- adpcm_le.c was added because the decoder needs little-endian get_bits.h Samples: https://pross.sdf.org/sandpit/sanyo-mono-3bit-8000.wav https://pross.sdf.org/sandpit/sanyo-mono-4bit-8000.wav https://pross.sdf.org/sandpit/sanyo-mono-5bit-8000.wav libavcodec/Makefile | 1 + libavcodec/ad

Re: [FFmpeg-devel] [PATCH v2 1/2] avfilter: add scale_d3d11 filter

2025-06-25 Thread Hendrik Leppkes
On Tue, Jun 24, 2025 at 9:47 AM Dash Santosh Sathyanarayanan wrote: > > This commit introduces a new hardware-accelerated video filter, scale_d3d11, > which performs scaling and format conversion using Direct3D 11. The filter > enables > efficient GPU-based scaling and pixel format conversion (p0

[FFmpeg-devel] [PATCH] libavformat/usmdec: add support for HCA stream decryption

2025-06-25 Thread Pavel Roslyy
--- libavformat/usmdec.c | 53 +--- 1 file changed, 50 insertions(+), 3 deletions(-) diff --git a/libavformat/usmdec.c b/libavformat/usmdec.c index fd28e935ce..c5f2e208df 100644 --- a/libavformat/usmdec.c +++ b/libavformat/usmdec.c @@ -19,6 +19,7 @@ * Fou

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: at EOF, unref frame used for FPS conversion logic

2025-06-25 Thread Zhao Zhili
> On Jun 24, 2025, at 12:47, Steven Zhou wrote: > > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Zhao >> Zhili >> Sent: Monday, June 23, 2025 8:34 PM >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffm

[FFmpeg-devel] [PATCH 1/2] avfilter/asrc_sinc: fix leak in config_input()

2025-06-25 Thread Lidong Yan
In config_input(), fir_to_phase() allocates memory in h[longer]. But if av_calloc() to s->coeffs failed, memory in h[longer] would leak. Also noticed that after fir_to_phase() there are three return point, two of them didn't free h[longer]. However, the first return points means fir_to_phase() fail

Re: [FFmpeg-devel] [PATCH] Revert "Add FUNDING.json"

2025-06-25 Thread Michael Niedermayer
Hi Derek On Tue, Jun 24, 2025 at 06:24:32AM +0100, Derek Buitenhuis wrote: > On Monday, June 23, 2025, Michael Niedermayer > > > > and without a push noticed > > > to say it was going to be pushed. > > > > All members of the GA knew i intended to move forward > > with this. And they also knew th

[FFmpeg-devel] [PATCH v2 2/2] avcodec/mfenc: add support for D3D11 input surfaces

2025-06-25 Thread Dash Santosh Sathyanarayanan
Adds D3D11 input surface support to the MediaFoundation encoder (mfenc), allowing direct encoding of GPU frames without readback to system memory. This improves performance and compatibility when used alongside scale_d3d11. Signed-off-by: Dash Santosh --- libavcodec/mf_utils.h | 7 ++ libavcod

Re: [FFmpeg-devel] [PATCH] Revert "Add FUNDING.json"

2025-06-25 Thread Kieran Kunhya via ffmpeg-devel
--- Begin Message --- On Tue, 24 Jun 2025, 09:28 compn, wrote: > On Tue, 24 Jun 2025 07:48:30 +0100, Kieran Kunhya via ffmpeg-devel > wrote: > > > On Tue, 24 Jun 2025, 07:00 compn, wrote: > > > > > On Mon, 23 Jun 2025 21:20:56 +0100, Derek Buitenhuis wrote: > > > > > > > This was pushed with out

Re: [FFmpeg-devel] [PATCH] Revert "Add FUNDING.json"

2025-06-25 Thread Kieran Kunhya via ffmpeg-devel
--- Begin Message --- On Tue, 24 Jun 2025, 02:12 Michael Niedermayer, wrote: > Hi Derek > > You said > "The only mails you'll see from me in the future are code or reviews." > > On Mon, Jun 23, 2025 at 09:20:56PM +0100, Derek Buitenhuis wrote: > > This was pushed with outstanding reservations, >

Re: [FFmpeg-devel] [PATCH 12/12] avfilter/ffmpeg_filter: rate control all filter graphs

2025-06-25 Thread Michael Niedermayer
On Tue, Jun 24, 2025 at 09:23:10PM +0200, Marton Balint wrote: > It was never reliable to detect if a filtergraph have sources, because a > filter > can act as a source only after some time, for example the loop filter. > > So it is better to remove the source detection entirely and always give t

Re: [FFmpeg-devel] [PATCH] libavformat/usmdec: add support for HCA stream decryption

2025-06-25 Thread Michael Niedermayer
Hi On Mon, Jun 23, 2025 at 11:19:29PM -0700, Pavel Roslyy wrote: > --- > libavformat/usmdec.c | 53 +--- > 1 file changed, 50 insertions(+), 3 deletions(-) will apply please submit a patch adding documentation for both hca / usmdec to doc/ and also add a

Re: [FFmpeg-devel] [PATCH] libavformat/usmdec: add support for HCA stream decryption

2025-06-25 Thread Michael Niedermayer
On Thu, Jun 26, 2025 at 12:12:46AM +0200, Michael Niedermayer wrote: > Hi > > On Mon, Jun 23, 2025 at 11:19:29PM -0700, Pavel Roslyy wrote: > > --- > > libavformat/usmdec.c | 53 +--- > > 1 file changed, 50 insertions(+), 3 deletions(-) > > will apply bug

Re: [FFmpeg-devel] [PATCH] ffprobe: add -codec: option

2025-06-25 Thread James Zern via ffmpeg-devel
--- Begin Message --- On Tue, Jun 10, 2025 at 8:02 AM Maryla Ustarroz-Calonge via ffmpeg-devel wrote: > > > > > -- Forwarded message -- > From: Maryla Ustarroz-Calonge > To: ffmpeg-devel@ffmpeg.org > Cc: > Bcc: > Date: Tue, 10 Jun 2025 17:02:05 +0200 > Subject: [PATCH] ffprobe: ad

[FFmpeg-devel] [PATCH 6/8] avformat/tls_openssl: remove unnecessary checks

2025-06-25 Thread Marvin Scholz
Calling av_free with NULL is a no-op so this check is not needed. --- libavformat/tls_openssl.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 86e57ab389..8074251d9d 100644 --- a/libavformat/tls_openssl.c +++

[FFmpeg-devel] [PATCH 7/8] avformat/tls_openssl: use TLS_[client|server]_method

2025-06-25 Thread Marvin Scholz
SSLv23_*_method was just a define for these anyway since OpenSSL 1.1.0 and the old functions are deprecated. --- libavformat/tls_openssl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 8074251d9d..72ee36e7af 1006

[FFmpeg-devel] [PATCH 4/8] avformat/tls_openssl: properly get new BIO index

2025-06-25 Thread Marvin Scholz
As noted in the OpenSSL documentation, BIO_get_new_index must be used to get a new BIO index. This is ORd with the proper type flag BIO_TYPE_SOURCE_SINK. --- libavformat/tls_openssl.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/libavformat/tls_openssl.c b/

[FFmpeg-devel] [PATCH 5/8] avformat/tls_openssl: remove leftover comment

2025-06-25 Thread Marvin Scholz
--- libavformat/tls_openssl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 7f796c7ddb..86e57ab389 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -369,7 +369,6 @@ einval_end: ret = AVERROR(EINVAL); en

[FFmpeg-devel] [PATCH 2/8] avformat: tls: drop support for OpenSSL < 1.1.0

2025-06-25 Thread Marvin Scholz
--- libavformat/network.c | 8 -- libavformat/tls_openssl.c | 166 +- 2 files changed, 2 insertions(+), 172 deletions(-) diff --git a/libavformat/network.c b/libavformat/network.c index 2eabd0c167..a7026ac09b 100644 --- a/libavformat/network.c +++ b/libav

[FFmpeg-devel] [PATCH 1/8] configure: require at least OpenSSL 1.1.0

2025-06-25 Thread Marvin Scholz
Given that OPENSSL_init_ssl was introduced in 1.1.0 means we can rely on that to ensure we have at least 1.1.0. --- configure | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/configure b/configure index d625461983..25d736170b 100755 --- a/configure +++ b/configure @@ -7

[FFmpeg-devel] [PATCH 3/8] avformat/tls_openssl: remove now unnecessary define

2025-06-25 Thread Marvin Scholz
This was used previously when multiple OpenSSL versions were supported that required this to be handled differently. --- libavformat/tls_openssl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 525b7f3701..25991

[FFmpeg-devel] [PATCH 8/8] avformat/tls_openssl: use SSL_CTX_set_min_proto_version

2025-06-25 Thread Marvin Scholz
Using SSL_CTX_set_options to disallow specific versions is discouraged by the documentation, which recommends to use SSL_CTX_set_min_proto_version instead. --- libavformat/tls_openssl.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat

Re: [FFmpeg-devel] [PATCH v5] libavcodec/dvbsubenc.c: add a disable_2bpp option to work around some decoders.

2025-06-25 Thread Ronan Waide
> On 26 May 2025, at 19:41, Ronan Waide wrote: > >> >> On 14 Apr 2025, at 16:53, softworkz . >> wrote: >> >> >> >>> -Original Message- >>> From: ffmpeg-devel On Behalf Of >>> Ronan Waide >>> Sent: Sonntag, 30. März 2025 12:18 >>> To: FFmpeg development discussions and patches >>

Re: [FFmpeg-devel] [PATCH] checkasm/h264dsp: Fix stack-buffer-overflow, effective-type violations

2025-06-25 Thread Tristan Matthews via ffmpeg-devel
--- Begin Message --- On Monday, June 16th, 2025 at 2:22 PM, Andreas Rheinhardt wrote: > Tristan Matthews via ffmpeg-devel: > > > On Monday, June 16th, 2025 at 6:53 AM, Andreas Rheinhardt > > andreas.rheinha...@outlook.com wrote: > > > > > Patch attached. > > > > LGTM, and sorry about that,

Re: [FFmpeg-devel] [PATCH] avcodec/rv60dec: drop unused sum variable in read_slice_sizes

2025-06-25 Thread Michael Niedermayer
On Sun, Jun 22, 2025 at 02:33:10PM +1000, Peter Ross wrote: > --- > libavcodec/rv60dec.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is a danger to trust the dream we wish for rath