Re: [FFmpeg-devel] [PATCH 3/4] fftools/graph/graphprint: load CSS and HTML resources from ffmpeg data directories

2025-05-17 Thread Marton Balint
On Sat, 17 May 2025, softworkz . wrote: -Original Message- From: ffmpeg-devel On Behalf Of Marton Balint Sent: Samstag, 17. Mai 2025 01:09 To: ffmpeg-devel@ffmpeg.org Cc: Marton Balint Subject: [FFmpeg-devel] [PATCH 3/4] fftools/graph/graphprint: load CSS and HTML resources from

Re: [FFmpeg-devel] [PATCH] avfilter/version: Bump minor for avfilter_link_get_hw_frames_ctx()

2025-05-17 Thread James Almer
On 5/17/2025 10:13 AM, Andreas Rheinhardt wrote: Patch attached. (APIchanges even uses the wrong major version.) - Andreas I think this function should be removed instead, because it should have never been committed. The AVFilterLink API states that the user is not meant to access its intern

Re: [FFmpeg-devel] [PATCH 3/4] fftools/graph/graphprint: load CSS and HTML resources from ffmpeg data directories

2025-05-17 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Marton > Balint > Sent: Samstag, 17. Mai 2025 11:14 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 3/4] fftools/graph/graphprint: load CSS and > HTML resources from ffmpeg data directories >

Re: [FFmpeg-devel] [PATCH 2/3] fftools/graphprint: Fix leak of graphprint object

2025-05-17 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: Samstag, 17. Mai 2025 13:14 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 2/3] fftools/graphprint: Fix leak of graphprint > object > > --- > fftools/graph/graphprint.c | 2 ++ > 1 file chan

Re: [FFmpeg-devel] [PATCH 1/3] fftools/resources: fix preservation of intermediary resman build artifacts

2025-05-17 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Timo > Rothenpieler > Sent: Samstag, 17. Mai 2025 01:02 > To: ffmpeg-devel@ffmpeg.org > Cc: Timo Rothenpieler > Subject: [FFmpeg-devel] [PATCH 1/3] fftools/resources: fix preservation of > intermediary resman build artifacts > > W

Re: [FFmpeg-devel] [PATCH 3/3] fftools/resources: add missing extensions to .gitignore

2025-05-17 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Timo > Rothenpieler > Sent: Samstag, 17. Mai 2025 01:02 > To: ffmpeg-devel@ffmpeg.org > Cc: Timo Rothenpieler > Subject: [FFmpeg-devel] [PATCH 3/3] fftools/resources: add missing extensions > to .gitignore > > --- > fftools/resou

[FFmpeg-devel] [PATCH] avcodec/tests/.gitignore: Add apv test tool

2025-05-17 Thread Andreas Rheinhardt
Patch attached. - Andreas From abc080244caa6aa137e5bccd82aff5617c23d130 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sat, 17 May 2025 19:52:37 +0200 Subject: [PATCH] avcodec/tests/.gitignore: Add apv test tool Signed-off-by: Andreas Rheinhardt --- libavcodec/tests/.gitignore | 1 +

Re: [FFmpeg-devel] [PATCH 1/3] ffmpeg: Don't print graphs if there are no graphs to print

2025-05-17 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: Samstag, 17. Mai 2025 13:14 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 1/3] ffmpeg: Don't print graphs if there are no > graphs to print > > Avoids writing an empty json blob in setup err

Re: [FFmpeg-devel] [PATCH 1/2] avformat/demux: use io_close2 when closing avfromat

2025-05-17 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Kacper Michajłow: >> It's not valid to call avio_close() on context that has not been open >> with avio_open(). >> >> This fixes use of custom IO. (io_open / io_close2 callbacks) >> >> Note that by default io_close2 is set to io_close2_default() which calls >> avio_close(), so

[FFmpeg-devel] [PATCH] avformat/avformat: Remove outdated io_close2 documentation

2025-05-17 Thread Andreas Rheinhardt
Patch attached. - Andreas From 0e27f202721b7d3c6e06db5bb909787532350837 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sat, 17 May 2025 15:21:48 +0200 Subject: [PATCH] avformat/avformat: Remove outdated io_close2 documentation The io_close callback has been removed in d6799ee0e41dee35eb

Re: [FFmpeg-devel] [PATCH] avformat/flvenc: Specify codec tag with MKTAG

2025-05-17 Thread Zhao Zhili
> On May 17, 2025, at 19:14, Timo Rothenpieler wrote: > > On 17.05.2025 06:35, Zhao Zhili wrote: >>> 在 2025年5月17日,上午1:39,Timo Rothenpieler 写道: >>> >>> On 16.05.2025 19:24, Zhao Zhili wrote: >> On May 17, 2025, at 01:10, Zhao Zhili >> wrote: > > > >> On May 17, 20

Re: [FFmpeg-devel] FFmpeg 4.4.6 and 4.2.11

2025-05-17 Thread Michael Niedermayer
On Sat, Mar 15, 2025 at 01:36:59AM +0100, Michael Niedermayer wrote: > On Wed, Mar 12, 2025 at 02:17:32PM +0100, Michael Niedermayer wrote: > > On Mon, Mar 03, 2025 at 02:10:49AM +0100, Michael Niedermayer wrote: > > > Hi all > > > > > > As ive already backported and somewhat tested release/4.3 i

Re: [FFmpeg-devel] [PATCH 1/2] avformat/demux: use io_close2 when closing avfromat

2025-05-17 Thread Andreas Rheinhardt
Kacper Michajłow: > It's not valid to call avio_close() on context that has not been open > with avio_open(). > > This fixes use of custom IO. (io_open / io_close2 callbacks) > > Note that by default io_close2 is set to io_close2_default() which calls > avio_close(), so default case will work the

[FFmpeg-devel] [PATCH] avfilter/version: Bump minor for avfilter_link_get_hw_frames_ctx()

2025-05-17 Thread Andreas Rheinhardt
Patch attached. (APIchanges even uses the wrong major version.) - Andreas From 51232a1e903fdd11bd6a3fd5d7b20dd970f259c3 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sat, 17 May 2025 15:08:48 +0200 Subject: [PATCH] avfilter/version: Bump minor for avfilter_link_get_hw_frames_ctx() For

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/libaribb24: change new lines to \n in ASS header

2025-05-17 Thread Marton Balint
On Fri, 9 Aug 2024, Kacper Michajlow wrote: On Fri, 9 Aug 2024 at 00:04, Jan Ekström wrote: On Fri, May 10, 2024 at 11:31 PM Kacper Michajłow wrote: > > Fixes remaining \r\n is ASS header after 57c545090d. > > Signed-off-by: Kacper Michajłow > --- With an initial look this set looks good

Re: [FFmpeg-devel] [PATCH] avformat/flvenc: Specify codec tag with MKTAG

2025-05-17 Thread Timo Rothenpieler
On 17.05.2025 16:05, Zhao Zhili wrote: On May 17, 2025, at 19:14, Timo Rothenpieler wrote: On 17.05.2025 06:35, Zhao Zhili wrote: 在 2025年5月17日,上午1:39,Timo Rothenpieler 写道: On 16.05.2025 19:24, Zhao Zhili wrote: On May 17, 2025, at 01:10, Zhao Zhili wrote: On May 17, 2025, at 00:2

Re: [FFmpeg-devel] [PATCH 1/3] ffmpeg: Don't print graphs if there are no graphs to print

2025-05-17 Thread Mark Thompson
On 17/05/2025 18:52, softworkz . wrote: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Mark >> Thompson >> Sent: Samstag, 17. Mai 2025 13:14 >> To: ffmpeg-devel@ffmpeg.org >> Subject: [FFmpeg-devel] [PATCH 1/3] ffmpeg: Don't print graphs if there are >> no >> graphs to pri

Re: [FFmpeg-devel] [PATCH 1/3] ffmpeg: Don't print graphs if there are no graphs to print

2025-05-17 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: Samstag, 17. Mai 2025 20:19 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/3] ffmpeg: Don't print graphs if there > are no graphs to print > > On 17/05/2025 18:52, softworkz . wrote: >

Re: [FFmpeg-devel] [PATCH 2/3] ffbuild: correctly silence and tag new css/html steps

2025-05-17 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Timo > Rothenpieler > Sent: Samstag, 17. Mai 2025 01:02 > To: ffmpeg-devel@ffmpeg.org > Cc: Timo Rothenpieler > Subject: [FFmpeg-devel] [PATCH 2/3] ffbuild: correctly silence and tag new > css/html steps > > --- > ffbuild/common.

Re: [FFmpeg-devel] [PATCH v5 6/7] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-05-17 Thread Romain Beauxis
Le mar. 13 mai 2025 à 14:23, Michael Niedermayer a écrit : > > On Fri, May 09, 2025 at 06:43:26PM -0500, Romain Beauxis wrote: > > --- > > libavcodec/vorbisdec.c | 37 + > > libavformat/oggparsevorbis.c | 174 + > > tests/ref/fate/ogg-vor

Re: [FFmpeg-devel] [PATCH 3/3] fftools/graphprint: Fix leak of graph section header string

2025-05-17 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: Samstag, 17. Mai 2025 13:14 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 3/3] fftools/graphprint: Fix leak of graph > section header string > > --- > fftools/graph/graphprint.c | 2 ++ > 1

Re: [FFmpeg-devel] [PATCH 1/2] avformat/demux: use io_close2 when closing avfromat

2025-05-17 Thread Kacper Michajlow
On Sat, 17 May 2025 at 15:03, Andreas Rheinhardt wrote: > > Andreas Rheinhardt: > > Kacper Michajłow: > >> It's not valid to call avio_close() on context that has not been open > >> with avio_open(). > >> > >> This fixes use of custom IO. (io_open / io_close2 callbacks) > >> > >> Note that by defa

[FFmpeg-devel] [PATCH v2] ffmpeg: Don't print graphs if there are no outputs yet

2025-05-17 Thread Mark Thompson
Avoids writing an empty json blob in setup error cases. --- On 17/05/2025 20:08, softworkz . wrote: > If you could resubmit without the nb_filtergraphs check that would be fine! Sure, here. Thanks, - Mark fftools/ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffto

Re: [FFmpeg-devel] [PATCH v2] ffmpeg: Don't print graphs if there are no outputs yet

2025-05-17 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: Samstag, 17. Mai 2025 22:02 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v2] ffmpeg: Don't print graphs if there are no > outputs yet > > Avoids writing an empty json blob in setup error ca

Re: [FFmpeg-devel] [PATCH 3/4] fftools/graph/graphprint: load CSS and HTML resources from ffmpeg data directories

2025-05-17 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of softworkz . > Sent: Samstag, 17. Mai 2025 19:22 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 3/4] fftools/graph/graphprint: load CSS and > HTML resources from ffmpeg data directories > > >

[FFmpeg-devel] [PATCH v4 1/4] libavcodec/vc2enc: Split out common functions between software and hardware encoders

2025-05-17 Thread IndecisiveTurtle
From: IndecisiveTurtle --- libavcodec/Makefile| 2 +- libavcodec/vc2enc.c| 679 ++--- libavcodec/vc2enc_common.c | 571 +++ libavcodec/vc2enc_common.h | 178 ++ 4 files changed, 772 insertions(+), 658 deletions

[FFmpeg-devel] [PATCH v4 3/4] libavcodec/vulkan: Add modifications to common shader for VC2 vulkan encoder

2025-05-17 Thread IndecisiveTurtle
From: IndecisiveTurtle --- libavcodec/vulkan/common.comp | 54 --- 1 file changed, 44 insertions(+), 10 deletions(-) diff --git a/libavcodec/vulkan/common.comp b/libavcodec/vulkan/common.comp index 10af9c0623..db216a2ac6 100644 --- a/libavcodec/vulkan/common.comp

[FFmpeg-devel] [PATCH v4 2/4] libavcodec/vc2enc: Switch quant to int

2025-05-17 Thread IndecisiveTurtle
From: IndecisiveTurtle Prevents compiler from mistaking it as a string Also makes passing it to the GPU in a buffer easier --- libavcodec/vc2enc_common.c | 2 +- libavcodec/vc2enc_common.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vc2enc_common.c b/libav

[FFmpeg-devel] [PATCH v4 4/4] lavc: implement a Vulkan-based VC-2 encoder Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets and should work with all wavelet depths.

2025-05-17 Thread IndecisiveTurtle
From: IndecisiveTurtle Performance wise, encoding a 3440x1440 1-minute video is performed in about 2.4 minutes with the cpu encoder running on my Ryzen 5 4600H, while it takes about 1.3 minutes on my NVIDIA GTX 1650 Haar shader has a subgroup optimized variant that applies when configured wav

Re: [FFmpeg-devel] [PATCH v4 4/4] lavc: implement a Vulkan-based VC-2 encoder Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets and should work with all wavelet depths.

2025-05-17 Thread IndecisiveTurtle
I tried to solve all the review comments from the last patchset, please review in case I missed anything. Thanks Στις Σάβ 17 Μαΐ 2025 στις 11:49 μ.μ., ο/η IndecisiveTurtle έγραψε: > > From: IndecisiveTurtle > > Performance wise, encoding a 3440x1440 1-minute video is performed in about > 2.4 mi

[FFmpeg-devel] [PATCH v1] lavc/vvc: Avoid UB in DB strength derivation for PLT CUs

2025-05-17 Thread Frank Plowman
When called for palette-predicted CUs, boundary_strength could cause undefined behaviour due to accessing uninitialised motion information. The spec doesn't include this, but in the reference software it seems the deblock strength is always set to 0 for palette CUs due to some implementation detail

[FFmpeg-devel] [PATCH v1] lavc/vvc: Validate num_signalled_palette_entries

2025-05-17 Thread Frank Plowman
"The value of CurrentPaletteSize[ startComp ] shall be in the range of 0 to maxNumPaletteEntries, inclusive." Signed-off-by: Frank Plowman --- libavcodec/vvc/ctu.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/libavcodec/vvc/ctu.c b/libavcodec/vvc/ctu.c inde

Re: [FFmpeg-devel] [PATCH] cbs_apv: Fix memory leak on metadata parse failure

2025-05-17 Thread Mark Thompson
On 14/05/2025 21:50, Mark Thompson wrote: > Buffers are allocated inside some metadata types, so we must ensure > that the object is visible to the free function before a parse failure. > > Found by libFuzzer. > --- > libavcodec/cbs_apv_syntax_template.c | 4 ++-- > 1 file changed, 2 insertions(+

Re: [FFmpeg-devel] [PATCH] avformat/flvenc: Specify codec tag with MKTAG

2025-05-17 Thread Timo Rothenpieler
On 17.05.2025 06:35, Zhao Zhili wrote: 在 2025年5月17日,上午1:39,Timo Rothenpieler 写道: On 16.05.2025 19:24, Zhao Zhili wrote: On May 17, 2025, at 01:10, Zhao Zhili wrote: On May 17, 2025, at 00:27, Timo Rothenpieler wrote: On 16.05.2025 17:59, Zhao Zhili wrote: On May 16, 2025, at 22:52

[FFmpeg-devel] [PATCH 3/3] fftools/graphprint: Fix leak of graph section header string

2025-05-17 Thread Mark Thompson
--- fftools/graph/graphprint.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fftools/graph/graphprint.c b/fftools/graph/graphprint.c index 9e3e03274a..50f1a2ecdc 100644 --- a/fftools/graph/graphprint.c +++ b/fftools/graph/graphprint.c @@ -780,6 +780,8 @@ static int print_streams(GraphPrint

[FFmpeg-devel] [PATCH 2/3] fftools/graphprint: Fix leak of graphprint object

2025-05-17 Thread Mark Thompson
--- fftools/graph/graphprint.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fftools/graph/graphprint.c b/fftools/graph/graphprint.c index fc94a75797..9e3e03274a 100644 --- a/fftools/graph/graphprint.c +++ b/fftools/graph/graphprint.c @@ -862,6 +862,8 @@ static void uninit_graphprint(Graph

[FFmpeg-devel] [PATCH 1/3] ffmpeg: Don't print graphs if there are no graphs to print

2025-05-17 Thread Mark Thompson
Avoids writing an empty json blob in setup error cases. --- fftools/ffmpeg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 964770df23..ad28cff78d 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -309,7 +309,8 @@ const AVIOInt

Re: [FFmpeg-devel] [PATCH v5 6/7] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-05-17 Thread Michael Niedermayer
On Sat, May 17, 2025 at 01:10:26PM -0500, Romain Beauxis wrote: > Le mar. 13 mai 2025 à 14:23, Michael Niedermayer a > écrit : > > > > On Fri, May 09, 2025 at 06:43:26PM -0500, Romain Beauxis wrote: > > > --- > > > libavcodec/vorbisdec.c | 37 + > > > libavformat/oggparse

Re: [FFmpeg-devel] [PATCH v5 1/7] libavformat/oggdec.h: Document packet function return value.

2025-05-17 Thread Michael Niedermayer
On Fri, May 16, 2025 at 12:39:36PM -0500, Romain Beauxis wrote: > Le mer. 14 mai 2025 à 17:32, Michael Niedermayer a > écrit : > > > > On Fri, May 09, 2025 at 06:43:21PM -0500, Romain Beauxis wrote: > > > --- > > > libavformat/oggdec.h | 6 ++ > > > 1 file changed, 6 insertions(+) > > > > > >

Re: [FFmpeg-devel] FFmpeg 6.1.3 and 7.0.3

2025-05-17 Thread Michael Niedermayer
On Sat, May 17, 2025 at 05:03:22PM +0200, Michael Niedermayer wrote: > On Sat, Mar 15, 2025 at 01:36:59AM +0100, Michael Niedermayer wrote: > > On Wed, Mar 12, 2025 at 02:17:32PM +0100, Michael Niedermayer wrote: > > > On Mon, Mar 03, 2025 at 02:10:49AM +0100, Michael Niedermayer wrote: > > > > Hi

Re: [FFmpeg-devel] [PATCH] avformat/flvenc: Specify codec tag with MKTAG

2025-05-17 Thread Michael Niedermayer
Hi Zhao Zhili On Sat, May 17, 2025 at 10:05:34PM +0800, Zhao Zhili wrote: > > > > On May 17, 2025, at 19:14, Timo Rothenpieler wrote: > > > > On 17.05.2025 06:35, Zhao Zhili wrote: > >>> 在 2025年5月17日,上午1:39,Timo Rothenpieler 写道: > >>> > >>> On 16.05.2025 19:24, Zhao Zhili wrote: > >> On

Re: [FFmpeg-devel] [PATCH v1] lavc/vvc: Validate num_signalled_palette_entries

2025-05-17 Thread Nuo Mi
Hi Frank, 👍,your fuzzing infrastructure caught this issue as well. How about this: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20250517055150.807683-1-nuomi2...@gmail.com/ On Sun, May 18, 2025 at 5:05 AM Frank Plowman wrote: > "The value of CurrentPaletteSize[ startComp ] shall be in the r

[FFmpeg-devel] [PATCH] ffbuild/commonmak: Fix rebuild check with implicit rule chains

2025-05-17 Thread softworkz
From: softworkz When there's a chain of implicit rules, make treats files generated inside that chain as intermediate files. Those intermediate files are removed after completion of make. When make is run again, it normally determines the need for a rebuild by comparing the timestamps of the orig

Re: [FFmpeg-devel] [PATCH 1/3] fftools/resources: fix preservation of intermediary resman build artifacts

2025-05-17 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Timo > Rothenpieler > Sent: Samstag, 17. Mai 2025 01:02 > To: ffmpeg-devel@ffmpeg.org > Cc: Timo Rothenpieler > Subject: [FFmpeg-devel] [PATCH 1/3] fftools/resources: fix preservation of > intermediary resman build artifacts > > W

[FFmpeg-devel] [PATCH v2] ffbuild/commonmak: Fix rebuild check with implicit rule chains

2025-05-17 Thread softworkz
From: softworkz When there's a chain of implicit rules, make treats files generated inside that chain as intermediate files. Those intermediate files are removed after completion of make. When make is run again, it normally determines the need for a rebuild by comparing the timestamps of the orig

Re: [FFmpeg-devel] [PATCH v1] lavc/vvc: Validate num_signalled_palette_entries

2025-05-17 Thread Frank Plowman
On 18/05/2025 02:42, Nuo Mi wrote: > Hi Frank, > 👍,your fuzzing infrastructure caught this issue as well. > How about this: > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20250517055150.807683-1-nuomi2...@gmail.com/ Sorry, I missed this. Your patch looks good to me: probably preferable in th