Re: [FFmpeg-devel] [PATCH v3 1/2] libavformat/oggdec.c: Changing the packet() callback API/Return value

2025-05-04 Thread Romain Beauxis
Le dim. 4 mai 2025 à 09:04, Michael Niedermayer a écrit : > > On Sat, May 03, 2025 at 12:03:28PM -0500, Romain Beauxis wrote: > > --- > > libavformat/oggdec.c | 22 ++ > > libavformat/oggdec.h | 6 ++ > > 2 files changed, 20 insertions(+), 8 deletions(-) > > > > diff --gi

Re: [FFmpeg-devel] [PATCH v3 1/2] libavformat/oggdec.c: Changing the packet() callback API/Return value

2025-05-04 Thread Michael Niedermayer
On Sun, May 04, 2025 at 11:42:13AM -0500, Romain Beauxis wrote: > Le dim. 4 mai 2025 à 09:04, Michael Niedermayer a > écrit : > > > > On Sat, May 03, 2025 at 12:03:28PM -0500, Romain Beauxis wrote: > > > --- > > > libavformat/oggdec.c | 22 ++ > > > libavformat/oggdec.h | 6 +

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-05-04 Thread Stefano Sabatini
On date Tuesday 2025-04-29 10:30:55 +0200, Nicolas George wrote: > Stefano Sabatini (HE12025-04-27): > > Elaborating on this. ffprobe/textformat is based on a notion of > > hierarchical tree-like data > > No, this is not true. FFprobe and all its supporting code is based on > one level of hierarc

[FFmpeg-devel] [PATCH] libpostproc/tests: Factor ff_chksum() out

2025-05-04 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libpostproc/Makefile | 6 ++ libpostproc/test_utils.c | 38 ++ libpostproc/test_utils.h | 27 libpostproc/tests/blocktest.c | 18 ++-- libpostproc/tests/stripete

[FFmpeg-devel] [PATCH v11 00/15] Execution Graph Printing

2025-05-04 Thread ffmpegagent
Shortest cover letter for my longest-running FFmpeg patchset: * Apply * Build * Add the "-sg" switch to any FFmpeg command line * Press 'q' when you don't want to wait SG = Show Graph Documentation and examples can be found here: https://github.com/softworkz/ffmpeg_output_apis/wiki Versio

[FFmpeg-devel] [PATCH v11 14/15] fftools/graphprint: Add execution graph printing

2025-05-04 Thread softworkz
From: softworkz The key benefits are: - Different to other graph printing methods, this is outputting: - all graphs with runtime state (including auto-inserted filters) - each graph with its inputs and outputs - all filters with their in- and output pads - all connections between all

[FFmpeg-devel] [PATCH v11 12/15] fftools/resources: Add resource manager files with build-time compression

2025-05-04 Thread softworkz
From: softworkz Compression requires zlib to be available, otherwise resources will be included uncompressed - in either case via BIN2C. It can also be disabled via ./configure --disable-resource-compression Size figures: graph.css 7752 graph.css.min 6655 (css is always minified)

[FFmpeg-devel] [PATCH v11 10/15] fftools/ffmpeg_filter: Move some declaration to new header file

2025-05-04 Thread softworkz
From: softworkz to allow filtergraph printing to access the information. Signed-off-by: softworkz --- fftools/ffmpeg_filter.c | 190 +--- fftools/ffmpeg_filter.h | 234 2 files changed, 235 insertions(+), 189 deletions(-) cr

[FFmpeg-devel] [PATCH v11 11/15] avfilter/avfilter: Add avfilter_link_get_hw_frames_ctx()

2025-05-04 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/APIchanges | 3 +++ libavfilter/avfilter.c | 9 + libavfilter/avfilter.h | 12 3 files changed, 24 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index 75d66f87f3..d0869561f3 100644 --- a/doc/APIchanges

[FFmpeg-devel] [PATCH v11 13/15] fftools/ffmpeg_mux: Make ms_from_ost() inline

2025-05-04 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/ffmpeg_mux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux.h b/fftools/ffmpeg_mux.h index f41f2c18fa..4ca8ab73a4 100644 --- a/fftools/ffmpeg_mux.h +++ b/fftools/ffmpeg_mux.h @@ -123,7 +123,7 @@ typedef

[FFmpeg-devel] [PATCH v11 01/15] fftools/textformat: Formatting and whitespace changes

2025-05-04 Thread softworkz
From: softworkz Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 92 +++--- fftools/textformat/avtextformat.h | 20 +++ fftools/textformat/avtextwriters.h | 11 ++-- fftools/textformat/tf_compact.c| 91

[FFmpeg-devel] [PATCH v11 07/15] fftools/textformat: Introduce common header and deduplicate code

2025-05-04 Thread softworkz
From: softworkz Also change writer_printf signature in AVTextWriter to use va_list, so that it can be called by the new function writer_printf() in tf_internal.h. Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/avtextwriters.h | 2 +- fftools/textformat/tf_compa

[FFmpeg-devel] [PATCH v11 02/15] fftools/textformat: Apply quality improvements

2025-05-04 Thread softworkz
From: softworkz Perform multiple improvements to increase code robustness. In particular: - favor unsigned counters for loops - add missing checks - avoid possible leaks - move variable declarations to inner scopes when feasible - provide explicit type-casting when needed Signed-off-by: softwork

[FFmpeg-devel] [PATCH v11 05/15] fftools/avtextformat: Re-use BPrint in loop

2025-05-04 Thread softworkz
From: softworkz Instead of initializing a new BPrint in each iteration of the loop, re-use the same BPrint struct and just clear it for each iteration. Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-)

[FFmpeg-devel] [PATCH v11 06/15] fftools/textformat: Introduce AVTextFormatOptions for avtext_context_open()

2025-05-04 Thread softworkz
From: softworkz This allows future addition of options without changes to the signature of avtext_context_open(). Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/ffprobe.c | 13 + fftools/textformat/avtextformat.c | 21 - ffto

[FFmpeg-devel] [PATCH v11 04/15] fftools/textformat: Rename name param to key for API consistency

2025-05-04 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 14 +++--- fftools/textformat/avtextformat.h | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c index 32cec9

[FFmpeg-devel] [PATCH v11 09/15] fftools/textformat: Add flags param to function avtext_print_integer()

2025-05-04 Thread softworkz
From: softworkz Make this function work analog to avtext_print_string() which already has a flags parameter. Signed-off-by: softworkz --- fftools/ffprobe.c | 2 +- fftools/textformat/avtextformat.c | 24 ++-- fftools/textformat/avtextformat.h | 2 +- 3 fil

[FFmpeg-devel] [PATCH v11 03/15] fftools/textformat: Remove unused print_rational() pointer from AVTextFormatter

2025-05-04 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/textformat/avtextformat.h | 1 - fftools/textformat/avtextwriters.h | 5 - 2 files changed, 6 deletions(-) diff --git a/fftools/textformat/avtextformat.h b/fftools/textformat/avtextformat.h index 86feb9d09d..c61dca159f 100644 --- a/fft

[FFmpeg-devel] [PATCH v11 08/15] fftools/tf_internal: Use av_default_item_name

2025-05-04 Thread softworkz
From: softworkz Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/tf_internal.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fftools/textformat/tf_internal.h b/fftools/textformat/tf_internal.h index 362a4cbc38..484886b7a7 100644 --- a/fft

[FFmpeg-devel] [PATCH v11 15/15] fftools/graphprint: Now, make it a Killer-Feature!

2025-05-04 Thread softworkz
From: softworkz remember this: -sg <= means Show Graph Signed-off-by: softworkz --- doc/ffmpeg.texi | 4 + fftools/Makefile | 1 + fftools/ffmpeg.c | 2 +- fftools/ffmpeg.h | 1 + fftools/ffmpeg_filter.c | 2 +- fftools/ffmpeg_o

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs: add ff_cbs_read_buf()

2025-05-04 Thread James Almer
On 5/1/2025 10:44 PM, James Almer wrote: To take a reference from an existing buffer outside of AVPackets. Signed-off-by: James Almer --- libavcodec/cbs.c | 10 +- libavcodec/cbs.h | 11 +++ 2 files changed, 20 insertions(+), 1 deletion(-) Will apply set. OpenPGP_signat

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-05-04 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Stefano > Sabatini > Sent: Sonntag, 4. Mai 2025 17:33 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface > > On date Tuesday 2025-04-29 10:30:55 +0200, Nicolas

Re: [FFmpeg-devel] [PATCH] avformat/apvdec: also look for an au_info PBU during probing

2025-05-04 Thread James Almer
On 5/1/2025 2:49 PM, James Almer wrote: If present, an Access unit information PBU must be the first in an AU. Signed-off-by: James Almer --- libavformat/apvdec.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/libavformat/apvdec.c b/libavformat/apvdec

Re: [FFmpeg-devel] [PATCH] avcodec/exr: add support for half-float DWAA/B compression

2025-05-04 Thread James Almer
On 5/1/2025 12:25 AM, James Almer wrote: Fixes ticket #11555. Signed-off-by: James Almer --- libavcodec/exr.c | 56 +++- 1 file changed, 41 insertions(+), 15 deletions(-) Will rename the commit to "avcodec/exr: output half-float DWAA/B compresse

Re: [FFmpeg-devel] [PATCH v3 1/2] libavformat/oggdec.c: Changing the packet() callback API/Return value

2025-05-04 Thread Michael Niedermayer
On Sat, May 03, 2025 at 12:03:28PM -0500, Romain Beauxis wrote: > --- > libavformat/oggdec.c | 22 ++ > libavformat/oggdec.h | 6 ++ > 2 files changed, 20 insertions(+), 8 deletions(-) > > diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c > index 5339fdd32c..9baf80

[FFmpeg-devel] [PATCH] postproc/tests/.gitignore: Add temptest

2025-05-04 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libpostproc/tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/libpostproc/tests/.gitignore b/libpostproc/tests/.gitignore index d77aa7e3dd2..60dc67fa74f 100644 --- a/libpostproc/tests/.gitignore +++ b/libpostproc/tests/.gitignore @@ -1,2 +