Re: [FFmpeg-devel] [PATCH 00/17] swscale v2: new framework [RFC]

2025-05-02 Thread Niklas Haas
On Sat, 26 Apr 2025 19:41:04 +0200 Niklas Haas wrote: > Hi all, > > After extensive amounts of refactoring and iteration on the design and API, > and the implementation of an x86 SIMD backend, I'm happy to present the > revised version of my ongoing swscale rewrite. Now with 100% less reliance on

Re: [FFmpeg-devel] [PATCH] lavc: Add unit test for APV entropy decode

2025-05-02 Thread Michael Niedermayer
On Wed, Apr 30, 2025 at 10:09:11PM +0100, Mark Thompson wrote: > --- > Cleaned up a bit from use earlier. This program allows testing of changes to > entropy decode in a form much easier to debug than a whole stream. > > I had a more complete randomised test of transform here as well along with

Re: [FFmpeg-devel] [PATCH] lavc: Add unit test for APV entropy decode

2025-05-02 Thread James Almer
On 4/30/2025 6:09 PM, Mark Thompson wrote: diff --git a/tests/fate/libavcodec.mak b/tests/fate/libavcodec.mak index ef6e6ec40e..5f7ec97ff3 100644 --- a/tests/fate/libavcodec.mak +++ b/tests/fate/libavcodec.mak @@ -3,6 +3,11 @@ fate-av1-levels: libavcodec/tests/av1_levels$(EXESUF) fate-av1-level

[FFmpeg-devel] [PATCH 1/2] avcodec/hevc/hevcdec: ensure a bit was read when checking for alignment_bit_equal_to_one

2025-05-02 Thread James Almer
Prevents printing bogus errors about the value being 0, when in fact we overread the available slice buffer. Signed-off-by: James Almer --- libavcodec/hevc/hevcdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c index 83

[FFmpeg-devel] [PATCH 2/2] avcodec/hevc/hevcdec: move the slice header buffer overread check up in the function

2025-05-02 Thread James Almer
Abort as soon as we're done reading the slice header instead of running extra checks that assume slice data may follow. Signed-off-by: James Almer --- libavcodec/hevc/hevcdec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/hevc/hevcdec.c b/libavcode

Re: [FFmpeg-devel] [PATCH 5/5] checkasm: add vvc_sao

2025-05-02 Thread Nuo Mi
On Fri, May 2, 2025 at 3:49 PM Martin Storsjö wrote: > On Fri, 2 May 2025, Nuo Mi wrote: > > > From: Shaun Loo > > > > This is a part of Google Summer of Code 2023 > > > > AVX2: > > - vvc_sao.sao_band [OK] > > - vvc_sao.sao_edge [OK] > > > > Co-authored-by: Nuo Mi > > --- > > tests/checkasm/Mak

Re: [FFmpeg-devel] [PATCH 16/17] swscale/format: add new format decode/encode logic

2025-05-02 Thread Michael Niedermayer
On Sat, Apr 26, 2025 at 07:41:20PM +0200, Niklas Haas wrote: > From: Niklas Haas > > This patch adds format handling code for the new operations. This entails > fully decoding a format to standardized RGB, and the inverse. > > Handling it this way means we can always guarantee that a conversion

Re: [FFmpeg-devel] [PATCH 16/17] swscale/format: add new format decode/encode logic

2025-05-02 Thread Niklas Haas
On Fri, 02 May 2025 16:10:57 +0200 Michael Niedermayer wrote: > On Sat, Apr 26, 2025 at 07:41:20PM +0200, Niklas Haas wrote: > > From: Niklas Haas > > > > This patch adds format handling code for the new operations. This entails > > fully decoding a format to standardized RGB, and the inverse. >

Re: [FFmpeg-devel] [PATCH 10/17] swscale/ops_backend: add reference backend basend on C templates

2025-05-02 Thread Michael Niedermayer
On Sat, Apr 26, 2025 at 07:41:14PM +0200, Niklas Haas wrote: > From: Niklas Haas > > This will serve as a reference for the SIMD backends to come. That said, > with auto-vectorization enabled, the performance of this is not atrocious, and > can often beat even the old SIMD. > > In theory, we can

Re: [FFmpeg-devel] [PATCH v2 2/2] ogg/{vorbis, flac, opus}: Remove header packets from subsequent ogg streams from the demuxer output.

2025-05-02 Thread Michael Niedermayer
On Tue, Apr 29, 2025 at 07:49:54PM -0500, Romain Beauxis wrote: > Le mar. 29 avr. 2025 à 19:17, Michael Niedermayer > a écrit : > > > > Hi Romain > > > > On Tue, Apr 29, 2025 at 05:42:22PM -0500, Romain Beauxis wrote: > > > Le mar. 29 avr. 2025 à 16:35, Michael Niedermayer > > > a écrit : > > > >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_setparams: Fix chroma_location being cleared

2025-05-02 Thread Michael Niedermayer
On Wed, Apr 30, 2025 at 02:56:58PM +0200, Tobias Rapp wrote: > On 30/04/2025 14:09, Tobias Rapp wrote: > > > Fix chroma_location being cleared by setrange and setfield filters. > > This was forgotten in 201f1cba150d44de6fedfeee4e8647170ed5fbca. > > > > Signed-off-by: Tobias Rapp > > --- > > li

Re: [FFmpeg-devel] [PATCH 5/5] checkasm: add vvc_sao

2025-05-02 Thread Martin Storsjö
On Fri, 2 May 2025, Nuo Mi wrote: On Fri, May 2, 2025 at 3:49 PM Martin Storsjö wrote: On Fri, 2 May 2025, Nuo Mi wrote: > From: Shaun Loo > > This is a part of Google Summer of Code 2023 > > AVX2: > - vvc_sao.sao_band [OK] > - vvc_sao.sao_edge

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hls: Split allowed_segment_extensions off allowed_extensions

2025-05-02 Thread Michael Niedermayer
On Wed, Apr 30, 2025 at 01:44:04AM +0200, Michael Niedermayer wrote: > This allows the user to set only the one that is needed to ALL or a > specific "wrong" extension like html > > Signed-off-by: Michael Niedermayer > --- > libavformat/hls.c | 17 + > 1 file changed, 13 insertio

Re: [FFmpeg-devel] [PATCH 1/7] postproc/tests: Add test for temporal denoise

2025-05-02 Thread Michael Niedermayer
On Fri, May 02, 2025 at 12:27:29AM +0200, Michael Niedermayer wrote: > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libpostproc/Makefile | 1 + > libpostproc/tests/temptest.c | 120 + > tests/fate/libpostproc.mak | 4 + > tests/ref/fate/

Re: [FFmpeg-devel] [PATCH v8 14/15] fftools/graphprint: Add execution graph printing

2025-05-02 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Michael > Niedermayer > Sent: Freitag, 2. Mai 2025 02:12 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v8 14/15] fftools/graphprint: Add execution > graph printing > > On Tue, Apr 29, 2025 a

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-05-02 Thread Russell Greene
Is this documented anywhere? Should I maybe have a fixed sized stack buffer and fallback to an allocation if it's just a rule of thumb that it'll be less than some known small number. I just somehow doubt this is in the vulkan spec or any sort of guaranteed On Thu, May 1, 2025 at 6:10 PM Lynne

Re: [FFmpeg-devel] [PATCH] configure: Enable -fno-common for Darwin targets, avoid linker warnings

2025-05-02 Thread Martin Storsjö
On Tue, 29 Apr 2025, Martin Storsjö wrote: Since GCC 10 and llvm.org Clang 11, -fno-common is the default. However Apple's Xcode Clang hasn't followed suit yet, and still defaults to -fcommon. Compiling with -fcommon causes uninitialized global variables to be treated as "common" (which allows

[FFmpeg-devel] [PATCH 2/5] x86/hevcdec: sao, refact out h26x macros

2025-05-02 Thread Nuo Mi
From: Shaun Loo This is a part of Google Summer of Code 2023 Co-authored-by: Nuo Mi --- libavcodec/x86/h26x/h2656_sao.asm | 301 libavcodec/x86/h26x/h2656_sao_10bit.asm | 301 libavcodec/x86/hevc/sao.asm | 278 +---

[FFmpeg-devel] [PATCH 5/5] checkasm: add vvc_sao

2025-05-02 Thread Nuo Mi
From: Shaun Loo This is a part of Google Summer of Code 2023 AVX2: - vvc_sao.sao_band [OK] - vvc_sao.sao_edge [OK] checkasm: all 54 tests passed vvc_sao_band_8_8_c:157.4 ( 1.00x) vvc_sao_band_8_8_avx2: 30.7 ( 5.12x) vvc_sao_b

[FFmpeg-devel] [PATCH 4/5] x86/vvcdec: sao, add avx2 support

2025-05-02 Thread Nuo Mi
From: Shaun Loo This is a part of Google Summer of Code 2023 Co-authored-by: Nuo Mi --- libavcodec/x86/h26x/h2656_sao.asm | 8 +-- libavcodec/x86/vvc/Makefile | 2 + libavcodec/x86/vvc/dsp_init.c | 41 +++ libavcodec/x86/vvc/sao.asm| 73 +++ liba

[FFmpeg-devel] [PATCH 3/5] x86/hevcdec: refact, remove duplicate code in HEVC_SAO_{BAND, EDGE}_FILTER

2025-05-02 Thread Nuo Mi
From: Shaun Loo This is a part of Google Summer of Code 2023 Co-authored-by: Nuo Mi --- libavcodec/x86/hevc/sao_10bit.asm | 100 ++ 1 file changed, 48 insertions(+), 52 deletions(-) diff --git a/libavcodec/x86/hevc/sao_10bit.asm b/libavcodec/x86/hevc/sao_10bit.asm

[FFmpeg-devel] [PATCH 1/2] avformat/rtsp: set AVFMTCTX_UNSEEKABLE flag

2025-05-02 Thread Kaarle Ritvanen via ffmpeg-devel
for live RTP streams. Some external applications, such as Qt Multimedia, depend on this flag being set correctly. Signed-off-by: Kaarle Ritvanen --- libavformat/rtsp.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 5ea47

[FFmpeg-devel] [PATCH 2/2] avformat/seek: fail seeking immediately

2025-05-02 Thread Kaarle Ritvanen via ffmpeg-devel
when AVFMTCTX_UNSEEKABLE is set. Depending on the codec, the execution of this function may take several seconds. This is an optimization for the case where the stream is already known unseekable. Signed-off-by: Kaarle Ritvanen --- libavformat/seek.c | 3 +++ 1 file changed, 3 insertions(+) dif

[FFmpeg-devel] [PATCH 1/5] x86/vvcdec: misc, reordered functions in dsp_init for improved readability

2025-05-02 Thread Nuo Mi
--- libavcodec/x86/vvc/dsp_init.c | 48 +-- 1 file changed, 29 insertions(+), 19 deletions(-) diff --git a/libavcodec/x86/vvc/dsp_init.c b/libavcodec/x86/vvc/dsp_init.c index dc833bb0f1..bb68ba0b1e 100644 --- a/libavcodec/x86/vvc/dsp_init.c +++ b/libavcodec/x86/vvc

Re: [FFmpeg-devel] [PATCH 5/5] checkasm: add vvc_sao

2025-05-02 Thread Martin Storsjö
On Fri, 2 May 2025, Nuo Mi wrote: From: Shaun Loo This is a part of Google Summer of Code 2023 AVX2: - vvc_sao.sao_band [OK] - vvc_sao.sao_edge [OK] Co-authored-by: Nuo Mi --- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checka