Re: [FFmpeg-devel] [PATCH] avutil/map: [WIP] Introduction

2025-04-24 Thread Michael Niedermayer
Hi On Wed, Apr 23, 2025 at 11:16:13PM +0200, Marton Balint wrote: > > > On Wed, 23 Apr 2025, Michael Niedermayer wrote: > > > Hi > > > > On Mon, Apr 21, 2025 at 09:55:33PM +0200, Marton Balint wrote: > > > > > > > > > On Sun, 20 Apr 2025, Michael Niedermayer wrote: [...] > > > Because as far

Re: [FFmpeg-devel] [PATCH v1 5/8] avformat/mov_muxer: Extended MOV muxer to handle APV video content

2025-04-24 Thread Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
> -Original Message- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: środa, 23 kwietnia 2025 23:08 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v1 5/8] avformat/mov_muxer: Extended > MOV muxer to handle APV video content > > On 23/04/2025 15:13, Dawid

Re: [FFmpeg-devel] [PATCH] avcodec/bsf/h264_mp4toannexb.c: change extradata to annexb if this is avcc.

2025-04-24 Thread jie jiang
I resubmitted it according to your suggestion. please check. https://patchwork.ffmpeg.org/project/ffmpeg/patch/20250424124250.71553-1-jiangjie...@gmail.com/ So only remove AV_PKT_DATA_NEW_EXTRADATA can fix the issue? answer: yes, but AV_PKT_DATA_NEW_EXTRADATA is used for event notification, it

[FFmpeg-devel] On errors, asserts and crashing (was: Shaping the AVTextFormat API Surface)

2025-04-24 Thread Nicolas George
softworkz . (HE12025-04-22): > At the implementation level, I sensed that "you" ("FFmpeg") > are following some principles which are somewhat contradictive to > those that I'm usually adhering to (e.g. "parameter validation > being a responsibility of the call site, crashing otherwise > being acc

[FFmpeg-devel] [PATCH 2/2] avutil/map: document AV_DICT_MULTIKEY difference

2025-04-24 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavutil/map.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/map.h b/libavutil/map.h index 61c64900ace..7df591873a6 100644 --- a/libavutil/map.h +++ b/libavutil/map.h @@ -129,6 +129,9 @@ * there are restrictions on what compare function

[FFmpeg-devel] [PATCH 1/2] avutil/map: clearer and shorter compare flags

2025-04-24 Thread Michael Niedermayer
The new flags allow specifying the case sensitivity of key and value independently The are shorter 0 now represents key never keyvalue reducing the risk for accidential overread Signed-off-by: Michael Niedermayer --- libavutil/map.c | 60 +-- libavu

Re: [FFmpeg-devel] [PATCH] avcodec/bsf/h264_mp4toannexb.c: change extradata to annexb if this is avcc.

2025-04-24 Thread Zhao Zhili
> On Apr 24, 2025, at 20:42, jiangjie wrote: > > if get AV_PKT_DATA_NEW_EXTRADATA in AVPacket, this bitstream filter will > return an error. > ffmpeg -i rtmp://xxx/live/xxx -bsf:v > "h264_mp4toannexb,h264_metadata=aud=remove" -c copy -f null - The subject and commit message is confusing. ’t

[FFmpeg-devel] [PATCH] avcodec/bsf/h264_mp4toannexb.c: change extradata to annexb if this is avcc.

2025-04-24 Thread jiangjie
if get AV_PKT_DATA_NEW_EXTRADATA in AVPacket, this bitstream filter will return an error. ffmpeg -i rtmp://xxx/live/xxx -bsf:v "h264_mp4toannexb,h264_metadata=aud=remove" -c copy -f null - --- libavcodec/bsf/h264_mp4toannexb.c | 26 ++- tests/fate/h264.mak

Re: [FFmpeg-devel] [PATCH] avcodec/bsf/h264_mp4toannexb.c: change extradata to annexb if this is avcc.

2025-04-24 Thread jie jiang
ctx->par_out->extradata isn't updated by this commit. Only NEW_EXTRADATA is updated (avvc to annexb). You suggest the patch should only remove AV_PKT_DATA_NEW_EXTRADATA from packet, but AV_PKT_DATA_NEW_EXTRADATA is used to notify the codec or the format that the extradata buffer was changed and

Re: [FFmpeg-devel] [PATCH] avcodec/bsf/h264_mp4toannexb.c: change extradata to annexb if this is avcc.

2025-04-24 Thread Zhao Zhili
> On Apr 24, 2025, at 21:04, jie jiang wrote: > > I resubmitted it according to your suggestion. > please check. > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20250424124250.71553-1-jiangjie...@gmail.com/ > > > So only remove AV_PKT_DATA_NEW_EXTRADATA can fix the issue? > answer: yes,

Re: [FFmpeg-devel] [PATCH v1 5/8] avformat/mov_muxer: Extended MOV muxer to handle APV video content

2025-04-24 Thread Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
> -Original Message- > From: ffmpeg-devel On Behalf Of James > Almer > Sent: środa, 23 kwietnia 2025 16:44 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v1 5/8] avformat/mov_muxer: Extended > MOV muxer to handle APV video content > > On 4/23/2025 11:13 AM, Dawid Ko

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cri, tdsc, tiff: Use ff_mjpeg_decoder directly

2025-04-24 Thread Kacper Michajlow
On Mon, 21 Apr 2025 at 20:40, Andreas Rheinhardt wrote: > > Patches attached. Patches make sense to me. - Kacper ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, o

Re: [FFmpeg-devel] [PATCH v3 5/7] lavc/apv: AVX2 transquant for x86-64

2025-04-24 Thread Mark Thompson
On 24/04/2025 03:55, James Almer wrote: > On 4/23/2025 5:45 PM, Mark Thompson wrote: >> Typical checkasm result on Alder Lake: >> >> decode_transquant_8_c: 464.2 ( 1.00x) >> decode_transquant_8_avx2:   86.2 ( 5.38x) >> decode_transquant_10

Re: [FFmpeg-devel] [PATCH v3 3/7] lavf: APV demuxer

2025-04-24 Thread Mark Thompson
On 24/04/2025 01:10, James Almer wrote: > On 4/23/2025 5:45 PM, Mark Thompson wrote: >> +static int apv_read_header(AVFormatContext *s) >> +{ >> +    AVStream *st; >> +    GetByteContext gbc; >> +    APVHeaderInfo header; >> +    uint8_t buffer[28]; >> +    uint32_t au_size, signature, pbu_size; >>

Re: [FFmpeg-devel] [PATCH v3 2/7] lavc/cbs: APV support

2025-04-24 Thread Mark Thompson
On 24/04/2025 01:02, James Almer wrote: > On 4/23/2025 5:45 PM, Mark Thompson wrote: >> +static int cbs_apv_split_fragment(CodedBitstreamContext *ctx, >> +  CodedBitstreamFragment *frag, >> +  int header) >> +{ >> +    uint8_t *data =

Re: [FFmpeg-devel] [PATCH] avcodec/bsf/h264_mp4toannexb.c: change extradata to annexb if this is avcc.

2025-04-24 Thread Zhao Zhili
On Apr 24, 2025, at 22:53, jie jiang wrote: > > ctx->par_out->extradata isn't updated by this commit. Only NEW_EXTRADATA > is updated (avvc to annexb). > > You suggest the patch should only remove AV_PKT_DATA_NEW_EXTRADATA from > packet, but AV_PKT_DATA_NEW_EXTRADATA is used to notify the code

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/hls: Show error info when read key file failed

2025-04-24 Thread Marvin Scholz
On 24 Apr 2025, at 5:54, Zhao Zhili wrote: > From: Zhao Zhili > > --- > libavformat/hls.c | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 6623c80309..6139b8525e 100644 > --- a/libavformat/hls.c > +++ b/li

Re: [FFmpeg-devel] [PATCH v1 5/8] avformat/mov_muxer: Extended MOV muxer to handle APV video content

2025-04-24 Thread Mark Thompson
On 24/04/2025 13:08, Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of Mark >> Thompson >> Sent: środa, 23 kwietnia 2025 23:08 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v1 5/

[FFmpeg-devel] [PATCH] avcodec/bsf/h264_mp4toannexb: Fix mixed bitstream format

2025-04-24 Thread Zhao Zhili
From: Zhao Zhili This bsf converts AV_PKT_DATA_NEW_EXTRADATA side data in avcc format to in-band annexb format. However, the side data wasn't been removed and copied from input packet to output packet. So the output packet has mixed bitstream format. We don't support mixed bitstream format. For e

Re: [FFmpeg-devel] [PATCH v1 8/8] avcodec/apv_decoder: Provided support for APV decoder

2025-04-24 Thread Mark Thompson
On 23/04/2025 15:13, Dawid Kozinski wrote: > - Added APV decoder wrapper > - Changes in project configuration file and libavcodec Makefile > - Added documentation for APV decoder wrapper > > Signed-off-by: Dawid Kozinski > --- > configure | 1 + > doc/decoders.texi | 27 ++ >

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-04-24 Thread Rémi Denis-Courmont
Le tiistaina 22. huhtikuuta 2025, 7.20.26 Itä-Euroopan kesäaika softworkz . a écrit : > Hi Stefano, Andreas, Nicolas > and of course, anybody who's interested in the AVTextFormat APIs, > > > let me start by saying that I have no intention to rush the > publicization of those APIs. I think there'

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-04-24 Thread Nicolas George
softworkz . (HE12025-04-22): > AVTextFormatter Implementations > > - print_section_header > - print_section_footer > - print_integer > - print_string > TextFormat API > > - avtext_context_open > - avtext_context_close > - avtext_print_section_header > - avtext_print_section_footer You are ignor

Re: [FFmpeg-devel] [PATCH v3 5/7] lavc/apv: AVX2 transquant for x86-64

2025-04-24 Thread James Almer
On 4/24/2025 5:37 PM, Mark Thompson wrote: On 24/04/2025 03:55, James Almer wrote: On 4/23/2025 5:45 PM, Mark Thompson wrote: Typical checkasm result on Alder Lake: decode_transquant_8_c: 464.2 ( 1.00x) decode_transquant_8_avx2:   86.

Re: [FFmpeg-devel] [PATCH] avcodec/bsf/h264_mp4toannexb.c: change extradata to annexb if this is avcc.

2025-04-24 Thread jie jiang
Yes, your patch solves my problem too, which is very nice. But I still think AV_PKT_DATA_NEW_EXTRADATA is not just data, it is also an event. As sps/pps data it can be removed, but as event it should be reserved. Anyway, your patch should be merged. On Fri, Apr 25, 2025 at 1:24 AM Zhao Zhili <

Re: [FFmpeg-devel] [PATCH v1 5/8] avformat/mov_muxer: Extended MOV muxer to handle APV video content

2025-04-24 Thread Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
> -Original Message- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: czwartek, 24 kwietnia 2025 21:02 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v1 5/8] avformat/mov_muxer: Extended > MOV muxer to handle APV video content > > On 24/04/2025 13:08, Dawid