Re: [FFmpeg-devel] [PATCH 5/6] lavc/apv: AVX2 transquant for x86-64

2025-04-19 Thread Mark Thompson
On 19/04/2025 20:07, Mark Thompson wrote: > Typical checkasm result on Alder Lake: > > decode_transquant_8_c: 408.7 ( 1.00x) > decode_transquant_8_avx2: 94.2 ( 4.34x) > decode_transquant_10_c:413.1 ( 1.00

[FFmpeg-devel] [PATCH] avutil/map: [WIP] Introduction

2025-04-19 Thread Michael Niedermayer
Note, help is welcome. Time i spend on this, i cannot spend on other things Note2: i intend to push AVMap after the release unless the release ends up delayed alot for other reasons, theres no real reason to hurry here except that i seem to keep workig on it when people ask for some non trivial ch

[FFmpeg-devel] [PATCH] fftools/ffmpeg: Log 'EXIT' on exit

2025-04-19 Thread softworkz
From: softworkz When viewing logs, there are situations where it is not entirely clear whether ffmpeg CLI has exited gracefully. The two primary cases are - A crash/segfault has occured Windows for example doesn't output any message to the calling shell - The process has been terminated (e.g.

Re: [FFmpeg-devel] [PATCH 5/6] lavc/apv: AVX2 transquant for x86-64

2025-04-19 Thread James Almer
On 4/19/2025 4:07 PM, Mark Thompson wrote: diff --git a/libavcodec/x86/apv_dsp.asm b/libavcodec/x86/apv_dsp.asm new file mode 100644 index 00..0329089f45 --- /dev/null +++ b/libavcodec/x86/apv_dsp.asm @@ -0,0 +1,243 @@ +;

[FFmpeg-devel] [PATCH] fftools/ffmpeg: Include elapsed-time in print_report()

2025-04-19 Thread softworkz
From: softworkz It's a highly useful metric, both at runtime and when viewing logs. Signed-off-by: softworkz --- fftools/ffmpeg: Include elapsed-time in print_report() It's a highly useful metric, both at runtime and when viewing logs. Signed-off-by: softworkz softwo...@ho

[FFmpeg-devel] [PATCH] fftools/ffprobe: Disable stderr buffering on Windows

2025-04-19 Thread softworkz
From: softworkz An identical call exists in ffmpeg.c With POSIX/glibc, stderr is already unbuffered (or line-buffered when a terminal is connected), but not in case of MSVCRT. Explicitly calling setvbuf() like in this commit, makes the Windows runtime behave like POSIX, giving the same “print im

Re: [FFmpeg-devel] Hardware purchase request: Ryzen 9 CPU

2025-04-19 Thread Neal Gompa
On Fri, Apr 4, 2025 at 5:22 PM Niklas Haas wrote: > > On Fri, 04 Apr 2025 22:41:39 +0200 Lynne wrote: > > On 04/04/2025 19:20, Niklas Haas wrote: > > > Hi all, > > > > > > My current workstation (first generation Zen) is getting rather old (8 > > > years). > > > On top of being slow and power hu

[FFmpeg-devel] [PATCH v4] libavutil: Add AVMap

2025-04-19 Thread Michael Niedermayer
AVL Tree based Map compared to AVDictionary this has * clone is O(n) instead of O(n²) * copy is O(n*log n) instead of O(n²) * O(log n) malloc() calls by default and O(1) if av_map_realloc() is used instead of O(n) * get/add/delete is O(log n) * * You can add (if memory is realloced before)

Re: [FFmpeg-devel] [PATCH 5/6] lavc/apv: AVX2 transquant for x86-64

2025-04-19 Thread James Almer
On 4/19/2025 4:07 PM, Mark Thompson wrote: Typical checkasm result on Alder Lake: decode_transquant_8_c: 408.7 ( 1.00x) decode_transquant_8_avx2: 94.2 ( 4.34x) decode_transquant_10_c:413.1 ( 1.00x) deco

[FFmpeg-devel] [PATCH] fftools/ffprobe: Print size of attachments

2025-04-19 Thread softworkz
From: softworkz libavformat/asfdec: Fix regression bug when reading image attachments --- fftools/ffprobe: Print size of attachments libavformat/asfdec: Fix regression bug when reading image attachments Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-71%

[FFmpeg-devel] [PATCH] libavformat/asfdec: Fix regression bug when reading image attachments

2025-04-19 Thread softworkz
From: softworkz Commit c8140fe7324f264faacf7395b27e12531d1f13f7 had introduced a check for value_len > UINT16_MAX. As a consequence, attached images of sizes larger than UINT16_MAX could no longer be read. This is a minimal fix of the regression, avoiding the controversies of my earlier submissi

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix decoding fragmented MP4 with multiple sample entries and empty stsc

2025-04-19 Thread Dimitry Andric
On 10 Apr 2025, at 11:03, Dimitry Andric wrote: > > On 3 Apr 2025, at 22:02, Dimitry Andric wrote: >> >> When decoding fragmented MP4 files that have an empty stsc box, and >> instead contain sample description indexes in their tfhd boxes, the mov >> demuxer does not notify the decoder whenever

Re: [FFmpeg-devel] [PATCH v3] libavutil: Add AVMap

2025-04-19 Thread Michael Niedermayer
Hi Leo On Sat, Apr 19, 2025 at 06:36:56AM -0400, Leo Izen wrote: > On 4/17/25 12:52, Michael Niedermayer wrote: [...] > > +typedef struct{ > > +AVMapEntry map_entry; > > +uint8_t treenode_and_keyvalue[0]; > > +} AVMapInternalEntry; > > + > > +struct AVMap{ > > +#define CMP_MASK 31 > > +

[FFmpeg-devel] [PATCH] avformat/mpegts: update stream info when PMT ES stream_type changes

2025-04-19 Thread Pavel Koshevoy
I have a couple of .ts captures where video and audio codec changes even though the PMT version does not change and the PIDs stay the same. --- libavformat/mpegts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 54594b3a11..8a7

[FFmpeg-devel] [PATCH] avcodec/vulkan_{av1, h264, hevc}: demote per frame logs to AV_LOG_DEBUG

2025-04-19 Thread llyyr
Matches vaapi and software decoding behavior Signed-off-by: llyyr --- libavcodec/vulkan_av1.c | 2 +- libavcodec/vulkan_h264.c | 2 +- libavcodec/vulkan_hevc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vulkan_av1.c b/libavcodec/vulkan_av1.c index 0e5958b2

Re: [FFmpeg-devel] [PATCH 2/3] doc/dict2: Add doc and api change for AVDictionary2

2025-04-19 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Samstag, 19. April 2025 04:29 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/3] doc/dict2: Add doc and api > change for AVDictionary2 > > Hi

[FFmpeg-devel] [PATCH 3/6] lavc/cbs: APV support

2025-04-19 Thread Mark Thompson
--- configure| 1 + libavcodec/Makefile | 1 + libavcodec/apv.h | 86 libavcodec/cbs.c | 6 + libavcodec/cbs_apv.c | 395 ++ libavcodec/cbs_apv.h | 209 +

[FFmpeg-devel] [PATCH 0/6] APV support

2025-04-19 Thread Mark Thompson
Hi all, This set implements some support for APV. APV is "Advanced Professional Video", yet another JPEG knockoff codec being promoted by Samsung for professional applications. It seems to have some adoption for Android devices, though it's unclear to what degree that will succeed. Spec:

[FFmpeg-devel] [PATCH 2/6] lavf: APV demuxer

2025-04-19 Thread Mark Thompson
Demuxes raw streams as defined in draft spec section 10.2. --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/apvdec.c | 245 +++ 3 files changed, 247 insertions(+) create mode 100644 libavformat/apvdec.c diff --git a/libav

[FFmpeg-devel] [PATCH 4/6] lavc: APV decoder

2025-04-19 Thread Mark Thompson
--- configure| 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/apv_decode.c | 327 +++ libavcodec/apv_decode.h | 80 ++ libavcodec/apv_dsp.c | 136 libavcodec/apv_dsp.h |

[FFmpeg-devel] [PATCH 5/6] lavc/apv: AVX2 transquant for x86-64

2025-04-19 Thread Mark Thompson
Typical checkasm result on Alder Lake: decode_transquant_8_c: 408.7 ( 1.00x) decode_transquant_8_avx2: 94.2 ( 4.34x) decode_transquant_10_c:413.1 ( 1.00x) decode_transquant_10_avx2:

[FFmpeg-devel] [PATCH 6/6] lavc: APV metadata bitstream filter

2025-04-19 Thread Mark Thompson
--- libavcodec/bitstream_filters.c | 1 + libavcodec/bsf/Makefile| 1 + libavcodec/bsf/apv_metadata.c | 134 + 3 files changed, 136 insertions(+) create mode 100644 libavcodec/bsf/apv_metadata.c diff --git a/libavcodec/bitstream_filters.c b/libavcodec

[FFmpeg-devel] [PATCH] rtpdec_vp9: Update header parsing to RFC 9628

2025-04-19 Thread Parallelc
Signed-off-by: Parallelc --- libavformat/rtpdec_vp9.c | 141 --- 1 file changed, 72 insertions(+), 69 deletions(-) diff --git a/libavformat/rtpdec_vp9.c b/libavformat/rtpdec_vp9.c index 6bbdf4847a..924065b5da 100644 --- a/libavformat/rtpdec_vp9.c +++ b/libavfo

Re: [FFmpeg-devel] [PATCH v3 0/2] Improve HWDeviceContext logging

2025-04-19 Thread softworkz .
> -Original Message- > From: ffmpegagent > Sent: Samstag, 19. April 2025 16:43 > To: ffmpeg-devel@ffmpeg.org > Cc: softworkz > Subject: [PATCH v3 0/2] Improve HWDeviceContext logging > > This changeset > > * adds an av class category for hw device contexts > * assigns a color to it

Re: [FFmpeg-devel] [PATCH v3] libavutil: Add AVMap

2025-04-19 Thread Nicolas George
Michael Niedermayer (HE12025-04-19): > I dont know what you are trying to acomplish here. I am trying to help make this API as good as possible before it becomes public and cannot be changed. I am nowhere as good as you in many areas, but I think I can say that architecture, and in particular API

Re: [FFmpeg-devel] [PATCH v3] libavutil: Add AVMap

2025-04-19 Thread Nicolas George
Nicolas George (HE12025-04-19): > Let me make you a promise: if you can write an introduction to the API > (as all non-trivial APIs should have) that makes other major developers > say “that was clear”, I will leave the matter alone. … which does not mean I demand you do that. You can probably con

Re: [FFmpeg-devel] [PATCH v3] libavutil: Add AVMap

2025-04-19 Thread Leo Izen
On 4/17/25 12:52, Michael Niedermayer wrote: AVL Tree based Map compared to AVDictionary this has * clone is O(n) instead of O(n²) * copy is O(n*log n) instead of O(n²) * O(log n) malloc() calls by default and O(1) if av_map_realloc() is used instead of O(n) * get/add/delete is O(log n)

Re: [FFmpeg-devel] [PATCH v3] libavutil: Add AVMap

2025-04-19 Thread Nicolas George
Michael Niedermayer (HE12025-04-17): > ok, i will change teh name Thanks. > You can implement an av_map_new() variant thats on the stack > if thats what you want to have / to use / to do > once the code is in git > or maybe i will do it but there are many more interresting things I have checked,

Re: [FFmpeg-devel] [PATCH v3] libavutil: Add AVMap

2025-04-19 Thread Michael Niedermayer
Hi On Sat, Apr 19, 2025 at 03:03:16PM +0200, Nicolas George wrote: > Michael Niedermayer (HE12025-04-17): > > ok, i will change teh name > > Thanks. > > > You can implement an av_map_new() variant thats on the stack > > if thats what you want to have / to use / to do > > once the code is in git

[FFmpeg-devel] [PATCH v3 1/2] avutil/log, hwcontext: Add AV_CLASS_CATEGORY_HWDEVICE

2025-04-19 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/APIchanges| 3 +++ libavutil/hwcontext.c | 1 + libavutil/log.c | 1 + libavutil/log.h | 1 + libavutil/version.h | 2 +- 5 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 22

[FFmpeg-devel] [PATCH v3 2/2] avutil/hwcontext: Add item_name function for AVHWDeviceContext

2025-04-19 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavutil/hwcontext.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext.c b/libavutil/hwcontext.c index 276dc9cee6..3111a44651 100644 --- a/libavutil/hwcontext.c +++ b/libavutil/hwcontext.c @@ -137,9 +137,

[FFmpeg-devel] [PATCH v3 0/2] Improve HWDeviceContext logging

2025-04-19 Thread ffmpegagent
This changeset * adds an av class category for hw device contexts * assigns a color to it * adds an item_name function to the av class for hw device context Before == [AVHWDeviceContext @ 0260A9C63E00] Selecting d3d11va adapter 2 [AVHWDeviceContext @ 0260A9C63E00] Using device 80

[FFmpeg-devel] [PATCH 1/6] lavc: APV codec ID and descriptor

2025-04-19 Thread Mark Thompson
--- libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + 2 files changed, 8 insertions(+) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 9fb190e35a..88fed478a3 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c @@ -1985,6 +1985,13 @@ static con