Re: [FFmpeg-devel] [PATCH v3 1/5] libavcodec/vc2enc: Split out common functions between software and hardware encoders

2025-04-18 Thread Andreas Rheinhardt
IndecisiveTurtle: > From: IndecisiveTurtle > > --- > libavcodec/Makefile| 2 +- > libavcodec/vc2enc.c| 513 + > libavcodec/vc2enc_common.c | 376 +++ > libavcodec/vc2enc_common.h | 196 ++ > 4 files changed

Re: [FFmpeg-devel] [PATCH v3 5/5] lavc: implement a Vulkan-based VC-2 encoder Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets and should work with all wavelet depths.

2025-04-18 Thread Andreas Rheinhardt
IndecisiveTurtle: > From: IndecisiveTurtle > > Performance wise, encoding a 1080p 1-minute video is performed in about 2.5 > minutes with the cpu encoder running on my Ryzen 5 4600H, while it takes > about 30 seconds on my NVIDIA GTX 1650 > > Haar shader has a subgroup optimized variant that a

Re: [FFmpeg-devel] [PATCH] libavfilter/ebur128: SIMD optimization

2025-04-18 Thread Guillaume Khayat
Thank you for the feedback. OK I understand. We’ll do that. Guillaume ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] [PATCH v3] libavutil: Add AVMap

2025-04-18 Thread Leo Izen
On 4/17/25 16:12, Michael Niedermayer wrote: + * @param keyvalue_cmp compare function, will be passed the key + value concatenated. Please no. Pass the key and the value separately to the compare function. thats neither efficient nor does it fit the existing APIs. The value is most of the

[FFmpeg-devel] [PATCH] avcodec/vc2enc: Improve error codes

2025-04-18 Thread Andreas Rheinhardt
Patch attached. - Andreas From 7ef2a150ad06043c1e97d565360d7366f5fb81fe Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Fri, 18 Apr 2025 11:09:21 +0200 Subject: [PATCH] avcodec/vc2enc: Improve error codes Signed-off-by: Andreas Rheinhardt --- libavcodec/vc2enc.c | 6 +++--- 1 file chan

Re: [FFmpeg-devel] [PATCH v3 5/5] lavc: implement a Vulkan-based VC-2 encoder Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets and should work with all wavelet depths.

2025-04-18 Thread Andreas Rheinhardt
IndecisiveTurtle: > From: IndecisiveTurtle > > Performance wise, encoding a 1080p 1-minute video is performed in about 2.5 > minutes with the cpu encoder running on my Ryzen 5 4600H, while it takes > about 30 seconds on my NVIDIA GTX 1650 These are the same numbers as the first version of this

[FFmpeg-devel] [PATCH] vulkan: use ReadWithoutFormat/WriteWithoutFormat

2025-04-18 Thread Lynne
This implements support for reading and writing storage images with no format. The issue is that we define our images as arrays, and arrays can only have a single type, which means that f.ex. NV12 needs two different images, R8 and RG8. Not using any formats fixes this. --- libavutil/vulkan.c | 2

[FFmpeg-devel] [PATCH] lavc/vvc: Detect subpic overlaps at CTU level

2025-04-18 Thread Frank Plowman
In d5dbcc00d889fb17948b025a468b00ddbea9e058, it was hoped that detection of subpicture overlaps could be performed at the tile level, so as to avoid introducing per-CTU checks. Unfortunately since that patch, fuzzing has indicated there are some structures involving pps_subpic_one_or_more_tiles_sli

[FFmpeg-devel] [PATCH v3] libavutil: Add AVMap

2025-04-18 Thread Michael Niedermayer
AVL Tree based Map compared to AVDictionary this has * clone is O(n) instead of O(n²) * copy is O(n*log n) instead of O(n²) * O(log n) malloc() calls by default and O(1) if av_map_realloc() is used instead of O(n) * get/add/delete is O(log n) * * You can add (if memory is realloced before)

Re: [FFmpeg-devel] [PATCH v2] fate: add various FFv1 tests for 1024 slices

2025-04-18 Thread Michael Niedermayer
On Wed, Apr 16, 2025 at 04:09:13PM +0200, Lynne wrote: > This lets us test features that were broken earlier, as well as > test the hardware decoder by using the HWACCEL=vulkan option. > --- > tests/Makefile| 1 + > tests/fate/ffv1.mak | 46 ++

Re: [FFmpeg-devel] [PATCH v3] libavutil: Add AVMap

2025-04-18 Thread Michael Niedermayer
On Fri, Apr 18, 2025 at 10:46:42AM -0400, Leo Izen wrote: > On 4/17/25 16:12, Michael Niedermayer wrote: > > > > > > > + * @param keyvalue_cmp compare function, will be passed the key + > > > > value concatenated. > > > > > > Please no. Pass the key and the value separately to the compare > > >

Re: [FFmpeg-devel] [PATCH] avcodec/libvvenc: use av_vlog to print external library log messages

2025-04-18 Thread Nuo Mi
LGTM, Nit: Would a lookup table be better? On Fri, Apr 18, 2025 at 12:42 AM James Almer wrote: > And improve the vvencMsgLevel <-> AV_LOG_* mapping. > > Signed-off-by: James Almer > --- > libavcodec/libvvenc.c | 35 +++ > 1 file changed, 27 insertions(+), 8 dele

Re: [FFmpeg-devel] [PATCH v2] fate: add various FFv1 tests for 1024 slices

2025-04-18 Thread Lynne
On 19/04/2025 03:01, Michael Niedermayer wrote: On Wed, Apr 16, 2025 at 04:09:13PM +0200, Lynne wrote: This lets us test features that were broken earlier, as well as test the hardware decoder by using the HWACCEL=vulkan option. --- tests/Makefile| 1 + tests/fate/ffv1.ma

Re: [FFmpeg-devel] [PATCH v2] fate: add various FFv1 tests for 1024 slices

2025-04-18 Thread Michael Niedermayer
On Sat, Apr 19, 2025 at 03:38:22AM +0200, Lynne wrote: > On 19/04/2025 03:01, Michael Niedermayer wrote: > > On Wed, Apr 16, 2025 at 04:09:13PM +0200, Lynne wrote: > > > This lets us test features that were broken earlier, as well as > > > test the hardware decoder by using the HWACCEL=vulkan optio

Re: [FFmpeg-devel] [PATCH 2/3] doc/dict2: Add doc and api change for AVDictionary2

2025-04-18 Thread Michael Niedermayer
Hi On Thu, Apr 17, 2025 at 10:38:32PM +, softworkz . wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of [...] > > the LLM would probably mix and confuse things and hallucinate > > a lot of nonsense. > > That's less of a problem meanwhile as the available context

Re: [FFmpeg-devel] [PATCH] libavcodec/riscv:add RVV optimized for idct_32x32_8:

2025-04-18 Thread Michael Niedermayer
On Tue, Apr 15, 2025 at 03:34:24PM +0800, daichengr...@iscas.ac.cn wrote: > From: daichengrong > > riscv/hevcdsp_idct_rvv: Optimize idct_32x32_8 > > On Banana PI F3: > > hevc_idct_32x32_8_c:119579.3 ( 1.00x) > hevc_idct_32x32_8_rvv_i64:

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/tests/mjpegenc_huffman: Also test length counts

2025-04-18 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Patches attached. > I also tried to sort equal length codes in such a way that codes that > start and end with 1 bits are paired with values that occur less > frequently as suggested by Michael in > https://ffmpeg.org/pipermail/ffmpeg-devel/2025-April/341917.html. Yet > strang

[FFmpeg-devel] [PATCH v3 09/11] fftools/ffmpeg_mux: Make ms_from_ost() inline

2025-04-18 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/ffmpeg_mux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux.h b/fftools/ffmpeg_mux.h index f41f2c18fa..4ca8ab73a4 100644 --- a/fftools/ffmpeg_mux.h +++ b/fftools/ffmpeg_mux.h @@ -123,7 +123,7 @@ typedef

Re: [FFmpeg-devel] [PATCH 2/3] doc/dict2: Add doc and api change for AVDictionary2

2025-04-18 Thread Michael Niedermayer
Hi On Wed, Apr 16, 2025 at 11:15:12PM +, softworkz . wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Michael Niedermayer > > Sent: Mittwoch, 16. April 2025 23:48 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpe