From: xiaohuanshu
Problem:
The max_url_size calculation for DASH segment URLs only considered the base URL
length, leading to buffer overflow when the segment's sourceURL exceeded the
pre-allocated buffer. This triggered the log error:
"DASH request for url 'invalid:truncated'".
Reproduce:
1. A
From: Zhao Zhili
The macro is meant to suppress false uninitialized warnings. However,
sometimes these 'false uninitialized warnings' are really undefined
behavior, and leading to real issue like crash, e.g., ab792634197e.
For false uninitialized warnings, it can be silenced by initialization,
a
From: Zhao Zhili
---
libavfilter/af_aecho.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/af_aecho.c b/libavfilter/af_aecho.c
index ff316eaa67..4406e0dbb2 100644
--- a/libavfilter/af_aecho.c
+++ b/libavfilter/af_aecho.c
@@ -164,7 +164,7 @@ static void echo_sampl
From: Zhao Zhili
---
libavfilter/af_compand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/af_compand.c b/libavfilter/af_compand.c
index 69de1360f1..3b6a83c056 100644
--- a/libavfilter/af_compand.c
+++ b/libavfilter/af_compand.c
@@ -195,7 +195,7 @@ static int c
From: Zhao Zhili
---
libavfilter/vsrc_mandelbrot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/vsrc_mandelbrot.c b/libavfilter/vsrc_mandelbrot.c
index 3f14f1e7f9..84eeadb703 100644
--- a/libavfilter/vsrc_mandelbrot.c
+++ b/libavfilter/vsrc_mandelbrot.c
@@ -256
From: Zhao Zhili
---
libavcodec/ac3enc.c | 5 +++--
libavcodec/ac3enc_template.c | 16
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c
index 3649289865..17d45097ac 100644
--- a/libavcodec/ac3enc.c
+++ b/libavco
From: Zhao Zhili
---
libswscale/yuv2rgb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c
index ff8e013da4..eebe840ad6 100644
--- a/libswscale/yuv2rgb.c
+++ b/libswscale/yuv2rgb.c
@@ -733,7 +733,7 @@ av_cold int ff_yuv2rgb_c_init_ta
From: Zhao Zhili
---
libavcodec/bfi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/bfi.c b/libavcodec/bfi.c
index 1d2d3a7204..4c47861791 100644
--- a/libavcodec/bfi.c
+++ b/libavcodec/bfi.c
@@ -93,7 +93,7 @@ static int bfi_decode_frame(AVCodecContext *avctx, AVF
From: Zhao Zhili
---
libavcodec/dvdsubenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/dvdsubenc.c b/libavcodec/dvdsubenc.c
index 00bab35988..818ac2b0f5 100644
--- a/libavcodec/dvdsubenc.c
+++ b/libavcodec/dvdsubenc.c
@@ -123,7 +123,7 @@ static void count_colo
From: Zhao Zhili
---
libavcodec/eamad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/eamad.c b/libavcodec/eamad.c
index 44dac46083..cf2f5c1e9d 100644
--- a/libavcodec/eamad.c
+++ b/libavcodec/eamad.c
@@ -195,7 +195,7 @@ static int decode_motion(GetBitContext *gb
From: Zhao Zhili
---
libavcodec/ffv1enc.c | 4 ++--
libavcodec/ffv1enc_template.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c
index 807850a432..b1f4f7bca6 100644
--- a/libavcodec/ffv1enc.c
+++ b/libavcodec/ffv1enc.
From: Zhao Zhili
---
libavcodec/flacdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/flacdec.c b/libavcodec/flacdec.c
index 0c88f577a1..1219f5b20a 100644
--- a/libavcodec/flacdec.c
+++ b/libavcodec/flacdec.c
@@ -303,7 +303,7 @@ static int decode_subframe_fixed
From: Zhao Zhili
---
libavcodec/lpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/lpc.c b/libavcodec/lpc.c
index e793e54038..d1a84d0c5b 100644
--- a/libavcodec/lpc.c
+++ b/libavcodec/lpc.c
@@ -278,7 +278,7 @@ int ff_lpc_calc_coefs(LPCContext *s,
if (lpc_ty
From: Zhao Zhili
---
libavcodec/mpeg4videodec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c
index e21f1d24a2..d3d68a1e33 100644
--- a/libavcodec/mpeg4videodec.c
+++ b/libavcodec/mpeg4videodec.c
@@ -1336,7 +1336,7 @@
From: Zhao Zhili
---
libavcodec/qtrleenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/qtrleenc.c b/libavcodec/qtrleenc.c
index ae341c60b6..91e30ce152 100644
--- a/libavcodec/qtrleenc.c
+++ b/libavcodec/qtrleenc.c
@@ -145,7 +145,7 @@ static void qtrle_encode_li
From: Zhao Zhili
---
libavcodec/ra144enc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/ra144enc.c b/libavcodec/ra144enc.c
index d38c39ce14..c671689ab9 100644
--- a/libavcodec/ra144enc.c
+++ b/libavcodec/ra144enc.c
@@ -192,8 +192,8 @@ static void create_adap
From: Zhao Zhili
---
libavcodec/vp8.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c
index c42170519f..ea8457c0b1 100644
--- a/libavcodec/vp8.c
+++ b/libavcodec/vp8.c
@@ -2625,7 +2625,7 @@ int vp78_decode_frame(AVCodecContext *avctx, AVFra
From: Zhao Zhili
---
libavcodec/wmavoice.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c
index 7fc735ad1d..7e776eb1c0 100644
--- a/libavcodec/wmavoice.c
+++ b/libavcodec/wmavoice.c
@@ -1497,8 +1497,8 @@ static int synth_fram
From: Zhao Zhili
---
libavformat/flvdec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c
index b90ed34b1c..5dbe82ca0e 100644
--- a/libavformat/flvdec.c
+++ b/libavformat/flvdec.c
@@ -1361,8 +1361,8 @@ static int flv_read_packet
From: Zhao Zhili
---
libavformat/srtp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/srtp.c b/libavformat/srtp.c
index 7e5a42e327..d1e69c0702 100644
--- a/libavformat/srtp.c
+++ b/libavformat/srtp.c
@@ -128,8 +128,8 @@ int ff_srtp_decrypt(struct SRTPContext
From: Zhao Zhili
---
libavformat/wavdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
index ae6ff0e022..1eb129126d 100644
--- a/libavformat/wavdec.c
+++ b/libavformat/wavdec.c
@@ -350,7 +350,7 @@ static const AVMetadataConv wav_
From: Zhao Zhili
---
libavformat/tests/seek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/tests/seek.c b/libavformat/tests/seek.c
index 94a72d9422..eeb220235d 100644
--- a/libavformat/tests/seek.c
+++ b/libavformat/tests/seek.c
@@ -118,7 +118,7 @@ int main(int
From: Zhao Zhili
The macro is dangerous since it can hide real issue.
---
libavutil/attributes.h | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/libavutil/attributes.h b/libavutil/attributes.h
index 04c615c952..a7c64cf8fc 100644
--- a/libavutil/attributes.h
+++ b/lib
From: Zhao Zhili
---
libavformat/electronicarts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c
index 04acf3a409..fa256c4137 100644
--- a/libavformat/electronicarts.c
+++ b/libavformat/electronicarts.c
@@ -595,7 +5
Zhao Zhili (HE12025-04-11):
> From: Zhao Zhili
>
> The macro is meant to suppress false uninitialized warnings. However,
> sometimes these 'false uninitialized warnings' are really undefined
> behavior, and leading to real issue like crash, e.g., ab792634197e.
>
> For false uninitialized warning
> On Apr 11, 2025, at 16:36, Nicolas George wrote:
>
> Zhao Zhili (HE12025-04-11):
>> From: Zhao Zhili
>>
>> The macro is meant to suppress false uninitialized warnings. However,
>> sometimes these 'false uninitialized warnings' are really undefined
>> behavior, and leading to real issue lik
> On Apr 11, 2025, at 16:36, Nicolas George wrote:
>
> Zhao Zhili (HE12025-04-11):
>> From: Zhao Zhili
>>
>> The macro is meant to suppress false uninitialized warnings. However,
>> sometimes these 'false uninitialized warnings' are really undefined
>> behavior, and leading to real issue like
Zhao Zhili (HE12025-04-11):
> With UB, the compiler can remove branch check and assign some random
> value to it, which cannot be detected by valgrind.
>
> For ab792634197e, the UB is there for decades and never detected by
> valgrind, and the warning is silenced by av_uninit.
You make a valid po
> On Apr 11, 2025, at 17:32, Nicolas George wrote:
>
> Zhao Zhili (HE12025-04-11):
>> With UB, the compiler can remove branch check and assign some random
>> value to it, which cannot be detected by valgrind.
>>
>> For ab792634197e, the UB is there for decades and never detected by
>> valgrind
Zhao Zhili (HE12025-04-11):
> This is only check on particular compiler implementation. It works until
> someone
> use a different compiler and UB kicks in.
No, with this suggestion there is no UB.
--
Nicolas George
___
ffmpeg-devel mailing list
ffm
Background:
1. There is a av_uninit macro which suppress uninitialized variable warning
#if (defined(__GNUC__) || defined(__clang__)) && !defined(__INTEL_COMPILER)
#define av_uninit(x) x=x
#else
#define av_uninit(x) x
#endif
2. Declaration after statement coding style is allowed now
3.
Hello,
1. I agree that av_uninit should be removed; in fact, I also wanted to
do so and already made some commits to do so where I consider the commit
to be beneficial on its own (even without the av_uninit removal) like
348461e550f88c5e27afeafc85e7ace11fe8fae4 and its parent.
2. You fail to actu
Zhao Zhili (HE12025-04-11):
> Background:
>
> 1. There is a av_uninit macro which suppress uninitialized variable warning
>
> #if (defined(__GNUC__) || defined(__clang__)) && !defined(__INTEL_COMPILER)
> #define av_uninit(x) x=x
> #else
> #define av_uninit(x) x
> #endif
Yes.
> 2. Declar
Patch attached.
- Andreas
From 90d34e5d87a390b6e0058426a1f0b1168eb5ebeb Mon Sep 17 00:00:00 2001
From: Andreas Rheinhardt
Date: Fri, 11 Apr 2025 11:01:01 +0200
Subject: [PATCH] avcodec/decode: Only use ff_progress_frame_get_buffer() with
blank input
All users (namely HEVC) that use ff_progress_
Andreas Rheinhardt:
> Patches attached.
>
> - Andreas
>
Will apply this patchset tomorrow unless there are objections.
- Andreas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, vi
Andreas Rheinhardt:
> Patch attached.
>
> - Andreas
>
Will apply this patch tomorrow unless there are objections.
- Andreas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit l
Andreas Rheinhardt:
> Patches attached.
>
> - Andreas
>
Will apply this patchset tomorrow unless there are objections.
- Andreas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, vi
It was removed / left unreferenced some time ago.
---
libpostproc/postprocess.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h
index 5decb7e8a9..cc48c552cc 100644
--- a/libpostproc/postprocess.h
+++ b/libpostproc/postprocess.h
@@ -87,7 +87,
Sean McGovern:
> It was removed / left unreferenced some time ago.
> ---
> libpostproc/postprocess.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h
> index 5decb7e8a9..cc48c552cc 100644
> --- a/libpostproc/postprocess.h
> +++ b/libpos
On Fri, Apr 11, 2025 at 9:17 AM Andreas Rheinhardt
wrote:
>
> Sean McGovern:
> > It was removed / left unreferenced some time ago.
> > ---
> > libpostproc/postprocess.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h
> > index 5d
Sean McGovern:
> On Fri, Apr 11, 2025 at 9:17 AM Andreas Rheinhardt
> wrote:
>>
>> Sean McGovern:
>>> It was removed / left unreferenced some time ago.
>>> ---
>>> libpostproc/postprocess.h | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/libpostproc/postprocess.h b/libpostproc/postp
It was left unreferenced in 1f0948272a0fcd0e4947f629b600983f3338c02f.
---
libpostproc/postprocess.h | 2 ++
libpostproc/version.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h
index 5decb7e8a9..7010c2b51b 100644
--- a/libpostproc/p
Sean McGovern (HE12025-04-11):
> WHY does this need a deprecation period? It neither enables nor
> disables anything.
If somebody uses it in their code, the fact that it does nothing will
not prevent the compilation to fail.
Regards,
--
Nicolas George
_
Michael Niedermayer (HE12025-03-29):
> can you repost the AVWriter patches ?
Sure, but I need to find the latest branch, and it is proving a cause of
procrastination for me. In the meantime, let me explain anew the
principles behind it, after a few years I might be able to express them
better.
(I
Patches attached.
- Andreas
From e2ca8a7268f0d6071d170b1d99e5a264392e1b2e Mon Sep 17 00:00:00 2001
From: Andreas Rheinhardt
Date: Fri, 11 Apr 2025 00:36:59 +0200
Subject: [PATCH 1/2] avcodec/asvenc: Don't use FF_INPUT_BUFFER_MIN_SIZE
ASV-1/2 does not really have a header and so using
FF_INPUT_BU
Hi
On Tue, Apr 08, 2025 at 09:30:16PM +, softworkz . wrote:
[...]
> To tell you the truth - at that point I was thinking: "Ah, clever! That's why
> the AVDictionary is done like that" 😊
The dictionary implementation is not clever
look at copy for example it iterates over av_dict_set() whic
On Tue, Apr 08, 2025 at 12:19:59PM +0200, Michael Niedermayer wrote:
> Hi all
>
> As i have too many things to do already i did the most logic thing and
> started thinking about a new and unrelated idea.
>
> This is a list of problems and ideas, that everyone is welcome to add to and
> comment on
Signed-off-by: Michael Niedermayer
---
libavformat/id3v2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c
index 3bdd23a2509..90314583a74 100644
--- a/libavformat/id3v2.c
+++ b/libavformat/id3v2.c
@@ -304,7 +304,7 @@ static int decode_
Fixes infinite loop with unknown encodings
We could alternatively error out from decode_str() or consume all of taglen
this would affect other callers though.
Fixes:
409819224/clusterfuzz-testcase-minimized-ffmpeg_dem_H261_fuzzer-6003527535362048
Signed-off-by: Michael Niedermayer
---
libavfor
On Fri, Apr 11, 2025 at 08:57:09PM +0200, Andreas Rheinhardt wrote:
> Patches attached.
>
> - Andreas
> asvenc.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> f02ccdc5e7ec0835b2af195734590d1e3f294d33
> 0001-avcodec-asvenc-Don-t-use-FF_INPUT_BUFFER_MIN_SIZE.patch
> From e2ca8
On Fri, Apr 11, 2025 at 08:32:55AM +0200, Andreas Rheinhardt wrote:
> Michael Niedermayer:
> > Signed-off-by: Michael Niedermayer
> > ---
> > configure | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index bd4f8723760..f1db8b6f235 100755
On 12.04.2025 02:11, Michael Niedermayer wrote:
On Fri, Apr 11, 2025 at 08:32:55AM +0200, Andreas Rheinhardt wrote:
Michael Niedermayer:
Signed-off-by: Michael Niedermayer
---
configure | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index bd4f872
Hi
On Tue, Apr 08, 2025 at 07:05:16PM +0530, SUBHANGANI JHA wrote:
> Hello FFmpeg developers,
>
> I'm a 2025 Gsoc applicant and have submitted a proposal for implementing a
> basic VP6 Encoder in FFmpeg. I understand the importance of community
> engagement and am reaching out to introduce myself
On Sat, Apr 12, 2025 at 02:19:08AM +0200, Timo Rothenpieler wrote:
> On 12.04.2025 02:11, Michael Niedermayer wrote:
> > On Fri, Apr 11, 2025 at 08:32:55AM +0200, Andreas Rheinhardt wrote:
> > > Michael Niedermayer:
> > > > Signed-off-by: Michael Niedermayer
> > > > ---
> > > > configure | 3 ++-
On Wed, Apr 09, 2025 at 09:25:56PM -0500, Romain Beauxis wrote:
> Le mer. 9 avr. 2025 à 20:12, Michael Niedermayer
> a écrit :
> >
> > On Fri, Apr 04, 2025 at 04:14:44PM -0500, Romain Beauxis wrote:
> > > ---
> > > libavcodec/decode.c | 130
> > > 1 fi
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Nicolas George
> Sent: Freitag, 11. April 2025 19:09
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [RFC] FFmpeg Execution Graph Visualization
>
> Michael Niedermayer (HE12025-03-29):
> > can you r
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Michael Niedermayer
> Sent: Freitag, 11. April 2025 21:06
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [RFC] AVDictionary2
>
> Hi
>
> On Tue, Apr 08, 2025 at 09:30:16PM +, softworkz . wrote:
On Tue, Apr 08, 2025 at 10:45:38PM +, softworkz . wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Michael Niedermayer
> > Sent: Mittwoch, 9. April 2025 00:25
> > To: FFmpeg development discussions and patches
> > Subject: Re: [FFmpeg-devel] SW's Patchsets O
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Michael Niedermayer
> Sent: Samstag, 12. April 2025 00:27
> To: FFmpeg development discussions and patches
> Subject: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that
> decode_str() did advance
>
> Fixes infinite loop with
59 matches
Mail list logo