Re: [FFmpeg-devel] [PATCH] avformat/libopenmpt: Update dts in read_seek function

2025-02-08 Thread DodoGTA GT
Any comments on this change? It's been basically a month since I sent this ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org w

[FFmpeg-devel] [PATCH] lavc/vvc: Set fc->ref to NULL at top of decode_nal_units

2025-02-08 Thread Frank Plowman
In the fail: block of decode_nal_units, a check as to whether fc->ref is nonzero is used. Before this patch, fc->ref was set to NULL in frame_context_setup. The issue is that, by the time frame_context_setup is called, falliable functions (namely slices_realloc and ff_vvc_decode_frame_ps) have al

Re: [FFmpeg-devel] [PATCH 5/6] avformat/iff: Check that we have a stream in read_dst_frame()

2025-02-08 Thread Peter Ross
On Sun, Feb 09, 2025 at 03:24:20AM +0100, Michael Niedermayer wrote: > Fixes: null pointer dereference > Fixes: > 385644864/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-4551049565765632 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffm

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/rv60dec: Initialize slice gb with actually allocated size

2025-02-08 Thread Peter Ross
On Sun, Feb 09, 2025 at 03:24:21AM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 385170375/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV60_fuzzer-4710055187906560 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects

Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: avoid hard failure on illegal sBIT chunks

2025-02-08 Thread Leo Izen
On 2/3/25 10:22 PM, Leo Izen wrote: If a malformed chunk like sBIT appears but otherwise the stream is still parseable, we should print a warning and skip it rather than failing with an error. Signed-off-by: Leo Izen --- libavcodec/pngdec.c | 18 ++ 1 file changed, 10 inserti

Re: [FFmpeg-devel] [PATCH] avformat: add DAT (Digital Audio Tape) demuxer

2025-02-08 Thread Jerome Martinez
Le 01/02/2025 à 03:13, Michael Niedermayer a écrit : [...] yes, this is the 2nd such dumb mistake i make in the last few days the whole (still ongoing) "mobbing" compaign against me seems to affect the quality of my reviews and work Sorry to read that, I hope that this will stop soon. [...] d

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vvc/refs: Check content_ref in set_pict_type()

2025-02-08 Thread Nuo Mi
On Fri, Feb 7, 2025 at 4:25 AM Frank Plowman wrote: > On 02/02/2025 21:17, Michael Niedermayer wrote: > > Fixes: > 390565846/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-4990028521996288 > > Fixes: Null pointer dereference > > > > Found-by: continuous fuzzing process > https://git

Re: [FFmpeg-devel] [PATCH] avcodec/aarch64/opusdsp_neon: Simplify opus_postfilter_neon

2025-02-08 Thread Krzysztof Pyrkosz via ffmpeg-devel
On Sat, Feb 08, 2025 at 01:59:32AM +0100, Lynne wrote: > On 07/02/2025 20:42, Krzysztof Pyrkosz via ffmpeg-devel wrote: > > This change removes one extra floating point operation and simplifies > > load operations at the beginning of the loop by using dedicated register > > for each of the 5 pointe

Re: [FFmpeg-devel] Captions SCC

2025-02-08 Thread Devin Heitmueller
On Fri, Feb 7, 2025 at 6:59 PM Marth64 wrote: > > Hi Devin & Softworks, > > I have been working on a slide deck in my spare time with suggestions > and a roadmap to improve general digital Closed Captions support. > I hope to share this with you and the community for feedback in the > next 2 week

Re: [FFmpeg-devel] [PATCH] aacenc: move to libavcodec/aac/

2025-02-08 Thread James Almer
On 2/8/2025 2:32 AM, Lynne wrote: The decoder was already moved there. --- libavcodec/Makefile | 5 +- libavcodec/aac/Makefile | 2 + libavcodec/{ => aac}/aaccoder.c | 0 libavcodec/aac/aaccoder.h | 46 +

[FFmpeg-devel] [PATCH] checkasm/v210enc.c: Use checkasm_check_type

2025-02-08 Thread Kieran Kunhya via ffmpeg-devel
$subj 0001-checkasm-v210enc.c-Use-checkasm_check_type.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@

Re: [FFmpeg-devel] [PATCH] aacenc: move to libavcodec/aac/

2025-02-08 Thread Lynne
On 08/02/2025 16:54, James Almer wrote: On 2/8/2025 2:32 AM, Lynne wrote: The decoder was already moved there. ---   libavcodec/Makefile   |  5 +-   libavcodec/aac/Makefile   |  2 +   libavcodec/{ => aac}/aaccoder.c   |  0   libavcodec/aac/

Re: [FFmpeg-devel] [PATCH v2 1/3] libavformat/oggdec: Allow first parameter in ff_vorbis_comment to be a generic AVClass struct

2025-02-08 Thread Romain Beauxis
Le ven. 7 févr. 2025 à 05:56, Andreas Rheinhardt a écrit : > > Romain Beauxis: > > Firt argument in these function is only used to pass to av_log. This > > makes it possible to re-use them with any type of AVClass struct. > > > > --- > > libavformat/oggdec.h | 5 - > > libavformat/ogg

Re: [FFmpeg-devel] [PATCH] threadprogress: reorder instructions to silence tsan warning.

2025-02-08 Thread Ronald S. Bultje
Hi, On Fri, Feb 7, 2025 at 10:50 PM Zhao Zhili < quinkblack-at-foxmail@ffmpeg.org> wrote: > > > > On Feb 8, 2025, at 00:05, Ronald S. Bultje wrote: > > > > Hi, > > > > On Fri, Feb 7, 2025 at 8:44 AM Zhao Zhili < > > quinkblack-at-foxmail@ffmpeg.org> wrote: > > > >>> On Feb 7, 2025, at 21

Re: [FFmpeg-devel] Captions SCC

2025-02-08 Thread Tom Vaughan
I'm excited to see this discussion. There are many leading video distributors (streaming services, etc.) that would love to see solid support in FFMPEG for closed captions. No promises, but my sense is that additional money can be raised to sponsor this development. WebVTT as a sidecar captions

[FFmpeg-devel] [PATCH] avformat/mpegenc: increase the default size of the VBV buffer

2025-02-08 Thread Jack Lau via ffmpeg-devel
Increase the default buffer size to match more modern encoding scenarios. --- libavformat/mpegenc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegenc.c b/libavformat/mpegenc.c index 6b6763c30f..2b3b98b894 100644 --- a/libavformat/mpegenc.c +++ b/libavform

[FFmpeg-devel] [PATCH 4/6] avcodec/aac/aacdec_lpd: Limit get_unary()

2025-02-08 Thread Michael Niedermayer
The limit is based on later code storing 32bits Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int' Fixes: 393164866/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-4606798354513920 Found-by: continuous fuzzing process https://github.com/google/

[FFmpeg-devel] [PATCH 2/6] avcodec/aac/aacdec_usac: Simplify decode_usac_scale_factors()

2025-02-08 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/aac/aacdec_usac.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c index 2938e693874..ccdf58bc8e2 100644 --- a/libavcodec/aac/aacdec_usac.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 3/6] avcodec/aac/aacdec_usac: Fix memory deallocation of pl_data

2025-02-08 Thread Michael Niedermayer
Fixes: double free Fixes: 393523547/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-6740617236905984 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aac/aacdec.c | 19 ++

[FFmpeg-devel] [PATCH 1/6] avcodec/aac/aacdec: Clear SFO on error

2025-02-08 Thread Michael Niedermayer
types and SFO become confused for a USAC stream Fixes: out of array access Fixes: 383854203/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-4996677847547904.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 5/6] avformat/iff: Check that we have a stream in read_dst_frame()

2025-02-08 Thread Michael Niedermayer
Fixes: null pointer dereference Fixes: 385644864/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-4551049565765632 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/iff.c | 3 +++ 1 file ch

[FFmpeg-devel] [PATCH 6/6] avcodec/rv60dec: Initialize slice gb with actually allocated size

2025-02-08 Thread Michael Niedermayer
Fixes: out of array access Fixes: 385170375/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV60_fuzzer-4710055187906560 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/rv60dec.c | 2 +- 1 f