Re: [FFmpeg-devel] [PATCH] doc/filters: Add CUDA Video Filters section for CUDA-based and CUDA+NPP based filters.

2025-02-03 Thread Gyan Doshi
Hi Danil, See notes below. On 2025-02-02 06:53 pm, Danil Iashchenko wrote: --- doc/filters.texi | 1323 -- 1 file changed, 700 insertions(+), 623 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index c2817b2661..7460b7ef18 100644 ---

Re: [FFmpeg-devel] [PATCH] fix pad artifacting

2025-02-03 Thread Ben Lu via ffmpeg-devel
Sure, looks like gmail is complying with a plaintext email RFC. Let me try attaching to eml with: `git format-patch -s -o "outputfolder" --add-header "X-Unsent: 1" --suffix .eml --to ffmpeg-devel@ffmpeg.org -1 0f497eb391b` On Mon, Feb 3, 2025 at 3:22 PM James Almer wrote: > On 2/3/2025 10:58 AM,

[FFmpeg-devel] [PATCH 1/3] avfilter/delogo: add parameter to switch on circular delogo

2025-02-03 Thread Jörg Habenicht via ffmpeg-devel
Add a parameter (boolean) r to switch the area from rectangular (r=0) to circular(r=1) delogo. Signed-off-by: Jörg Habenicht --- libavfilter/vf_delogo.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c index bfbf8e6f4c.

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-02-03 Thread Nicolas George
Michael Niedermayer (12025-02-03): > Lets assume we have 2 projects in one the vulnerability was taken advantage of > while in the other it was not. > > How would you tell them apart ? One of them would have a software-defined radio subsystem, the other not. Regards, -- Nicolas George __

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec: add AV_CODEC_ID_IVTV_VBI

2025-02-03 Thread Marth64
Hi Scott, LGTM. I will push soon and fix the APIchanges on the way. Apologies for the delay on this simple patch. Had a lot of issues getting the machine up and running. I was able to capture a sample finally and test this out. I wanted to test it to get an idea of how EIA-608 travels through th

[FFmpeg-devel] [PATCH 3/3] avcodec/osq: avoid undefined negation

2025-02-03 Thread Michael Niedermayer
Fixes: negation of -2147483648 cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to negate this value to itself Fixes: 390646659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-5040277374435328 Found-by: continuous fuzzing process https://github.com/goog

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/osq: avoid undefined negation

2025-02-03 Thread James Almer
On 2/3/2025 11:58 PM, Michael Niedermayer wrote: Fixes: negation of -2147483648 cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to negate this value to itself Fixes: 390646659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-5040277374435328 Found-by:

[FFmpeg-devel] [PATCH] avcodec/pngdec: avoid hard failure on illegal sBIT chunks

2025-02-03 Thread Leo Izen
If a malformed chunk like sBIT appears but otherwise the stream is still parseable, we should print a warning and skip it rather than failing with an error. Signed-off-by: Leo Izen --- libavcodec/pngdec.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/lib

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-02-03 Thread Michael Niedermayer
Hi On Sun, Feb 02, 2025 at 03:14:58PM -0300, James Almer wrote: > On 2/1/2025 6:53 PM, Michael Niedermayer wrote: > > Hi James > > > > On Sat, Feb 01, 2025 at 10:30:21AM -0300, James Almer wrote: > > > On 1/31/2025 9:49 PM, Michael Niedermayer wrote: [...] > , the text points this out in a mockin

[FFmpeg-devel] [PATCH 0/3] *** SUBJECT HERE ***

2025-02-03 Thread Jörg Habenicht via ffmpeg-devel
Dear list, I made a patch for the delogo filter. With this I can create a circular or elliptic zone to apply the delogo algorithm. The borders are defined with x,y,w,h parameter just like the rectangular area definition. To become circular I added an additional parameter 'r'=0/1 defaulting to '0'

[FFmpeg-devel] [PATCH 2/3] avfilter/delogo: added circular delogo algorithm description

2025-02-03 Thread Jörg Habenicht via ffmpeg-devel
Added a description of the elliptic formed delogo algorithm. Placed it outside the doxygen function comment. Signed-off-by: Jörg Habenicht --- libavfilter/vf_delogo.c | 24 1 file changed, 24 insertions(+) diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c

[FFmpeg-devel] [PATCH 3/3] avfilter/delogo: added the circular delogo algorithm

2025-02-03 Thread Jörg Habenicht via ffmpeg-devel
Use the corrected x,y,w,h values with boundaries and clipping to calculate the points inside the ellipse. Signed-off-by: Jörg Habenicht --- libavfilter/vf_delogo.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_delogo.c b/libavfi

[FFmpeg-devel] [PATCH] avcodec/hw_base_encode: log the readable error message on failure

2025-02-03 Thread Marth64
Currently, if there is a hardware encode failure, the numeric error code will be printed making it somewhat hard to get to the root cause of the issue. Print the readable message generated by av_err2str() instead. Signed-off-by: Marth64 --- libavcodec/hw_base_encode.c | 5 +++-- 1 file changed,

[FFmpeg-devel] [PATCH v2 1/6] avutil: add an API to handle Three Dimensional Reference Displays Information

2025-02-03 Thread James Almer
As defined in section G.14.3.2.3 of ITU-T H.265, it's required for proper signaling of MV-HEVC. Signed-off-by: James Almer --- Better namespace, and now only allocating the required display reference entries. libavutil/Makefile| 2 + libavutil/ref_displays_info.c | 53 ++

[FFmpeg-devel] [PATCH v2 2/6] avutil/frame: add a 3D Reference Displays Information side data type

2025-02-03 Thread James Almer
Signed-off-by: James Almer --- No changes since last version. libavutil/frame.c | 1 + libavutil/frame.h | 11 +++ 2 files changed, 12 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 992115e04f..d1566298ae 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@

[FFmpeg-devel] [PATCH 5/6] avcodec/hevc/sei: dynamically allocate 3D Reference Displays Information SEI messages

2025-02-03 Thread James Almer
Considerably reduces the size of HEVCSEI and eliminates data copy between threads. Signed-off-by: James Almer --- libavcodec/hevc/hevcdec.c | 4 ++-- libavcodec/hevc/refs.c| 4 ++-- libavcodec/hevc/sei.c | 6 +- libavcodec/hevc/sei.h | 6 +- 4 files changed, 14 insertions(+)

[FFmpeg-devel] [PATCH 4/6] avcodec/hevc/sei: ensure num_ref_displays is not set unless the SEI message is valid

2025-02-03 Thread James Almer
This field can be used the same way "present" is used for other message types. Signed-off-by: James Almer --- libavcodec/hevc/sei.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/hevc/sei.c b/libavcodec/hevc/sei.c index e11a33773c..8793d86fdc 100644 --

[FFmpeg-devel] [PATCH v2 6/6] avcodec/hevc/hevcdec: export 3D Reference Displays side data

2025-02-03 Thread James Almer
Signed-off-by: James Almer --- libavcodec/hevc/hevcdec.c | 55 ++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c index f9ff22dbac..ffacbcad24 100644 --- a/libavcodec/hevc/hevcdec.c +++ b/liba

[FFmpeg-devel] [PATCH v2 3/6] avfilter/vf_showinfo: add support for 3D Reference Displays Information side data

2025-02-03 Thread James Almer
Signed-off-by: James Almer --- No changes since last version. libavfilter/vf_showinfo.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 8109ca7fce..29700f5d68 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vvc/refs: fix negative pps_scaling_win offsets

2025-02-03 Thread Michael Niedermayer
On Mon, Feb 03, 2025 at 08:05:19AM +, Frank Plowman wrote: > On 02/02/2025 21:17, Michael Niedermayer wrote: > > The spec seems to allow these to be negative > > > > Fixes: left shift of negative value -15 > > Fixes: > > 392687035/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: log unsupported subtitle codec name

2025-02-03 Thread Marth64
LGTM. I'm aligned. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/3] swscale/output: Fix integer overflow in yuv2gbrp_full_X_c()

2025-02-03 Thread Michael Niedermayer
Fixes: signed integer overflow: 1966895953 + 210305024 cannot be represented in type 'int' Fixes: 391921975/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-5916798905548800 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michae

[FFmpeg-devel] [PATCH 1/3] swscale/swscale: Do not crash on floats

2025-02-03 Thread Michael Niedermayer
Fixes: shift exponent 32 is too large for 32-bit type 'unsigned int' Fixes: division by zero Fixes: 391981061/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-6691017763389440 Fixes: 392929028/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-5142088307507200 Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vvc/refs: fix negative pps_scaling_win offsets

2025-02-03 Thread Frank Plowman
On 02/02/2025 21:17, Michael Niedermayer wrote: > The spec seems to allow these to be negative > > Fixes: left shift of negative value -15 > Fixes: > 392687035/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-6559804532785152 > > Found-by: continuous fuzzing process > https://githu

[FFmpeg-devel] [PATCH 1/2] lavc/vvcdec: refact, set AVCodecContext->has_b_frames in sps_export_stream_params

2025-02-03 Thread Nuo Mi
--- libavcodec/vvc/dec.c | 1 - libavcodec/vvc/ps.c | 29 +++-- 2 files changed, 19 insertions(+), 11 deletions(-) diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c index 51dd60ae92..68fb26352e 100644 --- a/libavcodec/vvc/dec.c +++ b/libavcodec/vvc/dec.c @@ -812,7

[FFmpeg-devel] [PATCH 2/2] lavc/vvcdec: export stream level VUI information

2025-02-03 Thread Nuo Mi
Previously, VUI information was not exposed. If the container lacks HDR metadata, HDR videos appear washed out Command: mp4box -add hdr.mp4#video:colr=nclc,1,1,1 -new new.mp4 && ffprobe new.mp4 Before: Stream #0:0[0x1](und): Video: vvc (vvc1 / 0x31637676), yuv420p10le(bt709), 1920x1080, 12164 kb

Re: [FFmpeg-devel] [PATCH v3] swscale/x86/rgb2rgb: add AVX512ICL versions of shuffle_bytes

2025-02-03 Thread James Almer
On 1/29/2025 10:03 AM, Shreesh Adiga wrote: Hi Andreas, I am not sure if that is needed. I can add the data observed on my machine (AMD 7950x Zen 4), I think this will vary from machine to machine. It is expected to be around 2x compared to AVX2 and there is no core change apart from processing

Re: [FFmpeg-devel] [PATCH v2 0/3] avcodec/hevc: Add alpha video decoding support

2025-02-03 Thread Zhao Zhili
Hi Timo, You have added encoding support for hevc alpha video, may I invite you to help review the decoding support? Alpha layer can be previewed like this: ./ffmpeg -i hevc-alpha.mp4 -an -vf extractplanes=planes=a -f nut - |ffplay - > On Jan 10, 2025, at 17:03, Zhao Zhili wrote: > > Ping. >

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/nvenc: Enable recovery point SEI for intra refresh mode

2025-02-03 Thread Zhao Zhili
> On Jan 25, 2025, at 03:08, Timo Rothenpieler wrote: > > On 24.01.2025 16:05, Kieran Kunhya via ffmpeg-devel wrote: >> On Fri, Jan 24, 2025 at 3:59 AM Zhao Zhili >> wrote: >>> >>> >>> On Jan 24, 2025, at 02:02, Timo Rothenpieler wrote: On 23.01.2025 15:17, Zhao Zhili wrote

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-02-03 Thread Michael Niedermayer
Hi James On Sun, Feb 02, 2025 at 03:14:58PM -0300, James Almer wrote: > On 2/1/2025 6:53 PM, Michael Niedermayer wrote: > > Hi James > > > > On Sat, Feb 01, 2025 at 10:30:21AM -0300, James Almer wrote: > > > On 1/31/2025 9:49 PM, Michael Niedermayer wrote: > > > > Hi James > > > > > > > > On Fri

Re: [FFmpeg-devel] [PATCH] fix pad artifacting

2025-02-03 Thread Ben Lu via ffmpeg-devel
Sorry about that, it looks correct in gmail and sending to myself also looks fine, not sure where the line width corruption is happening. Our org doesn't allow programmatic email. Is it possible to use this gist? https://gist.github.com/ayroblu/1d7bbfdf82aa9a127abefa4c5d518cdb Also trying again:

Re: [FFmpeg-devel] [PATCH] fix pad artifacting

2025-02-03 Thread James Almer
On 2/3/2025 10:58 AM, Ben Lu via ffmpeg-devel wrote: Sorry about that, it looks correct in gmail and sending to myself also looks fine, not sure where the line width corruption is happening. Our org doesn't allow programmatic email. Looks like lines with a single blank space are being replaced

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-02-03 Thread Vittorio Giovara
On Mon, Feb 3, 2025 at 7:08 PM Michael Niedermayer wrote: > Hi James > > On Sun, Feb 02, 2025 at 03:14:58PM -0300, James Almer wrote: > > On 2/1/2025 6:53 PM, Michael Niedermayer wrote: > > > Hi James > > > > > > On Sat, Feb 01, 2025 at 10:30:21AM -0300, James Almer wrote: > > > > On 1/31/2025 9:

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec: add a ffv1 parser

2025-02-03 Thread James Almer
On 2/3/2025 2:42 AM, Lynne wrote: On 03/02/2025 03:16, James Almer wrote: Only setting frame and stream properties. No packetization is performed. Signed-off-by: James Almer ---   configure    |  1 +   libavcodec/Makefile  |  1 +   libavcodec/ffv1_parser.c | 86

[FFmpeg-devel] [PATCH] avformat/matroskaenc: log unsupported subtitle codec name

2025-02-03 Thread Zhao Zhili
From: Zhao Zhili It's more user friendly than codec ID. --- libavformat/matroskaenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 3285735a7f..2e06f68304 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/

[FFmpeg-devel] [PATCH] swscale/x86/rgb2rgb: add AVX512ICL version of uyvytoyuv422

2025-02-03 Thread Shreesh Adiga
The scalar loop is replaced with masked AVX512 instructions. For extracting the Y from UYVY, vperm2b is used instead of various AND and packuswb. Instead of loading the vectors with interleaved lanes as done in AVX2 version, normal load is used. At the end of packuswb, for U and V, an extra permut