Re: [FFmpeg-devel] [PATCH] lavc/vvc: Fix pix_fmt change detection

2025-01-13 Thread Frank Plowman
On 13/01/2025 06:29, Wang, Fei W wrote: > On Sun, 2025-01-12 at 11:45 +0800, Nuo Mi wrote: >> >> >> On Sat, Jan 11, 2025 at 9:18 PM Frank Plowman >> wrote: >>> In some scenarios, the VVCContext.pix_fmt and the >>> AVCodecContext.pix_fmt can get out-of-sync.  It is more robust here >>> to check the

Re: [FFmpeg-devel] [PATCH] checkasm/sw_rgb: fix buffer overflow

2025-01-13 Thread Andreas Rheinhardt
Niklas Haas: > From: Niklas Haas > > Fixes: c601bb8df5ae > Signed-off-by: Niklas Haas > --- > tests/checkasm/sw_rgb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c > index 5714bfaa1e..042102fa73 100644 > --- a/tes

Re: [FFmpeg-devel] [PATCH 3/4] doc/faq: Document the plan ahead for Governance

2025-01-13 Thread Nicolas George
Michael Niedermayer (12025-01-11): > But i think a company which actually depends on a FFmpeg vote outcome > will be able to connect the dots and be able to enumerate the options > to influcence said vote Hi. That is true. Which is why we must fix the issue, not document it. Democracy was just a

[FFmpeg-devel] [PATCH] avformat/mov: fix potential unsigned underflow in loop condition

2025-01-13 Thread James Almer
if sc->tts_count is 0, this condition will wrap around to UINT_MAX and the code will try to dereference a NULL pointer. Fixes ticket #11417 Signed-off-by: James Almer --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix potential unsigned underflow in loop condition

2025-01-13 Thread Andreas Rheinhardt
James Almer: > if sc->tts_count is 0, this condition will wrap around to UINT_MAX and the > code will try to dereference a NULL pointer. > > Fixes ticket #11417 > > Signed-off-by: James Almer > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix potential unsigned underflow in loop condition

2025-01-13 Thread James Almer
On 1/13/2025 6:22 PM, Andreas Rheinhardt wrote: James Almer: if sc->tts_count is 0, this condition will wrap around to UINT_MAX and the code will try to dereference a NULL pointer. Fixes ticket #11417 Signed-off-by: James Almer --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+),

[FFmpeg-devel] [PATCH v2 3/2] avcodec/sanm: codec37 buffers are private

2025-01-13 Thread Manuel Lauss
codec37 operates on 2 buffers, which must be considered private to the codec and must therefore not be changed by subsequent FOBJs. Let codec37 therefore operate on frm1/2 instead of frm0/2, but copy the decoded image to frm0 where other codecs operate on. Fixes artifacts encountered in Full Thro

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: set pict_type and AV_FRAME_FLAG_KEY

2025-01-13 Thread Rubén Gonzalez
I tested your ([PATCH v2] lavc/vvc/refs: export keyframe and picture type in output frames) implementation and it works correctly. For instance, I found different output from my original implementation in SUBPIC_D_ERICSSON_1.bit[1]. Thanks you. [1] https://www.itu.int/wftp3/av-arch/jvet-site/bit

Re: [FFmpeg-devel] [PATCH v2] lavc/vvc/refs: export keyframe and picture type in output frames

2025-01-13 Thread Rubén Gonzalez
+1 to this improved implementation. I tested with all vectors from the test suite JVET-VVC_draft6 using fluster [1] [1] https://github.com/fluendo/fluster/ On Sun, Jan 12, 2025 at 4:34 AM Nuo Mi wrote: > Tested with: > ``` > wget > https://www.itu.int/wftp3/av-arch/jvet-site/bitstream_exchange

Re: [FFmpeg-devel] [PATCH] lavc/vvcdec: show frames info with ffprobe and other tools.

2025-01-13 Thread Rubén Gonzalez
IIRC This is needed for raw bitstreams and muxed videos. I did a fast test [1] and only patched version works. [2] https://www.elecard.com/storage/video/NovosobornayaSquare_640x360.mp4 On Sun, Jan 12, 2025 at 4:38 AM Nuo Mi wrote: > On Sun, Jan 12, 2025 at 6:24 AM James Almer wrote: > > > On

[FFmpeg-devel] [PATCH] avfilter/signalstats: add NULL_IF_CONFIG_SMALL

2025-01-13 Thread Abdulrahman Saber
Signed-off-by: abdo --- libavfilter/vf_signalstats.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c index b1451cc465..9b6af8becd 100644 --- a/libavfilter/vf_signalstats.c +++ b/libavfilter/vf_signalstats.c @@ -20,6

Re: [FFmpeg-devel] [PATCH] swresample/rematrix: fix mixing of center channels

2025-01-13 Thread Michael Niedermayer
Hi On Mon, Jan 13, 2025 at 05:38:14PM -0300, James Almer wrote: > On 1/13/2025 5:30 PM, Michael Niedermayer wrote: > > Hi > > > > On Mon, Jan 13, 2025 at 03:51:07PM -0300, James Almer wrote: > > > On 1/13/2025 12:49 AM, Michael Niedermayer wrote: > > > > Hi James > > > > > > > > On Sun, Jan 12,

Re: [FFmpeg-devel] [PATCH] avfilter/signalstats: add NULL_IF_CONFIG_SMALL

2025-01-13 Thread Michael Niedermayer
On Tue, Jan 14, 2025 at 01:50:49AM +0200, Abdulrahman Saber wrote: > Signed-off-by: abdo > --- > libavfilter/vf_signalstats.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c > index b1451cc465..9b6af8becd 1006

[FFmpeg-devel] [PATCH] avcodec/vvc: Add support for output_corrupt/showall flags

2025-01-13 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/vvc/refs.c | 16 +++- libavcodec/vvc/refs.h | 1 + 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/libavcodec/vvc/refs.c b/libavcodec/vvc/refs.c index bc3b3d0d13..a204e7d800 100644 --- a/libavcodec/vvc/refs.c +++ b/libavcodec/vvc/refs.c

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/g728dec: G.728 decoder

2025-01-13 Thread Peter Ross
On Sun, Jan 12, 2025 at 12:42:05AM -0300, James Almer wrote: > On 1/11/2025 11:37 PM, Peter Ross wrote: > > --- > > libavcodec/Makefile | 1 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/codec_desc.c | 7 ++ > > libavcodec/codec_id.h | 1 + > > libavcodec/g728data.h | 7

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/g728dec: G.728 decoder

2025-01-13 Thread Peter Ross
On Sun, Jan 12, 2025 at 02:48:00PM +0100, Andreas Rheinhardt wrote: > Peter Ross: > > --- > > libavcodec/Makefile | 1 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/codec_desc.c | 7 ++ > > libavcodec/codec_id.h | 1 + > > libavcodec/g728data.h | 70 + > > libavc

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild/bin2c: misc fix

2025-01-13 Thread myp...@gmail.com
On Sun, Jan 12, 2025 at 8:59 PM Alexander Strasser via ffmpeg-devel wrote: > > On 2025-01-08 19:42 +0800, Jun Zhao wrote: > > From: Jun Zhao > > > > close the input file if open output fail > > > > Signed-off-by: Jun Zhao > > --- > > ffbuild/bin2c.c | 4 +++- > > 1 file changed, 3 insertions(+)

Re: [FFmpeg-devel] [PATCH 2/2] lavc/ac3dsp: fix R-V HAVE_RVV scope issue

2025-01-13 Thread myp...@gmail.com
On Sun, Jan 12, 2025 at 10:11 PM Rémi Denis-Courmont wrote: > > > > Le 8 janvier 2025 19:42:15 GMT+08:00, Jun Zhao a écrit : > >From: Jun Zhao > > > >fix R-V HAVE_RVV scope issue > > > >Signed-off-by: Jun Zhao > >--- > > libavcodec/riscv/ac3dsp_init.c | 2 +- > > 1 file changed, 1 insertion(+),

Re: [FFmpeg-devel] [PATCH 2/2] lavc/ac3dsp: fix R-V HAVE_RVV scope issue

2025-01-13 Thread Rémi Denis-Courmont
Le 13 janvier 2025 17:01:01 GMT+08:00, "myp...@gmail.com" a écrit : >On Sun, Jan 12, 2025 at 10:11 PM Rémi Denis-Courmont wrote: >> >> >> >> Le 8 janvier 2025 19:42:15 GMT+08:00, Jun Zhao a écrit : >> >From: Jun Zhao >> > >> >fix R-V HAVE_RVV scope issue >> > >> >Signed-off-by: Jun Zhao >>

Re: [FFmpeg-devel] [PATCH 3/4] doc/faq: Document the plan ahead for Governance

2025-01-13 Thread Vittorio Giovara
On Mon, Jan 13, 2025 at 10:00 AM Nicolas George wrote: > Michael Niedermayer (12025-01-11): > > But i think a company which actually depends on a FFmpeg vote outcome > > will be able to connect the dots and be able to enumerate the options > > to influcence said vote > > Hi. That is true. Which i

[FFmpeg-devel] [PATCH 3/2] avcodec/sanm: codec37 buffers are private

2025-01-13 Thread Manuel Lauss
codec37 operates on 2 buffers, which must be considered private to the codec and must therefore not be changed by subsequent FOBJs. Let codec37 therefore operate on frm1/2 instead of frm0/2, but copy the decoded image to frm0 where other codecs operate on. Fixes artifacts encountered in Full Thro

[FFmpeg-devel] [PATCH 1/2] avformat/mov: fix potential unsigned underflow in loop condition

2025-01-13 Thread James Almer
if sc->tts_count is 0, this condition will wrap around to UINT_MAX and the code will try to dereference a NULL pointer. Fixes ticket #11417 Signed-off-by: James Almer --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c

[FFmpeg-devel] [PATCH 2/2] avformat/mov: simplify allocating stts/ctts arrays

2025-01-13 Thread James Almer
No point using av_fast_realloc() in a loop when we want to allocate all entries to begin with, and any duplicate stts/ctts will just replace the old arrays. Furthermore, these are temporary arrays that will be merged into tts_data when building the index. Signed-off-by: James Almer --- libavform

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: simplify allocating stts/ctts arrays

2025-01-13 Thread Andreas Rheinhardt
James Almer: > No point using av_fast_realloc() in a loop when we want to allocate all > entries to begin with, and any duplicate stts/ctts will just replace the > old arrays. > Furthermore, these are temporary arrays that will be merged into tts_data > when building the index. > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: simplify allocating stts/ctts arrays

2025-01-13 Thread James Almer
On 1/13/2025 7:35 PM, Andreas Rheinhardt wrote: James Almer: No point using av_fast_realloc() in a loop when we want to allocate all entries to begin with, and any duplicate stts/ctts will just replace the old arrays. Furthermore, these are temporary arrays that will be merged into tts_data when

[FFmpeg-devel] [PATCH] avfilter/signalstats: add NULL_IF_CONFIG_SMALL

2025-01-13 Thread Abdulrahman Saber
Signed-off-by: abdo --- libavfilter/vf_signalstats.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c index b1451cc465..9b6af8becd 100644 --- a/libavfilter/vf_signalstats.c +++ b/libavfilter/vf_signalstats.c @@ -20,

Re: [FFmpeg-devel] [PATCH 3/4] doc/faq: Document the plan ahead for Governance

2025-01-13 Thread Ronald S. Bultje
Hi Michael, On Mon, Jan 13, 2025 at 12:29 PM Michael Niedermayer wrote: > Then this needs to be documented properly, not covering half the story up. > Given how subjective this ("covering half the story up") will be, I would encourage you to do this on your blog, not on the project website. Ro

[FFmpeg-devel] [PATCH] avfilter: minor spell fix

2025-01-13 Thread Leandro Santiago
Signed-off-by: Leandro Santiago --- libavfilter/dnn/dnn_backend_openvino.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 2f6706dcd4..ec46e29b8a 100644 --- a/libavfilter/dnn/dnn_backend

[FFmpeg-devel] [PATCH] checkasm/sw_rgb: fix buffer overflow

2025-01-13 Thread Niklas Haas
From: Niklas Haas Fixes: c601bb8df5ae Signed-off-by: Niklas Haas --- tests/checkasm/sw_rgb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c index 5714bfaa1e..042102fa73 100644 --- a/tests/checkasm/sw_rgb.c +++ b/tests/ch

[FFmpeg-devel] [PATCH v2] lavc/vvc: Set both s->pix_fmt & c->pix_fmt in set_output_format

2025-01-13 Thread Frank Plowman
The logic in export_frame_params relies on the assumption that s->pix_fmt and c->pix_fmt always correspond to one another (although they are not necessarily equal to one another in the case of hardware-accelerated decoders). Consequently, whenever we set s->pix_fmt we must also set c->pix_fmt and

Re: [FFmpeg-devel] [PATCH 3/4] doc/faq: Document the plan ahead for Governance

2025-01-13 Thread Michael Niedermayer
Hi Ronald On Sat, Jan 11, 2025 at 07:53:46AM -0500, Ronald S. Bultje wrote: > Hi Michael, > > On Fri, Jan 10, 2025 at 9:01 PM Michael Niedermayer > wrote: > > > But i think a company which actually depends on a FFmpeg vote outcome > > > > will be able to connect the dots and be able to enumerat

Re: [FFmpeg-devel] [PATCH] swresample/rematrix: fix mixing of center channels

2025-01-13 Thread James Almer
On 1/13/2025 12:49 AM, Michael Niedermayer wrote: Hi James On Sun, Jan 12, 2025 at 06:52:55PM -0300, James Almer wrote: On 1/12/2025 6:25 PM, Michael Niedermayer wrote: Hi On Sat, Jan 11, 2025 at 11:13:30AM -0300, James Almer wrote: With this, the output from ffmpeg -i $fate-samples/ac3/mon

Re: [FFmpeg-devel] [PATCH] swresample/rematrix: fix mixing of center channels

2025-01-13 Thread Michael Niedermayer
Hi On Mon, Jan 13, 2025 at 03:51:07PM -0300, James Almer wrote: > On 1/13/2025 12:49 AM, Michael Niedermayer wrote: > > Hi James > > > > On Sun, Jan 12, 2025 at 06:52:55PM -0300, James Almer wrote: > > > On 1/12/2025 6:25 PM, Michael Niedermayer wrote: > > > > Hi > > > > > > > > On Sat, Jan 11,

Re: [FFmpeg-devel] [PATCH] swresample/rematrix: fix mixing of center channels

2025-01-13 Thread James Almer
On 1/13/2025 5:30 PM, Michael Niedermayer wrote: Hi On Mon, Jan 13, 2025 at 03:51:07PM -0300, James Almer wrote: On 1/13/2025 12:49 AM, Michael Niedermayer wrote: Hi James On Sun, Jan 12, 2025 at 06:52:55PM -0300, James Almer wrote: On 1/12/2025 6:25 PM, Michael Niedermayer wrote: Hi On Sa

Re: [FFmpeg-devel] [PATCH 3/2] avcodec/sanm: codec37 buffers are private

2025-01-13 Thread Marton Balint
On Mon, 13 Jan 2025, Manuel Lauss wrote: codec37 operates on 2 buffers, which must be considered private to the codec and must therefore not be changed by subsequent FOBJs. Let codec37 therefore operate on frm1/2 instead of frm0/2, but copy the decoded image to frm0 where other codecs operat