Re: [FFmpeg-devel] [PATCH] avutil/frame.h: improve documentation for AV_FRAME_FLAG_LOSSLESS

2025-01-08 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-07 20:13 -0500, Leo Izen wrote: > It should be more clear what this flag is indicating with a more > verbose comment documenting it. > > Signed-off-by: Leo Izen > --- > libavutil/frame.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/libavutil/frame.h b

[FFmpeg-devel] [PATCH v3] loongarch: fixes fate-checkasm-sw_rgb failure

2025-01-08 Thread yuanhecai
The reason for the failure is that the function yuv2rgb_1_c_template was modified in 095f8038fa9180842cd38d4d61c7c47a02aad9ed. The corresponding functional test was added in c601bb8df5ae896061c42dd0e23cea8fba938ecb. The code on loongarch was not updated in a timely manner, resulting in the error.

[FFmpeg-devel] [PATCH v2] fate/vvc: Add vvc-frames-with-ltr.vvc

2025-01-08 Thread Frank Plowman
This sample is rather difficult, containing a lot of subtle edge cases which revealed errors in the VVC decoder. It covers 88.4% of lines in libavcodec/vvc and brings the line coverage of the entire VVC fate suite from 96.3% to 97.2%. Signed-off-by: Frank Plowman --- Changes since v1: * Remove i

[FFmpeg-devel] [PATCH] avcodec/vvc/dec: print thread debug logs only if DEBUG is defined

2025-01-08 Thread James Almer
Makes the output of a normal decoding process with loglevel debug a lot less verbose. Signed-off-by: James Almer --- libavcodec/vvc/thread.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/libavcodec/vvc/thread.c b/libavcodec/vvc/thread.c index 8f8358..6194416

Re: [FFmpeg-devel] [PATCH] libavcodec/sanm: implement codec37 subcodec1

2025-01-08 Thread Manuel Lauss
Interesting, which compiler do you use? I see no such errors with gcc-15. I'll redo the patch, thanks for testing! Manuel On Thu, Jan 9, 2025 at 4:02 AM Michael Niedermayer wrote: > > Hi > > On Tue, Jan 07, 2025 at 03:46:09PM +0100, Manuel Lauss wrote: > > RLE-compressed stream of motion vector

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: set pict_type and AV_FRAME_FLAG_KEY

2025-01-08 Thread Rubén Gonzalez
Sounds very good, thanks! Issue: https://trac.ffmpeg.org/ticket/11406 I would be glad to try it. On Wed, Jan 8, 2025 at 2:04 PM Nuo Mi wrote: > > > On Wed, Jan 8, 2025 at 12:35 AM Rubén Gonzalez > wrote: > >> Hi Nuo Mi, >> >> thanks for your feedback. Unfortunately I don't have enough >> kno

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: set pict_type and AV_FRAME_FLAG_KEY

2025-01-08 Thread Nuo Mi
On Wed, Jan 8, 2025 at 12:35 AM Rubén Gonzalez wrote: > Hi Nuo Mi, > > thanks for your feedback. Unfortunately I don't have enough knowledge/time > to improve the patch. I only mimicked H.26[45]. > > IMHO, reporting AV_FRAME_FLAG_KEY is better than nothing, so I will send a > new patch only with

Re: [FFmpeg-devel] [PATCH v2] fate/vvc: Add vvc-frames-with-ltr.vvc

2025-01-08 Thread Nuo Mi
LGTM. On Wed, Jan 8, 2025 at 7:51 PM Frank Plowman wrote: > This sample is rather difficult, containing a lot of subtle edge cases > Are we still encountering issues with the latest code? > which revealed errors in the VVC decoder. It covers 88.4% of lines in > libavcodec/vvc and brings the lin

Re: [FFmpeg-devel] [PATCH v2] fate/vvc: Add vvc-frames-with-ltr.vvc

2025-01-08 Thread James Almer
On 1/8/2025 8:49 AM, Frank Plowman wrote: This sample is rather difficult, containing a lot of subtle edge cases which revealed errors in the VVC decoder. It covers 88.4% of lines in libavcodec/vvc and brings the line coverage of the entire VVC fate suite from 96.3% to 97.2%. Signed-off-by: Fra

[FFmpeg-devel] [PATCH] avformat/libopenmpt: Update dts in read_seek function

2025-01-08 Thread Aida Jonikienė
This makes the song position correct after doing a seek operation (previously there would be an EOF after seeking about more than half into the song's actual duration). Fixes ticket #7916. Signed-off-by: Aida Jonikienė --- libavformat/libopenmpt.c | 1 + 1 file changed, 1 insertion(+) diff --g

Re: [FFmpeg-devel] [PATCH v2] fate/vvc: Add vvc-frames-with-ltr.vvc

2025-01-08 Thread Frank Plowman
On 08/01/2025 13:08, Nuo Mi wrote: > LGTM. > On Wed, Jan 8, 2025 at 7:51 PM Frank Plowman wrote: > >> This sample is rather difficult, containing a lot of subtle edge cases >> > Are we still encountering issues with the latest code? > No, most of my last patches are solving issues I found with

Re: [FFmpeg-devel] [PATCH] avformat/mov: perform sanity checks for heif before index building

2025-01-08 Thread James Almer
On 1/8/2025 5:31 PM, Michael Niedermayer wrote: Fixes: undefined NULL pointer use Fixes: clusterfuzz-testcase-minimized-audio_decoder_fuzzer-6363211175493632 This performs equivalent sanity checks as are done in mov_read_trak() before mov_build_index() Reported-by: Dale Curtis Signed-off-by: M

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_overlay: Remove spec-incompliant '; '

2025-01-08 Thread Andreas Rheinhardt
Patch attachedFrom c12eebac43c0124e6b20821cb57992f7e060ca49 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Wed, 8 Jan 2025 21:43:57 +0100 Subject: [PATCH 1/2] avfilter/vf_overlay: Remove spec-incompliant ';' Fixes warnings with -pedantic with GCC and Clang. Signed-off-by: Andreas Rheinh

[FFmpeg-devel] [PATCH] avcodec/aac_ac3_parser: Remove unused variable

2025-01-08 Thread Andreas Rheinhardt
Patch attachedFrom 67dd50c448c34028357ae58b55e1692774f033a1 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Wed, 8 Jan 2025 20:03:21 +0100 Subject: [PATCH] avcodec/aac_ac3_parser: Remove unused variable Added in 64bb91fd3b5a00a8849531c7e8dd207f2a626096, never used. Signed-off-by: Andreas

[FFmpeg-devel] [PATCH] avcodec/sga: Silence -Wunused-but-set-variable warnings

2025-01-08 Thread Andreas Rheinhardt
Patch attachedFrom 340f4c4d08d8477652573037670c9343ea1e8aef Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Wed, 8 Jan 2025 20:13:37 +0100 Subject: [PATCH] avcodec/sga: Silence -Wunused-but-set-variable warnings The variables are used, but only inside an av_assert1(). Signed-off-by: Andr

[FFmpeg-devel] [PATCH] swscale/cms, graph, lut3d: Use ff_-prefix, don't export, internal functions

2025-01-08 Thread Andreas Rheinhardt
Patch attachedFrom a4f032da79cbb3839aeaad6cf21133c1691d9f58 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Wed, 8 Jan 2025 21:22:37 +0100 Subject: [PATCH] swscale/cms,graph,lut3d: Use ff_-prefix, don't export internal functions Symbols with the sws_* prefix are exported. Signed-off-by:

[FFmpeg-devel] [PATCH] tests/ref/fate/png-icc-parse: Add lossless flag to ref file

2025-01-08 Thread Andreas Rheinhardt
Patch attachedFrom 15b74964a0f73c4fab8de1e31725f8cab606f513 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Thu, 9 Jan 2025 02:27:14 +0100 Subject: [PATCH] tests/ref/fate/png-icc-parse: Add lossless flag to ref file Forgotten in 8a29b4e38d515d4b4b8f30f782497809a54dd0fb (this test depends

[FFmpeg-devel] [PATCH] avcodec/aac/aacdec: Fix -Wdeclaration-after-statement

2025-01-08 Thread Andreas Rheinhardt
Patch attachedFrom f2580b0a3041a7b629ecd68cf6862dc57b14aecb Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Wed, 8 Jan 2025 20:16:41 +0100 Subject: [PATCH] avcodec/aac/aacdec: Fix -Wdeclaration-after-statement Signed-off-by: Andreas Rheinhardt --- libavcodec/aac/aacdec.c | 4 ++-- 1 fil

[FFmpeg-devel] [PATCH] avcodec/aac/aacdec: Fix -Wdeclaration-after-statement

2025-01-08 Thread Andreas Rheinhardt
Patch attachedFrom f2580b0a3041a7b629ecd68cf6862dc57b14aecb Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Wed, 8 Jan 2025 20:16:41 +0100 Subject: [PATCH] avcodec/aac/aacdec: Fix -Wdeclaration-after-statement Signed-off-by: Andreas Rheinhardt --- libavcodec/aac/aacdec.c | 4 ++-- 1 fil

Re: [FFmpeg-devel] [PATCH 1/5] ffv1dec: use dedicated pix_fmt field and call ff_get_format

2025-01-08 Thread Michael Niedermayer
Hi Lynne On Mon, Jan 06, 2025 at 01:07:29PM +0900, Lynne wrote: > Adding support for hwaccels means that avctx->pix_fmt will indicate > hardware formats. > --- > libavcodec/ffv1.h| 1 + > libavcodec/ffv1dec.c | 145 +++ > 2 files changed, 79 insertion

Re: [FFmpeg-devel] [PATCH] libavcodec/sanm: implement codec37 subcodec1

2025-01-08 Thread Michael Niedermayer
Hi On Tue, Jan 07, 2025 at 03:46:09PM +0100, Manuel Lauss wrote: > RLE-compressed stream of motion vector indices and a special opcode > to fill a block with data from the source stream. > > It is used in the LucasArts "Full Throttle" blink*.san animations. > > Signed-off-by: Manuel Lauss > ---

Re: [FFmpeg-devel] [PATCH 1/4] swscale/output: Fix undefined overflow in yuv2rgba64_full_X_c_template()

2025-01-08 Thread Michael Niedermayer
On Sun, Dec 01, 2024 at 05:03:03AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -1082982400 + -1195645138 cannot be > represented in type 'int' > Fixes: > 376136843/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-4791844321427456 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 1/6] tools/target_dec_fuzzer: Adjust threshold for VP6

2025-01-08 Thread Michael Niedermayer
On Mon, Dec 02, 2024 at 12:24:51AM +0100, Michael Niedermayer wrote: > Fixes: Timeout (would need 62sec) > Fixes: > 376731123/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP6_fuzzer-5926437896388608 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/pr

[FFmpeg-devel] [PATCH] avformat/mov: perform sanity checks for heif before index building

2025-01-08 Thread Michael Niedermayer
Fixes: undefined NULL pointer use Fixes: clusterfuzz-testcase-minimized-audio_decoder_fuzzer-6363211175493632 This performs equivalent sanity checks as are done in mov_read_trak() before mov_build_index() Reported-by: Dale Curtis Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 4 +++

Re: [FFmpeg-devel] [PATCH] avformat/mov: perform sanity checks for heif before index building

2025-01-08 Thread Michael Niedermayer
On Wed, Jan 08, 2025 at 06:05:16PM -0300, James Almer wrote: > On 1/8/2025 5:31 PM, Michael Niedermayer wrote: > > Fixes: undefined NULL pointer use > > Fixes: clusterfuzz-testcase-minimized-audio_decoder_fuzzer-6363211175493632 > > > > This performs equivalent sanity checks as are done in mov_rea

[FFmpeg-devel] [PATCH 2/2] avformat/mov: perform sanity checks for heif before index building

2025-01-08 Thread Michael Niedermayer
Fixes: undefined NULL pointer use Fixes: clusterfuzz-testcase-minimized-audio_decoder_fuzzer-6363211175493632 This performs equivalent sanity checks as are done in mov_read_trak() before mov_build_index() Reported-by: Dale Curtis Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 3 ++-

[FFmpeg-devel] [PATCH 1/2] avformat/mov: Factorize sanity check out

2025-01-08 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index a881acf99d0..8006bda7a1c 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -5144,6

Re: [FFmpeg-devel] [PATCH v3] loongarch: fixes fate-checkasm-sw_rgb failure

2025-01-08 Thread yinshiyou-hf
verified. LGTM. > -原始邮件- > 发件人: yuanhecai > 发送时间:2025-01-08 17:40:18 (星期三) > 收件人: ffmpeg-devel@ffmpeg.org > 抄送: yuanhecai > 主题: [FFmpeg-devel] [PATCH v3] loongarch: fixes fate-checkasm-sw_rgb failure > > The reason for the failure is that the function yuv2rgb_1_c_template was > modifie

Re: [FFmpeg-devel] [PATCHv2 1/3] avformat/mlvdec: demux LJ92 huffman comressed frames

2025-01-08 Thread Peter Ross
On Sun, Dec 22, 2024 at 06:40:31PM +1100, Peter Ross wrote: > A minimal DNG header is added to each LJ92 compressed frame, allowing > thme to be decoded by the TIFF decoder. The TIFF decoder is responsible > for setting up the MJPEG decoder, signalling the correct s->bayer flag, > and setting pix_f

[FFmpeg-devel] [PATCH 1/2] ffbuild/bin2c: misc fix

2025-01-08 Thread Jun Zhao
From: Jun Zhao close the input file if open output fail Signed-off-by: Jun Zhao --- ffbuild/bin2c.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ffbuild/bin2c.c b/ffbuild/bin2c.c index dfeedd7669..168b0c658d 100644 --- a/ffbuild/bin2c.c +++ b/ffbuild/bin2c.c @@ -38,8

[FFmpeg-devel] [PATCH 2/2] lavc/ac3dsp: fix R-V HAVE_RVV scope issue

2025-01-08 Thread Jun Zhao
From: Jun Zhao fix R-V HAVE_RVV scope issue Signed-off-by: Jun Zhao --- libavcodec/riscv/ac3dsp_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/riscv/ac3dsp_init.c b/libavcodec/riscv/ac3dsp_init.c index 24b3881854..f68a592839 100644 --- a/libavcodec/riscv/

Re: [FFmpeg-devel] [PATCH] avutil/frame.h: improve documentation for AV_FRAME_FLAG_LOSSLESS

2025-01-08 Thread Marton Balint
On Tue, 7 Jan 2025, Leo Izen wrote: It should be more clear what this flag is indicating with a more verbose comment documenting it. I guess we could bikeshed this till the end :) Below are my suggestions, heavily based on yours of course. Feel free to take what you like, and omit what yo

Re: [FFmpeg-devel] [PATCH] avformat/mov: perform sanity checks for heif before index building

2025-01-08 Thread James Almer
On 1/8/2025 5:31 PM, Michael Niedermayer wrote: Fixes: undefined NULL pointer use Fixes: clusterfuzz-testcase-minimized-audio_decoder_fuzzer-6363211175493632 This performs equivalent sanity checks as are done in mov_read_trak() before mov_build_index() Reported-by: Dale Curtis Signed-off-by: M