[FFmpeg-devel] [PATCH v3] libavcodec/v4l2_buffers.c: set AVFrame interlaced flags

2024-12-18 Thread Scott Theisen
Originally from: https://github.com/MythTV/mythtv/commit/669955c6cb29196b4b5120451b5b998d67a65749 --- v3: remove unnecessary clearing of already 0 valued flags use switch-case; I don't really think it is any simpler, but I do like the format better. --- libavcodec/v4l2_buffers.c | 19 ++

[FFmpeg-devel] [PATCH v2] libavcodec/v4l2_buffers.c: set AVFrame interlaced flags

2024-12-18 Thread Scott Theisen
Originally from: https://github.com/MythTV/mythtv/commit/669955c6cb29196b4b5120451b5b998d67a65749 --- libavcodec/v4l2_buffers.c | 20 1 file changed, 20 insertions(+) diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c index 23474ee143..85dfb40093 100644 --- a/

Re: [FFmpeg-devel] [PATCH v2] libavcodec/v4l2_buffers.c: set AVFrame interlaced flags

2024-12-18 Thread James Almer
On 12/18/2024 6:30 PM, Scott Theisen wrote: Originally from: https://github.com/MythTV/mythtv/commit/669955c6cb29196b4b5120451b5b998d67a65749 --- libavcodec/v4l2_buffers.c | 20 1 file changed, 20 insertions(+) diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buff

Re: [FFmpeg-devel] [PATCH] configure: add iso_writer golomb dependency

2024-12-18 Thread James Almer
On 12/16/2024 8:00 AM, Peter Ross wrote: since commit fce0622d0b1f69a85fe8ce61e1189dd57a8b0fcc, libavformat/hevc.c depends on golomb vlc tables. --- i often build with --disable-all and only turn on the components that i am working on. this dependency would otherwise go unnoticed since many codec

[FFmpeg-devel] [PATCH] swscale/unscaled: add pal8 -> gbr(a)p special converter

2024-12-18 Thread Niklas Haas
From: Niklas Haas Fixes: ticket #9520 Signed-off-by: Niklas Haas Sponsored-by: Sovereign Tech Fund --- libswscale/swscale.c | 2 + libswscale/swscale_unscaled.c | 81 ++- 2 files changed, 81 insertions(+), 2 deletions(-) diff --git a/libswscale/swscale

Re: [FFmpeg-devel] [PATCH v3] libavcodec/v4l2_buffers.c: set AVFrame interlaced flags

2024-12-18 Thread James Almer
On 12/18/2024 6:59 PM, Scott Theisen wrote: Originally from: https://github.com/MythTV/mythtv/commit/669955c6cb29196b4b5120451b5b998d67a65749 --- v3: remove unnecessary clearing of already 0 valued flags use switch-case; I don't really think it is any simpler, but I do like the format better.

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: remove systematic PAL8 hack

2024-12-18 Thread Vittorio Giovara
On Wed, Dec 18, 2024 at 12:48 PM Ronald S. Bultje wrote: > > > > It is worth pointing out that *libswscale* does not directly output PAL8; > > this rather is (and always was) handled by vf_scale. So in some sense, > this > > functionality already depends on libavfilter. > > > > That said, I do ag

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: remove systematic PAL8 hack

2024-12-18 Thread Ronald S. Bultje
Hi, On Wed, Dec 18, 2024 at 5:29 AM Niklas Haas wrote: > On Wed, 18 Dec 2024 02:32:07 +0100 Michael Niedermayer < > mich...@niedermayer.cc> wrote: > > Hi > > > > On Tue, Dec 17, 2024 at 10:31:42AM +0100, Niklas Haas wrote: > > > On Tue, 17 Dec 2024 01:48:02 +0100 Michael Niedermayer < > mich...@

[FFmpeg-devel] [PATCH] avformat/Makefile: add iso_writer golomb_tab from shared library dependency

2024-12-18 Thread Peter Ross
--- libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index dd96bf7ba8..a6935ad244 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile @@ -728,7 +728,7 @@ OBJS-$(CONFIG_LIBZMQ_PROTOCOL) += libzmq.

[FFmpeg-devel] [PATCH] vulkan_decode: support software-defined decoders

2024-12-18 Thread Lynne via ffmpeg-devel
--- libavcodec/vulkan_decode.c | 118 +++-- libavcodec/vulkan_decode.h | 8 +++ 2 files changed, 83 insertions(+), 43 deletions(-) diff --git a/libavcodec/vulkan_decode.c b/libavcodec/vulkan_decode.c index 4665a330ef..60ffdf7b38 100644 --- a/libavcodec/vulkan_dec

Re: [FFmpeg-devel] [PATCH] vulkan_decode: support software-defined decoders

2024-12-18 Thread Anton Khirnov
Quoting Lynne via ffmpeg-devel (2024-12-18 10:07:51) > vulkan_decode: support software-defined decoders > --- > libavcodec/vulkan_decode.c | 118 +++-- > libavcodec/vulkan_decode.h | 8 +++ > 2 files changed, 83 insertions(+), 43 deletions(-) This could really us

Re: [FFmpeg-devel] [PATCH] configure: add option to statically link to libvulkan

2024-12-18 Thread Leo Izen
On 12/18/24 3:46 AM, Lynne via ffmpeg-devel wrote: This may be useful in weird setups and on platforms where static linking to libvulkan is supported. libplacebo also has this fallback. --- I'm going to ask the classic "Why would you want to do this?" More specifically, I mean, can you give a

Re: [FFmpeg-devel] [PATCH] configure: add option to statically link to libvulkan

2024-12-18 Thread Lynne via ffmpeg-devel
On 19/12/2024 00:05, Leo Izen wrote: On 12/18/24 3:46 AM, Lynne via ffmpeg-devel wrote: This may be useful in weird setups and on platforms where static linking to libvulkan is supported. libplacebo also has this fallback. --- I'm going to ask the classic "Why would you want to do this?" Mor

Re: [FFmpeg-devel] [PATCH v2] swscale/unscaled: correctly round yuv2yuv when not dithering

2024-12-18 Thread Niklas Haas
On Tue, 17 Dec 2024 15:35:22 +0100 Niklas Haas wrote: > From: Niklas Haas > > We should at least bias towards the nearest integer, instead of always > rounding down, when not dithering. This is a bit more correct. > > Signed-off-by: Niklas Haas > Sponsored-by: Sovereign Tech Fund Ignore this on

[FFmpeg-devel] [PATCH 4/5] vulkan: do not NIH a queue context

2024-12-18 Thread Lynne via ffmpeg-devel
We recently introduced a public field which was a superset of the queue context we used to have. Switch to using it entirely. This also allows us to get rid of the NIH function just for video implementations. --- libavcodec/ffv1enc_vulkan.c | 18 libavcodec/vulkan_decode.c

[FFmpeg-devel] [PATCH 2/5] vulkan_decode: use a single execution pool

2024-12-18 Thread Lynne via ffmpeg-devel
Originally, the decoder had a single execution pool, with one execution context per thread. Execution pools were always intended to be thread-safe, as long as there were enough execution contexts in the pool to satisfy all threads. Due to synchronization issues, the threading part was removed at s

[FFmpeg-devel] [PATCH 1/5] hwcontext_vulkan: disable validation layer threading warnings

2024-12-18 Thread Lynne via ffmpeg-devel
The layer is buggy currently: https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/9045 --- libavutil/hwcontext_vulkan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 5601ef4d9e..6eca097ea3 100644 --- a/libavutil/hwc

[FFmpeg-devel] [PATCH 3/5] vulkan: remove pointless mutex locks

2024-12-18 Thread Lynne via ffmpeg-devel
This code was simply incorrect through and through. It did not protect what actually has to be protected in a multi-threaded setup. Perhaps it was used to silence threading errors? Either way, remove it, and document the correct way to use execution pools in a threaded environment. --- libavutil/

[FFmpeg-devel] [PATCH 5/5] vulkan_decode: add queue_flags field to specify queue used

2024-12-18 Thread Lynne via ffmpeg-devel
--- libavcodec/vulkan_av1.c| 1 + libavcodec/vulkan_decode.c | 2 +- libavcodec/vulkan_decode.h | 1 + libavcodec/vulkan_h264.c | 1 + libavcodec/vulkan_hevc.c | 1 + 5 files changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/vulkan_av1.c b/libavcodec/vulkan_av1.c index 29060

[FFmpeg-devel] [PATCH] configure: add option to statically link to libvulkan

2024-12-18 Thread Lynne via ffmpeg-devel
This may be useful in weird setups and on platforms where static linking to libvulkan is supported. libplacebo also has this fallback. --- configure| 7 ++- libavutil/hwcontext_vulkan.c | 9 + 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/configure

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: remove systematic PAL8 hack

2024-12-18 Thread Niklas Haas
On Wed, 18 Dec 2024 02:32:07 +0100 Michael Niedermayer wrote: > Hi > > On Tue, Dec 17, 2024 at 10:31:42AM +0100, Niklas Haas wrote: > > On Tue, 17 Dec 2024 01:48:02 +0100 Michael Niedermayer > > wrote: > > > Hi > > > > > > On Mon, Dec 16, 2024 at 02:57:53PM +0100, Niklas Haas wrote: > > > > Fro

Re: [FFmpeg-devel] [PATCH] vulkan_decode: support software-defined decoders

2024-12-18 Thread Lynne via ffmpeg-devel
On 18/12/2024 20:13, Anton Khirnov wrote: Quoting Lynne via ffmpeg-devel (2024-12-18 10:07:51) vulkan_decode: support software-defined decoders --- libavcodec/vulkan_decode.c | 118 +++-- libavcodec/vulkan_decode.h | 8 +++ 2 files changed, 83 insertions(+),

[FFmpeg-devel] [PATCH] avformat/iamf_writer: fix setting num_samples_per_frame for OPUS

2024-12-18 Thread James Almer
As per section 3.11.1 of the IAMF spec, the sample rate used in Codec Config for Opus shall be 48kHz, regardless of the original sample rate used during encoding. Signed-off-by: James Almer --- libavformat/iamf_writer.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) dif

Re: [FFmpeg-devel] [PATCH 3/4] checkasm/sw_rgb: add tests for yuv2packed{1, 2, X}

2024-12-18 Thread Michael Niedermayer
On Mon, Dec 16, 2024 at 12:48:19PM +0100, Niklas Haas wrote: > From: Niklas Haas > > --- > tests/checkasm/sw_rgb.c | 316 > 1 file changed, 316 insertions(+) seems breaking fate unless i forgot some patch checkasm: using random seed 3108170821 Assertion

Re: [FFmpeg-devel] [PATCH 1/4] checkasm/sw_scale: add assertion for hscale assumption

2024-12-18 Thread Michael Niedermayer
On Mon, Dec 16, 2024 at 12:48:17PM +0100, Niklas Haas wrote: > From: Niklas Haas > > This code only checks hcScale. In practice this is not an issue because > the function pointers should always be identical to hyScale for the same > filter size. > > Add an assertion just to make sure this assum

Re: [FFmpeg-devel] [PATCH 17/17] swscale: remove primaries/trc change warning

2024-12-18 Thread Michael Niedermayer
Hi On Thu, Dec 05, 2024 at 12:30:26PM +0100, Niklas Haas wrote: > From: Niklas Haas > > This is now supported when using the new API. > --- > libswscale/swscale.c | 11 --- > 1 file changed, 11 deletions(-) ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC

Re: [FFmpeg-devel] [PATCH v2 16/17] swscale/graph: allow dynamically updating HDR metadata

2024-12-18 Thread Michael Niedermayer
On Mon, Dec 16, 2024 at 12:17:37PM +0100, Niklas Haas wrote: > From: Niklas Haas > > Without triggering a full graph reinit. > --- > libswscale/graph.c | 21 - > libswscale/graph.h | 12 +--- > libswscale/utils.h | 6 ++ > 3 files changed, 35 insertions(+), 4 del

Re: [FFmpeg-devel] [PATCH 17/17] swscale: remove primaries/trc change warning

2024-12-18 Thread Michael Niedermayer
On Thu, Dec 19, 2024 at 04:58:05AM +0100, Michael Niedermayer wrote: > Hi > > On Thu, Dec 05, 2024 at 12:30:26PM +0100, Niklas Haas wrote: > > From: Niklas Haas > > > > This is now supported when using the new API. > > --- > > libswscale/swscale.c | 11 --- > > 1 file changed, 11 deleti

[FFmpeg-devel] [PATCH] avcodec/cbs_av1: fix variable shadowing in cbs_av1_split_fragment()

2024-12-18 Thread Marth64
header is previously declared as an int argument then shadowed in the scope of the loop as a AV1RawOBUHeader. Signed-off-by: Marth64 --- libavcodec/cbs_av1.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c index be086b81c

Re: [FFmpeg-devel] [PATCH] Fix crash when trying to get a fragment time for a non-existing fragment

2024-12-18 Thread Marth64
Will push in a few days ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: CC election

2024-12-18 Thread Michael Niedermayer
Hi Marth64 On Thu, Dec 05, 2024 at 12:39:49PM -0600, Marth64 wrote: > I volunteer. I have no revolutionary agenda or financial skin in this game, > and my current career does not intersect with A/V. I have been generally > reading the mailing list since March 2023. I can provide the following > se

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: CC election

2024-12-18 Thread Marth64
PS - I am analyzing this as if I was an outsider. I hold no grudges or negative feelings of anyone here, I am thankful for being welcomed into this community. My general philosophy is simple: We can do better than this. ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: CC election

2024-12-18 Thread Marth64
Hi Michael, > 2. and the most recent case Continuing where I left off. Let us analyze the s337m situation. * Contributor shares significant work, as an RFC, in good faith * A back and forth exchange happens with technical feedback and history * Then, two senior contributors exchange inflammatory

[FFmpeg-devel] [PATCH 1/2] avformat/Makefile: include object files for image_vbn_pipe demuxer

2024-12-18 Thread Peter Ross
--- found to be missing as the result of exhaustive configure options search. if image_vbn_pipe is selected on its own, build fails. libavformat/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/Makefile b/libavformat/Makefile index 691738eb4b..074efc118a 100644 --- a/libav

[FFmpeg-devel] [PATCH 2/2] avcodec/Makefile: include aom_film_grain.o file for h264_sei component

2024-12-18 Thread Peter Ross
h264_sei depends on h2645_sei, which in turn depends on aom_film_grain for ff_aom_uninit_film_grain_params() --- libavcodec/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index fd8e312fc8..350f50108a 100644 --- a/libavcodec/Ma

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: CC election

2024-12-18 Thread Kieran Kunhya via ffmpeg-devel
> 1a. Prior context: > For a long time FFmpeg booths where organized by various FFmpeg developers > like Thilo but also others. They where always announced publically, they > surely had a touch of hobbyists and a "non professional" community > > On NAB 2023 theres a booth paid by VideoLabs, with Vi

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: CC election

2024-12-18 Thread Marth64
Hi Michael, > can you maybe provide a few more details so I and people know better > how you would handle concrete examples, here are some: Yes, sure. Let us start with the booths. Unpacking this one based on information provided above and what I found in archives, Statement #1 (NAB 2023)

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: CC election

2024-12-18 Thread compn
On Thu, 19 Dec 2024 03:22:46 +0100, Michael Niedermayer wrote: i think we need to have a separate mailing list to talk about non development stuff. i think there are a lot of people who wish to contribute to ffmpeg and develop on ffmpeg but they dont care about booths or which dev said what to wh

Re: [FFmpeg-devel] [PATCH] avformat/Makefile: add iso_writer golomb_tab from shared library dependency

2024-12-18 Thread James Almer
On 12/18/2024 5:17 PM, Peter Ross wrote: --- libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index dd96bf7ba8..a6935ad244 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile @@ -728,7 +728,7 @@ OBJS-$

Re: [FFmpeg-devel] [PATCH] avformat/Makefile: add iso_writer golomb_tab from shared library dependency

2024-12-18 Thread Peter Ross
On Wed, Dec 18, 2024 at 05:21:33PM -0300, James Almer wrote: > On 12/18/2024 5:17 PM, Peter Ross wrote: > > --- > > libavformat/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/Makefile b/libavformat/Makefile > > index dd96bf7ba8..a6935ad244 10

Re: [FFmpeg-devel] [PATCH v2 03/17] swscale/utils: set static/implied HDR metadata

2024-12-18 Thread Michael Niedermayer
Hi On Mon, Dec 16, 2024 at 12:17:24PM +0100, Niklas Haas wrote: > From: Niklas Haas > > Provide default values for the fields added in the previous commit. > --- > libswscale/utils.c | 17 + > 1 file changed, 17 insertions(+) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH v2 02/17] swscale/utils: add HDR metadata to SwsFormat

2024-12-18 Thread Michael Niedermayer
Hi On Mon, Dec 16, 2024 at 12:17:23PM +0100, Niklas Haas wrote: [...] > diff --git a/libswscale/utils.h b/libswscale/utils.h > index 4d204ef6cc..52b1e67644 100644 > --- a/libswscale/utils.h > +++ b/libswscale/utils.h > @@ -21,26 +21,55 @@ > #ifndef SWSCALE_UTILS_H > #define SWSCALE_UTILS_H >