Hi Nicolas,
Quoting Nicolas Gaullier (2024-12-06 10:37:03)
> >De : Anton Khirnov
> >Envoyé : jeudi 5 décembre 2024 15:06
> >Hi,
> >I believe a similar approach was tried by Gyan earlier this year and
> >unanimously rejected by the TC [1-3].
> >
> >[1]
> >https://patchwork.ffmpeg.org/project/ffmpe
Hi Tristan,
I have a draft reply ongoing the last couple of days, but I got
sidetracked with other work, sorry. Will send it out without a new patch
so we can discuss the changes and it gives me more time to look into the
issue below.
On 12/11/24 23:53, Tristan Matthews via ffmpeg-devel wrot
Hi Tristan,
thanks for taking the time reviewing.
On 12/6/24 18:39, Tristan Matthews via ffmpeg-devel wrote:
Hi (also apologies if my client mangles the inline version of the patch, it's
the first time I've tried to review an attached patch with it)...
>
+av_log(ctx, AV_LOG_DEBUG, "RTP
>De : ffmpeg-devel de la part de Ramiro Polla
>
>Envoyé : jeudi 12 décembre 2024 15:56
>On Thu, Dec 12, 2024 at 1:28 PM Martin Storsjö wrote:
>>
>> This fixes occasional failed tests, if doing "make fate" without a
>> regular "make" or "make all" inbetween.
>
>I've had something similar locally
This fixes occasional failed tests, if doing "make fate" without a
regular "make" or "make all" inbetween.
---
tests/fate/audio.mak | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak
index 4d6c479b6b..6e091760ea 100644
--- a/tests/
On Tue, 21 May 2024 at 11:03, Timo Rothenpieler wrote:
>
> This is based on the preliminary spec for enhanced rtmp v2:
> https://veovera.org/docs/enhanced/enhanced-rtmp-v2
>
> The spec is not final, and can still undergo breaking changes, hence this set
> is purely for comments and review, and no
On 12/12/2024 17:30, Dennis Sädtler wrote:
With the spec now being in "beta" and no more (functional) changes
being expected, would you be happy to revisit this patch set and merge
it or do you want to wait for it to be declared "stable" or something?
Is that documented somewhere?
If the spec i
On Thu, 12 Dec 2024 at 17:31, Timo Rothenpieler wrote:
>
> On 12/12/2024 17:30, Dennis Sädtler wrote:
> > With the spec now being in "beta" and no more (functional) changes
> > being expected, would you be happy to revisit this patch set and merge
> > it or do you want to wait for it to be declare
>De : ffmpeg-devel de la part de Michael
>Niedermayer
>Envoyé : lundi 9 décembre 2024 04:55
>
>/usr/bin/ld: libavformat/libavformat.so: undefined reference to `ff_reverse'
>
>thx
Sorry, I forgot to check build against --enable-shared...
Thanks to you.
I can fix this in a new patch serie, but th
pthread_t is currently defined as a struct, which gets placed into
caller's memory and filled by pthread_create() (which accepts a
pthread_t*).
The problem with this approach is that pthread_join() accepts pthread_t
itself rather than a pointer to it, so it gets a _copy_ of this
structure. This ca
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index bf55ba67fa..266c5e7aab 100755
--- a/configure
+++ b/configure
@@ -7427,7 +7427,7 @@ fi
enabled amf &&
check_cpp_condition amf "AMF/core/Version.h" \
-"(AMF_VERSION_MAJOR <<
---
libavcodec/amfenc_av1.c | 66 +
1 file changed, 66 insertions(+)
diff --git a/libavcodec/amfenc_av1.c b/libavcodec/amfenc_av1.c
index 01b1f85747..11da9496ba 100644
--- a/libavcodec/amfenc_av1.c
+++ b/libavcodec/amfenc_av1.c
@@ -101,6 +101,10 @@ static c
Hi Timo,
On Wed, Dec 11, 2024 at 5:49 PM compn wrote:
> On Wed, 11 Dec 2024 14:56:23 +0100, Timo Rothenpieler wrote:
>
> > On 11/12/2024 10:10, Arnaud Masserann wrote:
> > > Hi, any feedback on this patch ?
> >
> > I do not appear to have received the mail you are replying to here
>
>
> https://
>De : ffmpeg-devel de la part de Anton
>Khirnov
>Envoyé : jeudi 12 décembre 2024 09:36
>
>I am not intimately familiar with these formats and their mutual
>relationship, so these problems you refer to are not clear to me.
>What I am familiar with is our APIs, and from that position I can say
>t
On Thu, Dec 12, 2024 at 1:28 PM Martin Storsjö wrote:
>
> This fixes occasional failed tests, if doing "make fate" without a
> regular "make" or "make all" inbetween.
> ---
> tests/fate/audio.mak | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/fate/audio.mak b
---
libavformat/flvdec.c | 571 +++
1 file changed, 310 insertions(+), 261 deletions(-)
diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c
index ddc3002fd5..51107cab19 100644
--- a/libavformat/flvdec.c
+++ b/libavformat/flvdec.c
@@ -1275,6 +1275,7 @@
Quoting Martin Storsjö (2024-12-12 18:40:27)
> On Thu, 12 Dec 2024, Anton Khirnov wrote:
>
> > pthread_t is currently defined as a struct, which gets placed into
> > caller's memory and filled by pthread_create() (which accepts a
> > pthread_t*).
> >
> > The problem with this approach is that pthr
On Mon, Dec 09, 2024 at 10:24:49PM +0100, Alexander Strasser via ffmpeg-devel
wrote:
> On 2024-12-08 12:36 +0100, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer
> > ---
> > src/template_head2 | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/src/template_head2 b/s
Hi
On Thu, Dec 12, 2024 at 12:54:29PM +, Nicolas Gaullier wrote:
[...]
> This is a significant work with some weird things like dealing with a
> truncated sample rate
> and droping one sample from time to time to keep sync. And with no active
> maintainer of the dolby_e decoder, so that won't
On Thu, 12 Dec 2024 at 19:45, Dennis Sädtler via ffmpeg-devel <
ffmpeg-devel@ffmpeg.org> wrote:
> On Thu, 12 Dec 2024 at 17:31, Timo Rothenpieler
> wrote:
> >
> > On 12/12/2024 17:30, Dennis Sädtler wrote:
> > > With the spec now being in "beta" and no more (functional) changes
> > > being expect
On Thu, 12 Dec 2024, Anton Khirnov wrote:
Quoting Martin Storsjö (2024-12-12 18:40:27)
On Thu, 12 Dec 2024, Anton Khirnov wrote:
> pthread_t is currently defined as a struct, which gets placed into
> caller's memory and filled by pthread_create() (which accepts a
> pthread_t*).
>
> The problem
---
libavformat/flvenc.c | 96 ++--
1 file changed, 47 insertions(+), 49 deletions(-)
diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c
index 21e2bca5be..fbe5416353 100644
--- a/libavformat/flvenc.c
+++ b/libavformat/flvenc.c
@@ -493,6 +493,45 @@ sta
---
libavformat/flvenc.c | 90 +---
1 file changed, 67 insertions(+), 23 deletions(-)
diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c
index 8b16f464c8..4366ef6586 100644
--- a/libavformat/flvenc.c
+++ b/libavformat/flvenc.c
@@ -132,7 +132,7 @@ type
---
libavformat/rtmpproto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index a56fec759f..a5e877cc55 100644
--- a/libavformat/rtmpproto.c
+++ b/libavformat/rtmpproto.c
@@ -2004,7 +2004,7 @@ static int send_invoke_response(UR
---
libavformat/flvdec.c | 41 +
1 file changed, 25 insertions(+), 16 deletions(-)
diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c
index 9831c263e2..cf41bb5741 100644
--- a/libavformat/flvdec.c
+++ b/libavformat/flvdec.c
@@ -1337,8 +1337,6 @@ retry
---
libavformat/flvdec.c | 44 ++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c
index b27928199e..ddc3002fd5 100644
--- a/libavformat/flvdec.c
+++ b/libavformat/flvdec.c
@@ -1396,8 +1396,8 @@ re
---
libavformat/flvdec.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c
index cf41bb5741..b27928199e 100644
--- a/libavformat/flvdec.c
+++ b/libavformat/flvdec.c
@@ -1338,12 +1338,26 @@ retry:
pkt_
---
libavformat/rtmpproto.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index b3b1eedacb..a56fec759f 100644
--- a/libavformat/rtmpproto.c
+++ b/libavformat/rtmpproto.c
@@ -356,9 +356,16 @@ static int gen_connect(
---
libavformat/flvenc.c | 93
1 file changed, 85 insertions(+), 8 deletions(-)
diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c
index fbe5416353..8b16f464c8 100644
--- a/libavformat/flvenc.c
+++ b/libavformat/flvenc.c
@@ -712,10 +712,82 @@ sta
Hello,
This person asked for coverity access:
https://x.com/acentauri92/status/1867186643704099105
I don't know if they should have access.
Kieran
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
T
On Fri, 13 Dec 2024, 00:39 Michael Niedermayer,
wrote:
> Hi
>
> On Thu, Dec 12, 2024 at 12:54:29PM +, Nicolas Gaullier wrote:
> [...]
> > This is a significant work with some weird things like dealing with a
> truncated sample rate
> > and droping one sample from time to time to keep sync. An
On Thu, 12 Dec 2024, 13:07 Nicolas Gaullier,
wrote:
> >De : ffmpeg-devel de la part de Anton
> Khirnov
> >Envoyé : jeudi 12 décembre 2024 09:36
> >
> >I am not intimately familiar with these formats and their mutual
> >relationship, so these problems you refer to are not clear to me.
> >What I
From: Dennis Sädtler
Based on enhanced-rtmp v2 spec published by Veovera:
https://veovera.github.io/enhanced-rtmp/docs/enhanced/enhanced-rtmp-v2
This implementation maintains some backwards compatibility by only
writing the track information for track indices > 0. This means that
older FFmpeg ve
---
libavformat/flv.h| 8 +++
libavformat/flvdec.c | 119 +++
2 files changed, 116 insertions(+), 11 deletions(-)
diff --git a/libavformat/flv.h b/libavformat/flv.h
index d030d576f3..8926db6388 100644
--- a/libavformat/flv.h
+++ b/libavformat/flv.h
@@
---
libavformat/flv.h| 6 ++
libavformat/flvenc.c | 143 +++
2 files changed, 111 insertions(+), 38 deletions(-)
diff --git a/libavformat/flv.h b/libavformat/flv.h
index 653c2bc82c..d030d576f3 100644
--- a/libavformat/flv.h
+++ b/libavformat/flv.h
@@
From: Dennis Sädtler
Based on enhanced-rtmp v2 spec published by Veovera:
https://veovera.github.io/enhanced-rtmp/docs/enhanced/enhanced-rtmp-v2
Signed-off-by: Dennis Sädtler
---
libavformat/flvdec.c | 117 +++
1 file changed, 96 insertions(+), 21 deleti
---
libavformat/flvenc.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c
index b85edc322f..21e2bca5be 100644
--- a/libavformat/flvenc.c
+++ b/libavformat/flvenc.c
@@ -1068,11 +1068,6 @@ static int flv_write_packet(AVFormatContext *s, AVPacket
On Thu, 12 Dec 2024, Anton Khirnov wrote:
pthread_t is currently defined as a struct, which gets placed into
caller's memory and filled by pthread_create() (which accepts a
pthread_t*).
The problem with this approach is that pthread_join() accepts pthread_t
itself rather than a pointer to it, s
On 12/12/24 01:41, Anton Khirnov wrote:
Quoting Scott Theisen (2024-12-10 21:42:06)
On 12/9/24 02:31, Anton Khirnov wrote:
Quoting Scott Theisen (2024-11-30 08:38:54)
On 11/25/24 00:42, Anton Khirnov wrote:
Quoting Scott Theisen (2024-11-14 05:37:49)
@@ -85,7 +85,13 @@ static int mpegaudio_p
Hi
On Fri, Dec 13, 2024 at 01:40:43AM +, Kieran Kunhya via ffmpeg-devel wrote:
> On Thu, 12 Dec 2024, 13:07 Nicolas Gaullier,
> wrote:
>
> > >De : ffmpeg-devel de la part de Anton
> > Khirnov
> > >Envoyé : jeudi 12 décembre 2024 09:36
> > >
> > >I am not intimately familiar with these for
Hi Kieran
On Fri, Dec 13, 2024 at 01:37:34AM +, Kieran Kunhya via ffmpeg-devel wrote:
> On Fri, 13 Dec 2024, 00:39 Michael Niedermayer,
> wrote:
>
> > Hi
> >
> > On Thu, Dec 12, 2024 at 12:54:29PM +, Nicolas Gaullier wrote:
> > [...]
> > > This is a significant work with some weird thing
Further fuzzing has found more problems in ffmpeg code. I have opened
two tickets:
https://trac.ffmpeg.org/ticket/11344
https://trac.ffmpeg.org/ticket/11345
No problems have been found in my changes.
Does this mean I have done sufficient testing to have my changes approved?
I asked for guidance
On Thu, 12 Dec 2024, Nicolas Gaullier wrote:
De : ffmpeg-devel de la part de Ramiro Polla
Envoyé : jeudi 12 décembre 2024 15:56
On Thu, Dec 12, 2024 at 1:28 PM Martin Storsjö wrote:
This fixes occasional failed tests, if doing "make fate" without a
regular "make" or "make all" inbetween.
A minimal DNG header is added to each LJ92 compressed frame, allowing
thme to be decoded by the TIFF decoder. The TIFF decoder is responsible
for setting up the MJPEG decoder, signalling the correct s->bayer flag,
and setting pix_fmt.
The LJ92 compressed frames can be muxed out to DNG files, and m
---
libavformat/mlvdec.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c
index 269f211e9f..830e416f57 100644
--- a/libavformat/mlvdec.c
+++ b/libavformat/mlvdec.c
@@ -249,6 +249,10 @@ static int scan_file(AVFormatContext *avctx, AVStream
*vst, A
---
libavformat/mlvdec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c
index 830e416f57..4f708a7705 100644
--- a/libavformat/mlvdec.c
+++ b/libavformat/mlvdec.c
@@ -253,9 +253,12 @@ static int scan_file(AVFormatContext *avctx, AVStream
*vst, AV
From: ulmus-scott
Defined in ISO/IEC 11172-3 and ISO/IEC 13818-3 as:
dual channel mode [audio]: A mode, where two audio channels with independent
programme contents (e.g. bilingual) are encoded within one bitstream. The
coding process is the same as for the stereo mode.
There is currently no way
On 12/12/2024 3:47 AM, Anton Khirnov wrote:
Quoting James Almer (2024-11-30 14:41:20)
with no speaker location implied
Also, is it really the case that no speaker location is implied? I'd
think mono (as opposed to just "1 channel") does carry the implication
is is the center channel.
Mono, a
48 matches
Mail list logo
