Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/cuvid: introduce a ringbuffer to reattach additional data

On Mon, 2 Dec 2024 at 13:01, Timo Rothenpieler wrote: > > On 02/12/2024 12:03, Clément Péron wrote: > > Hi Timo, > > > > I try to look deeper into this and compare it with others codec. > > And I'm not 100% sure why only cuviddec, dav1d and xevd set this flag > > "FF_CODEC_CAP_SETS_FRAME_PROPS" >

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/cuvid: introduce a ringbuffer to reattach additional data

On Tue, Dec 3, 2024 at 12:54 PM Clément Péron wrote: > > On Mon, 2 Dec 2024 at 13:01, Timo Rothenpieler wrote: > > > > On 02/12/2024 12:03, Clément Péron wrote: > > > Hi Timo, > > > > > > I try to look deeper into this and compare it with others codec. > > > And I'm not 100% sure why only cuvidde

Re: [FFmpeg-devel] [PATCH v2 00/11] fix broken CC detection and ffprobe fields (cover letter)

Quoting James Almer (2024-12-01 20:59:10) > I don't agree it should be in codecpar. It's rarely (if ever) filled > during header parsing (codec or container), and instead set when parsing > a frame that contains the relevant characteristic that's exported here > as a "property", like captions or

Re: [FFmpeg-devel] [PATCH 3/6] lavc/vvc: Store MIP information over entire CU area

Hi Frank, Thank you for the patch On Sat, Nov 30, 2024 at 8:13 PM Frank Plowman wrote: > On 30/11/2024 06:46, Nuo Mi wrote: > > On Fri, Nov 29, 2024 at 6:19 AM Frank Plowman > wrote: > > > >> Previously, the code only stored the MIP mode and transpose flag in the > >> relevant tables at the top

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h266: Fix typo

Thank you Alexander and Franek, Applied On Mon, Dec 2, 2024 at 5:44 AM Frank Plowman wrote: > On 01/12/2024 19:44, Alexander Strasser via ffmpeg-devel wrote: > > Introduced in commit 98698ed3c24bfd0b1e6e6db943b5f25f6046cee7 > > > > Fixes: CID1635788 CID1635789 > > Signed-off-by: Alexander Strass

Re: [FFmpeg-devel] [PATCH v4 4/8] swscale/range_convert: fix mpeg ranges in yuv range conversion for non-8-bit pixel formats

On Tue, Dec 3, 2024 at 3:35 AM Michael Niedermayer wrote: > On Sun, Dec 01, 2024 at 07:20:06PM +0100, Ramiro Polla wrote: > > There is an issue with the constants used in YUV to YUV range conversion, > > where the upper bound is not respected when converting to mpeg range. > > > > With this commit

[FFmpeg-devel] [PATCH 2/2] aarch64/vvc: Add apply_bdof

From: Zhao Zhili Test on rpi 5 with gcc 12: apply_bdof_8_8x16_c: 7315.2 ( 1.00x) apply_bdof_8_8x16_neon: 1876.8 ( 3.90x) apply_bdof_8_16x8_c: 7170.5 ( 1.00x) apply_bdof_8_16x8_neon:

[FFmpeg-devel] [PATCH 1/2] aarch64/vvc: Reuse ff_vvc_put_pel_pixels for chroma

From: Zhao Zhili --- libavcodec/aarch64/vvc/dsp_init.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/aarch64/vvc/dsp_init.c b/libavcodec/aarch64/vvc/dsp_init.c index e47f1ab4cc..4a7daf57a8 100644 --- a/libavcodec/aarch64/vvc/dsp_init.c +++ b/libavcodec/aarch64/vvc/dsp_in

Re: [FFmpeg-devel] [PATCH v2 00/11] fix broken CC detection and ffprobe fields (cover letter)

Hi Marton, > I see two possibilites: > > 1) Make ffprobe read the first packet or decode a first frame from every > stream and print information based on that. > > 2) Extend avstream_find_stream_info() so > - the API user can force it to read a packet or decode a frame from every > strea

Re: [FFmpeg-devel] [PATCH v2 0/3] Add WASM simd support

Le keskiviikkona 27. marraskuuta 2024, 14.35.08 EET Zhao Zhili a écrit : > Ping. I don't like that we use intrinsics, especially in this case, but I don't volunteer to rewrite the code as assembler. -- レミ・デニ-クールモン http://www.remlab.net/ ___ ffmpeg-

Re: [FFmpeg-devel] [PATCH 2/2] lavc/rv40dsp: fix RISC-V chroma_mc

Le sunnuntaina 1. joulukuuta 2024, 7.11.02 EET flow gg a écrit : > Hi, why is there an issue with the ABI? The ABI requires that the stack pointer is properly aligned AT ALL TIMES. Otherwise asynchronous signal handlers would break. > I previously just thought that s0 shouldn't be used here. Cl

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/cuvid: introduce a ringbuffer to reattach additional data

On Tue, Dec 3, 2024 at 9:57 AM Hendrik Leppkes wrote: > The real question is, why are you using cuviddec instead of nvdec? > side data would already pass through natively with nvdec, and other > hwaccel-based decoders. I suspect there could be benefits if your workload involves alot of decoding a

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: use dvdclut for YUV to RGB conversion of DVD subtitle palettes

Hi Michael, > v3 did build fine when i tested a few days ago IIRC Thank you very much. I also checked with some sources and it looked good to me. Will wait 4-5 days then push unless there is any objection. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpe

Re: [FFmpeg-devel] [PATCH] lavc/libx265: flag as experimental

On Tue, Dec 3, 2024 at 1:07 AM Kirithika Kalirathnam < kirith...@multicorewareinc.com> wrote: > Hi Vittorio, > > The commits in this PR > were > picked > and pushed to the master branch of x265.(b647da9 > < > https://bitbucket.org/mul

Re: [FFmpeg-devel] [PATCH v2 00/11] fix broken CC detection and ffprobe fields (cover letter)

On Tue, 3 Dec 2024, Marth64 wrote: Hi Marton, I see two possibilites: 1) Make ffprobe read the first packet or decode a first frame from every stream and print information based on that. 2) Extend avstream_find_stream_info() so - the API user can force it to read a packet or decode

Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegts: demux DVB VBI data

On Tue, 3 Dec 2024, Marton Balint wrote: On Sat, 30 Nov 2024, Scott Theisen wrote: DVB VBI data is defined in ETSI EN 301 775 and can include EBU teletext data as defined in ETSI EN 300 472. ETSI EN 300 468 defines teletext_descriptor, VBI_data_descriptor, and VBI_teletext_descripto

[FFmpeg-devel] [PATCH] lavc/h264dsp: R-V V intra loop filter

As with the inter loop filter, performance metrics seem to be biased in favour of the C implementation because checkasm inputs almost always fall in the no-op case. h264_h_loop_filter_chroma_intra_8bpp_c: 82.8 ( 1.00x) h264_h_loop_filter_chroma_intra_8bpp_rvv_i32: 72.6 (

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/mpegts*: reduce use of magic numbers

On Sun, 1 Dec 2024, Scott Theisen wrote: Note ISO/IEC 13818-1 defines an Extension_descriptor with descriptor_tag value 0x3f (63), so I kept the DVB comment. I don't know what defines stream_type value 0x8a as DTS. I don't have any Blu-ray standards so I don't know where those stream_type v

Re: [FFmpeg-devel] [PATCH 2/2] libavformat/mpegts.c: is_pes_stream() use switch case

On Sun, 1 Dec 2024, Scott Theisen wrote: also add STREAM_TYPE_PRIVATE_SECTION since a private_section() is not a PES_packet(). --- libavformat/mpegts.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) Will apply. Thanks, Marton diff --git a/libavformat/mpegts.c b/lib

Re: [FFmpeg-devel] [PATCH 2/2] avformat/rpl: Fix check for negative values

On Mon, Nov 18, 2024 at 10:26:37AM -0300, James Almer wrote: > On 11/18/2024 4:37 AM, Rémi Denis-Courmont wrote: > > Hi, > > > > Le 18 novembre 2024 05:09:11 GMT+02:00, Michael Niedermayer > > a écrit : > > > Fixes: signed integer overflow: 10 * -192326792533340 cannot be > > > represented

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/ilbcdec: Initialize tempbuff2

On Mon, Sep 23, 2024 at 11:32:43PM +0200, Michael Niedermayer wrote: > Fixes: Use of uninitialized value > Fixes: > 71350/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ILBC_fuzzer-6322020827070464 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/proje

Re: [FFmpeg-devel] [PATCH 3/9] avcodec/webp: Check ref_x/y

Hi Thilo On Fri, Nov 15, 2024 at 07:52:10PM +0100, Thilo Borgmann via ffmpeg-devel wrote: > Am 17.08.24 um 01:11 schrieb Michael Niedermayer: > > Fixes: > > 70991/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WEBP_fuzzer-5544067620995072 > > Fixes: use of uninintailized value > > > > Found-b

Re: [FFmpeg-devel] [PATCH] avcodec/vvc decode: ALF filtering without CC-ALF

Nuo Mi wrote: > This will introduce two writes for all blocks, even if there is no CC ALF. How about checking the sps_ccalf_enabled_flag in ff_vvc_alf_filter? That makes sense too, but I'd think you'd need to check both sps_ccalf_enabled_flag and the slice header sh_alf_cc_cb_enabled_flag/sh_alf

Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegts: demux DVB VBI data

On Sat, 30 Nov 2024, Scott Theisen wrote: DVB VBI data is defined in ETSI EN 301 775 and can include EBU teletext data as defined in ETSI EN 300 472. ETSI EN 300 468 defines teletext_descriptor, VBI_data_descriptor, and VBI_teletext_descriptor, which has the same definition as, but different

[FFmpeg-devel] [PATCH 1/2] avcodec/libjxlenc: add animated JPEG XL encoder

libjxl supports animated encoding, so we add a wrapper to the library using the receive_packet callback method. This code was based largely on a patch sent by Zsolt Vadász, although it was updated to use more recent coding practices and many of the leaks and issues were fixed. Co-authored-by: Zso

[FFmpeg-devel] [PATCH 2/2] avformat/jpegxl_anim_dec: use new animated JPEG XL codec ID

A new codec ID has been added to avcodec for animated JPEG XL, so we should use that in the animated JPEG XL demuxer. Signed-off-by: Leo Izen --- libavformat/jpegxl_anim_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/jpegxl_anim_dec.c b/libavformat/jpegxl_a

Re: [FFmpeg-devel] [PATCH 3/3] scale_qsv frame crop support

I am embedding ffmpeg and running a dynamic number of filters passes per frame. The standard crop filter supports commands that allow updating the crop region on an existing filter. The vpp filter must be recreated for any change. My other changes (cuda and vt) implement the correct crop functional

[FFmpeg-devel] [PATCH 1/5] avutil: add hwcontext_amf.

Adds hwcontext_amf, enabling a shared AMF context for encoders, decoders, and AMF-based filters, without copy to the host memory. Code also was tested in HandBrake. Benefits: - Optimizations for direct video memory access from CPU - Significant performance boost in full AMF pipelines with fi

[FFmpeg-devel] [PATCH 3/5] avfilter/scale_amf: Add AMF VPP & super resolution filters

From: Evgeny Pavlov This commit adds two AMF filters: vpp_amf & sr_amf. Both filters are using AMF hardware acceleration. vpp_amf supports simple scaling algorithms & color conversion. sr_amf supports advanced scaling algorithms such as FSR & can be used for upscaling only. --- configure

[FFmpeg-devel] [PATCH 4/5] doc/filters: Add documentation for AMF filters

From: Evgeny Pavlov Signed-off-by: Evgeny Pavlov --- doc/filters.texi | 238 +++ 1 file changed, 238 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 428986a1e9..7d75ebfa3e 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -

[FFmpeg-devel] [PATCH 5/5] avcodec/amfenc: redesign to use hwcontext_amf.

Co-authored-by: Evgeny Pavlov v3: cleanup code --- libavcodec/amfenc.c | 875 +-- libavcodec/amfenc.h | 34 +- libavcodec/amfenc_av1.c | 8 +- libavcodec/amfenc_h264.c | 6 +- libavcodec/amfenc_hevc.c | 6 +- 5 files changed, 306 insertions(+)

[FFmpeg-devel] [PATCH 2/5] avcodec: add amfdec.

From: Evgeny Pavlov Added AMF based h264, hevc, av1 decoders. Co-authored-by: Dmitrii Ovchinnikov v2: added encoder reinitialisation v3: use AMF_SURFACE_UNKNOWN to int decoder(ctx->output_format before) --- configure | 3 + libavcodec/Makefile| 7 +- libavcodec/allcodecs.c

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/cuvid: introduce a ringbuffer to reattach additional data

Hi Hendrik, On Tue, 3 Dec 2024 at 17:47, Devin Heitmueller wrote: > > On Tue, Dec 3, 2024 at 9:57 AM Hendrik Leppkes wrote: > > The real question is, why are you using cuviddec instead of nvdec? > > side data would already pass through natively with nvdec, and other > > hwaccel-based decoders.

Re: [FFmpeg-devel] [PATCH 3/6] lavc/vvc: Store MIP information over entire CU area

Hi, Thanks for your review. On 03/12/2024 10:04, Nuo Mi wrote: > Hi Frank, > Thank you for the patch > > On Sat, Nov 30, 2024 at 8:13 PM Frank Plowman wrote: > >> On 30/11/2024 06:46, Nuo Mi wrote: >>> On Fri, Nov 29, 2024 at 6:19 AM Frank Plowman >> wrote: >>> Previously, the code only

Re: [FFmpeg-devel] [PATCH v2] avcodec/ffv1enc: Add enum for qtable

On Mon, Dec 02, 2024 at 01:08:24PM +0900, Lynne via ffmpeg-devel wrote: > On 02/12/2024 11:15, Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/ffv1enc.c| 8 +++- > > libavcodec/ffv1enc.h| 6 ++ > > libavcodec/ffv1enc_vulkan.c

[FFmpeg-devel] [PATCH v2] lavc/vvc: Use a bitfield to store MIP information

Reduces memory consumption by ~4MB for 1080p video with a maximum delay of 16 frames by packing various information related to MIP: * intra_mip_flag, 1 bit * intra_mip_transposed_flag, 1 bit * intra_mip_mode, 4 bits Into a single byte. Co-authored-by: Nuo Mi Signed-off-by: Frank Plowman --- Chan

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: CC election

On Thu, Nov 28, 2024 at 9:33 AM Anton Khirnov wrote: > Hi all, > the current Community Committee (CC) was elected on 2023-12-05 and its > mandate lasts for one year, so we should hold a new election soon. If > there are no unforeseen circumstances, I would like to start the vote on > Monday 2024-