Re: [FFmpeg-devel] [PATCH 3/3] avutil/rational: never return greater num/den than the maximum allowed in av_d2q

2024-11-15 Thread Nicolas George
Marton Balint (12024-11-15): > Ping for this, will apply soon. I have had a busy week, I will be able to look at it this week-end. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/f

Re: [FFmpeg-devel] [PATCH 3/3] avutil/rational: never return greater num/den than the maximum allowed in av_d2q

2024-11-15 Thread Marton Balint
On Sun, 10 Nov 2024, Marton Balint wrote: This reverts 887d74c47efa70d7d1513e9492d41cf7f88dee0b, because it ignores the maximum allowed numerator/denominator. Even if the result was rounded to zero or infinity, it should not be cause to ignore the maximum allowed number, this "feature" is uni

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/asrc_sine: increase frequency accuracy

2024-11-15 Thread Nicolas George
Marton Balint (12024-11-15): > Will apply the series soon. Sorry, this was the series I was thinking of when replying: I have had a busy week, I will be able to look at it this week-end. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmp

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/asrc_sine: increase frequency accuracy

2024-11-15 Thread Marton Balint
On Sun, 10 Nov 2024, Marton Balint wrote: Previously the delta phase was fixed point fractional with 2^32 fractions, which caused inaccuracies in the output frequency, unless the input frequency*2^32 was divisable by the sample rate. This patch improves frequency accuracy by tracking subfrac

Re: [FFmpeg-devel] root access voting

2024-11-15 Thread Vittorio Giovara
So when are we going to vote? Vittorio On Wed, Nov 13, 2024 at 2:06 AM Rémi Denis-Courmont wrote: > > > Le 13 novembre 2024 00:51:23 GMT+02:00, compn a > écrit : > >> That is a major red flag, very similar to what you yourself claimed > >> as motivation to reject Josh - precarious employment si

[FFmpeg-devel] [PATCH] avformat/movenc: don't disable edit lists when writing CMAF output

2024-11-15 Thread James Almer
They are needed for audio tracks with priming samples, where negative CTS offsets are not used. Fixes ticket #11031. Signed-off-by: James Almer --- libavformat/movenc.c | 8 1 file changed, 8 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 73cc6f5845..b24f

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1: Support slice coding mode 1 with golomb rice

2024-11-15 Thread Michael Niedermayer
On Fri, Oct 25, 2024 at 03:57:21AM +0200, Michael Niedermayer wrote: > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/ffv1dec.c | 20 ++-- > libavcodec/ffv1dec_template.c | 3 +++ > libavcodec/ffv1enc.c | 23 +++

Re: [FFmpeg-devel] [PATCH] avformat/sapdec: check return value of avcodec_parameters_copy()

2024-11-15 Thread Marth64
Tested and pushed On Sat, Nov 9, 2024 at 10:16 Marth64 wrote: > Will push in 2 days > > Thanks > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-d

Re: [FFmpeg-devel] [PATCH 1/5] compat: add a fallback implementation of C23 stdckdint.h

2024-11-15 Thread James Almer
On 11/15/2024 7:22 PM, Andreas Rheinhardt wrote: James Almer: From: Justine Tunney Header contents taken from https://github.com/jart/jtckdint/commit/62df1fc0966926299253b7af46c23e345545 Signed-off-by: James Almer --- compat/stdckdint/stdckdint.h | 663

Re: [FFmpeg-devel] [PATCH v3 00/17] avformat/dvdvideodec: bugfixes and menu chapter markers

2024-11-15 Thread Marth64
Will push soon. Set fixes several issues and makes seeking smoother. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with su

Re: [FFmpeg-devel] root access voting

2024-11-15 Thread Michael Niedermayer
Hi Vittorio On Fri, Nov 15, 2024 at 10:19:07AM -0500, Vittorio Giovara wrote: > So when are we going to vote? vote about what ? Maybe you should first reveal what you want then we can try to discuss that, and improve FFmpeg, if theres something to improve. the infra text, we will improve, that

Re: [FFmpeg-devel] [PATCH] swscale/ppc: remove AltiVec acceleration for YUV->RGB conversions

2024-11-15 Thread Andrew Randrianasulu
чт, 14 нояб. 2024 г., 23:38 Sean McGovern : > Even on a reasonably modern POWER9 (ppc64le), it does not function > correctly. > I was under impression it was mostly developed and used on older G4/G5 cpus (big endian) --- > libswscale/ppc/Makefile | 1 - > libswscale/ppc/swscale

Re: [FFmpeg-devel] [PATCH 3/9] avcodec/webp: Check ref_x/y

2024-11-15 Thread Thilo Borgmann via ffmpeg-devel
Am 17.08.24 um 01:11 schrieb Michael Niedermayer: Fixes: 70991/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WEBP_fuzzer-5544067620995072 Fixes: use of uninintailized value Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mi

Re: [FFmpeg-devel] [PATCH v13 2/8] avcodec/webp: separate VP8 decoding

2024-11-15 Thread Thilo Borgmann via ffmpeg-devel
Am 21.06.24 um 13:52 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2024-06-21 12:43:17) From: Thilo Borgmann via ffmpeg-devel --- libavcodec/webp.c | 50 +-- 1 file changed, 44 insertions(+), 6 deletions(-) diff --git a/libavcod

Re: [FFmpeg-devel] [PATCH 16/22] avformat/webpenc: Check filesize in trailer

2024-11-15 Thread Thilo Borgmann via ffmpeg-devel
Am 12.07.24 um 01:34 schrieb Michael Niedermayer: not sure this is possible Fixes: CID1604446 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/webpenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Should be ok if tested. -

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: add CC format for user_data 0x05 0x02

2024-11-15 Thread Marth64
This is working on samples I have from 1999. Even ccextractor seems not to work on those samples anymore. I will review the code more closely and write back. Thanks for sharing, this is cool. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://f

Re: [FFmpeg-devel] [PATCH] Fix incorrect enum type used for a local variable

2024-11-15 Thread Marth64
Will push in a few days with commit message & whitespace fix. Thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with su

[FFmpeg-devel] [PATCH 1/3] avcodec/cavs: Limit align requirement to variable than type

2024-11-15 Thread Zhao Zhili
From: Zhao Zhili There are another three cavs_vector variables, ff_cavs_dir_mv, ff_cavs_intra_mv and un_mv. They don't need align to 8. --- libavcodec/cavs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/cavs.h b/libavcodec/cavs.h index 244c322b35..d3a88ca403

[FFmpeg-devel] [PATCH 3/3] avutil/mem_internal: local align should always work

2024-11-15 Thread Zhao Zhili
From: Zhao Zhili --- configure| 7 --- libavutil/mem_internal.h | 28 2 files changed, 4 insertions(+), 31 deletions(-) diff --git a/configure b/configure index 0e9ed6dc3c..b9fb3cd5af 100755 --- a/configure +++ b/configure @@ -2246,7 +2246,6 @@

[FFmpeg-devel] [PATCH 2/3] avutil/mem_internal: define DECLARE_ALIGNED as C11's _Alignas

2024-11-15 Thread Zhao Zhili
From: Zhao Zhili _Alignas is portable than compiler's specific __attribute__. It do have a limitation, that _Alignas don't support specify aligment on the declarations of struct (it works for specify alignment on struct fields), which only used by avcodec/cavs, and is removed now. --- libavutil/

Re: [FFmpeg-devel] [PATCH 2/3] avutil/mem_internal: define DECLARE_ALIGNED as C11's _Alignas

2024-11-15 Thread Rémi Denis-Courmont
Le 15 novembre 2024 12:56:23 GMT+02:00, Zhao Zhili a écrit : >From: Zhao Zhili > >_Alignas is portable than compiler's specific __attribute__. It do >have a limitation, that _Alignas don't support specify aligment on >the declarations of struct (it works for specify alignment on struct >fields

[FFmpeg-devel] [PATCH v2 2/3] avutil/mem_internal: define DECLARE_ALIGNED as C11's alignas

2024-11-15 Thread Zhao Zhili
From: Zhao Zhili alignas is portable than compiler's specific __attribute__. It do have a limitation, that alignas don't support specify aligment on the declarations of struct (it works for specify alignment on struct fields), which only used by avcodec/cavs, and is removed now. --- libavutil/me

Re: [FFmpeg-devel] [PATCH v4 0/5] avcodec/x86/diracdsp: migrate last remaining MMX function to SSE2

2024-11-15 Thread Ronald S. Bultje
Hi, On Thu, Nov 14, 2024 at 2:43 PM Ronald S. Bultje wrote: > Hi, > > On Thu, Nov 14, 2024 at 1:28 PM Kyosuke Kawakami > wrote: > >> This series of patch migrates the last remaining MMX function in >> diracdsp to SSE2. >> >> Changes from v3 are: >> - Use correct register load/use counts >> - Fi

Re: [FFmpeg-devel] [RFC] STF 2025

2024-11-15 Thread Thilo Borgmann via ffmpeg-devel
Hi, Am 17.05.24 um 15:49 schrieb Michael Niedermayer: Hi all Before this is forgotten again, better start some dicsussion too early than too late I propose that if we have the oppertunity again next year to receive a grant from STF. That we use it to fund: [...] the trac page for the STF 20

Re: [FFmpeg-devel] [PATCH 2/3] avutil/mem_internal: define DECLARE_ALIGNED as C11's _Alignas

2024-11-15 Thread Scott Theisen
On 11/15/24 08:47, Rémi Denis-Courmont wrote: Le 15 novembre 2024 12:56:23 GMT+02:00, Zhao Zhili a écrit : From: Zhao Zhili _Alignas is portable than compiler's specific __attribute__. It do have a limitation, that _Alignas don't support specify aligment on the declarations of struct (it wo

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers

2024-11-15 Thread Pavel Koshevoy
On Sat, Nov 9, 2024 at 10:46 AM Pavel Koshevoy wrote: > > > On Sat, Nov 9, 2024 at 10:39 AM James Almer wrote: > >> On 11/9/2024 2:34 PM, Pavel Koshevoy wrote: >> > On Sat, Nov 9, 2024 at 10:27 AM James Almer wrote: >> > >> >> On 11/9/2024 1:57 PM, Pavel Koshevoy wrote: >> >>> This avoids unple

[FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers (v2)

2024-11-15 Thread Pavel Koshevoy
This avoids unpleasant surprises to av_frame_get_buffer callers that explicitly specified 64-byte alignment and didn't get AVFrame.data pointers that are 64-byte aligned. For example, see https://github.com/sekrit-twc/zimg/issues/212 Although the zscale issue has already been resolved by other me

Re: [FFmpeg-devel] [PATCH] swscale/ppc: remove AltiVec acceleration for YUV->RGB conversions

2024-11-15 Thread Andreas Rheinhardt
Sean McGovern: > Even on a reasonably modern POWER9 (ppc64le), it does not function correctly. IMO the commit message should contain a bit more information about what doesn't function correctly. > --- > libswscale/ppc/Makefile | 1 - > libswscale/ppc/swscale_altivec.c | 25 - > libsw

[FFmpeg-devel] [PATCH 1/2] avcodec/x86/aacencdsp: fix inverting sign in output values

2024-11-15 Thread James Almer
using OR will unconditionally set output values to negative if the input is negative, when what needs to be done is inverting the sign of the output value if the input value is negative. Signed-off-by: James Almer --- libavcodec/x86/aacencdsp.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[FFmpeg-devel] [PATCH 2/2] checkasm/aacencdsp: initialize AAC tables

2024-11-15 Thread James Almer
Without this, the tables will be zero and the tests completely useless. Signed-off-by: James Almer --- tests/checkasm/aacencdsp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/checkasm/aacencdsp.c b/tests/checkasm/aacencdsp.c index 5308a2ac03..d53a04c532 100644 --- a/tests/checkasm/a

Re: [FFmpeg-devel] [PATCH] lavc/x86/videodsp: Drop MMX usage

2024-11-15 Thread Andreas Rheinhardt
Frank Plowman: > Remove the MMX versions of these functions and modify the SSE > implementations to avoid using MMX registers. > > Signed-off-by: Frank Plowman > --- > This wasn't wholly straightforward as the existing SSE implementation did > not only use SSE but rather a blend of SSE and MMX.

Re: [FFmpeg-devel] root access voting

2024-11-15 Thread Ronald S. Bultje
Hi, On Fri, Nov 15, 2024 at 1:41 PM Michael Niedermayer wrote: > adding a assembly course to FFmpeg github will happen once someone replies > and > says who will do it and what access (s)he needs. > Kieran says he would like access in the future, but doesn't need it right now yet, so no action

[FFmpeg-devel] [PATCH] vulkan: Don't try to early reuse exec context with query

2024-11-15 Thread David Rosca
It needs to first get the query before the context can be used again. Fixes getting incorrect values from encode query with async_depth > 1. --- libavutil/vulkan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c index 2c71312d78..8485c5

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers (v2)

2024-11-15 Thread Anton Khirnov
Quoting Pavel Koshevoy (2024-11-15 20:32:21) > This avoids unpleasant surprises to av_frame_get_buffer callers > that explicitly specified 64-byte alignment and didn't get > AVFrame.data pointers that are 64-byte aligned. > > For example, see https://github.com/sekrit-twc/zimg/issues/212 > > Alth

Re: [FFmpeg-devel] root access voting

2024-11-15 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-11-06 15:48:19) > > You publicly resigned as this project's leader 9 years ago. Yet after > > all this time you treat it as a matter of course that you and only you > > can unilaterally decide who is trustworthy enough to be root, get git > > push, or any other inf

Re: [FFmpeg-devel] [PATCH 2/2] checkasm/aacencdsp: initialize AAC tables

2024-11-15 Thread Rémi Denis-Courmont
Le perjantaina 15. marraskuuta 2024, 22.41.20 EET James Almer a écrit : > Without this, the tables will be zero and the tests completely useless. > > Signed-off-by: James Almer > --- > tests/checkasm/aacencdsp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/checkasm/aacencdsp.c

Re: [FFmpeg-devel] root access voting

2024-11-15 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-11-06 14:38:09) > Hi > > [...] > > > > > And having an all inclusive meeting, there is no remote participation, no > > > recording, Even the developer with the most commits in FFmpeg has no > > > option > > > to participate. > > > > You DO have an option to parti

Re: [FFmpeg-devel] Patch for libx265 memory leak

2024-11-15 Thread Anton Khirnov
Quoting Damiano Galassi (2024-11-12 07:36:53) > On Tue, Nov 12, 2024 at 3:38 AM Zhao Zhili wrote: > > > > > cleanup() release library static allocations, and I don’t see lock or > > reference count > > within x265_cleanup(). So call cleanup() will break other x265 encoder > > instance, > > right?

Re: [FFmpeg-devel] [PATCH 2/3] avutil/mem_internal: define DECLARE_ALIGNED as C11's _Alignas

2024-11-15 Thread Rémi Denis-Courmont
Le perjantaina 15. marraskuuta 2024, 22.09.25 EET Scott Theisen a écrit : > On 11/15/24 08:47, Rémi Denis-Courmont wrote: > > Le 15 novembre 2024 12:56:23 GMT+02:00, Zhao Zhili a écrit : > >> From: Zhao Zhili > >> > >> _Alignas is portable than compiler's specific __attribute__. It do > >> have

[FFmpeg-devel] [PATCH 2/3] lavc/h264dsp: remove RISC-V table alignment

2024-11-15 Thread Rémi Denis-Courmont
These values are bytes and need not be aligned. --- libavcodec/riscv/h264idct_rvv.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/riscv/h264idct_rvv.S b/libavcodec/riscv/h264idct_rvv.S index d2f77a5b47..fda1f37a3c 100644 --- a/libavcodec/riscv/h264idct_rvv.S +++ b/

[FFmpeg-devel] [PATCH 1/3] lavc/h264dsp: move RISC-V fn pointers to .data.rel.ro

2024-11-15 Thread Rémi Denis-Courmont
This should fix PIC builds. --- libavcodec/riscv/h264dsp_rvv.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/riscv/h264dsp_rvv.S b/libavcodec/riscv/h264dsp_rvv.S index 079896b17b..05d077f44e 100644 --- a/libavcodec/riscv/h264dsp_rvv.S +++ b/libavcodec/riscv/h264dsp

[FFmpeg-devel] [PATCH 3/3] lavc/vp8dsp: remove RISC-V table alignment

2024-11-15 Thread Rémi Denis-Courmont
These values are bytes and need not be aligned. --- libavcodec/riscv/vp8dsp_rvv.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/riscv/vp8dsp_rvv.S b/libavcodec/riscv/vp8dsp_rvv.S index a8b3e239ba..a0548fbf0a 100644 --- a/libavcodec/riscv/vp8dsp_rvv.S +++ b/libavcod

Re: [FFmpeg-devel] [RFC] dormant git accounts

2024-11-15 Thread compn
On Wed, 13 Nov 2024 10:44:29 -1000 compn wrote: > the server admins know who has access. the access list isnt a public > document. some developers want it to be a public document. > i dont particularly care if the list is public or not. > > i am curious to know why this is now an important issue,

Re: [FFmpeg-devel] root access voting

2024-11-15 Thread Anton Khirnov
Quoting Tomas Härdin (2024-11-06 18:36:12) > I've been meaning to critique the idea that commits should be the > membership criterion. It's biased towards those who write lots of > patches It actually seems the reverse to me - 20 commits in 3 years is a VERY low bar, it's not all that hard to writ

[FFmpeg-devel] [PATCH 2/2] checkasm: add RISC-V vector width to arch info

2024-11-15 Thread Rémi Denis-Courmont
--- tests/checkasm/checkasm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index fb307af0ae..f30c53cec2 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -96,6 +96,8 @@ #if ARCH_AARCH64 #include "libavut

[FFmpeg-devel] [PATCH 1/2] tests/cpu: print the RISC-V Vector length

2024-11-15 Thread Rémi Denis-Courmont
--- libavutil/tests/cpu.c | 8 1 file changed, 8 insertions(+) diff --git a/libavutil/tests/cpu.c b/libavutil/tests/cpu.c index 9e45527408..1eb3055ff0 100644 --- a/libavutil/tests/cpu.c +++ b/libavutil/tests/cpu.c @@ -25,6 +25,8 @@ #if ARCH_AARCH64 #include "libavutil/aarch64/cpu.h"