Re: [FFmpeg-devel] Develop FFmpeg through your browser?

2024-11-09 Thread Jean-Baptiste Kempf
Hello, On Sat, 9 Nov 2024, at 11:16, Rémi Denis-Courmont wrote: > The community will always have the option to move to another host thanks to > Git's decentralised design. The only thing to worry about would be losing the > requests and issues history. But even that could probably be copied and

Re: [FFmpeg-devel] libavfilter: integral images and minkowski pooling for SSIM - ping

2024-11-09 Thread Kieran Kunhya via ffmpeg-devel
On Tue, 22 Oct 2024, 07:25 Michael Niedermayer, wrote: > On Mon, Oct 21, 2024 at 07:32:20PM +0200, AndreaMastroberti wrote: > > --- > > doc/filters.texi | 14 +++ > > libavfilter/ssim.h| 6 + > > libavfilter/version.h | 4 +- > > libavfilter/vf_ssim.c | 277

Re: [FFmpeg-devel] Develop FFmpeg through your browser?

2024-11-09 Thread Rémi Denis-Courmont
Le sunnuntaina 3. marraskuuta 2024, 1.56.26 EET Michael Niedermayer a écrit : > Should we move to a different development system ? Simply no. The issue is the review and merge process, not the software development as such. E-mail was not designed to do code reviews. It does a pretty poor job at

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: clear window

2024-11-09 Thread Michael Niedermayer
On Thu, Nov 07, 2024 at 11:04:50AM -0500, Leo Izen wrote: > On 11/7/24 12:28 AM, Kacper Michajlow wrote: > > On Tue, 5 Nov 2024 at 11:05, Leo Izen wrote: > > > > > > This says reported by kacper, could you send me the fuzz testcase? > > > > I've sent you testcases privately. > > > > - Kacper >

Re: [FFmpeg-devel] [PATCH 6/7] ffv1: use standard syntax for indexing state

2024-11-09 Thread Lynne via ffmpeg-devel
On 11/10/24 02:36, Michael Niedermayer wrote: On Sat, Nov 09, 2024 at 08:22:25AM +0100, Lynne via ffmpeg-devel wrote: It isn't immediately obvious what indexing this array does. Use standard syntax instead. --- libavcodec/ffv1.h | 2 +- libavcodec/ffv1dec_template.c | 2 +- libav

Re: [FFmpeg-devel] [PATCH 6/7] ffv1: use standard syntax for indexing state

2024-11-09 Thread Michael Niedermayer
On Sat, Nov 09, 2024 at 08:22:25AM +0100, Lynne via ffmpeg-devel wrote: > It isn't immediately obvious what indexing this array does. > Use standard syntax instead. > --- > libavcodec/ffv1.h | 2 +- > libavcodec/ffv1dec_template.c | 2 +- > libavcodec/ffv1enc_template.c | 4 ++-- > 3 f

Re: [FFmpeg-devel] [PATCH] fate: Add a target for listing failed tests

2024-11-09 Thread Michael Niedermayer
On Thu, Nov 07, 2024 at 11:36:24AM +0200, Martin Storsjö wrote: > If running tests with "make -j fate", the execution will stop > after the first failing test. To get an overview of the whole > test suite, one rather would run "make -k -j fate", which then > again buries the results about what test

Re: [FFmpeg-devel] [PATCH 0/2] fix for seeking in HLS with FMP4 media

2024-11-09 Thread Steven Liu
vectronic 于2024年11月8日周五 05:31写道: > > I am again updating and resubmitting a patch which fixes the following ticket: > > https://trac.ffmpeg.org/ticket/7359 > > This fix has been tested and recommended by several people now and I have > been using it in production successfully since I submitted it

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add missing ISO/IEC 15444-4 conformance tests

2024-11-09 Thread Michael Niedermayer
On Fri, Nov 08, 2024 at 01:09:34PM -0800, p...@sandflow.com wrote: > From: Pierre-Anthony Lemieux > > --- > tests/fate/jpeg2000.mak | 122 ++- > tests/ref/fate/jpeg2000dec-ds0_hm_15_b8 | 6 ++ > tests/ref/fate/jpeg2000dec-ds0_ht_02_b11 | 6 ++ > tests/re

Re: [FFmpeg-devel] [PATCH 3/7] ffv1enc: split off encoder initialization into a separate function

2024-11-09 Thread Michael Niedermayer
On Sat, Nov 09, 2024 at 08:22:22AM +0100, Lynne via ffmpeg-devel wrote: > --- > libavcodec/ffv1enc.c | 352 +++ > libavcodec/ffv1enc.h | 30 > 2 files changed, 216 insertions(+), 166 deletions(-) > create mode 100644 libavcodec/ffv1enc.h This breaks:

Re: [FFmpeg-devel] [RFC] dormant git accounts

2024-11-09 Thread myp...@gmail.com
On Sun, Nov 10, 2024 at 12:18 AM Michael Niedermayer wrote: > > Hi all > > Should we disable git accounts for developers who have not been active since > a long time (like 10 years) ? > > (if these developers come back, the account would then be enabled again) > but disabling such accounts may imp

[FFmpeg-devel] [PATCH] avfilter/framepool: align the frame buffers

2024-11-09 Thread James Almer
And not just the linesizes. Use the extra align bytes allocated for this purpose. Signed-off-by: James Almer --- libavfilter/framepool.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c index e8621e07ac..1a1fc0de1

Re: [FFmpeg-devel] [PATCH] avformat/sapdec: check return value of avcodec_parameters_copy()

2024-11-09 Thread Marth64
Will push in 2 days Thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] fate/pixfmt: disable dithering in the scale filter

2024-11-09 Thread James Almer
On 11/9/2024 1:19 PM, Michael Niedermayer wrote: On Sat, Nov 09, 2024 at 11:05:32AM -0300, James Almer wrote: On 11/8/2024 9:03 PM, Michael Niedermayer wrote: On Fri, Nov 08, 2024 at 04:56:38PM -0300, James Almer wrote: On 11/8/2024 5:15 AM, Martin Storsjö wrote: On Thu, 7 Nov 2024, James Alm

Re: [FFmpeg-devel] [PATCH] fate/pixfmt: disable dithering in the scale filter

2024-11-09 Thread Michael Niedermayer
On Sat, Nov 09, 2024 at 11:05:32AM -0300, James Almer wrote: > On 11/8/2024 9:03 PM, Michael Niedermayer wrote: > > On Fri, Nov 08, 2024 at 04:56:38PM -0300, James Almer wrote: > > > On 11/8/2024 5:15 AM, Martin Storsjö wrote: > > > > On Thu, 7 Nov 2024, James Almer wrote: > > > > > > > > > Should

[FFmpeg-devel] [RFC] dormant git accounts

2024-11-09 Thread Michael Niedermayer
Hi all Should we disable git accounts for developers who have not been active since a long time (like 10 years) ? (if these developers come back, the account would then be enabled again) but disabling such accounts may improve security (lots of "if" here but assuming they loose their key, assumin

Re: [FFmpeg-devel] [RFC] dormant git accounts

2024-11-09 Thread James Almer
On 11/9/2024 1:18 PM, Michael Niedermayer wrote: Hi all Should we disable git accounts for developers who have not been active since a long time (like 10 years) ? (if these developers come back, the account would then be enabled again) but disabling such accounts may improve security (lots of "

[FFmpeg-devel] [PATCH] lavfi/zscale: fix tmp ptr alignment for zimg_filter_graph_process

2024-11-09 Thread Pavel Koshevoy
--- libavfilter/vf_zscale.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 4ba059064b..87fe691cfd 100644 --- a/libavfilter/vf_zscale.c +++ b/libavfilter/vf_zscale.c @@ -750,7 +750,9 @@ static int filter_slice(AVFi

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers

2024-11-09 Thread James Almer
On 11/9/2024 1:57 PM, Pavel Koshevoy wrote: This avoids unpleasant surprises to av_frame_get_buffer callers that explicitly specified 64-byte alignment and didn't get AVFrame.data pointers that are 64-byte aligned. Again, the doxy is clear that only the buffer sizes are aligned, not the pointe

Re: [FFmpeg-devel] [PATCH] lavfi/zscale: Fix unaligned data ptr issues in realign_frame

2024-11-09 Thread Pavel Koshevoy
On Sat, Nov 9, 2024 at 9:47 AM James Almer wrote: > On 11/9/2024 12:55 PM, Pavel Koshevoy wrote: > > On Sat, Nov 9, 2024 at 6:22 AM James Almer wrote: > > > >> On 11/9/2024 1:40 AM, Pavel Koshevoy wrote: > >>> On Fri, Nov 8, 2024 at 7:29 PM James Almer wrote: > >>> > On 11/8/2024 10:51 PM,

Re: [FFmpeg-devel] [PATCH] lavfi/zscale: Fix unaligned data ptr issues in realign_frame

2024-11-09 Thread Pavel Koshevoy
On Sat, Nov 9, 2024 at 9:53 AM James Almer wrote: > On 11/9/2024 12:55 PM, Pavel Koshevoy wrote: > > On Sat, Nov 9, 2024 at 6:22 AM James Almer wrote: > > > >> On 11/9/2024 1:40 AM, Pavel Koshevoy wrote: > >>> On Fri, Nov 8, 2024 at 7:29 PM James Almer wrote: > >>> > On 11/8/2024 10:51 PM,

Re: [FFmpeg-devel] [PATCH] lavfi/zscale: fix tmp buffer ptr alignment for zimg_filter_graph_process (v2)

2024-11-09 Thread James Almer
On 11/9/2024 2:05 PM, Pavel Koshevoy wrote: --- libavfilter/vf_zscale.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 4ba059064b..07e295652d 100644 --- a/libavfilter/vf_zscale.c +++ b/libavfilter/vf_zscale

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers

2024-11-09 Thread Pavel Koshevoy
On Sat, Nov 9, 2024 at 10:27 AM James Almer wrote: > On 11/9/2024 1:57 PM, Pavel Koshevoy wrote: > > This avoids unpleasant surprises to av_frame_get_buffer callers > > that explicitly specified 64-byte alignment and didn't get > > AVFrame.data pointers that are 64-byte aligned. > > Again, the do

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/x86/diracdsp: Migrate last remaining MMX function to SSE2

2024-11-09 Thread Michael Niedermayer
On Thu, Nov 07, 2024 at 06:25:14PM +0900, Kyosuke Kawakami wrote: > The add_dirac_obmc8_mmx function was the only MMX function left. This > patch migrates it to SSE2. > > Signed-off-by: Kyosuke Kawakami > --- > libavcodec/x86/diracdsp.asm| 4 +--- > libavcodec/x86/diracdsp_init.c | 10 +++--

Re: [FFmpeg-devel] [PATCH] lavfi/zscale: Fix unaligned data ptr issues in realign_frame

2024-11-09 Thread James Almer
On 11/9/2024 1:40 AM, Pavel Koshevoy wrote: On Fri, Nov 8, 2024 at 7:29 PM James Almer wrote: On 11/8/2024 10:51 PM, Pavel Koshevoy wrote: I ran into segfaults in zimg when I attempted to use zscale to convert a 512x538@yuv444p16le(tv) image from HLG to Bt.709 with this filter chain: buffe

Re: [FFmpeg-devel] [PATCH] lavfi/zscale: Fix unaligned data ptr issues in realign_frame

2024-11-09 Thread James Almer
On 11/9/2024 12:55 PM, Pavel Koshevoy wrote: On Sat, Nov 9, 2024 at 6:22 AM James Almer wrote: On 11/9/2024 1:40 AM, Pavel Koshevoy wrote: On Fri, Nov 8, 2024 at 7:29 PM James Almer wrote: On 11/8/2024 10:51 PM, Pavel Koshevoy wrote: I ran into segfaults in zimg when I attempted to use zs

Re: [FFmpeg-devel] [PATCH] lavfi/zscale: fix tmp ptr alignment for zimg_filter_graph_process

2024-11-09 Thread James Almer
On 11/9/2024 1:37 PM, Pavel Koshevoy wrote: --- libavfilter/vf_zscale.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 4ba059064b..87fe691cfd 100644 --- a/libavfilter/vf_zscale.c +++ b/libavfilter/vf_zscale.c

Re: [FFmpeg-devel] [PATCH] lavfi/zscale: fix tmp ptr alignment for zimg_filter_graph_process

2024-11-09 Thread Pavel Koshevoy
On Sat, Nov 9, 2024 at 9:43 AM James Almer wrote: > On 11/9/2024 1:37 PM, Pavel Koshevoy wrote: > > --- > > libavfilter/vf_zscale.c | 8 ++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c > > index 4ba059064b..87f

[FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers

2024-11-09 Thread Pavel Koshevoy
This avoids unpleasant surprises to av_frame_get_buffer callers that explicitly specified 64-byte alignment and didn't get AVFrame.data pointers that are 64-byte aligned. In particular, this fixes an issue in vf_zscale. https://github.com/sekrit-twc/zimg/issues/212 --- libavutil/frame.c | 4 +++-

Re: [FFmpeg-devel] [PATCH] lavfi/zscale: Fix unaligned data ptr issues in realign_frame

2024-11-09 Thread James Almer
On 11/9/2024 12:55 PM, Pavel Koshevoy wrote: On Sat, Nov 9, 2024 at 6:22 AM James Almer wrote: On 11/9/2024 1:40 AM, Pavel Koshevoy wrote: On Fri, Nov 8, 2024 at 7:29 PM James Almer wrote: On 11/8/2024 10:51 PM, Pavel Koshevoy wrote: I ran into segfaults in zimg when I attempted to use zs

[FFmpeg-devel] [PATCH] lavfi/zscale: fix tmp buffer ptr alignment for zimg_filter_graph_process (v2)

2024-11-09 Thread Pavel Koshevoy
--- libavfilter/vf_zscale.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 4ba059064b..07e295652d 100644 --- a/libavfilter/vf_zscale.c +++ b/libavfilter/vf_zscale.c @@ -630,7 +630,7 @@ static int graphs_build(A

Re: [FFmpeg-devel] [RFC] dormant git accounts

2024-11-09 Thread Rémi Denis-Courmont
Le lauantaina 9. marraskuuta 2024, 18.18.08 EET Michael Niedermayer a écrit : > Hi all > > Should we disable git accounts for developers who have not been active since > a long time (like 10 years) ? Yes but git is probably the least dangerous of credentials to keep stale. A backdoor getting pus

Re: [FFmpeg-devel] [RFC] libpostproc splitout

2024-11-09 Thread Rémi Denis-Courmont
Le lauantaina 9. marraskuuta 2024, 18.11.07 EET Michael Niedermayer a écrit : > > And sorry but while I am all for splitting postproc to a separate > > repository, it is at best a few hundreds euros worth of consulting time. > > The difficult part, if there is one, is to reach the agreement to do i

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers

2024-11-09 Thread James Almer
On 11/9/2024 2:34 PM, Pavel Koshevoy wrote: On Sat, Nov 9, 2024 at 10:27 AM James Almer wrote: On 11/9/2024 1:57 PM, Pavel Koshevoy wrote: This avoids unpleasant surprises to av_frame_get_buffer callers that explicitly specified 64-byte alignment and didn't get AVFrame.data pointers that are

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers

2024-11-09 Thread Pavel Koshevoy
On Sat, Nov 9, 2024 at 10:39 AM James Almer wrote: > On 11/9/2024 2:34 PM, Pavel Koshevoy wrote: > > On Sat, Nov 9, 2024 at 10:27 AM James Almer wrote: > > > >> On 11/9/2024 1:57 PM, Pavel Koshevoy wrote: > >>> This avoids unpleasant surprises to av_frame_get_buffer callers > >>> that explicitly

Re: [FFmpeg-devel] [PATCH] avcodec/speexdec: fix decoding regressions

2024-11-09 Thread slbtty
Sorry, I didn't notice the license change. On Sat, Nov 9, 2024 at 10:33 AM Michael Niedermayer wrote: > Hi > > I have received the mail below from paul, I belive it refers to these > patches here > > On Sat, Nov 09, 2024 at 08:09:15AM +0100, Paul B Mahol wrote: > > I see you reviewing one of sto

Re: [FFmpeg-devel] [PATCH] fate/pixfmt: disable dithering in the scale filter

2024-11-09 Thread James Almer
On 11/8/2024 9:03 PM, Michael Niedermayer wrote: On Fri, Nov 08, 2024 at 04:56:38PM -0300, James Almer wrote: On 11/8/2024 5:15 AM, Martin Storsjö wrote: On Thu, 7 Nov 2024, James Almer wrote: Should fix fate failures across different systems. Signed-off-by: James Almer --- This only hides

Re: [FFmpeg-devel] [PATCH] avcodec/speexdec: fix decoding regressions

2024-11-09 Thread Michael Niedermayer
Hi I have received the mail below from paul, I belive it refers to these patches here On Sat, Nov 09, 2024 at 08:09:15AM +0100, Paul B Mahol wrote: > I see you reviewing one of stolen (The author of mail stole multiple > patches and changed original authorship) code patches from librempeg > proje

Re: [FFmpeg-devel] [PATCH 3/5] lavc/vvc_mc: R-V V put_uni_pixels

2024-11-09 Thread Rémi Denis-Courmont
Le maanantaina 28. lokakuuta 2024, 19.08.24 EET u...@foxmail.com a écrit : > From: sunyuechi > > k230 > banana_f3 put_uni_pixels_chroma_8_4x4_c: 128.3 ( > 1.00x)90.5 ( 1.00x) put_uni_pixels_chroma_8_4x

Re: [FFmpeg-devel] [PATCH v7] avcodec/jpeg2000: Fix FF_DWT97_INT to pass the conformance testing defined in ISO/IEC 15444-4

2024-11-09 Thread James Almer
On 11/8/2024 2:23 AM, Pierre-Anthony Lemieux wrote: Ok will merge the patch below. src/libavcodec/jpeg2000dec.c:1972:117: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' https://fate.ffmpeg.org/report.cgi?time=20241109021127&slot=x86_64-archlinux-gcc-ubsan O

Re: [FFmpeg-devel] [PATCH] lavfi/zscale: Fix unaligned data ptr issues in realign_frame

2024-11-09 Thread Pavel Koshevoy
On Sat, Nov 9, 2024 at 6:22 AM James Almer wrote: > On 11/9/2024 1:40 AM, Pavel Koshevoy wrote: > > On Fri, Nov 8, 2024 at 7:29 PM James Almer wrote: > > > >> On 11/8/2024 10:51 PM, Pavel Koshevoy wrote: > >>> I ran into segfaults in zimg when I attempted to use zscale > >>> to convert a 512x538

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: elaborate on h264_redundant_pps

2024-11-09 Thread Marth64
Pushed ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] lavfi/zscale: fix call to av_pix_fmt_count_planes

2024-11-09 Thread Pavel Koshevoy
realign_frame called av_pix_fmt_count_planes with incorrect parameter. --- libavfilter/vf_zscale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 4ba059064b..c29c599000 100644 --- a/libavfilter/vf_zscale.c +++ b/libavfilt

Re: [FFmpeg-devel] [RFC] libpostproc splitout

2024-11-09 Thread Michael Niedermayer
On Fri, Nov 08, 2024 at 08:00:50PM +0200, Rémi Denis-Courmont wrote: > Le torstaina 7. marraskuuta 2024, 22.04.04 EET Michael Niedermayer a écrit : > > On Thu, Nov 07, 2024 at 02:48:13PM +, Derek Buitenhuis wrote: > > > On 11/6/2024 11:11 PM, Michael Niedermayer wrote: > > > > 3. actually r