Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-05 Thread James Almer
On 11/5/2024 6:31 AM, Nicolas George wrote: Anton Khirnov (12024-11-05): That is an unreasonable demand IMO. Care to elaborate why requesting benchmarks for changes on a filter that was designed for speed on the architectures it would be most impacted on seems to you unreasonable? Asking for

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: check entropy_decoder_read_symbol return value

2024-11-05 Thread Leo Izen
On 11/1/24 8:50 AM, Kacper Michajłow wrote: Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavcodec/jpegxl_parser.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_parser.c index 8c45e1a1b7..746c429b9c 100644

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-05 Thread Nicolas George
Marton Balint (12024-11-04): > Signed-off-by: Marton Balint > --- > libavfilter/asrc_sine.c | 16 +- > tests/ref/fate/copy-shortest1 | 58 ++--- > tests/ref/fate/copy-shortest2 | 58 ++--- > tests/ref/fate/filter-concat| 344 ++-- > tests

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-05 Thread Rémi Denis-Courmont
Le 5 novembre 2024 11:40:33 GMT+02:00, Nicolas George a écrit  : >Anton Khirnov (12024-11-05): >> 32bit CPUs are effectively obsolete and heading to extinction > >The idea that FFmpeg is only for new hardware and should not support >“obsolete” hardware is unreasonable. Sure. We should still sup

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: clear window

2024-11-05 Thread Leo Izen
On 11/4/24 9:59 PM, James Almer wrote: On 11/4/2024 11:23 PM, Michael Niedermayer wrote: Fixes: Use of uninitialised value of size 8 Odd, the only load op with dec->window appears to be 4 bytes. Fixes: 368725676/clusterfuzz-testcase-minimized- fuzzer_protocol_file-6022251122589696-cut Fixes:

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-05 Thread Anton Khirnov
Quoting Nicolas George (2024-11-05 09:52:47) > Also, please check the speed impact on speed on a 32 bits CPU. A real > one, not an emulation or compatibility mode, and preferably a low-end > one. That is an unreasonable demand IMO. -- Anton Khirnov ___

Re: [FFmpeg-devel] [PATCH v2 4/4] tests/fate/filter-audio: add aloop test

2024-11-05 Thread Anton Khirnov
Quoting Marton Balint (2024-11-05 08:15:31) > v2: use -filter_complex instead of -f lavfi to generate input > > Signed-off-by: Marton Balint > --- > tests/fate/filter-audio.mak | 3 +++ > tests/ref/fate/filter-aloop | 45 + > 2 files changed, 48 insertions(+)

Re: [FFmpeg-devel] [PATCH 4/4] tests/fate/filter-audio: add aloop test

2024-11-05 Thread Anton Khirnov
Quoting Marton Balint (2024-11-04 21:30:23) > Signed-off-by: Marton Balint > --- > tests/fate/filter-audio.mak | 3 +++ > tests/ref/fate/filter-aloop | 45 + > 2 files changed, 48 insertions(+) > create mode 100644 tests/ref/fate/filter-aloop > > diff --git

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-05 Thread Nicolas George
Anton Khirnov (12024-11-05): > That is an unreasonable demand IMO. Care to elaborate why requesting benchmarks for changes on a filter that was designed for speed on the architectures it would be most impacted on seems to you unreasonable? -- Nicolas George

[FFmpeg-devel] [PATCH] lavfi/vf_libplacebo: eliminate LibplaceboInput.link

2024-11-05 Thread Anton Khirnov
Setting it was broken in 8160178dfc0e6bdaacf80dec58e595a9d595eedc, since links are not yet set up during init. It is also redundant, as the struct also stores the input index. Reported-By: llyyr --- libavfilter/vf_libplacebo.c | 41 ++--- 1 file changed, 20 insert

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-05 Thread Anton Khirnov
Quoting Nicolas George (2024-11-05 10:31:04) > Anton Khirnov (12024-11-05): > > That is an unreasonable demand IMO. > > Care to elaborate why requesting benchmarks for changes on a filter that > was designed for speed on the architectures it would be most impacted on > seems to you unreasonable?

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-05 Thread Nicolas George
Anton Khirnov (12024-11-05): > 32bit CPUs are effectively obsolete and heading to extinction The idea that FFmpeg is only for new hardware and should not support “obsolete” hardware is unreasonable. -- Nicolas George ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-05 Thread Rémi Denis-Courmont
Le 5 novembre 2024 11:31:04 GMT+02:00, Nicolas George a écrit  : >Anton Khirnov (12024-11-05): >> That is an unreasonable demand IMO. > >Care to elaborate why requesting benchmarks for changes on a filter that >was designed for speed on the architectures it would be most impacted on >seems to yo

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-05 Thread Nicolas George
Rémi Denis-Courmont (12024-11-05): > It should be obvious, but you can't expect people to have whatever > uncommon (or in this case, no longer common) hardware. Anybody who needs access to unusual hardware for a Free Software project can get an account on the GCC compile farm and thus access to a

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-05 Thread Nicolas George
James Almer (12024-11-05): > Asking for benchmarks on old CPUs that are running deprecated or obsolete > OSes is not reasonable. I did not ask that they be running deprecated or obsolete OSes, so… Also there are recent ARM32 CPUs. -- Nicolas George

Re: [FFmpeg-devel] root access voting

2024-11-05 Thread Ronald S. Bultje
Hi, On Sun, Nov 3, 2024 at 11:37 AM Michael Niedermayer wrote: > On Sun, Nov 03, 2024 at 08:56:36PM +0900, Rémi Denis-Courmont wrote: > > Le 2 novembre 2024 20:34:30 GMT+09:00, Michael Niedermayer < > mich...@niedermayer.cc> a écrit : > > >At teh current videolan developer days there where sever

Re: [FFmpeg-devel] [PATCH] Fix crash when trying to get a fragment time for a non-existing fragment

2024-11-05 Thread Eugene Zemtsov via ffmpeg-devel
Any feedback? On Thu, Oct 24, 2024 at 6:54 PM wrote: > From: Eugene Zemtsov > > Bug: https://issues.chromium.org/issues/372994341 > Change-Id: I695d625717c078ed6f84f44e58c34da858af4d3b > Reviewed-on: > https://chromium-review.googlesource.com/c/chromium/third_party/ffmpeg/+/5958151 > Reviewed-b

Re: [FFmpeg-devel] [PATCH] Fix incorrect enum type used for a local variable

2024-11-05 Thread Eugene Zemtsov via ffmpeg-devel
Any feedback? On Thu, Oct 24, 2024 at 6:52 PM wrote: > From: Eugene Zemtsov > > It's AVPacketSideDataType, not AVFrameSideDataType. > > Bug: https://issues.chromium.org/issues/374797732 > Change-Id: If75702c6d639ca63827cc3370477de00544d3c0f > Reviewed-on: > https://chromium-review.googlesource.

Re: [FFmpeg-devel] root access voting

2024-11-05 Thread Michael Niedermayer
On Tue, Nov 05, 2024 at 04:51:30PM -0500, Ronald S. Bultje wrote: > Hi, > > On Sun, Nov 3, 2024 at 11:37 AM Michael Niedermayer > wrote: > > > On Sun, Nov 03, 2024 at 08:56:36PM +0900, Rémi Denis-Courmont wrote: > > > Le 2 novembre 2024 20:34:30 GMT+09:00, Michael Niedermayer < > > mich...@niede

[FFmpeg-devel] [PATCH 2/2] avcodec/rv60: check init_get_bits8 return value

2024-11-05 Thread Peter Ross
Fixes CID 1634471 --- libavcodec/rv60dec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/rv60dec.c b/libavcodec/rv60dec.c index d68fa66fa7..86c7aefbca 100644 --- a/libavcodec/rv60dec.c +++ b/libavcodec/rv60dec.c @@ -2263,7 +2263,8 @@ static int decode_slice(A

[FFmpeg-devel] [PATCH 1/2] avcodec/rv60: negative qp guard

2024-11-05 Thread Peter Ross
Fixes CID 1634472 --- libavcodec/rv60dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/rv60dec.c b/libavcodec/rv60dec.c index d0cc10253b..d68fa66fa7 100644 --- a/libavcodec/rv60dec.c +++ b/libavcodec/rv60dec.c @@ -2270,6 +2270,8 @@ static int decode_slice(AVCodecContext *avctx

[FFmpeg-devel] [PATCHv2] avcodec/eatgq: decode motion vector macroblocks

2024-11-05 Thread Peter Ross
Signed-off-by: Peter Ross --- added missing reference frame check. will apply soon. libavcodec/codec_desc.c | 2 +- libavcodec/eatgq.c | 54 ++--- 2 files changed, 51 insertions(+), 5 deletions(-) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_