Re: [FFmpeg-devel] [PATCH, v3] avcodec/amfenc: increase precision of Sleep() on Windows

2024-10-31 Thread Dmitrii Ovchinnikov
If there are no comments, I plan to merge this patch at the end of the week. I will update the title and description to match the current version of the patch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpe

Re: [FFmpeg-devel] [RFC] libavutil split out

2024-10-31 Thread Michael Niedermayer
Hi On Thu, Oct 31, 2024 at 10:12:57AM +0100, Tomas Härdin wrote: > tor 2024-10-31 klockan 01:08 +0100 skrev Michael Niedermayer: [...] > > , well iam sure > > you see this doesnt work > > build ffmpeg first, theres no libmycodec, > > build libmycodec first, theres no libavutil > > now of course th

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: fix crash when vk renderer is null

2024-10-31 Thread Michael Niedermayer
On Thu, Oct 31, 2024 at 02:40:57PM +0100, Leandro Santiago wrote: > When vulkan rendering is requested by the user and fails, ffplay should > exit graciously instead of crash due to a null pointer deref. > > Signed-off-by: Leandro Santiago > --- > fftools/ffplay.c | 5 + > 1 file changed, 5

[FFmpeg-devel] [PATCH] avcodec/amfenc: Color information update

2024-10-31 Thread Araz Iusubov
Processing of transfer characteristic SMPTE2084 and 8-bit depth added on AMF side and will appear in one of upcoming releases. --- libavcodec/amfenc_av1.c | 13 - libavcodec/amfenc_hevc.c | 13 - 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/libavcodec/

Re: [FFmpeg-devel] [PATCH V3] Patch to add interlaced HEVC decoding to HEVCDEC

2024-10-31 Thread Michael Niedermayer
On Wed, Oct 30, 2024 at 01:31:35PM -0500, Jose Santiago wrote: > From d55b49766d5e0256685c4874568db002d3dd7889 Mon Sep 17 00:00:00 2001 > From: Jose Santiago > Date: Wed, 30 Oct 2024 12:28:35 -0500 > Subject: [PATCH] [PATCH V3] Patch to add interlaced HEVC decoding to > HEVCDEC > > --- > libav

Re: [FFmpeg-devel] [PATCH 3/7] swscale/output: add XV48 output support

2024-10-31 Thread Michael Niedermayer
On Tue, Oct 29, 2024 at 04:50:47PM -0300, James Almer wrote: > On 10/29/2024 4:29 PM, Michael Niedermayer wrote: > > On Tue, Oct 29, 2024 at 01:03:21PM +0100, Michael Niedermayer wrote: > > > On Fri, Oct 25, 2024 at 07:56:29PM -0300, James Almer wrote: > > > > On 10/25/2024 7:18 PM, Michael Niederm

[FFmpeg-devel] [PATCH] libavfi/vf_drawtext: fix double free when destroying font face

2024-10-31 Thread Leandro Santiago
Ref https://trac.ffmpeg.org/ticket/11152 According to harfbuzz docs, hb_ft_font_set_funcs() does not need to be called, as, quoted: ``` An #hb_font_t object created with hb_ft_font_create() is preconfigured for FreeType font functions and does not require this function to be used. ``` Using thi

Re: [FFmpeg-devel] [PATCH V5] Patch to add interlaced HEVC decoding to HEVCDEC

2024-10-31 Thread Jose Santiago
From 6cbe272375c746905238020f861633562c8b465e Mon Sep 17 00:00:00 2001 From: Jose Santiago Date: Thu, 31 Oct 2024 13:17:16 -0500 Subject: [PATCH V5] Patch to add interlaced HEVC decoding to HEVCDEC This version fixes a memory leak and does some code cleanup. --- libavcodec/hevc/hevcdec.c | 2

Re: [FFmpeg-devel] [PATCH V6] Patch to add interlaced HEVC decoding to HEVCDEC

2024-10-31 Thread Jose Santiago
From 14b950ad54a6b4ba9274769328fc32dc29e6efae Mon Sep 17 00:00:00 2001 From: Jose Santiago Date: Thu, 31 Oct 2024 13:38:57 -0500 Subject: [PATCH V6] Patch to add interlaced HEVC decoding to HEVCDEC Fixes repeat field for non-interlaced frame pictures. --- libavcodec/hevc/hevcdec.c | 24 ++-

Re: [FFmpeg-devel] [PATCH 1/2] avutil/channel_layout: add Binaural channels and layout

2024-10-31 Thread Marton Balint
On Sun, 27 Oct 2024, James Almer wrote: Signed-off-by: James Almer --- doc/utils.texi| 2 ++ libavutil/channel_layout.c| 3 +++ libavutil/channel_layout.h| 7 +++ tests/ref/fate/channel_layout | 1 + 4 files changed, 13 insertions(+) diff --git a/doc/utils.texi b/doc

Re: [FFmpeg-devel] [PATCH 1/2] avutil/channel_layout: add Binaural channels and layout

2024-10-31 Thread James Almer
On 10/31/2024 3:53 PM, Marton Balint wrote: On Sun, 27 Oct 2024, James Almer wrote: Signed-off-by: James Almer --- doc/utils.texi    | 2 ++ libavutil/channel_layout.c    | 3 +++ libavutil/channel_layout.h    | 7 +++ tests/ref/fate/channel_layout | 1 + 4 files changed, 13 inse

[FFmpeg-devel] [PATCH] swscale/swscale_unscaled: add unscaled rgb to planar rgba

2024-10-31 Thread James Almer
The fate test reference changes are due to the conversion being a simple lossless deinterleave, instead of going through a RGB -> YUV -> RGB roundtrip. Signed-off-by: James Almer --- libswscale/swscale_unscaled.c | 85 +++ tests/ref/fate/filter-overlay_gbrap_gbrap

Re: [FFmpeg-devel] [PATCH] libavutil/hwcontext_d3d11va: Support Y212/XV36 pixel format

2024-10-31 Thread James Almer
On 10/31/2024 9:45 AM, fei.w.wang-at-intel@ffmpeg.org wrote: From: Fei Wang Use DXGI 16bit pixel format to compatible with 12bit Y212/XV36 since there is no 12bit pixel defined in D3D11. Fix cmdline on Windows: $ ffmpeg.exe -hwaccel qsv -i input_12bit.bin -f null - Signed-off-by: Fei Wan

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: fix crash when vk renderer is null

2024-10-31 Thread Zhao Zhili
> On Oct 31, 2024, at 21:40, Leandro Santiago wrote: > > When vulkan rendering is requested by the user and fails, ffplay should > exit graciously instead of crash due to a null pointer deref. > > Signed-off-by: Leandro Santiago > --- > fftools/ffplay.c | 5 + > 1 file changed, 5 insertio

Re: [FFmpeg-devel] [RFC] AVFilter

2024-10-31 Thread Neal Gompa
On Sat, Oct 19, 2024 at 4:39 AM Rémi Denis-Courmont wrote: > > Le perjantaina 18. lokakuuta 2024, 14.42.46 EEST Nicolas George a écrit : > > That might be true if you only consider commercial projects. For > > community projects and hobby projects, that is certainly not true at > > all. > > > > An

Re: [FFmpeg-devel] [PATCH, v3] avcodec/amfenc: increase precision of Sleep() on Windows

2024-10-31 Thread Kieran Kunhya via ffmpeg-devel
On Thu, Oct 31, 2024 at 6:54 PM Dmitrii Ovchinnikov wrote: > > If there are no comments, I plan to merge this patch at the end of the > week. I will update the title and description to match the current version > of the patch. IMO patches like this playing with sleep() are completely unacceptable

Re: [FFmpeg-devel] [PATCH, v3] avcodec/amfenc: increase precision of Sleep() on Windows

2024-10-31 Thread Dmitrii Ovchinnikov
This patch does not touch the sleep . The description remains from the old version and I will correct it. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email f

[FFmpeg-devel] [PATCH] fftools/ffplay: fix crash when vk renderer is null

2024-10-31 Thread Leandro Santiago
When vulkan rendering is requested by the user and fails, ffplay should exit graciously instead of crash due to a null pointer deref. Signed-off-by: Leandro Santiago --- fftools/ffplay.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index a59697276

[FFmpeg-devel] [PATCH v2] fftools/ffplay: fix crash when vk renderer is null

2024-10-31 Thread Leandro Santiago
When vulkan rendering is requested by the user and fails, ffplay should exit graciously instead of crash due to a null pointer deref. Signed-off-by: Leandro Santiago --- fftools/ffplay.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index a596972769

[FFmpeg-devel] [PATCH] swscale/swscale: prevent integer overflow in chrRangeToJpeg16_c

2024-10-31 Thread James Almer
Same as it's done in lumRangeToJpeg16_c(). Plenty of allowed input values can overflow here. Fixes: src/libswscale/swscale.c:198:47: runtime error: signed integer overflow: 475328 * 4663 cannot be represented in type 'int' Signed-off-by: James Almer --- libswscale/swscale.c | 4 ++-- 1 file cha

[FFmpeg-devel] [PATCH] lavfi/vf_drawtext: use INT_(MIN|MAX) instead of hardcoded values

2024-10-31 Thread Leandro Santiago
The values +-32000 smell like something that will break in the future. Signed-off-by: Leandro Santiago --- libavfilter/vf_drawtext.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index 2b0a21a4b4..96a8a59f0e 100

[FFmpeg-devel] [PATCH] doc/examples: unify approach for get_format on hwaccel related examples

2024-10-31 Thread Leandro Santiago
This adds lots of copy&paste, but introducing ways to reuse the code would find the examples harder to read. Signed-off-by: Leandro Santiago --- doc/examples/hw_decode.c | 10 -- doc/examples/qsv_decode.c | 11 --- doc/examples/qsv_transcode.c | 11 --- doc/e

[FFmpeg-devel] [PATCH v2] lavfi/vf_drawtext: use INT_(MIN|MAX) instead of hardcoded values

2024-10-31 Thread Leandro Santiago
The values +-32000 smell like something that will break in the future. Signed-off-by: Leandro Santiago --- libavfilter/vf_drawtext.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index 2b0a21a4b4..96a8a59f0e 1006

[FFmpeg-devel] [PATCH v2] libavfi/vf_drawtext: fix memory management when destroying font face

2024-10-31 Thread Leandro Santiago
Ref https://trac.ffmpeg.org/ticket/11152 According to harfbuzz docs, hb_ft_font_set_funcs() does not need to be called, as, quoted: ``` An #hb_font_t object created with hb_ft_font_create() is preconfigured for FreeType font functions and does not require this function to be used. ``` Using this

[FFmpeg-devel] [PATCH] avcodec/vaapi_encode: skip AVBR if HRD parameters are set

2024-10-31 Thread Cameron Gutman
AVBR does not use VAEncMiscParameterTypeHRD, so attempting to set rc_buffer_size and bit_rate together will cause the rc_buffer_size to be ignored if the VAAPI driver supports AVBR. We should prefer regular VBR for that case. Signed-off-by: Cameron Gutman --- libavcodec/vaapi_encode.c | 5 -

Re: [FFmpeg-devel] [PATCH] lavf/mxfenc: Use nb_components, not av_pix_fmt_count_planes()

2024-10-31 Thread Tomas Härdin
tis 2024-10-29 klockan 08:48 -0700 skrev Pierre-Anthony Lemieux: > LGTM Will push later today /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpe

Re: [FFmpeg-devel] [RFC] libavutil split out

2024-10-31 Thread Tomas Härdin
tor 2024-10-31 klockan 01:08 +0100 skrev Michael Niedermayer: > Hi > > Theres a problem with libavutil, or maybe more than one > > a library implementing a codec that tries do use libavutil and itself > is > used by libavcodec. Creates a (build) dependancy like this > libavutil -> libmycodec -> l

[FFmpeg-devel] [PATCH] libavutil/hwcontext_d3d11va: Support Y212/XV36 pixel format

2024-10-31 Thread fei . w . wang-at-intel . com
From: Fei Wang Use DXGI 16bit pixel format to compatible with 12bit Y212/XV36 since there is no 12bit pixel defined in D3D11. Fix cmdline on Windows: $ ffmpeg.exe -hwaccel qsv -i input_12bit.bin -f null - Signed-off-by: Fei Wang --- libavutil/hwcontext_d3d11va.c | 4 1 file changed, 4 i

Re: [FFmpeg-devel] [PATCH v4 1/8] lavc/vaapi_dec: Create VA parameters dynamically

2024-10-31 Thread Xiang, Haihao
On Wo, 2024-10-30 at 01:15 +, Xiang, Haihao wrote: > On Ma, 2024-10-28 at 16:55 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > > From: Fei Wang > > > > Signed-off-by: Fei Wang > > --- > >  libavcodec/vaapi_decode.c | 34 +- > >  libavcodec/vaapi_decode.h | 

Re: [FFmpeg-devel] [PATCH 3/7] swscale/output: add XV48 output support

2024-10-31 Thread James Almer
On 10/31/2024 3:34 PM, Michael Niedermayer wrote: On Tue, Oct 29, 2024 at 04:50:47PM -0300, James Almer wrote: On 10/29/2024 4:29 PM, Michael Niedermayer wrote: On Tue, Oct 29, 2024 at 01:03:21PM +0100, Michael Niedermayer wrote: On Fri, Oct 25, 2024 at 07:56:29PM -0300, James Almer wrote: On

Re: [FFmpeg-devel] [PATCH] lavf/mxfenc: Use nb_components, not av_pix_fmt_count_planes()

2024-10-31 Thread Marton Balint
On Tue, 29 Oct 2024, Tomas Härdin wrote: tis 2024-10-29 klockan 12:21 -0300 skrev James Almer: From ce4b1dfb97530b242f899e5d1686f98fa83a7698 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 29 Oct 2024 16:13:04 +0100 Subject: [PATCH] lavf/mxfenc: Use nb_components, n