Re: [FFmpeg-devel] [RFC PATCH 0/2] Make fate tests succeed with zlib-ng

2024-10-19 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-18 21:02 +0200, Michael Niedermayer wrote: > On Fri, Oct 18, 2024 at 02:02:48PM +0200, Alexander Strasser via ffmpeg-devel > wrote: > > This is as subject notes an RFC. I wanted to send it out quickly. > > Didn't actually test on zlib systems yet (old and new). > > > > So it is not that

Re: [FFmpeg-devel] [RFC] AVFilter

2024-10-19 Thread Rémi Denis-Courmont
Le perjantaina 18. lokakuuta 2024, 14.42.46 EEST Nicolas George a écrit : > That might be true if you only consider commercial projects. For > community projects and hobby projects, that is certainly not true at > all. > > And I want to emphasize that community projects and hobby projects > deserv

Re: [FFmpeg-devel] [PATCH 2/4] scale_cuda frame crop support

2024-10-19 Thread Timo Rothenpieler
The commit message doesn't follow the standard format. Should be avfilter/scale_cuda: or lavfi/scale_cuda: On 19.10.2024 01:05, Koushik Dutta wrote: The crop filter has no effect on scale_cuda: -vf crop=100:100,scale_cuda=300x300 Hardware frames (AV_PIX_FMT_FLAG_HWACCEL) are expected to use th

Re: [FFmpeg-devel] [PATCH 3/5] lavc/vvc_mc: R-V V put_uni_pixels

2024-10-19 Thread Rémi Denis-Courmont
Le lauantaina 19. lokakuuta 2024, 13.55.46 EEST Rémi Denis-Courmont a écrit : > Le perjantaina 11. lokakuuta 2024, 13.40.20 EEST u...@foxmail.com a écrit : > > From: sunyuechi > > +.macro put_uni_pixels w, vlen, id > > +\id\w\vlen: > > +.if \w == 128 && \vlen == 128 > > +li

Re: [FFmpeg-devel] [PATCH v2] fate: skip encoded output hashing for tests that depend on zlib

2024-10-19 Thread Martin Storsjö
On Sat, 19 Oct 2024, James Almer wrote: On 10/19/2024 11:04 AM, Martin Storsjö wrote: On Sat, 19 Oct 2024, James Almer wrote: As there's no guarantee that the output will be exactly the same across implementations, just don't test it at all. Signed-off-by: James Almer --- All tests covered

Re: [FFmpeg-devel] [PATCH v2 02/19] swscale: rename SwsContext to SwsInternal

2024-10-19 Thread Michael Niedermayer
On Thu, Oct 17, 2024 at 02:28:54PM +0200, Niklas Haas wrote: > On Mon, 14 Oct 2024 20:58:31 +0200 Michael Niedermayer > wrote: > > On Mon, Oct 14, 2024 at 08:33:50PM +0200, Niklas Haas wrote: > > > On Mon, 14 Oct 2024 19:49:21 +0200 Michael Niedermayer > > > wrote: > > > > On Mon, Oct 14, 2024

Re: [FFmpeg-devel] [PATCH v2] fate: skip encoded output hashing for tests that depend on zlib

2024-10-19 Thread James Almer
On 10/19/2024 7:09 PM, Michael Niedermayer wrote: On Sat, Oct 19, 2024 at 10:33:58AM -0300, James Almer wrote: As there's no guarantee that the output will be exactly the same across implementations, just don't test it at all. Signed-off-by: James Almer not objecting to this patch but infl

Re: [FFmpeg-devel] [PATCH 1/5] lavc/vvc_mc: R-V V put_pixels

2024-10-19 Thread Rémi Denis-Courmont
Le perjantaina 11. lokakuuta 2024, 13.38.42 EEST u...@foxmail.com a écrit : > From: sunyuechi > > k230 > banana_f3 put_chroma_pixels_8_4x4_c: 61.5 ( > 1.00x)69.5 ( 1.00x) put_chroma_pixels_8_4x4_r

Re: [FFmpeg-devel] [PATCH 3/5] lavc/vvc_mc: R-V V put_uni_pixels

2024-10-19 Thread Rémi Denis-Courmont
Le perjantaina 11. lokakuuta 2024, 13.40.20 EEST u...@foxmail.com a écrit : > From: sunyuechi > +.macro put_uni_pixels w, vlen, id > +\id\w\vlen: > +.if \w == 128 && \vlen == 128 > +lit0, \w > +vsetvli zero, t0, e8, m8, ta, ma > +.else > +vsetvlsta

Re: [FFmpeg-devel] [RFC PATCH 0/2] Make fate tests succeed with zlib-ng

2024-10-19 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-18 15:55 +0100, Derek Buitenhuis wrote: > On 10/18/2024 1:02 PM, Alexander Strasser via ffmpeg-devel wrote: > > Alexander Strasser (2): > > Reapply "tests/fate: disable compression for zlib-based codecs" > > fate: Make it possible to have alternative reference files > > I want to add

[FFmpeg-devel] [PATCH v2] fate: skip encoded output hashing for tests that depend on zlib

2024-10-19 Thread James Almer
As there's no guarantee that the output will be exactly the same across implementations, just don't test it at all. Signed-off-by: James Almer --- All tests covered now. Do we go this route, or update the zlib version of the failing FATE machines? tests/fate-run.sh | 26

[FFmpeg-devel] [PATCH] avcodec/amfenc: properly set primaries, transfer, and matrix values

2024-10-19 Thread Damiano Galassi
HEVC and AV1 encoders had hard-coded color values for 8-bit and 10-bit depths, and they were completely disregarding the provided values. --- libavcodec/amfenc.c | 109 +++ libavcodec/amfenc.h | 2 + libavcodec/amfenc_av1.c | 16 +++--- libavcodec/

Re: [FFmpeg-devel] [PATCH v2] fate: skip encoded output hashing for tests that depend on zlib

2024-10-19 Thread Martin Storsjö
On Sat, 19 Oct 2024, James Almer wrote: As there's no guarantee that the output will be exactly the same across implementations, just don't test it at all. Signed-off-by: James Almer --- All tests covered now. Do we go this route, or update the zlib version of the failing FATE machines? I w

Re: [FFmpeg-devel] [PATCH v2] fate: skip encoded output hashing for tests that depend on zlib

2024-10-19 Thread James Almer
On 10/19/2024 11:04 AM, Martin Storsjö wrote: On Sat, 19 Oct 2024, James Almer wrote: As there's no guarantee that the output will be exactly the same across implementations, just don't test it at all. Signed-off-by: James Almer --- All tests covered now. Do we go this route, or update the z

Re: [FFmpeg-devel] [PATCH v2] fate: skip encoded output hashing for tests that depend on zlib

2024-10-19 Thread James Almer
On 10/19/2024 6:07 PM, Martin Storsjö wrote: On Sat, 19 Oct 2024, James Almer wrote: On 10/19/2024 11:04 AM, Martin Storsjö wrote: On Sat, 19 Oct 2024, James Almer wrote: As there's no guarantee that the output will be exactly the same across implementations, just don't test it at all. Sig

Re: [FFmpeg-devel] [PATCH v2] fate: skip encoded output hashing for tests that depend on zlib

2024-10-19 Thread Michael Niedermayer
On Sat, Oct 19, 2024 at 10:33:58AM -0300, James Almer wrote: > As there's no guarantee that the output will be exactly the same across > implementations, > just don't test it at all. > > Signed-off-by: James Almer not objecting to this patch but inflate is 550 lines of code "Entire inflater (i